Thank you very much. Of course, I will follow up all the other comments. BR, Wei > -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, June 19, 2019 4:20 PM > To: devel@edk2.groups.io; Wu, Hao A <hao.a...@intel.com>; Xu, Wei6 > <wei6...@intel.com> > Cc: Wang, Jian J <jian.j.w...@intel.com>; Zhang, Chao B > <chao.b.zh...@intel.com> > Subject: RE: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On > Disk APIs into CapsuleLib. > > Forgot to mention, please help to handle other comments in the first reply to > the patch. Thanks in advance. > > Best Regards, > Hao Wu > > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Wednesday, June 19, 2019 4:17 PM > > To: Xu, Wei6; devel@edk2.groups.io > > Cc: Wang, Jian J; Zhang, Chao B > > Subject: Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On > > Disk APIs into CapsuleLib. > > > > > > > > No, that's how it is designed. > > > PcdCodRelocationDevPath is used by platform to specify a device to > > > store temp Cod relocation file. > > > If this PCD is not available, it means that platform doesn't have a > > requirement > > > to store the file to a specific place. > > > Then save the file to the device where the capsules are placed. > > > > > > > Got it. > > I suggest to add comments to explicitly mention this in the codes. > > > > > > > > For Capsule On Disk, no capsule hob means the Cod temp relocations > > > file is corrupted, which also means current boot is insecure. > > > Then force reset to re-apply normal boot platform secure policy. > > > I will update the description. Do you have comments for it? > > > > > > > If the behavior change of the 'ProcessCapsules' API is covered during > > design review process, then updating the comments is good to me. > > > > Best Regards, > > Hao Wu > > > > > > > > BR, > > > Wei Xu > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42582): https://edk2.groups.io/g/devel/message/42582 Mute This Topic: https://groups.io/mt/31938582/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
