[edk2-devel] Documentation errors

2023-01-20 Thread tlaronde
Context: I continue to explore the EDK II in order to allow NetBSD to be a more direct OS host for compilation and testing. Starting to review the documentation for building (low level: Build), I have spotted this: In: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Documentation i

[edk2-devel] [PATCH 1/1 v3] EmulatorPkg: fixes for NetBSD compilation

2023-01-09 Thread tlaronde
EmulatorPkg: fixes for NetBSD compilation. Note: generated against today (2023-01-09) master. v3: - Macro __NetBSD__ used instead of lower level _NETBSD_SOURCE; - The required fd value (-1) for mmap(3) under *BSD is given as is with a comment indicating why this particular value for MAP_ANON; -

Re: [edk2-devel] PING [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

2023-01-06 Thread tlaronde
Le Thu, Jan 05, 2023 at 11:40:43PM +, Pedro Falcato a écrit : > On Thu, Jan 5, 2023 at 11:50 AM wrote: > > > Hello, > > > > Ping'ing for this patch sent on November 2022. > > > > The patch is trivial. Can someone review it or eventually merge it if OK? > > > > TIA, > > -- > > Thierry

[edk2-devel] PING [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

2023-01-05 Thread tlaronde
Hello, Ping'ing for this patch sent on November 2022. The patch is trivial. Can someone review it or eventually merge it if OK? TIA, -- Thierry Laronde http://www.kergis.com/ http://kertex.kergis.com/ Key fingerprint = 0FF7 E906 FBAF FE95 FD89

[edk2-devel] [PATCH 1/1 v2] EmulatorPkg: fixes for NetBSD

2022-11-24 Thread tlaronde
Signed-off-by: Thierry Laronde Fixes for compilation on NetBSD. --- EmulatorPkg/Unix/Host/BlockIo.c | 16 +++- EmulatorPkg/Unix/Host/Host.c| 7 +-- EmulatorPkg/Unix/Host/Host.h| 7 ++- 3 files changed, 26 insertions(+), 4 deletions(-) diff --git a/EmulatorPkg/Unix

Re: [edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-22 Thread tlaronde
Le Tue, Nov 22, 2022 at 04:31:14PM +, Pedro Falcato a écrit : > On Tue, Nov 22, 2022 at 4:26 PM wrote: > > > Le Tue, Nov 22, 2022 at 08:40:30AM -0700, Rebecca Cran a écrit : > > > On 11/21/22 15:22, Pedro Falcato wrote: > > > > > > > I kind of dislike your solution. Does NetBSD ship /bin/whic

Re: [edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-22 Thread tlaronde
Le Tue, Nov 22, 2022 at 08:40:30AM -0700, Rebecca Cran a écrit : > On 11/21/22 15:22, Pedro Falcato wrote: > > > I kind of dislike your solution. Does NetBSD ship /bin/which by default? > > I think replacing whereis with "which -a" would be a lot better. > > I don't think there's a 100% standard w

Re: [edk2-devel] EmulatorPkg: fixes for NetBSD compilation

2022-11-22 Thread tlaronde
Hello Pedro, Le Mon, Nov 21, 2022 at 10:32:51PM +, Pedro Falcato a écrit : > On Mon, Nov 21, 2022 at 9:21 PM wrote: > > > diff --git a/EmulatorPkg/Unix/Host/BlockIo.c > > b/EmulatorPkg/Unix/Host/BlockIo.c > > index cf2d6b4cda..c0c694be55 100644 > > --- a/EmulatorPkg/Unix/Host/BlockIo.c > > +

Re: [edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-22 Thread tlaronde
Hello Pedro, Le Mon, Nov 21, 2022 at 10:22:21PM +, Pedro Falcato a écrit : > On Mon, Nov 21, 2022 at 9:21 PM wrote: > > > diff --git a/edksetup.sh b/edksetup.sh > > index 06d2f041e6..46b295c430 100755 > > --- a/edksetup.sh > > +++ b/edksetup.sh > > @@ -105,6 +105,19 @@ function SetupEnv() >

[edk2-devel] EmulatorPkg: fixes for NetBSD compilation

2022-11-21 Thread tlaronde
diff --git a/EmulatorPkg/Unix/Host/BlockIo.c b/EmulatorPkg/Unix/Host/BlockIo.c index cf2d6b4cda..c0c694be55 100644 --- a/EmulatorPkg/Unix/Host/BlockIo.c +++ b/EmulatorPkg/Unix/Host/BlockIo.c @@ -133,6 +133,20 @@ EmuBlockIoOpenDevice ( ioctl (Private->fd, DKIOCGETMAXBLOCKCOUNTWRITE, &Priva

[edk2-devel] edksetup.sh: fix for non POSIX whereis(1)

2022-11-21 Thread tlaronde
diff --git a/edksetup.sh b/edksetup.sh index 06d2f041e6..46b295c430 100755 --- a/edksetup.sh +++ b/edksetup.sh @@ -105,6 +105,19 @@ function SetupEnv() fi } +# whereis(1) is not a POSIX utility and, for example, its implementation +# in NetBSD is different form the Linux one. +# +function whe