Re: [edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable

2023-09-05 Thread Wang, Yin
Hi Ard, I have an EDK2 modification, which is located in the OvmfPkg/PlatformDxe/Platform.c file. The modification involves changing a Hii form name. Could you please review this change? Or do you know who I should ask to review it? Thanks Yin On 9/1/2023 4:21 PM, Yin Wang wrote: The Hii f

[edk2-devel] [PATCH v5 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable

2023-09-01 Thread Wang, Yin
The Hii form is named "MainFormState" while the EFI variable is named "PlatformConfig". This discrepancy in names causes the following SCT cases to fail on RiscVVirtQemu: ExtractConfigConformance ExtractConfigFunction ExtractConfig_Func Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: G

[edk2-devel] [PATCH v4 1/1] OvmfPkg: Fix Hii form name mismatch with EFI variable

2023-08-31 Thread Wang, Yin
The Hii form is named "MainFormState" while the EFI variable is named "PlatformConfig". This discrepancy in names causes the following SCT cases to fail on RiscVVirtQemu: ExtractConfigConformance ExtractConfigFunction ExtractConfig_Func Previous Commit 16acacf addressed two of these issues, and t

Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-08-07 Thread Wang, Yin
Hi Sunil, I will be providing a detailed update soon, along with a new version. Thank you for your careful review and comments. Best regards, Yin -Original Message- From: Sunil V L Sent: Monday, August 7, 2023 8:02 PM To: devel@edk2.groups.io; Wang, Yin Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-19 Thread Wang, Yin
The last 2 change was found when I debug another two fail cases,RouteConfigFunction/RouteConfig_Func,  I will do more investigating on them. let's fallback  to patch v1. I will continue on that thread. Thanks for your time. Yin On 7/19/2023 9:48 PM, Gerd Hoffmann wrote: On Wed, Jul 19, 2023 at

Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-19 Thread Wang, Yin
Hi, Could you help to review on it? Thanks in advance! Yin On 7/17/2023 7:36 PM, Gerd Hoffmann wrote: On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote: Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig") Find by sct case:ExtractConfigConformance fai

Re: [edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-19 Thread Wang, Yin
Hi Grand Thanks for quick reply, Yes, uefi variable mVariableName by shell command dmpstore, could you help to figure out where to initialize mVariableName for arm of x86? Thanks Yin -Original Message- From: Gerd Hoffmann Sent: Wednesday, July 19, 2023 9:48 PM To: Wang, Yin Cc: devel

[edk2-devel] [PATCH] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-19 Thread Wang, Yin
Onemore need change beside 16acacf24c ("OvmfPkg: fix PlatformConfig") Find by sct cases:ExtractConfigConformance ExtractConfigFunction ExtractConfig_Func fail on RiscVVirtQemu. Signed-off-by: Yin Wang --- OvmfPkg/PlatformDxe/Platform.c | 2 +- OvmfPkg/PlatformDxe/PlatformC

Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-16 Thread Wang, Yin
Corrected Cc unsuccessful in git. Thanks for your reviewing. On 7/14/2023 4:59 PM, Yin Wang wrote: Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig") Find by sct case:ExtractConfigConformance fail. Signed-off-by: Yin Wang --- OvmfPkg/PlatformDxe/Platform.c | 2 +- 1

[edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable

2023-07-14 Thread Wang, Yin
Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix PlatformConfig") Find by sct case:ExtractConfigConformance fail. Signed-off-by: Yin Wang --- OvmfPkg/PlatformDxe/Platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/Platf