Hi Ard,
I have an EDK2 modification, which is located in the
OvmfPkg/PlatformDxe/Platform.c file. The modification involves changing
a Hii form name. Could you please review this change? Or do you know who
I should ask to review it?
Thanks
Yin
On 9/1/2023 4:21 PM, Yin Wang wrote:
The Hii form is named "MainFormState" while the EFI variable is named
"PlatformConfig".
This discrepancy in names causes the following SCT cases to fail on
RiscVVirtQemu:
ExtractConfigConformance
ExtractConfigFunction
ExtractConfig_Func
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Jordan Justen <jordan.l.jus...@intel.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Sunil V L <suni...@ventanamicro.com>
Cc: Andrei Warkentin <andrei.warken...@intel.com>
Cc: Dandan Bi <dandan...@intel.com>
Cc: Eric Dong <eric.d...@intel.com>
Signed-off-by: Yin Wang <yin.w...@intel.com>
Acked-by: Gerd Hoffmann <kra...@redhat.com>
Acked-by: Sunil V L <suni...@ventanamicro.com>
---
v5: Re-organize commit message
v4: Update commit message about version history
- aefcc918: Enhance ExtractConfig() to match UEFI specification,
adding check of whether "<ConfigHdr> matches the GUID and name"
- 16acacf2: Fix Hii form name mismatch in ExtractConfig()
- This patch: Add one more fix for Hii form name mismatch
v3: Gerd comments on v2 that caused issues may related to RISC-V
specific config. To address this separately, the patch was restored to v1,
and details were added to the commit message.
v2: Add two more changes which caused other two SCT Hii cases to fail.
v1: Initial version
---
OvmfPkg/PlatformDxe/Platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c
index cd3bfd554c..c32439683d 100644
--- a/OvmfPkg/PlatformDxe/Platform.c
+++ b/OvmfPkg/PlatformDxe/Platform.c
@@ -279,7 +279,7 @@ ExtractConfig (
//
ConfigRequestHdr = HiiConstructConfigHdr (
&gOvmfPlatformConfigGuid,
- mVariableName,
+ mHiiFormName,
mImageHandle
);
if (ConfigRequestHdr == NULL) {
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108297): https://edk2.groups.io/g/devel/message/108297
Mute This Topic: https://groups.io/mt/101090614/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
