Hi Siddhartha
We had to set PcieRpDetectTimeoutMs in FSP to 50ms for WD drives to work.
Sean
On Mon, 27 Jan 2025 at 10:28, Siddhartha via groups.io wrote:
> Hi.
>
> We updated the files in (MdeModulePkg\Bus\Pci\NvmExpressDxe\ and other
> related folders) from stable version 202008 to 202411 (l
PR created - https://github.com/tianocore/edk2/pull/5513
LGTM but I can't check it against UPL.
@Dong, Guo Would you be able to take a look please'?
On Wed, 4 Oct 2023 at 21:02, MrChromebox wrote:
> Fixes serial output on platforms using coreboot and a non-default
> clock rate such as AMD Pic
Reviewed-by: Sean Rhodes
On Fri, 12 Jan 2024 at 11:43, Guo, Gua wrote:
> Reviewed-by: Gua Guo
> --
> *From:* Lean Sheng Tan
> *Sent:* Friday, January 12, 2024 7:33:00 PM
> *To:* Rudolph, Patrick
> *Cc:* devel@edk2.groups.io ; Rhodes, Sean
> ;
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong
> Cc: Ray Ni
&g
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Presently, `ArchIsRngSupported()` always returns TRUE, per
>
> https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bde74/MdePkg/Library/BaseRngLib/Ran
PR created at https://github.com/tianocore/edk2/pull/4231
On Mon, 3 Apr 2023 at 08:32, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
> wrote:
>
>> Copied values from OVMF, these are sufficient for a debug build.
>>
>
Reviewed-by: Sean Rhodes
On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
wrote:
> Copied values from OVMF, these are sufficient for a debug build.
>
> Now that those are improved, remove
> PcdResetOnMemoryTypeInformationChange override. If the memory map must
> change, reset syste
Reviewed-by: Sean Rhodes
On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
wrote:
> MemoryType information assists GCD with defragmenting the memory map.
> When the DXE core starts, GCD adds memory descriptors for the resource
> descriptors HOBs. This allocates heap space which can be reu
d logo locations.
>
>
>
> Mike
>
>
>
>
>
> *From:* Ni, Ray
> *Sent:* Wednesday, March 15, 2023 2:24 AM
> *To:* devel@edk2.groups.io; Rhodes, Sean
> *Cc:* Kinney, Michael D ; Gao, Zhichao <
> zhichao@intel.com>; Wang, Jian J ; Gao, Liming
>
>
to
> control the position of the Logo
>
>
>
> I need a reason of adding
> EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
>
> In my opinion, without adding this new enum value, it’s still possible to
> support MS recommendation.
>
>
>
> *From:* devel@edk2
Reviewed-by: Sean Rhodes
On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph
wrote:
> Add protocol gEfiHiiPackageListProtocolGuid to DEPEX
> to make sure it's present before using it.
>
> Fixes ASSERTION seen on DEBUG build.
>
> Signed-off-by: Patrick Rudolph
> ---
Reviewed-by: Sean Rhodes
On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph
wrote:
> Drop the "-z max-page-size=0x40" option as it causes the ELF
> header to overflow into the .text section, causing undefined
> behaviour.
>
> With high optimization level it corrupts essent
>> payloads/external/edk2/workspace/tianocore/
>>
>>
>>
>> *Thanks & RegardsRitul Guru+91-9916513186*
>>
>>
>> On Wed, Feb 8, 2023 at 2:06 AM Sean Rhodes wrote:
>>
>>> Why the edk2 changes? Just to fix this issue?
>>>
>&
Why the edk2 changes? Just to fix this issue?
Have you seen L36 of payloads/external/edk2/Kconfig
On Tue, 7 Feb 2023 at 20:30, ritul guru wrote:
>
>
> Loading driver 378D7B65-8DA9-4773-B6E4-A47826A833E1
> InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 51A3E1C0
> Loading driver a
8, 2023 at 12:31 AM ritul guru wrote:
>
>> building it inside coreboot only.
>>
>>
>>
>> *Thanks & RegardsRitul Guru+91-9916513186*
>>
>>
>> On Wed, Feb 8, 2023 at 12:00 AM Sean Rhodes
>> wrote:
>>
>>> Hi Ritul
>>&g
Hi Ritul
It might be easier to build it inside coreboot; that'll use coreboots tool
chain and Kconfig so everything will just work.
I.e. CONFIG_PAYLOAD_EDK2=y
Sean
On Tue, 7 Feb 2023, 18:24 ritul guru, wrote:
> UefiPayloadPkg/UefiPayloadPkg.fdf
> DEFINE FD_BASE = 0x0080
>
> Is the a
Hi Ray
Would it be possible to merge this?
Thanks
Sean
On Fri, 16 Dec 2022, 09:03 Ni, Ray, wrote:
> Reviewed-by: Ray Ni
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> > Sent: Friday, December 16, 2022 4:58 P
nd resolve? Thanks.
>
> Best Regards,
> Hao Wu
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> > Rhodes
> > Sent: Wednesday, December 21, 2022 4:15 PM
> > To: devel@edk2.groups.io
> > Cc: Rhodes, Sean
> > Subject:
Okay, a bit more testing - it seems all debug builds hang at that point. I
tested back to edk2-stable202111 so I think that's a coreboot problem.
Your patch does resolve release builds not booting.
> Could you help to use latest Edk2 repo UPL to reproduce the issue that @Sean
Rhodes e
RSAL_PAYLOAD is not set.
>
> Cc: Ray Ni
> Cc: Sean Rhodes
> Cc: James Lu
> Cc: Gua Guo
> Signed-off-by: Guo Dong
> ---
> UefiPayloadPkg/UefiPayloadPkg.fdf | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayl
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Force resetting the port by clearing the USB_PORT_STAT_C_RESET bit in
PortChangeStatus
when XhcPollPortStatusChange fails
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the Compatible Port Offset to find
the starting Port of Root Hubs that support the protocol.
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c| 2 +-
MdeModulePk
ntrib-05
>
>
>
> Specifically this one I think:
>
>
>
> git config diff.ini.xfuncname '^\[[A-Za-z0-9_., ]+]'
>
>
>
> Mike
>
>
>
> *From:* Sean Rhodes
> *Sent:* Thursday, December 15, 2022 2:17 PM
> *To:* Kinney, Michael D
> *Cc:* devel@edk
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
elow.
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> > Sent: Thursday, December 15, 2022 1:12 PM
> > To: devel@edk2.groups.io
> > Cc: Rhodes, Sean ; Gao, Zhichao <
> zhichao@intel.com>; Ni, Ray ;
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
;
> Attach sample code snippet and data dump from my side.
>
> Thanks,
> Ian Chiu
>
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Monday, December 5, 2022 5:18 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier ; Wu, Hao A &
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the Compatible Port Offset to find
the starting Port of Root Hubs that support the protocol.
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c| 2 +-
MdeModulePk
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library
Link to PR passing CI - https://github.com/tianocore/edk2/pull/3353
On Mon, 5 Dec 2022 at 09:18, Sean Rhodes via groups.io wrote:
> Adjusts the requirements for the MaxPacketLength to match what is seen on
> real world devices that do not follow the USB specification.
>
> This fixes
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Adjusts the requirements for the MaxPacketLength to match what is seen on
real world devices that do not follow the USB specification.
This fixes enumeration on the multiple USB 3 devices made by SanDisk,
Integral, Kingston and other generic brands.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean
lt is edk2 detecting USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the extended capability registers
for USB2 before USB3. If edk2 finds a match for a USB 2 device, don't
check for USB 3.
Cc: Hao A Wu
Cc: Ray Ni
Reviewe
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +
1 file changed, 9
; Best Regards,
> Hao Wu
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> > Rhodes
> > Sent: Friday, December 2, 2022 4:25 AM
> > To: devel@edk2.groups.io
> > Cc: Matt DeVillier ; Wu, Hao A
> > ; Ni, Ray ; Rhodes, Sean
> &g
Adjusts the requirements for the MaxPacketLength to match what is seen on
real world devices that do not follow the USB specification.
This fixes enumeration on the multiple USB 3 devices made by SanDisk,
Integral, Kingston and other generic brands.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +
1 file changed, 9
lt is edk2 detecting USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the extended capability registers
for USB2 before USB3. If edk2 finds a match for a USB 2 device, don't
check for USB 3.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: S
25, 2022 12:58 AM
> *To:* devel@edk2.groups.io; Rhodes, Sean
> *Cc:* Gao, Zhichao ; Wang, Jian J <
> jian.j.w...@intel.com>; Gao, Liming
> *Subject:* Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to
> control the position of the Logo
>
>
>
> I need a reason of
Hi Mike/Ray
Thanks - so you mean something like
https://github.com/tianocore/edk2/pull/3528? (
https://github.com/tianocore/edk2/pull/3528 ) (Just for example)
If not, I'm not sure how to control it without the PCD?
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
hich produces
> EDKII_PLATFORM_LOGO_PROTOCOL.
>
> This driver should know the image size and it can account for the image
> size.
>
>
>
> Thanks,
>
> Ray
>
>
>
> *From:* Sean Rhodes
> *Sent:* Monday, October 10, 2022 4:51 PM
> *To:* Ni, Ray
> *Cc:* devel@edk2.groups.
Hi Ray
Done
Thank you
On Tue, 25 Oct 2022 at 07:04, Ni, Ray wrote:
> Can you update the PR to rebase to latest trunk?
>
> Also please modify commit message to capture Reviewed-by tags.
>
>
>
> *From:* devel@edk2.groups.io * On Behalf Of *Sheng
> Lean Tan
> *Sent:* Tuesday, October 25, 2022 10
the image
> size.
>
>
>
> Thanks,
>
> Ray
>
>
>
> *From:* Sean Rhodes
> *Sent:* Monday, October 10, 2022 4:51 PM
> *To:* Ni, Ray
> *Cc:* devel@edk2.groups.io; Gao, Zhichao ; Wang,
> Jian J ; Gao, Liming
> *Subject:* Re: [PATCH 2/3] MdeModulePkg/Log
X = 0;
> *OffsetY = -118 * (INTN)
> GraphicsOutput->Mode->Info->VerticalResolution / 1000;
> }
>
> Thanks,
> Ray
>
> > -Original Message-
> > From: Sean Rhodes
> > Sent: Monday, September 26, 2022 4:10 PM
> > To: devel@ed
Make the wrapper executable so that it can be built without modification
on Linux.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UniversalPayloadBuild.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 8f23802199..48b2a650f2 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
b/MdeModulePkg/Include/Protocol
reaches the
> change you made:
> if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_RESET)
> &&
>
> (Status != EFI_DEVICE_ERROR))
>
> ‘Status’ will always be EFI_SUCCESS, I do not understand what is the point
> of adding “&& (Status != E
nough in the USB domain to quickly figure out the
> whole picture with only log being provided.
>
>
>
> Best Regards,
>
> Hao Wu
>
>
>
> *From:* Sean Rhodes
> *Sent:* Wednesday, September 21, 2022 4:01 PM
> *To:* Wu, Hao A
> *Cc:* devel@edk2.groups.io; Ni,
after a
> success return from GetPortStatus()? Thanks in advance.
>
> Also, one inline comment below:
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> > Rhodes
> > Sent: Tuesday, September 20, 2022 9:14 PM
> > To: devel@edk
Try a port reset if GetPortStatus returns and error.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c
b/MdeModulePkg/Bus/Usb
Zero out the PortState in case GetPortStatus didn't set it, to avoid
continuing with EFI_DEVICE_ERROR.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/MdeModulePkg/Bus/Usb/UsbB
if we could avoid it.
>
> Thanks,
> Guo
> -----Original Message-
> From: Sean Rhodes
> Sent: Friday, August 5, 2022 12:53 AM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean ; Dong, Guo ;
> Ni, Ray
> Subject: [PATCH 3/3] UefiPayloadPkg: Hook up MICROSOFT_RECOMMENDE
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Hook up MICROSOFT_RECOMMENDED macro to PcdFollowMicrosoftRecommended.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h
b/MdeModulePkg/Include/Protocol
e spec description.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Sean Rhodes
> > 发送时间: 2022年7月26日 16:15
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Rhodes ; Zhichao Gao
> > ; Ray Ni ; Jian J Wang
> > ; Liming Gao
>
Hi Ray/ Jian/ Liming
Would you be able to review this patch please?
Many thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92109): https://edk2.groups.io/g/devel/message/92109
Mute This Topic: https://groups.io/mt/92623125/216
Merged as 444260d45ec2a84e8f8c192b3539a3cd5591d009
On Thu, 4 Aug 2022 at 07:02, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Wed, 3 Aug 2022 at 22:14, Dong, Guo wrote:
>
>> Reviewed-by: Guo Dong
>>
>> -Original Message-
>> From: dev
Reviewed-by: Sean Rhodes
On Wed, 3 Aug 2022 at 22:14, Dong, Guo wrote:
> Reviewed-by: Guo Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Tuesday, August 2, 2022 1:00 PM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean ;
Merged as 79aab22fcaecf0bd70099e97c92fe3e816e450ce
On Thu, 4 Aug 2022 at 07:01, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Wed, 3 Aug 2022 at 22:14, Guo Dong wrote:
>
>>
>> Reviewed-by: Guo Dong
>>
>> -Original Message-
>> Fro
Reviewed-by: Sean Rhodes
On Wed, 3 Aug 2022 at 22:14, Guo Dong wrote:
>
> Reviewed-by: Guo Dong
>
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean Rhodes
> Sent: Tuesday, August 2, 2022 1:00 PM
> To: devel@edk2.groups.io
> Cc: Rhodes, Sean
Add a macro called BOOTSPLASH_IMAGE, which when enabled, will
display a logo at boot time.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 9 +
.../PlatformBootManagerLib/PlatformBootManagerLib.inf| 1
If the boot logo is enabled, this will allow edk2 to pass the logo
to the OS via ACPI.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 10 ++
UefiPayloadPkg/UefiPayloadPkg.fdf | 4
2 files changed, 14 insertions(+)
diff --git a
Hi All
For a large number of boards running coreboot (reported on CML, TGL, ADL,
SKL and APL), a change in the last few months has caused an indefinite hang.
For the last three years, coreboot has used a default value of 1000
for gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue, but to
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Add an option to position the logo 38.2% from the top of the screen,
which follows the BGRT specification.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++-
MdeModulePkg/Library/BootLogoLib
Hook up FOLLOW_BGRT_SPEC macro to PcdFollowBGRTSpecification.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 862d440b16
Reviewed-by: Sean Rhodes
On Wed, 20 Jul 2022 at 22:58, Michael D Kinney
wrote:
> Cc: Andrew Fish
> Cc: Leif Lindholm
> Cc: Daniel Schaefer
> Cc: Sean Rhodes
> Cc: Debkumar De
> Cc: Erdem Aktas
> Signed-off-by: Michael D Kinney
> ---
> Maintainers.txt | 10 +
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c| 5 +
.../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++
UefiPayloadPkg
This will allow the OS to display the logo whilst booting.
Cc: Guo Dong
Cc: Ray Ni
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++
UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++
2 files changed, 8 insertions(+)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b
Reviewed-by: Sean Rhodes
On Sat, 16 Jul 2022, 03:37 Benjamin You, wrote:
> Reviewed-by: Benjamin You
>
> > -Original Message-
> > From: Dong, Guo
> > Sent: Saturday, July 16, 2022 9:02 AM
> > To: devel@edk2.groups.io
> > Cc: Dong, Guo ; Ni,
This patch can be disregarded as the --pcd build option will be integrated into
the coreboot build process.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91229): https://edk2.groups.io/g/devel/message/91229
Mute This Topic: https://grou
This patch can be disregarded as the --pcd build option will be integrated into
the coreboot build process.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91228): https://edk2.groups.io/g/devel/message/91228
Mute This Topic: https://grou
.
Therefore, leverage edk2 existing support for this until coreboot can
handle this on it's own.
Sean Rhodes (2):
UefiPayloadPkg: Enable Boot Logo
UefiPayloadPkg: Load Boot Logo into ACPI table
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 3 +++
.../PlatformBootManag
This will allow the OS to display the logo whilst booting.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++
UefiPayloadPkg/UefiPayloadPkg.fdf | 1 +
2 files changed, 4 insertions(+)
diff --git a/UefiPayloadPkg
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 3 +++
.../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
UefiPayloadPkg/UefiPayloadPkg.dsc
ing.
>
>
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn | 128
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow | 40
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdVideoHorizontalResolution | 1024
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdVideoVerticalResolution | 768
>
>
>
> Thanks
>
> Liming
>
Hook up PCIE_BASE to PcdPciExpressBaseAddress
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b
Add 4 spaces before the boot prompt "F2 or Down..." so that the
spacing is equadistant from the top, which is spaced with a `\n`,
and the left.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBoo
Set PCDs ConOutRow, ConOutColumn, SetupConOutRow and SetupConOutColumn
to 0 to allow front page to full the screen.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 6 --
1 file changed, 4 insertions(+), 2
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
b
Hi Gerd
Thank you very much :)
On Mon, 4 Jul 2022 at 10:40, Gerd Hoffmann wrote:
> On Mon, Jul 04, 2022 at 10:03:40AM +0100, Sean Rhodes wrote:
> > Hi
> >
> > Would anyone have any suggestions on getting the Front Page to fill the
> > screen? As far as I can see,
Hook up PCIE_BASE to PcdPciExpressBaseAddress
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc
b/UefiPayloadPkg
Set the Pcd's relating to console to 100 to make UiApp fill the
display
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/UefiPaylo
Reviewed-by: Sean Rhodes
On Wed, 8 Jun 2022 at 16:05, Lean Sheng Tan wrote:
> Reviewed-by: Lean Sheng Tan
>
>
>
> On Mon, 6 Jun 2022 at 02:56, Benjamin Doron
> wrote:
>
>> Writes TianoCore debug logs into the CBMEM console ringbuffer, from
>> where the user
Reviewed-by: Sean Rhodes
On Sun, 22 May 2022 at 19:47, Benjamin Doron
wrote:
> Writes TianoCore debug logs into the CBMEM console ringbuffer, from
> where the user can retrieve them with the `cbmem` userspace utility.
>
> The intention is to aid in debugging non-fatal issues eve
rding to Art. 13 GDPR
> <https://9elements.com/privacy>
>
>
>
>
>
> On Mon, 16 May 2022 at 11:03, Wu, Hao A wrote:
>
> Sorry Star and Liming,
>
>
>
> For the below patch (removing the alignment check for WorkSpace &
> SpareArea):
>
> https:
rom:* devel@edk2.groups.io * On Behalf Of *Sean
> Rhodes
> *Sent:* Monday, May 16, 2022 3:00 PM
> *To:* Wu; Wu, Hao A ; devel@edk2.groups.io
> *Subject:* Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe:
> Don't check for address alignment
>
>
>
> Hi Hao
WorkSpaceAddress and SpareAreaAddress point into MMIO, which isn't
always aligned. Remove the check for block alignment to avoid
false assertions.
Signed-off-by: Sean Rhodes
Change-Id: Ia1c1f44b6a0e7f32cac0d7806e74d729e5d83a6d
---
MdeModulePkg/MdeModulePkg.dec
Hi Hao
Yes, it does conflict - I will update the patch to fix these comments :)
Thank you
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89741): https://edk2.groups.io/g/devel/message/89741
Mute This Topic: https://groups.io/mt/91134149
Hi
Would any one be able to review please?
Thank you
On Fri, 1 Apr 2022, 09:03 Sean Rhodes via groups.io, wrote:
> WorkSpaceAddress and SpareAreaAddress point into MMIO, which isn't
> always aligned. Remove the check for block alignment to avoid
> false assertions.
>
> C
WorkSpaceAddress and SpareAreaAddress point into MMIO, which isn't
always aligned. Remove the check for block alignment to avoid
false assertions.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Change-Id: Ia1c1f44b6a0e7f32cac0d7806e74d729e5d83a6d
---
.../Univ
Reviewed-by Sean Rhodes
On Wed, 30 Mar 2022 at 19:29, Sean Rhodes wrote:
> From: Lean Sheng Tan
>
> Don't assume a 64bit register always holds an address greater than 4GB.
> Check the value in the register and decide which Aperature it should be
> assigned to.
>
>
1 - 100 of 218 matches
Mail list logo
