Hi Siddhartha
We had to set PcieRpDetectTimeoutMs in FSP to 50ms for WD drives to work.
Sean
On Mon, 27 Jan 2025 at 10:28, Siddhartha via groups.io wrote:
> Hi.
>
> We updated the files in (MdeModulePkg\Bus\Pci\NvmExpressDxe\ and other
> related folders) from stable version 2020
I doing think it makes sense in edk2. That is a platform responsibility and in
general edk2 should not represent the platform.
Thanks
Sean
From: devel@edk2.groups.io on behalf of Doug Flick via
groups.io
Sent: Monday, November 18, 2024 9:58:43 AM
To: Rebecca
No tools and ci meeting this week.
As discussed in previous meetings I will schedule twice a month
meetings. I will schedule a meeting for the 11th @ 4:30 PM Pacific time.
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
I support removal of vs2015 and 2017. Since ci only builds and tests n
(vs2022). Supporting n-1 (vs2019) is already just on faith and with the idea
that reported failures will be fixed.
I also agree with dropping previously deprecated tags. Thanks for the effort.
Thanks
Sean
I think @Oliver Smith-Denny<mailto:o...@linux.microsoft.com> has proposed
keeping the macro STATIC as a way to enable cleaner and easier unit tests. Did
that get resolved?
Thanks
Sean
From: devel@edk2.groups.io on behalf of Rebecca Cran
Sent: Th
Tools & CI meeting - September 30th,
2024 - Euro friendly edition · tianocore/edk2 · Discussion #6208
(github.com) <https://github.com/tianocore/edk2/discussions/6208>
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (
confirming this meeting for 1 hour from now.
Discussion and agenda will are available in the github discussion here:
Tools and CI Meeting - Date 8/5 · tianocore/edk2 · Discussion #6047
(github.com) <https://github.com/tianocore/edk2/discussions/6047>
Thanks
Sean
On 8/11/2024 4
ew updates from Michael Kubacki or myself. We plan to
build a prototype for the codeowners, github queue, and reviewer adding
github action. Others welcome to signup if so desired.
Thanks
Sean
On 7/15/2024 3:30 PM, Group Notification wrote:
*Reminder: Tools, CI, Code base constructi
Just confirming this meeting will happen today.
Discussion here: Tools and CI Meeting - Date 7/1 & 7/8 · tianocore/edk2
· Discussion #5843 (github.com)
<https://github.com/tianocore/edk2/discussions/5843>
Thanks
Sean
On 7/7/2024 4:30 PM, Group Notification wrote:
*Reminder:
confirming this meeting will be held today.
Topics and agenda posted: Tools and CI Meeting - Date 6/3 ·
tianocore/edk2 · Discussion #5723 (github.com)
<https://github.com/tianocore/edk2/discussions/5723>
Add additional agenda topics to the github discussion.
Thanks
Sean
On 6/2/202
FYI - Since PRs are targeted to be enabled on Friday may 24th we will
host this meeting today to close/align on any concerns.
Look forward to seeing everyone there.
thanks
Sean
On 5/19/2024 4:30 PM, Group Notification wrote:
*Reminder: Tools, CI, Code base construction meeting series
erent places, it is at least a good
template for a hob definition.
edk2/MdeModulePkg/Include/Guid/VariableFlashInfo.h at
284dbac43da752ee34825c8b3f6f9e8281cb5a19 · tianocore/edk2 (github.com)
<https://github.com/tianocore/edk2/blob/284dbac43da752ee34825c8b3f6f9e8281cb5a19/MdeModulePkg/Incl
t, I would
prefer the pcds and all implementation details be kept in or moved back to
manageability pkg.
Thanks
Sean
From: Attar, AbdulLateef (Abdul Lateef)
Sent: Monday, April 22, 2024 9:47:32 PM
To: Chang, Abner ; Sean Brogan ;
devel@edk2.groups.io ; Liming Gao
;
r IPMI (github.com) <https://github.com/microsoft/mu_feature_ipmi>,
and commercial vendors find some sort of alignment going forward as no
one wins with the mess that is in the industry now.
Thanks
Sean
On 4/22/2024 3:50 AM, Abdul Lateef Attar via groups.io wrote:
Gentle reminder, review
2.groups.io/g/devel/message/109337
> Mute This Topic: https://groups.io/mt/101763377/6718866
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [sean@starlabs.systems]
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
No requests listed here: Tools and CI Meeting - vNext - Date TBD ·
tianocore/edk2 · Discussion #5366 (github.com)
<https://github.com/tianocore/edk2/discussions/5366>
Cancelling for today.
Thanks
Sean
On 3/25/2024 4:16 PM, Group Notification wrote:
*Cancelled: Tools, CI, Cod
Not enough content requested here Tools and CI Meeting - vNext - Date TBD ·
tianocore/edk2 · Discussion #5366 (github.com) (
https://github.com/tianocore/edk2/discussions/5366 )
Cancelling the meeting for the week.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this g
Reviewed-by: Sean Rhodes
On Fri, 12 Jan 2024 at 11:43, Guo, Gua wrote:
> Reviewed-by: Gua Guo
> --
> *From:* Lean Sheng Tan
> *Sent:* Friday, January 12, 2024 7:33:00 PM
> *To:* Rudolph, Patrick
> *Cc:* devel@edk2.groups.io ; Rhodes, Sean
> ;
uled. Otherwise meeting with no agenda will be
cancelled.
Dec 11th meeting discussion here:
Tools and CI Meeting - Dec 11, 2023 · tianocore/edk2 · Discussion #5118
(github.com) <https://github.com/tianocore/edk2/discussions/5118>
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
As mentioned before don't forget to build the basetools. From there, my
experience is everything works. Thanks for reporting your issue.
Thanks
Sean
On 11/27/2023 10:16 AM, Sean wrote:
We are looking at it.
It seems to be a problem in the edk2-basetools but at this point it
still isn
e thread when we have more info.
Thanks
Sean
On 11/21/2023 8:22 AM, Laszlo Ersek wrote:
Adding Sean
Laszlo
On 11/19/23 23:43, ryderkeys via groups.io wrote:
Hi all,
I am trying to build EDK2 from most recent Github (namely, EmulatorPkg) with
the new Stuart build system on Windows 10 22H2 64 bit
Reviewed-by: Sean Brogan
From: devel@edk2.groups.io on behalf of Michael Kubacki
Sent: Tuesday, November 14, 2023 12:22:24 PM
To: devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
; Michael D Kinney ;
Liming Gao
Subject: [edk2-devel] [PATCH v1 1/3
for the series
Reviewed-by: Sean Brogan
Thanks
Sean
On 11/2/2023 1:03 PM, Michael Kubacki wrote:
From: Michael Kubacki
CodeQL currently runs via the codeql-analysis.yml GitHub workflow
which uses the github/codeql-action/init@v2 action (pre-build)
and the github/codeql-action/analyze@v2
Reviewed-by: Sean Brogan
On 11/2/2023 1:03 PM, Michael Kubacki wrote:
From: Michael Kubacki
Since a large number of CodeQL queries are being enabled to identify
issues that the community can collectively resolve, audit mode needs to
be enabled to prevent the build from failing.
In the
Reviewed-by: Sean Brogan
On 11/2/2023 1:03 PM, Michael Kubacki wrote:
From: Michael Kubacki
Updates the CodeQL queries opted into by edk2 to a set of queries from
the standard CodeQL query package `codeql/cpp-queries`.
After testing a large number of queries the included set here were
found
for the series
Reviewed-by: Sean Brogan
On 10/6/2023 4:10 PM, Michael Kubacki wrote:
From: Michael Kubacki
Python 3.12 released recently. The Python version is currently
specified to allow updates to newer minor versions. Time is
needed to adjust scripts for Python 3.12 so this series fixes
On 9/7/2023 1:54 PM, Laszlo Ersek wrote:
On 9/7/23 19:50, Sean Brogan wrote:
I would argue that by declaring that your library class supports type
DXE_CORE (or any core type) that you have declared you understand the
uniqueness of the environment and have accounted for it.
For instances that
FdtPL011SerialPortLib to detect if it's init
routine has been called.
Thanks
Sean
On 9/7/2023 8:24 AM, Oliver Smith-Denny wrote:
On 9/7/2023 6:10 AM, Laszlo Ersek wrote:
(replying on the webui... sorry!)
The problem is actually embedded in MdePkg and MdeModulePkg.
- In DxeMain() (and in func
The breaking change would be in the future to move/make these structural
changes (package /repo) in the future after checking in this patch.
Thanks
Sean
On 8/31/2023 11:45 AM, Michael D Kinney wrote:
How is the current patch set a breaking change?
Mike
*From:* Sean Brogan
*Sent
ng these kinds of changes.
Thanks for consideration.
Sean
On 8/31/2023 10:24 AM, Michael D Kinney wrote:
Jiewen,
Thanks. Option #1 makes more sense if it is the Mbedtls
wrapper code.
I prefer Option #1.
Breaking out into multiple repos also makes it hard to align
Releases across multiple
eaking the tight coupling of edk2
stable tags from the crypto used in the code base (crypto has more
widely tracked vulnerabilities).
Happy to discuss more if others have different ideas.
Thanks
Sean
On 8/30/2023 12:52 AM, Wenxing Hou wrote:
*** Add BaseCryptLibMbedTls for CryptoPkg, which
to opt-out if they didn't want this new functionality.
Thanks
Sean
On 6/26/2023 5:59 PM, gaoliming via groups.io wrote:
Joey:
So, this change is required for all package YAML. If yes, can PrEval be
auto set to the package dsc if only one DSC is in Package dire
is one and provide a better
infrastructure to build on?
Thanks
Sean
On 6/23/2023 9:26 AM, Ard Biesheuvel wrote:
On Tue, 20 Jun 2023 at 19:07, Sean Brogan wrote:
I don't think a MemoryAttributes2Protocol with a single API would have avoided
the errors.
The programming pattern that trigge
This has moved over to https://github.com/tianocore/edk2-basetools/issues
I am sure any help you could offer would be appreciated.
Thanks
Sean
From: devel@edk2.groups.io on behalf of Rebecca Cran
Sent: Tuesday, June 20, 2023 6:25:21 PM
To: joe.hasselst
p to "stay
the course" for this very necessary industry change. If a production
platform has requirements that force such a configuration option that is
understandable but it is counter productive in open-source industry
standard reference Edk2 code.
Thanks
Sean
On 6/20/2023
On 6/8/2023 10:48 AM, Ard Biesheuvel wrote:
On Thu, 8 Jun 2023 at 19:39, Oliver Smith-Denny
wrote:
On 6/8/2023 10:23 AM, Ard Biesheuvel wrote:
Currently, we rely on the logic in DXE IPL to create new page tables
from scratch when executing in X64 mode, which means that we run with
the initial
of the reasons we had desired long term to align on
GitHub build services instead.
Other thoughts?
Thanks
Sean
From: Kinney, Michael D
Sent: Monday, May 29, 2023 8:13:32 AM
To: devel@edk2.groups.io ; spbro...@outlook.com
; a...@kernel.org ; Rebecca Cran
Cc:
It has been rerun.
From: devel@edk2.groups.io on behalf of Ard Biesheuvel
Sent: Monday, May 29, 2023 7:44:37 AM
To: Rebecca Cran
Cc: devel@edk2.groups.io ; Michael Kinney
; Michael Kubacki ;
Liming Gao (Byosoft address)
Subject: Re: [edk2-devel] failed Pr
O
On 5/3/2023 10:56 PM, Gerd Hoffmann wrote:
Hi,
I agree the iasl dependency for CI has not been managed consistently. When
all of the CI was setup we decided that iasl should be controlled by the
platform and thus EmulatorPkg, ArmVirt, and OVMF have their own extdep.
This gives those platf
o
Wiki
<https://github.com/tianocore/tianocore.github.io/wiki/How-to-Build-With-Stuart#how-to-build-in-edk2-with-stuart>).
For example the user would need to have also done: setup python virtual
env, install pypi dependencies, and clone source + submodules.
Thanks
Sean
On 5/3/2023 1
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Uses CPU RDRAND support and installs the EfiRngProtocol.
> The protocol may be used by iPXE or the Linux kernel to gather entropy.
>
> Cc: Guo Dong
> Cc: Ray Ni
&g
Reviewed-by: Sean Rhodes
On Tue, 25 Apr 2023 at 18:09, Benjamin Doron
wrote:
> From: Benjamin Doron
>
> Presently, `ArchIsRngSupported()` always returns TRUE, per
>
> https://github.com/tianocore/edk2/blob/1eeca0750af5af2f0e78437bf791ac2de74bde74/MdePkg/Library/BaseRngLib/Ran
t; can you share details.
Thanks
Sean
From: devel@edk2.groups.io on behalf of Michael D Kinney
Sent: Saturday, April 22, 2023 8:15:56 PM
To: Guo, Gua ; devel@edk2.groups.io
Cc: Sean Brogan ; Michael Kubacki
; Oliver Steffen ; Kinney,
Michael D
Subject: Re:
PR created at https://github.com/tianocore/edk2/pull/4231
On Mon, 3 Apr 2023 at 08:32, Sean Rhodes wrote:
> Reviewed-by: Sean Rhodes
>
> On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
> wrote:
>
>> Copied values from OVMF, these are sufficient for a debug build.
>>
>
Reviewed-by: Sean Rhodes
On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
wrote:
> Copied values from OVMF, these are sufficient for a debug build.
>
> Now that those are improved, remove
> PcdResetOnMemoryTypeInformationChange override. If the memory map must
> change, reset syste
Reviewed-by: Sean Rhodes
On Sat, 1 Apr 2023 at 00:58, Benjamin Doron
wrote:
> MemoryType information assists GCD with defragmenting the memory map.
> When the DXE core starts, GCD adds memory descriptors for the resource
> descriptors HOBs. This allocates heap space which can be reu
reviewed-by: Sean Brogan
On 3/31/2023 4:48 PM, Michael Kubacki wrote:
From: Michael Kubacki
Sets the rebase-strategy to "disabled" to prevent automatic
rebasing.
Rebasing can be done manually in the dependabot PR either through
the GitHub UI or the dependabot command.
Cc: Sean
Regardless of directory path I would suggest that all "Packages" have a
unique and descriptive name. MinBoardPkg doesn't meet that
suggestion. If/when the edk2 CI tools run I would expect problems/odd
behavior if two packages collide in naming.
Thanks
Sean
On 3/22/2023
Thanks Ray. Lets discuss this style of testing next week at the tools
and CI meeting.
Reviewed-by: Sean Brogan
On 3/31/2023 11:22 AM, Ni, Ray wrote:
The random test cases just run for too long that may cause timeout
in CI test.
Disable them for now.
Signed-off-by: Ray Ni
Hi Ray
Some members of the coreboot community want to centre the logo (as it is
currently) and some want to use the Microsoft recommended position. All we
want to do is have the option to build edk2 with one or the other.
Thanks
Sean
On Mon, 20 Mar 2023 at 09:56, Ni, Ray wrote:
> Sheng L
Hi Ray
> You can return a carefully-calculated X/Y value to make
the logo at MS preferred position.
As we discussed before, we need to have both options.
Thanks
Sean
On Wed, 8 Mar 2023 at 09:01, Ni, Ray wrote:
> Maybe I didn’t explain my idea clearly.
>
Reviewed-by: Sean Rhodes
On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph
wrote:
> Add protocol gEfiHiiPackageListProtocolGuid to DEPEX
> to make sure it's present before using it.
>
> Fixes ASSERTION seen on DEBUG build.
>
> Signed-off-by: Patrick Rudolph
> ---
Reviewed-by: Sean Rhodes
On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph
wrote:
> Drop the "-z max-page-size=0x40" option as it causes the ELF
> header to overflow into the .text section, causing undefined
> behaviour.
>
> With high optimization level it corrupts essent
>> payloads/external/edk2/workspace/tianocore/
>>
>>
>>
>> *Thanks & RegardsRitul Guru+91-9916513186*
>>
>>
>> On Wed, Feb 8, 2023 at 2:06 AM Sean Rhodes wrote:
>>
>>> Why the edk2 changes? Just to fix this issue?
>>>
>&
Why the edk2 changes? Just to fix this issue?
Have you seen L36 of payloads/external/edk2/Kconfig
On Tue, 7 Feb 2023 at 20:30, ritul guru wrote:
>
>
> Loading driver 378D7B65-8DA9-4773-B6E4-A47826A833E1
> InstallProtocolInterface: 5B1B31A1-9562-11D2-8E3F-00A0C969723B 51A3E1C0
> Loading driver a
8, 2023 at 12:31 AM ritul guru wrote:
>
>> building it inside coreboot only.
>>
>>
>>
>> *Thanks & RegardsRitul Guru+91-9916513186*
>>
>>
>> On Wed, Feb 8, 2023 at 12:00 AM Sean Rhodes
>> wrote:
>>
>>> Hi Ritul
>>&g
Hi Ritul
It might be easier to build it inside coreboot; that'll use coreboots tool
chain and Kconfig so everything will just work.
I.e. CONFIG_PAYLOAD_EDK2=y
Sean
On Tue, 7 Feb 2023, 18:24 ritul guru, wrote:
> UefiPayloadPkg/UefiPayloadPkg.fdf
> DEFINE FD_BASE = 0x0080
Hi Ray
Would it be possible to merge this?
Thanks
Sean
On Fri, 16 Dec 2022, 09:03 Ni, Ray, wrote:
> Reviewed-by: Ray Ni
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> > Sent: Friday, December 16, 2022 4:58 P
tests if not a full refactor of the
library. I also think the edk2 idea of "custom mode" should be
removed. But that feedback isn't for this patch and I don't think this
patch should be held up just because the surrounding code is less than
ideal.
For patch 1 and 4.
Revi
t in custom mode and the payload
is not targeted PK.
Thanks
Sean
On 1/25/2023 1:38 PM, Jan Bobek wrote:
Hi Sean,
From looking over the patch 1/4 email i have a concern.
In AuthService.c on the conditional change you made. Aren't we losing
a case where we are evaluating a nonPK pay
unit test of library is here:
edk2/SecurityPkg/Library/SecureBootVariableLib/UnitTest at master ·
tianocore/edk2 (github.com)
<https://github.com/tianocore/edk2/tree/master/SecurityPkg/Library/SecureBootVariableLib/UnitTest>
Thanks
Sean
On 1/22/2023 10:13 PM, Yao, Jiewen wrote:
Hi S
how about 10am pacific Jan 17th. should be 7pm your time?
Thanks
Sean
On 1/5/2023 3:48 PM, Théo Jehl wrote:
it work that day I believe, but only 2-3 hours later. Does that work
for you folks?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View
a lot of feedback from
the mailing list. If interested I can provide more info on our BDS in
Project Mu and reference platform bds implementation used here
microsoft/mu_tiano_platforms: Project Mu Virtual Platform Firmware
(github.com) <https://github.com/microsoft/mu_tiano_platforms>
Than
Reviewed-by: Sean Brogan
On 1/5/2023 4:44 PM, Guo, Gua wrote:
From: Gua Guo
Skip CodeCoverage if coverage.xml not found
Cc: Sean Brogan
Cc: Michael Kubacki
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Gua Guo
---
.azurepipelines/templates/pr-gate-build-job.yml | 8
1
More likely the library
should be promoted to a more "core" package.
Could your qemu open board pkg be built using stuart and setup to run
tests? More details about the goals and plans for the qemu open board pkg.
Thanks
Sean
On 1/4/2023 3:57 PM, Pedro Falcato wrote:
Sean,
Thank
to enable Core CI (started with Ext4Pkg and
Usb3DebugFeaturePkg as examples).
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97948): https://edk2.groups.io/g/devel/message/97948
Mute This Topic: https://groups.io/mt/96060477/2
roved (HTML
reports generated) and metrics tracked per package instead of build
wide. These topics can be discussed at the Monday tools meeting but I
think this series as is should be merged now to start collecting this data.
Thanks for all your efforts.
Series Reviewed-by: Sean Brogan
On 1/2
/edk2/blob/master/BaseTools/Edk2ToolsBuild.py
You can read a little more about the feature here.
https://www.tianocore.org/edk2-pytool-extensions/features/sde/#path_env-descriptors
Thanks
Sean
From: devel@edk2.groups.io on behalf of Michael D Kinney
Sent: Thu
Hi Hao
This PR has passed CI - https://github.com/tianocore/edk2/pull/3353
Thanks
Sean
On Fri, 23 Dec 2022 at 08:56, Wu, Hao A wrote:
> Sorry,
>
> The CI tests failed for the proposed patch:
> https://github.com/tianocore/edk2/pull/3824
>
> Could you help to check a
Okay, a bit more testing - it seems all debug builds hang at that point. I
tested back to edk2-stable202111 so I think that's a coreboot problem.
Your patch does resolve release builds not booting.
> Could you help to use latest Edk2 repo UPL to reproduce the issue that @Sean
Rhodes e
RSAL_PAYLOAD is not set.
>
> Cc: Ray Ni
> Cc: Sean Rhodes
> Cc: James Lu
> Cc: Gua Guo
> Signed-off-by: Guo Dong
> ---
> UefiPayloadPkg/UefiPayloadPkg.fdf | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/UefiPayloadPkg/UefiPayl
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Force resetting the port by clearing the USB_PORT_STAT_C_RESET bit in
PortChangeStatus
when XhcPollPortStatusChange fails
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the Compatible Port Offset to find
the starting Port of Root Hubs that support the protocol.
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c| 2 +-
MdeModulePk
Hi Mike
Thanks; didn't work but I'll have a play wth it!
Sean
On Thu, 15 Dec 2022 at 22:55, Michael D Kinney
wrote:
> Hi Sean,
>
>
>
> Yes, that is the correct section. Hard to tell from patch email alone.
>
>
>
> There is a git config that can always inc
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Hi Mike
Thank you; changed to PcdGetBool.
It's in `[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,
PcdsDynamicEx]` - is that not right?
Thanks
Sean
On Thu, 15 Dec 2022 at 22:09, Kinney, Michael D
wrote:
> Hi Sean,
>
> A couple comments related to the PCD type b
When set to true, the Logo is positioned according to the BGRT
specification, 38.2% from the top of the screen. When set to false,
no behaviour is changed and the logo is positioned centrally.
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Sean Rhodes
Thank you :)
On Thu, 8 Dec 2022 at 07:06, Chiu, Ian wrote:
> Hi Sean, Matt DeVillier,
>
> I checked the patch 0001-0004, we are find and agree with 0002-0004.
> For the patch
> 0001-MdeModulePkg-XhciDxe-XhciReg-Handle-incorrect-PSIV-indices.
> The case you mention below with
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the Compatible Port Offset to find
the starting Port of Root Hubs that support the protocol.
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c| 2 +-
MdeModulePk
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Jian J Wang
Cc: Liming Gao
Cc: Zhichao Gao
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library
hen on monday we can talk more if needed.
Thanks
Sean
[https://opengraph.githubassets.com/1743f87e9d9139f88783fef5e0cdeb31d956f016a4ea69c0c5489778f4834eb7/tianocore/edk2/discussions/3739]<https://github.com/tianocore/edk2/discussions/3739>
Integrate target-based testing into Platform CI fo
nough
representation we will host the topic next week as well (12/12/2022).
Join us for the Tools, CI, Code base construction meeting series ·
Discussion #2614 · tianocore/edk2 (github.com)
<https://github.com/tianocore/edk2/discussions/2614>
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=
Link to PR passing CI - https://github.com/tianocore/edk2/pull/3353
On Mon, 5 Dec 2022 at 09:18, Sean Rhodes via groups.io wrote:
> Adjusts the requirements for the MaxPacketLength to match what is seen on
> real world devices that do not follow the USB specification.
>
> This fixes
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Adjusts the requirements for the MaxPacketLength to match what is seen on
real world devices that do not follow the USB specification.
This fixes enumeration on the multiple USB 3 devices made by SanDisk,
Integral, Kingston and other generic brands.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean
lt is edk2 detecting USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the extended capability registers
for USB2 before USB3. If edk2 finds a match for a USB 2 device, don't
check for USB 3.
Cc: Hao A Wu
Cc: Ray Ni
Reviewe
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +
1 file changed, 9
We have a great unit test framework. Is there any reason we can’t write or
extend a unit test for bugs like this?
Thanks
Sean
From: devel@edk2.groups.io on behalf of Yao, Jiewen
Sent: Saturday, December 3, 2022 7:19:26 AM
To: Wenyi Xie ; devel@edk2.groups.io
Hi Hao
They are now resolved
Thanks
Sean
On Fri, 2 Dec 2022 at 06:25, Wu, Hao A wrote:
> Hello,
>
> I saw there are several CI check failures for this 4 patches:
> https://github.com/tianocore/edk2/pull/3702
>
> Could you help to resolve them? Thanks.
>
>
Adjusts the requirements for the MaxPacketLength to match what is seen on
real world devices that do not follow the USB specification.
This fixes enumeration on the multiple USB 3 devices made by SanDisk,
Integral, Kingston and other generic brands.
Cc: Hao A Wu
Cc: Ray Ni
Signed-off-by: Sean
From: Matt DeVillier
PSID matching relies on comparing the PSIV against the PortSpeed
value. This patch stops edk2 from checking for a PSIV of 0, as it
is not valid; this reduces the number of register access by
approximately 6 per second.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
From: Matt DeVillier
Only enumerate devices that have media present.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: Sean Rhodes
Signed-off-by: Matt DeVillier
Change-Id: I78a0b8be3e2f33edce2d43bbdd7670e6174d0ff8
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +
1 file changed, 9
lt is edk2 detecting USB2 devices as USB3 devices, which
consequently causes enumeration to fail.
To avoid incorrect detection, check the extended capability registers
for USB2 before USB3. If edk2 finds a match for a USB 2 device, don't
check for USB 3.
Cc: Hao A Wu
Cc: Ray Ni
Reviewed-by: S
rocess will not use qemu. The platform
Ci files have their own yml with container specifier.
6. what about removing the steps for installing node and cspell from the
container build? Since these are managed in the container they should
be skipped.
Thanks
Sean
On 11/29/2022 11:26 AM, Oli
Reviewed-by: Sean Brogan
On 11/15/2022 5:47 PM, Michael Kubacki wrote:
From: Michael Kubacki
Adds a GitHub issue template to direct contributors familiar with
GitHub's issue tracker to the external resources used by TianoCore.
Cc: Sean Brogan
Cc: Michael D Kinney
Signed-off-by: Mi
Reviewed-by: Sean Brogan
On 11/10/2022 5:46 AM, Michael Kubacki wrote:
From: Michael Kubacki
Enables dependabot in this repo so we can better alerted when
dependency updates are available.
This GitHub action will automatically create pull requests and
summarize the dependency details
1 - 100 of 460 matches
Mail list logo
