starting from scratch).
@Oliver Smith-Denny<mailto:o...@linux.microsoft.com> is this something you can
help with, please?
Regards,
Sami Mujawar
From: Rebecca Cran
Date: Thursday, 24 October 2024 at 00:49
To: devel@edk2.groups.io , Leif Lindholm
, Sami Mujawar
Subject: ArmPkg,ArmPlatf
Hi Nhi, Sam,
Apologies, this slipped off the radar.
The changes look good to me.
Is it possible to submit a pull request, please?
Regards,
Sami Mujawar
From: Nhi Pham OS
Date: Friday 6 September 2024 at 18:38
To: "devel@edk2.groups.io" , Sam Kaynor
, "rebe...@bsdio.com"
Hi Pierre,
Thank you for these changes.
For this series.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/09/2024, 12:39, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
From: Pierre Gondois mailto:pierre.gond
Hi Ard,
Sorry saw you reply a bit later.
Yes, this is the change we need.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120451): https://edk2.groups.io/g/devel/message/120451
Mute This Topic: https://groups.io
/ArmVExpressLibRTSM/ArmVExpressLib.inf
+
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
}
!else
# UEFI lives in FLASH and copies itself to RAM
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Hi Ard,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
In addition to this patch I required the following changes for the FVP to boot
to the UEFI shell.
edk2 repo:
---
diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf
b/ArmPlatformPkg
of next week.
We had internally discussed few ideas some time back to solve a similar issue.
I think we need a generic solution for ID generation and management.
Is it ok if we get back with our findings once Pierre is back, please?
Regards,
Sami Mujawar
From: Jeshua Smith
Date: Wednesday 14
Pushed as 82179fd690fe..82f2b92e0aab
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120239): https://edk2.groups.io/g/devel/message/120239
Mute This Topic: https://groups.io/mt/107049626/21656
Group Owner
Hi Levi,
Thank you for these fixes.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120232): https://edk2.groups.io/g/devel/message/120232
Mute This Topic
Hi Prabin,
Your patch does not cleanly apply. Can you share a github branch with your
patch, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120226): https://edk2.groups.io/g/devel/message/120226
Mute
this locally before merging.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120215): https://edk2.groups.io/g/devel/message/120215
Mute This Topic: https://groups.io/mt/107486797/21656
G
es.
I will fix this locally before merging, but please run the patchcheck script
before submitting patches for review.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120214): https:
Hi Prabin,
Thank you for this patch.
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120213): https://edk2.groups.io/g/devel/message/120213
Mute This Topic
, please?
Regards,
Sami Mujawar
From: Sami Mujawar
Date: Thursday 1 August 2024 at 16:53
To: "devel@edk2.groups.io" , "srikanth.ait...@amd.com"
, Ard Biesheuvel , Jiewen
Yao , Gerd Hoffmann
Subject: Re: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi
request ca
Hi Srikanth,
Thanks for reporting this issue. It is strange that the virtio-blk driver is
working with a similar change.
I am looking into why this may be failing.
Regards,
Sami Mujawar
From: on behalf of "Aithal, Srikanth via groups.io"
Reply to: "devel@edk2.groups.io&qu
Hi Ard,
Thank you for this patch series.
For Platform/ARM/*, these changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120161): https://edk2.groups.io/g/devel
Hi Ard,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120132): https://edk2.groups.io/g/devel/message/120132
Mute This Topic
Hi Himanshu,
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120064): https://edk2.groups.io/g/devel/message/120064
Mute This Topic: https://groups.io/mt
Hi Ard,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/07/2024, 09:25, "Ard Biesheuvel" mailto:ardb+...@google.com>> wrote:
From: Ard Biesheuvel mailto:a...@kernel.org>>
The PSCI reset librari
The patch at
https://edk2.groups.io/g/devel/topic/platforms_devel_dynamictables_reorg/107268665
fixes an issue with handling of Arch Common Namespace objects on Morello
platform.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View
,
Sami Mujawar
On 09/07/2024, 09:03, "Rohit Mathew" mailto:rohit.mat...@arm.com>> wrote:
Thank you, Sami, for letting me know. I had created a PR as well for making
sure the CI goes through here - https://github.com/tianocore/edk2/pull/5888
<https://github.com/tianocore/edk2/pul
introduced.
You will need to create a PR for the new series to progress.
Regards,
Sami Mujawar
On 08/07/2024, 22:35, "Rohit Mathew" mailto:rohit.mat...@arm.com>> wrote:
This series adds the following
* definitions corresponding to MPAM ACPI 2.0 specification.
* MPAM parser An M
: https://github.com/tianocore/edk2-staging.git
Branch: dynamictables-reorg
2. edk2-platforms codebase
Repo: https://github.com/tianocore/edk2-platforms.git
Branch: devel-dynamictables-reorg
We look forward for your test and feedback.
Regards,
Sami Mujawar & Pierre Gondois
IMPORTANT NOTICE:
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 04/07/2024, 09:44, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
From: Pierre Gondois mailto:pierre.gond...@arm.com>>
A
Hi Pierre,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 03/07/2024, 10:54, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
For X64 builds, the EFIAPI is replaced by '(__attribute__((ms_abi))
imilar changes are required elsewhere in this patch.
If you agree, I will make the changes before merging.
Otherwise, this series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Sunil,
I think we can look into that. My initial thoughts are that this can be solved
using a Pcd. However, we need a bit of investigation.
Is it ok if we address that in a separate patch?
Regards,
Sami Mujawar
On 03/07/2024, 10:37, "Sunil V L" mailto:suni...@ventanamicro.c
efore merging.
With that,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 19/06/2024, 23:06, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
The DynamicTables framework has mainly been developed/tested against Arm
architecture. While still trying to have re-usable
Hi Sunil,
Thank you for the review.
> +EFI_STATUS
> +EFIAPI
> +FdtGetIntcAddressCells (
> + IN CONST VOID *Fdt,
> + IN INT32 Node,
> + OUT INT32 *AddressCells, OPTIONAL
> + OUT INT32 *SizeCells OPTIONAL
NIT: I might be wrong but alignment doesn't look correct.
[SAMI] I wonder if this is an artifa
xes
the build break.
>
> Any objection?
I do not have any objection from 'Platforms/ARM' perspective for merging these
patches.
Regards,
Sami Mujawar
>
> /
> Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
Hi Leif,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119678): https://edk2.groups.io/g/devel/message/119678
Mute This Topic
/message/119534
Regards,
Sami Mujawar
On 10/06/2024, 10:47, "devel@edk2.groups.io <mailto:devel@edk2.groups.io> on
behalf of PierreGondois via groups.io" mailto:devel@edk2.groups.io> on behalf of pierre.gondois=arm@groups.io
<mailto:arm@groups.io>> w
Hi Pierre,
Thank you for this patch series.
These changes look good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 10/06/2024, 10:34, "pierre.gond...@arm.com <mailto:pierre.gond...@arm.com>"
mailto:pierre.gond...@arm.com>> wrote:
Hi All,
I have merged this series at
https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables-reorg.
The corresponding DynamicTablesPkg reorg changes are also merged at
https://github.com/tianocore/edk2-staging/tree/dynamictables-reorg
Regards,
Sami Mujawar
From: devel@edk2
Hi All,
I have merged the [1] and [2] series at
https://github.com/tianocore/edk2-staging/tree/dynamictables-reorg
I have also merged the Platform support series at
https://github.com/tianocore/edk2-platforms/tree/devel-dynamictables-reorg.
Regards,
Sami Mujawar
From: Sunil V L
Date
patch series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119514): https://edk2.groups.io/g/devel/message/119514
Mute This Topic: https://groups.io/mt/105069934/21656
Merged as fc4cd3545fe6..8f05785753aa
Thanks.
Regards,
Sami Mujawar
From: "Prabin CA via Groups.Io"
Reply to: Prabin CA
Date: Wednesday 5 June 2024 at 16:38
To: Sami Mujawar , "devel@edk2.groups.io"
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] Platform
Hi Prabin,
If you agree with my suggestions for patch 2/5, can you reply back on
the list, please?
I will then fix that patch locally before merging.
Other than patch 2/5 the rest of the series looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 4/3/24 18:33, Prabin CA
Hi Prabin,
Thank you for this patch.
Please see my response inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 4/3/24 18:33, Prabin CA wrote:
The PcdL2CacheSize PCD specifies the size of L2 cache of the CPU.
Use the size specified by this PCD in the
Merged as f69888ada859..35bca3ca71c0
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119355): https://edk2.groups.io/g/devel/message/119355
Mute This Topic: https://groups.io/mt/106365450/21656
Group Owner
Other than my comments for patch 14 and 15 (the changes for which I will fix
locally before merging), this patch series looks good to me.
For this series,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group
Hi Sahil,
I will drop the loop before merging the changes.
Other than that this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: Sahil Kaushal
Date: Wednesday 29 May 2024 at 12:51
To: Sami Mujawar , "devel@edk2.groups.io"
Cc: Ard Biesheuvel , Lei
Hi Sahil,
There is a typo in one of the macro names, see my comment inline marked [SAMI].
I will fix that up before merging.
Other than that, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus.
Hi Sahil,
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 29/05/2024, 09:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad
Hi Sahil,
I cannot apply your patches cleanly. Can you share a github branch with your
patches, please?
Regards,
Sami Mujawar
On 23/05/2024, 11:56, "Sahil Kaushal" mailto:sahil.kaus...@arm.com>> wrote:
From: sahil mailto:sa...@arm.com>>
Moving these functi
Hi Sahil,
Thank you for this patch.
I have a minor suggession marked inline as [SAMI].
Otherwise this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/05/2024 11:55 am, Sahil Kaushal wrote:
From: sahil
This patch adds error_handler1 and error_handler2 labels
Hi Sahil,
Please find my response inline marked [SAMI].
Regards,
Sami mujawar
On 21/05/2024 09:37 am, Sahil wrote:
Hi Sami,
Thank you for reviewing the patches.
Please find my comments inline below marked as [SAHIL].
Also, for the documentation headers, I will try to add in
Hi Sahil,
Please see my response marked inline as [SAMI].
Regards,
Sami Mujawar
On 21/05/2024 10:24 am, sahil via groups.io wrote:
Hi Sami,
Thank you for reviewing the patches.
Please find my comments inline below marked as [SAHIL].
On Thu, 16 May 2024 at 20:54, Sami Mujawar via groups.io
Hi Sahil,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 09/05/2024 07:25 am, Sahil wrote:
Hi Pierre, Thanks for reviewing the patchset. Please find my comment
inline below.
On Thu, 2 May 2024 at 18:47, PierreGondois via groups.io
<http://groups.io>
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
This driver enables Fault Tolerant Write protocol, which provides
fault tolerant write capability for block devices
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Enable persistent storage on QSPI flash device.
Signed-off-by: sahil
---
Platform/ARM/N1Sdp/N1SdpPlatform.dsc
Hi Sahil,
Thank you for this patch.
Please find my response inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
In N1Sdp platform, the SoC is connected to IOFPGA which has a
Cadence Quad SPI
Hi Sahil,
Thank you for this patch.
I have some suggestions marked inline below, otherwise this patch looks
good to me.
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Add NOR flash library, this library
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Enable SCP QSPI flash region access by adding it in the PlatformLibMem.
This flash is shared between AP core and
Hi Sahil,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawarnd
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
This patch adds an optional functionality in NorFlashDxe to fetch and
print NOR Flash information from NorFlashInfoLib using its
Hi Sahil,
Thank you for this patch.
I have a minor comment marked inline as [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
This variable holds the QSPI controller's base address.
It is defined in AR
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
NorFlashDeviceLib can be used to provide implementations of different
NOR Flash to NorFlashDxe, i.e. NorFlashDxe
Hi Sahil,
Thank you for this patch.
Please find my response inline marked [SAMI].
With that fixed,
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
This patch implements functions to interact with P30 NOR Flash.
The code is taken
Hi Sahil,
Thank you for this patch.
I have some feedback marked inline as [SAMI].
Other than that, is is possible to add documentation header for the functions
and data streuctures in this file, please?
With that fixed,
Reviewed-by: Sami Mujawar <mailto:sami.muja...@arm.com>
Regards,
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Refactoring done in this patch has two major parts:
1. Moving out NorFlashUnlockAndEraseSingleBlock and
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
This patch splits NorFlash.h and adds NorFlashCommon.h which
will have all the flash independent functions and
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Moving this function from NorFlash.c to NorFlashDxe.c as it is not
dependent on any particular flash implementation
Hi Sahil,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil
Moving these functions from NorFlash.c to NorFlashBlockIoDxe.c as
they are not dependent on any particular flash
Hi Liming,
If the decision is to merge this patch, I have created a pull request at
https://github.com/tianocore/edk2/pull/5647
Regards,
Sami Mujawar
From: on behalf of "Sami Mujawar via groups.io"
Reply to: "devel@edk2.groups.io" , Sami Mujawar
Date: Thursday 9
patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
From: on behalf of "gaoliming via groups.io"
Reply to: "devel@edk2.groups.io" ,
"gaolim...@byosoft.com.cn"
Date: Thursday 9 May 2024 at 10:01
To: "'Attar, AbdulLateef (Abdul L
Hi All,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 02/05/2024, 17:36, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote:
Hello Abdul,
I added some comments.
I think that:
a. patches related to HPET/WSMT should require little work
b. MAD
also requires changes in TF-A, and this work is
in progress.
Levi (Yeo) is currently working on this feature and will post the patches to
the mailing list once we have the necessary components ready.
Regards,
Sami Mujawar
On 01/05/2024, 22:32, "Oliver Smith-Denny"
f827334&l=74
Regards,
Sami Mujawar
On 16/04/2024, 00:30, "devel@edk2.groups.io <mailto:devel@edk2.groups.io> on
behalf of levi.yun via groups.io" mailto:devel@edk2.groups.io> on behalf of yeoreum.yun=arm@groups.io
<mailto:arm@groups.io>> wrote:
If a
Hi Ard,
Thank you for your feedback.
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 27/03/2024, 14:00, "Ard Biesheuvel" mailto:a...@kernel.org>> wrote:
Hello Sami,
On Tue, 26 Mar 2024 at 19:07, Sami Mujawar mailto:sami.muja...@arm.com>> wrote:
ux-arm/edk2-cca
edk2-platforms: https://gitlab.arm.com/linux-arm/edk2-platforms-cca
- Branch: 2865_arm_cca_v2
- URLs:
edk2: https://gitlab.arm.com/linux-arm/edk2-cca/-/tree/2865_arm_cca_v2
edk2-platforms:
https://gitlab.arm.com/linux-arm/edk2-platforms-cca/-
The RMM 1.0-eac4 introduces a new FID RSI_FEATURES
to query the RSI features supported that have been
implemented.
Therefore, introduce a new function RsiGetFeatures
to query the features supported by the RSI.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
() to return the lower and
higher revision that is supported by the RMM. The RsiGetVersion
function also returns the RSI version that is implemented by
the firmware.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h
value in subsequent calls.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/ArmCcaLib/ArmCcaLib.c | 31
1 file changed, 18 insertions(+), 13 deletions(-)
diff --git a/ArmVirtPkg/Library/ArmCcaLib/ArmCcaLib.c
b
apping operation and
return a suitable return code.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmCcaIoMmuDxe/ArmCcaIoMmu.c | 63 +++-
1 file changed, 61 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/ArmCcaIoMmu
.
The RSI version masks were incorrectly defined which
resulted in an incorrect RSI version being returned
by RsiGetVersion (). Therefore, fix the RSI version
masks to reflect the bit fields defined by the RMM
specification.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami
not.
Therefore, define the macros for specifying the
RsiRipasChangeFlags that represent the
RsiRipasChangeDestroyed type.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 20
1 file changed
: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h
b/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h
index
2b72ad09da85a9fd2f067db1c511d12f636d3dda
The RMM 1.0-bet2 spec expands the set of GPRs for RSI host call
to X0-X30.
Therefore, update the RSI HOST_CALL_ARGS structure to reflect
these changes.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 29
token buffer.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 31 ++--
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 160 +++-
2 files changed, 146 insertions(+), 45 deletions(-)
diff
change
request to RAM.
Such a failure is fatal and not recoverable and the caller
is then expected to tear down the Realm.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 26 +++-
ArmVirtPkg
: Sami Mujawar
---
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c
b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c
index
59b9d7a12c82a534280595328347995f1ff51ee2
have an impact for non-Arm CCA enabled systems.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 6 +-
ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf | 3 ++-
2 files changed, 7 insertions(+), 2
side effect as the behaviour
will be similar to that of release builds where the asserts
would be removed.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Sami Mujawar
---
MdePkg/Library/BaseRngLib/AArch64/Rndr.c
operations can be performed by bouncing buffers using pages shared
with the Host. It uses the Realm Aperture Management protocol to
share the buffers with the Host.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmCcaIoMmuDxe/ArmCcaIoMmu.c
The RMM 1.0-bet1 updates the width of the RsiHostCall
structure to 256 (0x100) bytes.
Therefore, update the RSI HOST_CALL_ARGS structure to reflect
these changes.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h
Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c
b/ArmVirtPkg/Library/ArmCcaRsiLib/ArmCcaRsiLib.c
index
enumeration values SHA-256 and SHA-512.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/ArmVirtPkg/Include/Library/ArmCcaRsiLib.h
b
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec
| 3 +
ArmVirtPkg/Include/Protocol/RealmApertureManagementProtocol.h
| 103 +++
ArmVirtPkg/RealmApertureManagementProtocolDxe
not.
Therefore, update the RsiSetIpaState() to add a new
parameter for specifying the RsiRipasChangeFlags.
Also update the usage of RsiSetIpaState() in ArmCcaInitPeiLib
and in RealmApertureManagementProtocolDxe.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 13 +++--
ArmVirtPkg/ArmVirtKvmTool.fdf | 10 ++
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
index
UINT16 and add an additional
field UINT8 Reserved1[6] for padding.
Also update the RsiHostCall() to initialise the Reserved1 field
to zero.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 4 +++-
ArmVirtP
RETURN_UNSUPPORTED.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 21
1 file changed, 21 insertions(+)
diff --git a/ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c
b
: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
index
c358b0a55daea8f8231b037cc63005cc86fe9a18..835e4f1a5a618537d885682322a288f12b8ce8dd
100644
--- a
s external
abort being reflected to the Realm by the RMM.
Therefore, link the Null version of DebugLib in PrePi stage.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtKvmTool.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/
on defines the following Realm Service Interfaces for
managing the IPA state:
* RSI_IPA_STATE_GET
* RSI_IPA_STATE_SET
Therefore, update the ArmCcaRsiLib to add interfaces to get and set the
IPA state of Realm memory pages.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-of
RETURN_UNSUPPORTED.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 22
+++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/ArmVirtPkg/Library
which configures the MMIO
regions as Unprotected IPA by setting the protection attribute in the
page tables for the MMIO regions.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/KvmtoolVirtMemInfoLib.c
device tree it hands off to the firmware. Therefore, introduce
an ArmVirt instance of ArmMontorLib that parses this device tree
to read the PSCI conduit value and issues monitor calls using
the appropriate conduit.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
functions to call the Realm
Service Interface.
Therefore, add these libraries in the Kvmtool guest firmware
workspace as part of enabling support for Arm CCA.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg
Section B4.3.3 RSI_HOST_CALL command.
Also update the ArmCcaRsiLib library to add a new interface
RsiHostCall () to make a Host call.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Gerd Hoffmann
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Include/Library/ArmCcaRsiLib.h | 36
1 - 100 of 1002 matches
Mail list logo
