Hi Sahil,

Thank you for this patch.

These changes look good to me.

Reviewed-by: Sami Mujawar <sami.muja...@arm.com>

Regards,

Sami Mujawar

On 23/04/2024 06:56 am, Sahil Kaushal wrote:
From: sahil <sa...@arm.com>

Enable persistent storage on QSPI flash device.

Signed-off-by: sahil <sa...@arm.com>
---
  Platform/ARM/N1Sdp/N1SdpPlatform.dsc | 19 ++++++++++++++-----
  Platform/ARM/N1Sdp/N1SdpPlatform.fdf |  2 ++
  2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc 
b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
index 46412bff7d78..fd630fa08c35 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.dsc
@@ -161,11 +161,9 @@
    # ACPI Table Version

    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20

-  # Runtime Variable storage

-  gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0

-  gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|TRUE

-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

+  # NOR flash support

+  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase|0x18F00000

+  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize|0x00020000

  
################################################################################

  #

@@ -197,6 +195,16 @@
        gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

    }

+  # NOR flash support

+  Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf {

+    <LibraryClasses>

+      
NorFlashDeviceLib|Platform/ARM/Library/CadenceQspiNorFlashDeviceLib/CadenceQspiNorFlashDeviceLib.inf

+      
NorFlashPlatformLib|Silicon/ARM/NeoverseN1Soc/Library/NorFlashLib/NorFlashLib.inf

+      NorFlashInfoLib|EmbeddedPkg/Library/NorFlashInfoLib/NorFlashInfoLib.inf

+    <PcdsFixedAtBuild>

+      gPlatformArmTokenSpaceGuid.PcdNorFlashRegBaseAddress|0x1C0C0000

+  }

+

    # Architectural Protocols

    ArmPkg/Drivers/CpuDxe/CpuDxe.inf

    ArmPkg/Drivers/ArmGic/ArmGicDxe.inf

@@ -217,6 +225,7 @@
    MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf {

      <LibraryClasses>

        NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf

+      
NULL|EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf

        BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf

    }

diff --git a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf 
b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
index 7aae8e6a753b..07118725f168 100644
--- a/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
+++ b/Platform/ARM/N1Sdp/N1SdpPlatform.fdf
@@ -140,6 +140,8 @@ READ_LOCK_STATUS   = TRUE
    INF ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf

    INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf

+  INF Platform/ARM/Drivers/NorFlashDxe/NorFlashDxe.inf

+

    INF Platform/ARM/Drivers/BootMonFs/BootMonFs.inf

    INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118969): https://edk2.groups.io/g/devel/message/118969
Mute This Topic: https://groups.io/mt/105690948/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to