[edk2-devel] [PATCH 0/3] Platform/ARM/Juno: Use RngDxeLib

2024-09-04 Thread PierreGondois
From: Pierre Gondois Juno's RngLib implementation is: - BaseRngLib.inf if a secure RngLib is enforced - BaseRngLibTimerLib.inf if a non-secure RngLib is tolerated BaseRngLib.inf relies on the Arm's RNDR instruction. The instruction returns a DRBG-generated random number. The DRBG used is consid

[edk2-devel] [PATCH 3/3] Platform/ARM/Juno: Use DxeRngLib.inf as default RngLib implementation

2024-09-04 Thread PierreGondois
From: Pierre Gondois Juno's RngLib implementation is: - BaseRngLib.inf if a secure RngLib is enforced - BaseRngLibTimerLib.inf if a non-secure RngLib is tolerated BaseRngLib.inf relies on the Arm's RNDR instruction. The instruction returns a DRBG-generated random number. The DRBG used is conside

[edk2-devel] [PATCH 1/3] Platform/ARM: Place MdeLibs.dsc.inc as the first include

2024-09-04 Thread PierreGondois
From: Pierre Gondois For a same MODELE_TYPE/ARCH LibraryClasses section, multiple libraries can be defined. E.g.: [LibraryClasses.AARCH64.DXE_DRIVER] ArmTrngLib|ArmPkg/Library/ArmTrngLib/ArmTrngLib.inf ArmTrngLib|MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.inf In such case, the late

[edk2-devel] [PATCH 2/3] Platform/ARM: Move PcdEnforceSecureRngAlgorithms to MdePkg

2024-09-04 Thread PierreGondois
From: Pierre Gondois Reflect the deplacement of PcdEnforceSecureRngAlgorithms from the NetworkPkg to the MdePkg. Signed-off-by: Pierre Gondois --- Platform/ARM/JunoPkg/ArmJuno.dsc | 2 +- Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 2 +- 2 files changed, 2 insertions(+), 2 delet

Re: [edk2-devel] [PATCH edk2-platform v1 1/2] ARM/VExpressPkg: Add HobPrintLib in StandaloneMm

2024-08-08 Thread PierreGondois
Hello Levi, NIT: I think it's commit 049e12c03d27 ("StandaloneMmPkg/Core: Dump all HOB info in entrypoint") which breaks the build (whenever StandaloneMmPkg/Core/StandaloneMmCore.inf is used). The following platforms should have the same modification I think: - Platform/Socionext/DeveloperBox/D

Re: [edk2-devel] [platforms/devel-dynamictables-reorg PATCH V1 1/1] Platform/ARM/Morello: Check platform specific arch common namespace objects

2024-07-26 Thread PierreGondois
Hello Himanshu, Thanks for the patch: Reviewed-by: Pierre Gondois Pierre On 7/17/24 12:43, Himanshu Sharma wrote: Add a check for platform specific arch common namespace object in ConfigurationManager.c file. Signed-off-by: Himanshu Sharma --- Platform/ARM/Morello/ConfigurationManager/Co

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 1/1] Platform/NXP:LX2160: Update paths to DynamicTables generators

2024-07-04 Thread PierreGondois
From: Pierre Gondois Update the paths to some DynamicTables generators to reflect the change done in the patch from the edk2 repository: DynamicTablesPkg: Acpi: Move generic libraries to common folder Signed-off-by: Pierre Gondois --- Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 6 +++---

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 0/1] Platform/NXP:LX2160: Update paths to DynamicTables

2024-07-04 Thread PierreGondois
From: Pierre Gondois Additional patch to appply on top of: - [platforms/devel-dynamictables-reorg PATCH 00/14] Platform: N1Sdp,Morello,NXP: Move DynamicTablesPkg obj to Arch Common https://edk2.groups.io/g/devel/message/119520 Cc: AbdulLateef Attar Cc: Girish Mahadevan Cc: Jeff Brasen Cc:

Re: [edk2-devel] [staging/dynamictables-reorg PATCH 1/2] DynamicTablesPkg: Fix conversion compiler warnings

2024-07-03 Thread PierreGondois
Hi Sami, On 7/3/24 12:35, Sami Mujawar wrote: Hi Pierre, Thank you for these patches. On 03/07/2024, 10:54, "Pierre Gondois" mailto:pierre.gond...@arm.com>> wrote: Some CM objects fields are wider than the targeted field in ACPI tables. Some assignments are also subject to data loss and tr

Re: [edk2-devel] [staging/dynamictables-reorg PATCH 00/15] Prepare libraries to support other archs

2024-07-03 Thread PierreGondois
he libraries that are generic enough to be directly re-used are moved to a Common/ directory. For some libraries, additional arch-specific hooks have been added to allow architectures specific modifications. --- Changes can be seen at: https://github.com/pierregondois/edk2/tree/pg/dyntables_

[edk2-devel] [staging/dynamictables-reorg PATCH 2/2] DynamicTablesPkg: Add EFIAPI to generators hooks

2024-07-03 Thread PierreGondois
For X64 builds, the EFIAPI is replaced by '(__attribute__((ms_abi))'. This might lead to build error for some ACPI tablte generators due to function prototype mismatch. Add the EFIAPI to ACPI table generator hooks: - ACPI_TABLE_GENERATOR_BUILD_TABLEEX - ACPI_TABLE_GENERATOR_FREE_TABLEEX Signed-of

[edk2-devel] [staging/dynamictables-reorg PATCH 1/2] DynamicTablesPkg: Fix conversion compiler warnings

2024-07-03 Thread PierreGondois
Some CM objects fields are wider than the targeted field in ACPI tables. Some assignments are also subject to data loss and trigger the following warnings: - '<': signed/unsigned mismatch - '=': conversion from 'UINTxx' to 'UINTyy', possible loss of data with xx > yy. Add checks/cast to remove the

[edk2-devel] [staging/dynamictables-reorg PATCH 0/2] DynamicTablesPkg: CI related fixes

2024-07-03 Thread PierreGondois
Small fixes reported while running the CI. These patches should be applied on top of: - [staging/dynamictables-reorg PATCH 00/15] Prepare libraries to support other archs https://edk2.groups.io/g/devel/message/119632 Cc: AbdulLateef Attar Cc: Girish Mahadevan Cc: Jeff Brasen Cc: Jeshua Smit

[edk2-devel] [staging/dynamictables-reorg PATCH 14/15] DynamicTablesPkg: FdtHwInfoParserLib: Move IRQ map to arch folder

2024-06-19 Thread PierreGondois
The interrupts-extended property in DT is arch specific. Move the current implementation and the way to decode the property to the Arm folder to prepare for other architecture support. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Arm/ArmFdtUtility.c| 85 +

[edk2-devel] [staging/dynamictables-reorg PATCH 15/15] DynamicTablesPkg: FdtHwInfoParserLib: Create wrapper to get INTC addr cells

2024-06-19 Thread PierreGondois
Parent interrupt controller's address cells is arch specific. So, create a wrapper function which can be implemented differently for different archs. Move current implementation to ARM specific file. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../AcpiSsdtPcieLib/SsdtPcieGenerator

[edk2-devel] [staging/dynamictables-reorg PATCH 13/15] DynamicTablesPkg: FdtHwInfoParserLib: Move ArmLib.h to ArmGicCParser.c

2024-06-19 Thread PierreGondois
ArmLib.h is required only for building GIC in ARM. So, move it to ARM specific file. Otherwise, FdtHwInfoParserInclude.h being a common header across architectures will have issue on other architectures. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../Library/FdtHwInfoParserLib/Ar

[edk2-devel] [staging/dynamictables-reorg PATCH 12/15] DynamicTablesPkg: FdtHwInfoParserLib: Make Serial Port parser arch neutral

2024-06-19 Thread PierreGondois
To allow other architectures to potentially re-use the serial port parser and make the code arch neutral, remove the Arm prefixes. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Arm/ArmFdtHwInfoParser.c | 2 +- .../FdtHwInfoParserLib/FdtHwInfoParserLib.inf

[edk2-devel] [staging/dynamictables-reorg PATCH 10/15] DynamicTablesPkg: FdtHwInfoParserLib: Refactor to prepare for other archs

2024-06-19 Thread PierreGondois
To allow other architectures to potentially re-use the serial port parser and make the code arch neutral, make the MainDispatcher() function arch specific. Other architectures can choose which parse/dispatcher are desired to be called through the configuration of the HwInfoParserTable. Suggested-

[edk2-devel] [staging/dynamictables-reorg PATCH 11/15] DynamicTablesPkg: FdtHwInfoParserLib: Make Pci parser arch neutral

2024-06-19 Thread PierreGondois
To allow other architectures to potentially re-use the serial port parser and make the code arch neutral, remove the Arm prefixes. Also remove the check searching for a GIC version. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Arm/ArmFdtHwInfoParser.c | 4 ++

[edk2-devel] [staging/dynamictables-reorg PATCH 09/15] DynamicTablesPkg: FdtHwInfoParserLib: Move ARM parsers to Arm directory

2024-06-19 Thread PierreGondois
Create an Arm directory in the FdtHwInfoParserLib as a preparation step to support other architectures. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../{ => Arm}/BootArch/ArmBootArchParser.c| 2 +- .../{ => Arm}/BootArch/ArmBootArchParser.h| 0 .../GenericTimer/ArmGeneri

[edk2-devel] [staging/dynamictables-reorg PATCH 07/15] DynamicTablesPkg: AcpiSsdtCpuTopologyLib: Avoid dependency on GICC

2024-06-19 Thread PierreGondois
The GICC is an ARM specific structure. Other architectures have different local interrupt controller structures from which CPU topology can be created. Avoid the GICC reference in common code by: - creating a wrapper CreateTopologyFromIntC() instead of CreateTopologyFromGicC() so that different a

[edk2-devel] [staging/dynamictables-reorg PATCH 08/15] DynamicTablesPkg: DynamicTableManagerDxe: Refactor PresenceArray

2024-06-19 Thread PierreGondois
Mandatory ACPI tables depend on the architectures. Different architectures might also want to check other tables. Move mAcpiVerifyTables containing the list of ACPI tables to check to an arch specific file and introduce GetAcpiTablePresenceInfo() to get get the relevant information from the array.

[edk2-devel] [staging/dynamictables-reorg PATCH 06/15] DynamicTablesPkg: AcpiSratLib: Prepare to support other archs

2024-06-19 Thread PierreGondois
Allow other architectures to reuse the AcpiSratLib by extracting the Arm specific part of the table generation. Signed-off-by: Pierre Gondois --- .../Acpi/Common/AcpiSratLib/AcpiSratLib.inf | 7 + .../Common/AcpiSratLib/Arm/ArmSratGenerator.c | 262 ++ .../AcpiSratLib/Common/

[edk2-devel] [staging/dynamictables-reorg PATCH 05/15] DynamicTablesPkg: AcpiSpcrLib: Prepare to support other archs

2024-06-19 Thread PierreGondois
Remove the Arm name from the generator to show the generator can be used by other archs. Signed-off-by: Pierre Gondois --- .../Library/Acpi/Common/AcpiSpcrLib/SpcrGenerator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Common/Acpi

[edk2-devel] [staging/dynamictables-reorg PATCH 03/15] DynamicTablesPkg: AcpiFadtLib: Prepare to support other archs

2024-06-19 Thread PierreGondois
Allow other architectures to reuse the AcpiFadtLib by extracting the Arm specific part of the table generation. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois --- .../Acpi/Common/AcpiFadtLib/AcpiFadtLib.inf | 7 + .../Common/AcpiFadtLib/Arm/ArmFadtGenerator.c | 126 ++

[edk2-devel] [staging/dynamictables-reorg PATCH 04/15] DynamicTablesPkg: AcpiDbg2Lib: Prepare to support other archs

2024-06-19 Thread PierreGondois
Allow other architectures to reuse the AcpiDbg2Lib by extracting the Arm specific part of the table generation. Signed-off-by: Pierre Gondois --- .../Acpi/Common/AcpiDbg2Lib/AcpiDbg2Lib.inf | 7 ++ .../Common/AcpiDbg2Lib/Arm/ArmDbg2Generator.c | 67 +++ .../AcpiDbg2Lib/Common/

[edk2-devel] [staging/dynamictables-reorg PATCH 02/15] DynamicTablesPkg: Acpi: Prepare common libraries to support other archs

2024-06-19 Thread PierreGondois
Allow other architectures to reuse ACPI common libraries by: - Removing the Arm prefix from the BASE_NAME - Moving Arm specific libraries/packages to ARM/AARCH64 specific sections in the .inf files Also remove the empty .inf sections. Suggested-by: Sunil V L Signed-off-by: Pierre Gondois ---

[edk2-devel] [staging/dynamictables-reorg PATCH 01/15] DynamicTablesPkg: Acpi: Move generic libraries to common folder

2024-06-19 Thread PierreGondois
Some of the ACPI table generators are generic enough to be re-used by other architectures. Move the following generators to a 'Common' folder: - AcpiDbg2Lib - AcpiFadtLib - AcpiMcfgLib - AcpiPcctLib - AcpiPpttLib - AcpiRawLib - AcpiSpcrLib - AcpiSratLib - SsdtSerialPortLib - SsdtCpuTopologyLib - Ss

[edk2-devel] [staging/dynamictables-reorg PATCH 00/15] Prepare libraries to support other archs

2024-06-19 Thread PierreGondois
/ directory. For some libraries, additional arch-specific hooks have been added to allow architectures specific modifications. --- Changes can be seen at: https://github.com/pierregondois/edk2/tree/pg/dyntables_libraries_reorg --- References: 1. Staging branch creation: URL: https://edk2

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-06-11 Thread PierreGondois
On 6/10/24 18:28, Leif Lindholm wrote: On 2024-03-14 20:21, PierreGondois wrote: v2: - Move files to MdePkg/Include/Register/ instead of MdePkg/Include/ This patch relies on [1]. Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1], move the Chipset/* files to the MdePkg as the

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 14/14] Platform/NXP: Move Pci Config Space info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the NXP platforms for the following Arch Common object Id: - EArchCom

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 11/14] Platform/NXP: Add Arch Common objects handler

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Prepare the handling of these objects in the ConfigurationManagers by adding a function handler for these objects. This patch modifies the ConfigurationManager of the NXP platfo

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 10/14] Platform/ARM: N1Sdp: Move Memory Affinity info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - N1Sdp for the following Arch Common object

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 13/14] Platform/NXP: Move Serial Port info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the NXP platforms for the following Arch Common object Id: - EArchCom

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 12/14] Platform/NXP: Move Power Mgmt Profile info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the NXP platforms for the following Arch Common object Id: - EArchCom

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 06/14] Platform/ARM: Morello,N1Sdp: Move Pci Config Space info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 07/14] Platform/ARM: Morello,N1Sdp: Rename GicCToken

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. The following field: (struct CmArchCommonProcHierarchyInfo).GicCToken was renamed to 'AcpiIdObjectToken'. Reflect this change in the edk2-platforms repository. This patch modi

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 09/14] Platform/ARM: Morello,N1Sdp: Move Cache info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 08/14] Platform/ARM: Morello,N1Sdp: Move Proc Hierarchy info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 05/14] Platform/ARM: Morello,N1Sdp: Move CmRef info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 04/14] Platform/ARM: Morello,N1Sdp: Move Fixed Feat Flags info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 03/14] Platform/ARM: Morello,N1Sdp: Move Serial Port info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 02/14] Platform/ARM: Morello,N1Sdp: Move Power Mgmt Profile info to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Morello - N1Sdp for the following Arch Com

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 00/14] Platform: N1Sdp,Morello,NXP: Move DynamicTablesPkg obj to Arch Common

2024-06-10 Thread PierreGondois
From: Pierre Gondois Patches for the DynamicTablesPkg reorg branches are still sent through the mailing list for now. A branch with the patches is available at: https://github.com/pierregondois/edk2-platforms/pull/new/pg/Morello_N1Sdp_NXP_plat_reorg References: - edk2 reorg branch: https

[edk2-devel] [platforms/devel-dynamictables-reorg PATCH 01/14] Platform/ARM: Morello,N1Sdp: Add Arch Common objects handler

2024-06-10 Thread PierreGondois
From: Pierre Gondois Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Prepare the handling of these objects in the ConfigurationManagers by adding a function handler for these objects. This patch modifies the ConfigurationManager of the following

Re: [edk2-devel] [PATCH v2 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-06-03 Thread PierreGondois
Hello, Just a ping in case this was left aside and as the patch-set (+ Leif's initial patch) are a prerequisite to enable arm64 native instruction support for the openssllib, which would also allow to use openssl's DRBG, Regards, Pierre On 3/14/24 15:51, Pierre Gondois wrote: v2: - Move files t

Re: [edk2-devel] [PATCH v2 07/13] SecurityPkg: RngDxe: Remove incorrect limitation on GetRng

2024-05-13 Thread PierreGondois
Hello, The patch looks good to me: Reviewed-by: Pierre Gondois Regards, Pierre On 5/11/24 02:24, Yao, Jiewen wrote: Thanks to confirm that. I am OK on what you have said. Since the ARM part is added by Pierre Gondois pierre.gond...@arm.com , I will let him com

Re: [edk2-devel] [PATCH v1 0/4] Add EINJ table parser.

2024-05-13 Thread PierreGondois
Hello, For the whole patch-set: Reviewed-by: Pierre Gondois Thanks, Pierre On 5/10/24 14:22, levi.yun wrote: Add Error Injection Table (EINJ) parser for AcpiView and add some missing Error Injection Action definitions in each Acpi* headers. The changes can be seen at: https://github.com/

Re: [edk2-devel] [PATCH] DynamicTablesPkg: Adds integer to the AML package node

2024-05-06 Thread PierreGondois
Hello Abdul, With the changes below: Reviewed-by: Pierre Gondois On 5/6/24 05:08, Abdul Lateef Attar wrote: Adds an AmlAddIntegerPackageEntry() API to generate AML code, which adds an integer value to the package node. Cc: Pierre Gondois Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar

Re: [edk2-devel] [RESEND PATCH v4 5/5] DynamicTablesPkg: Adds X64 arch MADT Table generator

2024-05-02 Thread PierreGondois
Hello Abdul, some comments on the patch: On 4/29/24 08:03, Abdul Lateef Attar wrote: Adds X64 architecture specific MADT/APIC Table generator. Register/Deregister MADT table. Adds X64 architecture namespace objects. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar ---

Re: [edk2-devel] [RESEND PATCH v4 4/5] DynamicTablesPkg: Adds ACPI SSDT HPET Table generator

2024-05-02 Thread PierreGondois
Hello Abdul, some comments on the patch: On 4/29/24 08:03, Abdul Lateef Attar wrote: Adds generic ACPI SSDT HPET table generator library. Register/Deregister HPET table. Adds ACPI namespace object for HPET device. Adds Address space for HPET device. Cc: Sami Mujawar Cc: Pierre Gondois Signed-

Re: [edk2-devel] [RESEND PATCH v4 3/5] DynamicTablesPkg: Adds ACPI WSMT Table generator

2024-05-02 Thread PierreGondois
Hello Abdul, some comments on the patch: On 4/29/24 08:03, Abdul Lateef Attar wrote: Adds generic ACPI WSMT table generator library. Register/Deregister WSMT table. Update the WSMT table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar -

Re: [edk2-devel] [RESEND PATCH v4 2/5] DynamicTablesPkg: Adds ACPI HPET Table generator

2024-05-02 Thread PierreGondois
Hello Abdul, some comments on the patch: On 4/29/24 08:03, Abdul Lateef Attar wrote: Adds generic ACPI HPET table generator library. Register/Deregister HPET table. Update the HPET table during boot as per specification. Cc: Sami Mujawar Cc: Pierre Gondois Signed-off-by: Abdul Lateef Attar -

Re: [edk2-devel] [RESEND PATCH v4 0/5] DynamicTablesPkg: Adds FADT, HPET, WSMT and MADT Table generators

2024-05-02 Thread PierreGondois
Hello Abdul, I added some comments. I think that: a. patches related to HPET/WSMT should require little work b. MADT patch needs to redefine the CmObjects it uses, but it seems ok otherwise (just need to have the right properties in the right objects), c. FADT patch is re-defining CmObjects

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 00/14] Split NorFlashDxe driver and add CadenceQspiNorFlashDeviceLib library

2024-05-02 Thread PierreGondois
Hello Sahil, I had some comments for: - [PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe for all the other patches: Reviewed-by: Pierre Gondois Also, unless I missed something, shouldn't your mail address/signed-off tag be: 'Sahil ' -> 'Sahil Kaushal ' ? Reg

Re: [edk2-devel] [PATCH RESEND edk2-platforms][PATCH V2 12/14] Platform/ARM: Add CadenceQspiNorFlashDeviceLib for NorFlashDxe

2024-05-02 Thread PierreGondois
Hello Sahil, On 4/23/24 07:56, Sahil Kaushal via groups.io wrote: From: sahil In N1Sdp platform, the SoC is connected to IOFPGA which has a Cadence Quad SPI (QSPI) controller. This QSPI controller manages the flash chip device via QSPI bus. This patch adds CadenceQspiNorFlashDeviceLib which i

Re: [edk2-devel] [PATCH 1/1] BaseTool/Ecc: Fix incorrect parsing of variable initialisation

2024-04-16 Thread PierreGondois
Tested-by: Pierre Gondois On 4/15/24 20:59, levi.yun wrote: If a global variable is initialised using a macro with multiple arguments, ECC incorrectly parses the statement and reports the macro arguments as variable declarations. Example: In the following statement: STATIC INT WrongVariable

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-27 Thread PierreGondois
Hello Leif, On 3/12/24 17:47, Leif Lindholm wrote: On 2024-03-12 02:18, Pierre Gondois wrote: This patch relies on [1]. Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1], move the Chipset/* files to the MdePkg as the Armlib.h relies on them. These patches span over multiple pac

Re: [edk2-devel] [PATCH 00/19] DynamicTablesPkg: Move objects to Arch Common NameSpace (second)

2024-03-21 Thread PierreGondois
Hello, For reference: Patchsets: - https://edk2.groups.io/g/devel/message/116961 (first part) - https://edk2.groups.io/g/devel/message/116978 (second part) - https://edk2.groups.io/g/devel/message/117001 (platforms patches) Branches: - https://github.com/pierregondois/edk2/tree/sami

[edk2-devel] [PATCH 14/14] Platform/ARM: Juno: Move Psd info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjPsd

[edk2-devel] [PATCH 13/14] Platform/ARM: Juno: Move Cpc info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjCpc

[edk2-devel] [PATCH 12/14] Platform/ARM: Juno: Move Cache info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjCac

[edk2-devel] [PATCH 11/14] Platform/ARM: Juno: Move Proc Hierarchy info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjPro

[edk2-devel] [PATCH 10/14] Platform/ARM: Juno: Rename GicCToken

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. The following field: (struct CmArchCommonProcHierarchyInfo).GicCToken was renamed to 'AcpiIdObjectToken'. Reflect this change in the edk2-platforms repository. This patch modifies the ConfigurationM

[edk2-devel] [PATCH 09/14] Platform/ARM: Juno: Move Lpi info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjLpi

[edk2-devel] [PATCH 08/14] Platform/ARM: Juno: Move Pci Interrupt Map info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjPci

[edk2-devel] [PATCH 07/14] Platform/ARM: Juno: Move Pci Address Map info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjPci

[edk2-devel] [PATCH 06/14] Platform/ARM: FVP,Juno: Move Pci Config Space info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP for the following Arch Common object Id: - EArchCommon

[edk2-devel] [PATCH 05/14] Platform/ARM: Juno: Move CmRef info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno for the following Arch Common object Id: - EArchCommonObjCmR

[edk2-devel] [PATCH 04/14] Platform/ARM: FVP: Move Fixed Feat Flags info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - FVP for the following Arch Common object Id: - EArchCommonObjFixe

[edk2-devel] [PATCH 03/14] Platform/ARM: FVP,Juno:: Move Serial Port info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP for the following Arch Common object Id: - EArchCommon

[edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP for the following Arch Common object Id: - EArchCommon

[edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Prepare the handling of these objects in the ConfigurationManagers by adding a function handler for these objects. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP

[edk2-devel] [RESEND PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common

2024-03-21 Thread PierreGondois
xpress The following platforms were not updated yet: - Platform/ARM/N1Sdp - Platform/ARM/Morello - Platform/NXP/ConfigurationManagerPkg A branch holding the whole patchset is available at: - https://github.com/pierregondois/edk2-platforms/tree/pg/arch_common_obj_sent [1] Branch to reorg Dynamic Tables

[edk2-devel] [PATCH 02/14] Platform/ARM: FVP,Juno: Move Power Mgmt Profile info to Arch Common

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Reflect this change by renaming/moving the relevant object. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP for the following Arch Common object Id: - EArchCommon

[edk2-devel] [PATCH 01/14] Platform/ARM: FVP,Juno: Add Arch Common objects handler

2024-03-21 Thread PierreGondois
Some DynamicTables objects have been moved from the Arm namespace to a new Arch Common namespace. Prepare the handling of these objects in the ConfigurationManagers by adding a function handler for these objects. This patch modifies the ConfigurationManager of the following platforms: - Juno - FVP

[edk2-devel] [PATCH 00/14] Platform/ARM: FVP, Juno: Move DynamicTablesPkg obj to Arch Common

2024-03-21 Thread PierreGondois
holding the whole patchset is available at: - https://github.com/pierregondois/edk2-platforms/tree/pg/arch_common_obj_sent [1] Branch to reorg Dynamic Tables & support other arch https://edk2.groups.io/g/devel/topic/104054584#116308 [2] DynamicTablesPkg: Arch Common Namespace https://

[edk2-devel] [PATCH 18/19] DynamicTablesPkg: Move PCC Type 5 info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCC Subspace Type 5 info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PCCT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map.

[edk2-devel] [PATCH 19/19] DynamicTablesPkg: Move PSD info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PSD info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SSDT CPU topology generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. C

[edk2-devel] [PATCH 16/19] DynamicTablesPkg: Move PCC Type2 info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCC Subspace Type2 info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PCCT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map.

[edk2-devel] [PATCH 17/19] DynamicTablesPkg: Move PCC Type 3 & 4 info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCC Subspace Type 3 & 4 info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PCCT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer

[edk2-devel] [PATCH 15/19] DynamicTablesPkg: Move PCC Type1 info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCC Subspace Type1 info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PCCT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map.

[edk2-devel] [PATCH 14/19] DynamicTablesPkg: Move PCC Type0 info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCC Subspace Type0 info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PCCT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map.

[edk2-devel] [PATCH 13/19] DynamicTablesPkg: Move PCC structure definitions to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move PCC structure definitions from Arm Namespace header file to the Arch Common namespace header file. Cc: Pierre Gondois Cc: Yeo Reum Yun Cc: AbdulLateef Attar Cc: Jeshua Smith Cc: Jeff Brasen Cc: Girish Mahadevan Cc: Leif Lindholm Cc: Meenakshi Aggarwal Signed-off-b

[edk2-devel] [PATCH 11/19] DynamicTablesPkg: Move Cache info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the Cache info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PPTT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. Cc: Pierre G

[edk2-devel] [PATCH 12/19] DynamicTablesPkg: Move Continuous perf control info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the Continuous perfformance control info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SSDT CPU topology generator - ConfigurationManagerObjectParser - Dynamic

[edk2-devel] [PATCH 10/19] DynamicTablesPkg: Move Processor hierarchy info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the Processor hierarchy info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PPTT generator - SSDT CPU topology generator - ConfigurationManagerObjectParser - Dy

[edk2-devel] [PATCH 09/19] DynamicTablesPkg: Rename GicCToken field in Processor Hierarchy Info

2024-03-21 Thread PierreGondois
From: Sami Mujawar The GicCToken field in the CM_ARM_PROC_HIERARCHY_INFO structure is a reference to the associated object which has the corresponding ACPI Processor ID, e.g. for Arm systems this is a reference to the CM_ARM_GICC_INFO object. For other architecture this may be a reference to a si

[edk2-devel] [PATCH 08/19] DynamicTablesPkg: Move LPI info object to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the LPI info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SSDT Cpu Topology generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. C

[edk2-devel] [PATCH 07/19] DynamicTablesPkg: Move Generic Initiator affinity info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the Generic Initiator affinity info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SRAT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFix

[edk2-devel] [PATCH 06/19] DynamicTablesPkg: Move PCI device Handle object to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the PCI device Handle object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SRAT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. Cc: P

[edk2-devel] [PATCH 05/19] DynamicTablesPkg: Move ACPI device Handle object to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the ACPI device Handle object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SRAT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. Cc:

[edk2-devel] [PATCH 04/19] DynamicTablesPkg: Move Mem Affinity Info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move the Memory Affinity Info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SRAT generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map. Cc

[edk2-devel] [PATCH 03/19] DynamicTablesPkg: Move Pci Interrupt Map Info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move Pci Interrupt Map Info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SSDT PCIe library - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map -

[edk2-devel] [PATCH 02/19] DynamicTablesPkg: Move CM_ARM_GENERIC_INTERRUPT struct to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar The CM_ARM_GENERIC_INTERRUPT struct describes a standard interrupt and is generic. Therefore move it to the Arch Common namespace header file and rename it as CM_ARCH_COMMON_GENERIC_INTERRUPT. Correspondingly also update the following modules to reflect the changes introduced

[edk2-devel] [PATCH 01/19] DynamicTablesPkg: Move Pci Address Map Info to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move Pci Address Map Info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - SSDT PCIe generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map -

[edk2-devel] [PATCH 00/19] DynamicTablesPkg: Move objects to Arch Common NameSpace (second)

2024-03-21 Thread PierreGondois
/devel/message/116961 A branch holding the whole patchset is available at: - https://github.com/pierregondois/edk2/tree/sami/arch_common_obj_sent [1] Branch to reorg Dynamic Tables & support other arch https://edk2.groups.io/g/devel/topic/104054584#116308 [2] DynamicTablesPkg: Arch Common Names

[edk2-devel] [PATCH 16/16] DynamicTablesPkg & ArmVirtPkg: Move Pci Config Space Info

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move Pci Config Space Info object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - MCFG generator - SSDT PCIe generator - SSDT PCIe support library - ConfigurationManagerObje

[edk2-devel] [PATCH 15/16] DynamicTablesPkg: Move Cm Reference object to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move Cm Reference object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - PPTT generator - SSDT CPU topology generator - SSDT PCIe generator - ConfigurationManagerObjectParse

[edk2-devel] [PATCH 14/16] DynamicTablesPkg: Move FADT Fixed Features Flags to Arch Common

2024-03-21 Thread PierreGondois
From: Sami Mujawar Move FADT Fixed Features Flags object from Arm Namespace to the Arch Common namespace. Correspondingly also update the following modules to reflect the changes introduced by the move: - FADT Generator - ConfigurationManagerObjectParser - Dynamic Plat Repo TokenFixer map.

  1   2   3   4   5   6   7   8   9   10   >