Andrew, Ard,
In that case then I will update the patch to address Mike’s concerns and send a
new version up.
Thanks!
From: Andrew Fish
Sent: Wednesday, April 28, 2021 10:58 PM
To: Ard Biesheuvel
Cc: Kinney, Michael D ; edk2-devel-groups-io
; Loh, Tien Hock ;
thlo...@gmail.com; Leif
From: Loh Tien Hock
This adds support for Designware SDMMC driver. The SDMMC driver depends on
MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The
driver uses MMIO to read/write, and uses
gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device
with
From: Loh Tien Hock
This adds support for Designware SDMMC driver. The SDMMC driver depends on
MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The
driver uses MMIO to read/write, and uses
gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device
Please skip this patch, I missed one file in the patch.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#72570): https://edk2.groups.io/g/devel/message/72570
Mute This Topic: https://groups.io/mt/81194433/21656
Group Owner: devel+ow...@edk2
From: Loh Tien Hock
This adds support for Designware SDMMC driver. The SDMMC driver depends on
MdeModulePkg/Bus/Sd/, and produces EFI_SD_MMC_PASS_THRU_PROTOCOL. The
driver uses MMIO to read/write, and uses
gEdkiiNonDiscoverableDeviceProtocolGuid. Platform needs to register device
Hi Leif, Ard,
Sorry I've been working non EDK2 work for the past year and am now back to
working on this
Can you comment on the changes that is needed to get this driver upstreamed?
Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Onl
Hi Leif, Ard,
Can you help on the questions I have below?
Thanks!
> -Original Message-
> From: Loh, Tien Hock
> Sent: Tuesday, June 16, 2020 4:39 PM
> To: 'Haojian Zhuang' ; 'leif.lindh...@linaro.org'
> ; 'ard.biesheu...@linaro.org'
>
nges would help me understand and fix the concern you
have.
Thanks
> -Original Message-
> From: Loh, Tien Hock
> Sent: Thursday, September 12, 2019 12:59 PM
> To: Haojian Zhuang ; leif.lindh...@linaro.org;
> ard.biesheu...@linaro.org; christopher...@microsoft.com
&g
Hi Leif,
Yes, that's a Reviewed-by.
Thanks.
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, April 29, 2020 7:16 PM
> To: Loh, Tien Hock
> Cc: Pankaj Bansal ; Ard Biesheuvel
> ; Gaurav Jain ; Meenakshi
> Aggarwal ; devel@edk2.groups.io; Haoj
Pankaj Bansal
> Sent: Monday, April 27, 2020 2:19 PM
> To: Ard Biesheuvel ; Leif Lindholm
> ; Gaurav Jain ; Meenakshi
> Aggarwal
> Cc: devel@edk2.groups.io; Haojian Zhuang ; Loh,
> Tien Hock ; Varun Sethi
> Subject: RE: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Tr
Sent: Tuesday, April 21, 2020 2:40 PM
> To: Loh, Tien Hock ; Ard Biesheuvel
> ; Leif Lindholm
> Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian
> Zhuang
> Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> Transfer Limit 65535 in R/W.
>
> Hi Tien Hock
ril 7, 2020 3:02 PM
> To: Ard Biesheuvel ; Leif Lindholm
>
> Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian
> Zhuang ; Loh, Tien Hock
>
> Subject: RE: [EXT] Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock
> Transfer Limit 65535 in R/W.
>
>
>
> > -
Ok, noted with thanks Liming. I'll try the tools out.
Thanks
Tien Hock
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, October 8, 2019 10:04 PM
> To: Loh, Tien Hock ; devel@edk2.groups.io;
> ler...@redhat.com
> Cc: leif.lindh...@linaro.org; ard.biesheu.
Hi Liming,
Thanks for the quick response.
Can you help show me where I can find more information on the decompression
(ie. how to test the image, etc.)?
Thanks
Tien Hock
> -Original Message-
> From: Gao, Liming
> Sent: Sunday, September 29, 2019 3:06 PM
> To: Loh, Tien
Hi
I have an issue while porting a new platform to EDK2. After porting the Stratix
10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more
INF to the FDF file, it failed to decompress the image during boot time, log as
below
INFO:DDR: DRAM calibration success.
INFO:
Hi
I have an issue while porting a new platform to EDK2. After porting the Stratix
10 platform (ARM) to EDK2 it works correctly. However, when I tried to add more
INF to the FDF file, it failed to decompress the image during boot time, log as
below
INFO: DDR: DRAM calibration success.
INFO: S
Hi Ard, Leif, Christopher,
Any comments on the patches?
Thanks!
Tien Hock
> -Original Message-
> From: Haojian Zhuang
> Sent: Monday, September 2, 2019 5:31 PM
> To: Loh, Tien Hock
> Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org;
> christopher...@microso
From: "Tien Hock, Loh"
Added clock manager so that Stratix 10 UART clock doesn't need to be
hardcoded
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Platform/Intel/Stratix10/Stratix10SoCPk
From: "Tien Hock, Loh"
Update licenses to SPDX
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Platform/Intel/Stratix10/Drivers/IntelPlatformDxe/IntelPlatformDxe.inf
| 22 +++---
From: "Tien Hock, Loh"
Remove some unused packages in Stratix 10 packages, clean up some commented
out codes
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Platform/Intel/Stratix10/Stratix
From: "Tien Hock, Loh"
Update maintainers list for Stratix 10 devices
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 5 +
1 file changed, 5 insertions(+)
diff --git
From: "Tien Hock, Loh"
Update maintainer list, SPDX license, remove unused packages
and remove hardcoded UART clock
Tien Hock, Loh (4):
Platform: Intel: Update maintainers list for Stratix 10 device
Platform: Intel: Update license to SPDX
Platform: Intel: Remove unused packages and clean u
From: "Tien Hock, Loh"
Update all license to SPDX. Also update UART clock to be calculated instead
of hardcoded, removed some unused packages, and updated maintainers.
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Hi Leif, Ard, Christopher,
Haojian and I have tested the driver on 2 platforms, any further comments on
this?
Thanks
Tien Hock
> -Original Message-
> From: Haojian Zhuang
> Sent: Tuesday, July 30, 2019 3:33 PM
> To: Loh, Tien Hock ; leif.lindh...@linaro.org;
&
Hi Leif,
I'll update it and send another patch on top of the previously reviewed patch.
Thanks!
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, August 9, 2019 6:16 PM
> To: Loh, Tien Hock
> Cc: Kinney, Michael D ; devel@edk2.groups.io;
> thlo...@gm
> -Original Message-
> From: Kinney, Michael D
> Sent: Friday, August 9, 2019 3:50 AM
> To: Leif Lindholm ; Loh, Tien Hock
> ; Kinney, Michael D
>
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
>
> Subject: RE: [PATCH v6 1/1] Platform: Int
Hi Leif,
OK noted, I'll submit a new patch on top of the commit.
I'll also try to ping Micheal.
Thanks
Tien Hock
> -Original Message-
> From: Leif Lindholm
> Sent: Monday, August 5, 2019 5:26 PM
> To: Loh, Tien Hock ; Kinney, Michael D
>
> Cc: devel@edk2.
Hi Leif, Ard, Micheal,
Any comments on this patch?
Thanks
Tien Hock
> -Original Message-
> From: Loh, Tien Hock
> Sent: Thursday, August 1, 2019 6:32 PM
> To: devel@edk2.groups.io; thlo...@gmail.com
> Cc: Loh, Tien Hock ; Ard Biesheuvel
> ; Leif Lindholm ;
> Kinney,
Hi Leif, Ard, Micheal,
Any comments on this?
Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#44890): https://edk2.groups.io/g/devel/message/44890
Mute This Topic: https://groups.io/mt/32677389/21656
Group Owner: devel+ow...@edk2.
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
v5:
Remove hardcoded UART clock
---
Platform/Intel/Stratix10/Drivers/Inte
From: Haojian Zhuang
It's used to create NonDiscoverableDevice in embedded platform. Since
there's no PCI bus.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
Signed-off-by: Tien Hock, Loh
---
EmbeddedP
From: Haojian Zhuang
Add PlatformDwMmc protocol. It's used to set properties of DwMmc
device in platform driver.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Chris Co
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Haojian Zhuang
---
EmbeddedPkg/Include/Protocol/PlatformD
From: "Tien Hock, Loh"
Changelog:
v3:
* Fix an issue in NonDiscoverableDeviceDxe driver where it did not invalidate
cache before copying the memory.
v2:
*Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc protocol,
and the other is for DwMmcHcDxe driver.
v1:
*Add NonD
From: "Tien Hock, Loh"
Changelog:
v3:
* Fix an issue in NonDiscoverableDeviceDxe driver where it did not invalidate
cache before copying the memory.
v2:
*Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc protocol,
and the other is for DwMmcHcDxe driver.
v1:
*Add NonD
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Platform/Intel/Stratix10/Drivers/IntelPlatformDxe/IntelPlatformDxe.c
Leif,
Some comments inlined.
> -Original Message-
> From: Loh, Tien Hock
> Sent: Tuesday, June 11, 2019 5:12 PM
> To: Leif Lindholm
> Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io'
> ; 'thlo...@gmail.com' ; 'Ard
> Biesheuvel
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, June 11, 2019 5:09 PM
> To: Loh, Tien Hock
> Cc: 'Haojian Zhuang' ; 'devel@edk2.groups.io'
> ; 'thlo...@gmail.com' ; 'Ard
> Biesheuvel'
> Subject: Re: [PATCH v
e-
> > From: Haojian Zhuang
> > Sent: Thursday, May 30, 2019 3:06 PM
> > To: Leif Lindholm
> > Cc: Loh, Tien Hock ; devel@edk2.groups.io;
> > thlo...@gmail.com; Ard Biesheuvel
> > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand
>
> -Original Message-
> From: Haojian Zhuang
> Sent: Thursday, May 30, 2019 3:06 PM
> To: Leif Lindholm
> Cc: Loh, Tien Hock ; devel@edk2.groups.io;
> thlo...@gmail.com; Ard Biesheuvel
> Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand
> polling
&
Leif, thanks for reviewing, a question inlined.
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, May 29, 2019 10:43 PM
> To: Loh, Tien Hock
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
> ; Kinney, Michael D
>
> Subject: Re: [[edk
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, May 30, 2019 9:03 AM
> To: devel@edk2.groups.io; Loh, Tien Hock ;
> thlo...@gmail.com
> Cc: Ard Biesheuvel ; Leif Lindholm
> ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [[edk2-platforms]PATCH v
From: "Tien Hock, Loh"
Change SendCommand polling mode to remove unnecessary delay, and check
for transfer done only when block data is to be read/write. This would
also increase performance slightly.
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Driver
From: "Tien Hock, Loh"
Do not send CRC response check if the MMC command does not support CRC
response
Signed-off-by: Tien Hock, Loh
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Emb
From: "Tien Hock, Loh"
On CMD8, for SD, the controller should not expect data as this is a
SEND_IF_COND command to verify SD operating condition, and does not have
data.
Signed-off-by: Tien Hock, Loh
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2
- Change IsEmmc to EFI_MMC_HOST_CARD_TYPE
---
Em
From: "Tien Hock, Loh"
There are some issues with DwEmmc when being used with SD protocol.
These series of patches fixes the issues.
TIen Hock, Loh (1):
EmbeddedPkg: Add SD command support for DwEmmc
Tien Hock, Loh (6):
EmbeddedPkg: Fix DwEmmc CMD8 support for SD
EmbeddedPkg: Send command
From: "Tien Hock, Loh"
Add support for reading data that is less than DWEMMC_BLOCK_SIZE,
otherwise it would read bigger data than requested and cause errors
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2:
- Fix white space issue
---
EmbeddedPkg/Drivers/DwEmmcDxe/
From: "Tien Hock, Loh"
Clear CTYPE on initialization. This is important if previous bootloader
changes the CTYPE can cause the controller to not initialize correctly
if CTYPE is not reset to 0
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmc
From: "TIen Hock, Loh"
Added ACMD6 for SD support. For SD, after CMD55 is sent, the next
command should be an application command, which should not expect
data
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2:
- Move IsACmd as a local static variable in function
- F
From: "Tien Hock, Loh"
Send command when MMC ask for response in DwEmmcReceiveResponse, and
command is a pending command (eg. DMA needs to be set up first)
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 -
1 file
Hi Ard, Leif,
Can you help review this?
Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41204): https://edk2.groups.io/g/devel/message/41204
Mute This Topic: https://groups.io/mt/31552954/21656
Group Owner: devel+ow...@edk2.group
Hi Ard, Leif,
Can you help review this?
Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#41205): https://edk2.groups.io/g/devel/message/41205
Mute This Topic: https://groups.io/mt/31552976/21656
Group Owner: devel+ow...@edk2.group
From: "Tien Hock, Loh"
Add support for reading data that is less than DWEMMC_BLOCK_SIZE,
otherwise it would read bigger data than requested and cause errors
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2:
- Fix white space issue
---
EmbeddedPkg/Drivers/DwEmmcDxe/
From: "Tien Hock, Loh"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1771
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write. This patch adds the UNI information on the new Pcd
introduced - PcdSerialRegisterAccessWidth
Signed-off-by: "Tien Hock, Loh"
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, May 9, 2019 2:37 PM
> To: devel@edk2.groups.io; Loh, Tien Hock ;
> thlo...@gmail.com
> Cc: tien.hock.loh ; Wang, Jian J
> ; Zhu, Yonghong
> Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg:
> BaseSerial
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Contributed-under: TianoCore Contribution Agreement 1.1
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
--
v4
- Removed LibC
- Added NOOPT to BUILD_TARGETS
- Removed ARM from SUPPORT
From: "Tien Hock, Loh"
Change SendCommand polling mode to remove unnecessary delay, and check
for transfer done only when block data is to be read/write. This would
also increase performance slightly.
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Driver
From: "Tien Hock, Loh"
Clear CTYPE on initialization. This is important if previous bootloader
changes the CTYPE can cause the controller to not initialize correctly
if CTYPE is not reset to 0
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmc
From: "Tien Hock, Loh"
Do not send CRC response check if the MMC command does not support CRC
response
Signed-off-by: Tien Hock, Loh
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/Emb
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, May 3, 2019 8:19 PM
> To: Loh, Tien Hock
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
>
> Subject: Re: [[PATCH v2] 7/7] EmbeddedPkg: Fix DwEmmc driver bugs
>
> On Fri, May 0
From: "Tien Hock, Loh"
Send command when MMC ask for response in DwEmmcReceiveResponse, and
command is a pending command (eg. DMA needs to be set up first)
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 9 -
1 file
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, May 3, 2019 8:11 PM
> To: Loh, Tien Hock
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
>
> Subject: Re: [[PATCH v2] 5/7] EmbeddedPkg: Fix DwEmmc driver bugs
>
> On Fri, May 0
From: "Tien Hock, Loh"
On CMD8, for SD, the controller should not expect data as this is a
SEND_IF_COND command to verify SD operating condition, and does not have
data.
Signed-off-by: Tien Hock, Loh
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2
- Change IsEmmc to EFI_MMC_HOST_CARD_TYPE
---
Em
From: "TIen Hock, Loh"
Added ACMD6 for SD support. For SD, after CMD55 is sent, the next
command should be an application command, which should not expect
data
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
--
v2:
- Move IsACmd as a local static variable in function
- F
Hi Leif,
Sorry for the late reply, I were held up in other areas of the work.
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, May 3, 2019 7:52 PM
> To: Loh, Tien Hock
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
>
> Subject: Re: [[PATCH
From: "tien.hock.loh"
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write. This patch adds the UNI information on the new
Pcd introduced - PcdSerialRegisterAccessWidth
Signed-off-by: "Tien Hock, Loh"
Cc: Jian J Wang
Cc: Hao Wu
Cc: "Zhu, YongHong"
Signed
From: "Tien Hock, Loh"
Added ACMD6 for SD support. For SD, after CMD55 is sent, the next command
should be an application command, which should not expect data
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 15
From: "Tien Hock, Loh"
Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise
it would read bigger data than requested and cause errors
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 16 +--
From: "Tien Hock, Loh"
On CMD8, for SD, the controller should not expect data as this is a
SEND_IF_COND command to verify SD operating condition, and does not have
data
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c|
From: "Tien Hock, Loh"
Send command when MMC ask for response in DwEmmcReceiveResponse, and
command is a pending command (eg. DMA needs to be set up first)
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 10 +-
1 fi
From: "Tien Hock, Loh"
This fixes a few issues with DwEmmc driver:
- - Change SendCommand polling mode and check for DTO when read/write
- Add CMD6 for SD support
- Clear CTYPE on initialization
- Add CMD8 support for SD
- Add ACMD51 for SD
- Call send command when receive response is c
From: "Tien Hock, Loh"
Clear CTYPE on initialization. This is important if previous bootloader
changes the CTYPE can cause the controller to not initialize correctly
if CTYPE is not reset to 0
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmc
From: "Tien Hock, Loh"
Add ACMD51 support for SD, this is needed to do SEND_SCR command correctly
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 4
1 file changed, 4 insertions(+)
diff --git a/EmbeddedPkg/Drivers/DwE
From: "Tien Hock, Loh"
Do not send CRC response check if the MMC command does not support CRC
response
Signed-off-by: "Tien Hock, Loh"
Cc: Leif Lindholm
Cc: Ard Biesheuvel
---
EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, May 3, 2019 2:35 AM
> To: Loh, Tien Hock
> Cc: devel@edk2.groups.io; thlo...@gmail.com; Ard Biesheuvel
> ; Kinney, Michael D
>
> Subject: Re: [[edk2-platforms] PATCH v3 1/1] Platform/Intel/Stratix10: A
From: "Tien Hock, Loh"
This fixes some issues with DwEmmc when using with SDMMC card:
- clear CTYPE when controller initializes
- change SendCommand polling mode to remove unnecessary delay
- Add CMD6 support for SD support
- For pending read/write command, send when DwEmmcReceiveResponse is call
Please ignore this patch, something went wrong with the my mail server config.
See https://edk2.groups.io/g/devel/message/39897 for the actual patch
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#39898): https://edk2.groups.io/g/devel/mes
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
--
v3
- Updated Pcd with updated name
v2
- Updates ShellBinPkg with ShellPkg
---
.../Drivers/IntelPlatformDxe/IntelPlatformDxe.c|
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
#Cc: Ard Biesheuvel
#Cc: Leif Lindholm
#Cc: Michael D Kinney
--
v3
- Updated Pcd with updated name
v2
- Updates ShellBinPkg with ShellPkg
---
.../Drivers/IntelPlatformDxe/IntelPlatformDxe.c
Hi Ard, Leif, Micheal,
Can you help review this patch? Thanks!
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#39813): https://edk2.groups.io/g/devel/message/39813
Mute This Topic: https://groups.io/mt/31320028/21656
Group Owner: devel+ow
From: "Tien Hock, Loh"
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write
Signed-off-by: "Tien Hock, Loh"
Cc: Jian J Wang
Cc: Hao Wu
---
v5
- Updates function header comments
- Change the implementation to eliminate unnecessary else clause
v4
- Updates
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, April 26, 2019 1:36 PM
> To: thlo...@gmail.com; devel@edk2.groups.io; Loh, Tien Hock
> ; Kinney, Michael D
>
> Cc: Wang, Jian J
> Subject: RE: [PATCH 1/1] MdeModulePkg: BaseSerialPortLib165
From: "Tien Hock, Loh"
Adds support for Intel Stratix 10 Platform.
Signed-off-by: "Tien Hock, Loh"
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
--
v2
- Updates ShellBinPkg with ShellPkg
---
.../Drivers/IntelPlatformDxe/IntelPlatformDxe.c| 43 ++
.../Drivers/IntelPlatformD
From: "Tien Hock, Loh"
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write
Signed-off-by: "Tien Hock, Loh"
Cc: Jian J Wang
Cc: Hao Wu
--
v3
- Updates the Pcd to be UINT8 to allow more options such as 16 bits access
in the future
- Updated copyright date
don't have platform that uses I/O space, thus I'm unable to test the
changes.
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io]
> > On Behalf Of Wu, Hao A
> > Sent: Tuesday, April 23, 2019 8:20 PM
>
84 matches
Mail list logo
