Hi Leif, Ard, Can you help on the questions I have below?
Thanks! > -----Original Message----- > From: Loh, Tien Hock > Sent: Tuesday, June 16, 2020 4:39 PM > To: 'Haojian Zhuang' <haojian.zhu...@linaro.org>; 'leif.lindh...@linaro.org' > <leif.lindh...@linaro.org>; 'ard.biesheu...@linaro.org' > <ard.biesheu...@linaro.org>; 'christopher...@microsoft.com' > <christopher...@microsoft.com> > Cc: 'devel@edk2.groups.io' <devel@edk2.groups.io>; 'thlo...@gmail.com' > <thlo...@gmail.com> > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver > > Hi Leif, Ard, > > I talked to Haojian and got to know that you wanted the patch to go into the > MdeModulePkg. > I don't have a lot of context on it, do you have specific requirement? > The driver at its current state already uses the MdeModulePkg's SdDxe's API, > so > some more specific changes would help me understand and fix the concern you > have. > > Thanks > > > -----Original Message----- > > From: Loh, Tien Hock > > Sent: Thursday, September 12, 2019 12:59 PM > > To: Haojian Zhuang <haojian.zhu...@linaro.org>; > > leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > > christopher...@microsoft.com > > Cc: devel@edk2.groups.io; thlo...@gmail.com > > Subject: RE: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > Hi Ard, Leif, Christopher, > > > > Any comments on the patches? > > > > Thanks! > > Tien Hock > > > -----Original Message----- > > > From: Haojian Zhuang <haojian.zhu...@linaro.org> > > > Sent: Monday, September 2, 2019 5:31 PM > > > To: Loh, Tien Hock <tien.hock....@intel.com> > > > Cc: leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > > > christopher...@microsoft.com; devel@edk2.groups.io; > > > thlo...@gmail.com > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > Hi Leif, Ard, Christopher, > > > > > > Could you help to share the comments on this patch set? Thanks a lot. > > > > > > Best Regards > > > Haojian > > > > > > On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote: > > > > Hi Leif, Ard, Christopher, > > > > > > > > Haojian and I have tested the driver on 2 platforms, any further > > > > comments > > > on this? > > > > > > > > Thanks > > > > Tien Hock > > > > > > > > > -----Original Message----- > > > > > From: Haojian Zhuang <haojian.zhu...@linaro.org> > > > > > Sent: Tuesday, July 30, 2019 3:33 PM > > > > > To: Loh, Tien Hock <tien.hock....@intel.com>; > > > > > leif.lindh...@linaro.org; ard.biesheu...@linaro.org; > > > > > christopher...@microsoft.com > > > > > Cc: devel@edk2.groups.io; thlo...@gmail.com > > > > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > > > > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800, > > > > > tien.hock....@intel.com > > > wrote: > > > > > > From: "Tien Hock, Loh" <tien.hock....@intel.com> > > > > > > > > > > > > Changelog: > > > > > > v3: > > > > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it > > > > > > did not > > > > > invalidate > > > > > > cache before copying the memory. > > > > > > v2: > > > > > > *Split DwMmcHcDxe driver into two patches. One is for > > > > > > PlatformDwMmc > > > > > protocol, > > > > > > and the other is for DwMmcHcDxe driver. > > > > > > v1: > > > > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > > > > > DwMmcHcDxe driver > > > > > > to support both eMMC and SD controller. > > > > > > > > > > > > Haojian Zhuang (3): > > > > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > > > > > EmbeddedPkg: add PlatformDwMmc protocol > > > > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > > > > > > > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 > > > > > +++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 > > > ++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 > > > > > +++++++++++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 > +++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 > > > ++++++++ > > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > > > > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > > > > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > > > > > > .../NonDiscoverableDeviceDxe.c | 243 ++ > > > > > > .../NonDiscoverableDeviceDxe.inf | 52 + > > > > > > .../NonDiscoverableDeviceIo.c | 976 +++++++ > > > > > > .../NonDiscoverableDeviceIo.h | 92 + > > > > > > 16 files changed, 9495 insertions(+) create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > > > > > create mode 100644 > > > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > > > > > create mode 100644 > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > > > > > create mode 100644 > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > > > > > create mode 100644 > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > > > > > create mode 100644 > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > > > > > create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eDx > > > > > > e.c create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eDx > > > > > > e.inf create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eIo > > > > > > .c create mode 100644 > > > > > > > > > > > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > > > > eIo > > > > > > .h > > > > > > > > > > > > -- > > > > > > 2.19.0 > > > > > > > > > > > > > > > > Hi Leif, Ard & Chris, > > > > > > > > > > Could you help to share your comments on this patch set? > > > > > > > > > > Best Regards > > > > > Haojian -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61513): https://edk2.groups.io/g/devel/message/61513 Mute This Topic: https://groups.io/mt/32582252/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
