Table - Platform Design Document, Issue D, March 2018
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Make IORT parsing logic data driven [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 353
+---
1 file changed, 234 insertions(+), 119
DumpProcessorHierarchyNodeStructure function signature match that
of ACPI_STRUCT_PARSER_FUNC. This way, the function can be called from
ParseAcpiStruct ().
References:
- ACPI 6.3 Specification - January 2019, Section 5.2.29
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Make PPTT parsing logic data driven [Krzysztof
() call.
Remove the definition of the DumpWatchdogTimer (). Its only purpose was
to call ParseAcpi () and now this process is streamlined.
References:
- ACPI 6.3 Specification - January 2019, Section 5.2.24
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Make GTDT parsing logic data driven
treamline
the printing of ACPI structure name together with the structure's
current occurrence count.
References:
- ACPI 6.3, January 2019
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Add interface for data-driven table parsing [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/
Specification - January 2019, Section 5.2.16
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Make SRAT parsing logic data driven [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 204
1 file changed, 77 insertions(+), 127 deletions(-)
diff
platforms, make existing GIC Distributor (GICD) instance
count validation code use ACPI_STRUCT_INFO.
References:
- ACPI 6.3 Specification - January 2019, Section 5.2.12
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Make MADT parsing logic data driven [Krzysztof]
ShellPkg/Library
e contents validation in
acpiview, which is implemented in this patch series.
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/616_refactor_acpiview_parser_loops_v1
Krzysztof Koch (6):
ShellPkg: acpiview: Add interface for data-driven table parsing
ShellPkg: acpiview: Make MA
Hi Zhichao,
Any idea when this patch set will get merged?
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
groups.io
Sent: Friday, April 17, 2020 8:20
To: Krzysztof Koch ; devel@edk2.groups.io; Ni, Ray
Cc: Sami Mujawar ; Matteo
Hi,
Can I get a review for this patch series?
Thanks,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Krzysztof Koch
via Groups.Io
Sent: Wednesday, March 25, 2020 9:39
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar
; Matteo
:
0: Arm Server Base Boot Requirements 1.0, March 2016
1: Arm Server Base Boot Requirements 1.1, May 2018
2: Arm Server Base Boot Requirements 1.2, September 2019
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- add '-r' parameter for table requirements validaiton [Krzysztof
tables are present on the
platform.
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/617_sbbr_validate_acpi_table_counts_v1
Krzysztof Koch (3):
ShellPkg: acpiview: Add -r parameter for table requirements validation
ShellPkg: acpiview: Add library for SBBR ACPI requirements
tional and can be enabled with the -r command line
parameter.
Reference(s):
- Arm Server Base Boot Requirements 1.2, September 2019
- Arm Server Base Boot Requirements 1.1, May 2018
- Arm Server Base Boot Requirements 1.0, March 2016
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Arm Server Base Boot Requirements 1.2, September 2019
- Arm Server Base Boot Requirements 1.1, May 2018
- Arm Server Base Boot Requirements 1.0, March 2016
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- add library for SBBR ACPI requirements validation [Krzysztof]
ShellP
table buffer is not fully populated.
This is typically a bug on the ACPI table writer side.
In short, this method helps acpiview recover gracefully from a
zero-valued ACPI structure length.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/Krzy
Hi Liming,
The BZ is: https://bugzilla.tianocore.org/show_bug.cgi?id=2534
Please let me know if I should change something.
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Krzysztof Koch
via Groups.Io
Sent: Monday, February 17, 2020 15:23
To: devel
ts in making the tool more reliable.
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Liming Gao via
Groups.Io
Sent: Monday, February 17, 2020 15:11
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Ni, Ray ; Gao, Zhichao ; Sami
Mujawar ; Matteo Carlini
ug on the ACPI table writer side.
In short, this method helps acpiview recover gracefully from a
zero-valued ACPI structure length.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_prevent_inf_loops_v1
Notes:
v1:
- preve
s the definition of Platform Communications Channel
Table's signature to the relevant ACPI header files.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v2
Notes:
v2:
- Replicate the definition from Acpi50
Hi Liming,
No problem, I will resubmit the patch updating the relevant ACPI spec header
files.
Thanks,
Krzysztof
-Original Message-
From: Gao, Liming
Sent: Wednesday, February 12, 2020 13:59
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Matteo Carlini
; nd
Hi All,
Is there something I can do to help get this patch merged?
Kind regards,
Krzysztof
-Original Message-
From: Sami Mujawar
Sent: Thursday, January 30, 2020 11:40
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: michael.d.kin...@intel.com; liming@intel.com; Matteo Carlini
; nd
Check if the ACPI table length, as reported in the ACPI table header, is
big enough to fit at least the header itself.
If not, report an error to the user and stop parsing the table in order
to prevent buffer overruns.
Signed-off-by: Krzysztof Koch
---
Changes can be seet at:
https
-Original Message-
From: devel@edk2.groups.io On Behalf Of Krzysztof Koch
via Groups.Io
Sent: Monday, January 20, 2020 11:14
To: devel@edk2.groups.io
Cc: ray...@intel.com; zhichao@intel.com; Sami Mujawar
; Matteo Carlini ; nd
Subject: [edk2-devel] [PATCH v3 00/11] Test against
Check if the ACPI table length, as reported in the ACPI table header, is
big enough to fit at least the header itself.
If not, report an error to the user and stop parsing the table in order
to prevent buffer overruns.
Signed-off-by: Krzysztof Koch
---
Changes can be seet at:
https
e that the definitions in
these header files are correct.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/tianocore/edk2/compare/master...KrzysztofKoch1:remove_dup_defs_acpiview_v1?expand=1
Notes:
v1:
- Remove duplicate definitions [Krzysztof]
ShellP
9, Section 14.1
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/617_add_pcct_signature_def_v1
Notes:
v1:
- Add definition of PCCT table signature [Krzysztof]
MdePkg/Include/IndustryStandard/Acpi63.h | 7 ++-
1 file changed, 6 i
pler, thus, the 'defined but not used'
error got raised.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_variable_juno_dxe_v2
Notes:
v2:
- Specify which previous commit inroduced the error [Philippe
Check if the NumberOfPrivateResources, ProcessorTopologyStructureType
and ProcessorTopologyStructureLength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1
Check if global pointers have been successfully updated before they
are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v2:
- Do not require FadtMinorRevision and X_DsdtAddress pointers to be
valid in
Check if XsdtAddress pointer has been successfully updated before it
is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib
Check if global (in the scope of the IORT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg
Check if the MadtInterruptControllerType and
MadtInterruptControllerLength pointers have been successfully updated
before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers
ters to be
valid in FADT table parser [Zhichao]
v1:
- Validate static pointers in acpiview parsers before use [Krzysztof]
Krzysztof Koch (11):
ShellPkg: acpiview: Set ItemPtr to NULL for unprocessed table fields
ShellPkg: acpiview: RSDP: Validate global pointer before use
Check if global (in the scope of the GTDT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg
Check if SlitSystemLocalityCount pointer has been successfully updated
before it is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library
SLIT
locality count, then the matrix used to represent the localities is
N*N bytes long. The ACPI table length must be big enough to fit the
matrix.
3. Remove (now) redundant 64x64 bit multiplication.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
Check if SratRAType and SratRALength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library
ld
is not parsed, we will have a dangling pointer which could cause a
problem later.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Set ItemPtr to NULL for unprocessed table fields [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommand
Check if global (in the scope of the DBG2 parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v3:
- Rebase on latest master [Krzysztof]
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg
Sure! I don't mind changing the commit message. Shall I resubmit the patch?
Kind regards,
Krzysztof
-Original Message-
From: Philippe Mathieu-Daudé
Sent: Monday, January 20, 2020 9:15
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Ard Biesheuvel ; Leif Lindholm
; Michael D K
pler, thus, the 'defined but not used'
error got raised.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_variable_juno_dxe_v1
Notes:
v1:
- Fix 'defined but not used' Dynamic Tables build er
Add support for revision 3 of System Resource Affinity Table (SRAT).
Decode and dump the new Generic Initiator Affinity Structure.
Validate the Device Handle Type field inside the Generic Initiator
Affinity Structure.
Signed-off-by: Krzysztof Koch
---
The changes can be seen at:
https
Hi Liming,
This is a feature support. This patch is a rebased version of a reviewed patch
that was pending to be merged due to a lack of 'tested-by', see:
https://edk2.groups.io/g/devel/message/42297?p=,,,20,0,0,0::Created,,Krzysztof+Koch+SRAT,20,2,0,32042587
https://edk2.groups.
Add support for parsing revision 3 of System Resource Affinity Table
(SRAT).
Decode and dump the new Generic Initiator Affinity Structure.
Validate the Device Handle Type field inside the Generic Initiator
Affinity Structure.
Signed-off-by: Krzysztof Koch
---
The changes can be seen at
https
Check if global pointers have been successfully updated before they
are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/612_add_pointer_validation_v2
Notes:
v1:
- Test against NULL pointers
Hi Zhichao,
Please find my comments inline marked as [Krzysztof].
Kind regards,
Krzysztof
-Original Message-
From: Gao, Zhichao
Sent: Monday, August 19, 2019 2:19
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sami
Mujawar ; Matteo Carlini ; nd
Subject
Hi Zhichao,
I think you're right. I will submit a v2 patch that minimizes the amount of
pointer validation required for parsing the remaining tables.
Kind regards,
Krzysztof
-Original Message-
From: Gao, Zhichao
Sent: Friday, August 16, 2019 8:35
To: Krzysztof Koch ; devel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2089
Hi Liming,
Sure, no problem.
Kind regards,
Krzysztof
-Original Message-
From: Gao, Liming
Sent: Friday, August 16, 2019 5:03
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Gao,
Zhichao ; Sami Mujawar
Check if global (in the scope of the DBG2 parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2
Check if global (in the scope of the GTDT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt
Check if the MadtInterruptControllerType and
MadtInterruptControllerLength pointers have been successfully updated
before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library
Check if global (in the scope of the IORT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort
Check if the NumberOfPrivateResources, ProcessorTopologyStructureType
and ProcessorTopologyStructureLength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof
SLIT
locality count, then the matrix used to represent the localities is
N*N bytes long. The ACPI table length must be big enough to fit the
matrix.
3. Remove (now) redundant 64x64 bit multiplication.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Validate the 'Number of System Localit
is not parsed, this could result in a dangling pointer which could
cause a problem later.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Set ItemPtr to NULL for unprocessed table fields [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 9 -
1 file changed
Check if XsdtAddress pointer has been successfully updated before it
is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 12
1
Check if global pointers have been successfully updated before they
are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 14
++
1
r to
NULL and testing for NULL whenever these pointers are dereferenced.
Changes can be seet at:
https://github.com/KrzysztofKoch1/edk2/tree/612_add_pointer_validation_v1
Krzysztof Koch (11):
ShellPkg: acpiview: Set ItemPtr to NULL for unprocessed table fields
ShellPkg: acpiview: RSDP: Valid
Check if SlitSystemLocalityCount pointer has been successfully updated
before it is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 16
Check if SratRAType and SratRALength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
n all parsers.
"""
Please let me know what you think.
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
Groups.Io
Sent: Tuesday, August 6, 2019 8:43
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Sa
ting rid of DbgDevInfoHeaderParser would work as
you assume that the remaining table buffer length should be passed to
ParseAcpi() as an argument, not the length of the Debug Device Information
Structure. What do you think?
Kind regards,
Krzysztof
-Original Message-
From: Gao, Zhichao
Table (Issue D), Platform Design Document, March 2018
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns in IORT acpiview parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 191
+++-
1 file changed, 105 in
ure's buffer fits in the
PPTT table buffer before its contents are dumped.
Prevent buffer overruns when reading the processor topology structure's
header.
References:
- ACPI 6.3, January 2019, Section 5.2.29
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns i
7;s header.
References:
- ACPI 6.3, January 2019, Section 5.2.16
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns in SRAT acpiview parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | 14
+-
1 file changed, 13
(to get the length) a new ACPI_PARSER array is defined.
References:
- Microsoft Debug Port Table 2 (DBG2), December 10, 2015
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns in DBG2 acpiview parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers
ACPI structure's
field.
References:
- ACPI 6.3, January 2019, Table 5-124
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns in GTDT acpiview parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 147
++
Modify the parsing logic to prevent reading past the MADT table buffer
length provided when parsing the Interrupt Controller Structure header.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Prevent buffer overruns in MADT acpiview parser [Krzysztof]
ShellPkg/Library
Krzysztof Koch (6):
ShellPkg: acpiview: DBG2: Prevent buffer overruns
ShellPkg: acpiview: GTDT: Prevent buffer overruns
ShellPkg: acpiview: IORT: Prevent buffer overruns
ShellPkg: acpiview: MADT: Prevent buffer overruns
ShellPkg: acpiview: PPTT: Prevent buffer overruns
ShellPkg: acpiview
eries into smaller
functional units as requested in the review comments.
Kind regards,
Krzysztof
-Original Message-
From: Sami Mujawar
Sent: Tuesday, July 23, 2019 10:57
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; nd
S
devel@edk2.groups.io On Behalf Of Krzysztof Koch
via Groups.Io
Sent: Monday, July 22, 2019 8:50
To: devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami
Mujawar ; Matteo Carlini ; nd
Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers
Controller Structures (for all interrupt models
which can be represented in MADT). Check if the controller length
specified is shorter than the byte size of the first two fields
('Type' and 'Length') present in every valid Interrupt Controller
Structure.
Signed-off-by: Krzysz
parsing and is limited to
a single table field in scope, therefore, it is better to keep it away
from the code responsible for traversing the table.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- refactor PMCG node mapping count validation [Krzysztof]
ShellPkg/Library
Minor changes to the SRAT parser code to conform with the EDKII coding
style and to make it consistent with other ACPI table parsers.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- minor code style enhancements [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat
effectively means that no more ACPI tables will be parsed because
of this RSDP table content error.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- minor code style enhancements [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11
+--
1 file
/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_enhance_v2
Krzysztof Koch (6):
ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()
ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call
ShellPkg: acpiview: RSDP: Make code consistent with other parsers
ShellPkg: acpiview: SRAT
rsers.
Update all existing DumpGasStruct() calls in acpiview to add the
length argument.
Signed-off-by: Krzysztof Koch
---
Notes:
v2:
- Pass GAS_LENGTH to DumpGasStruct() in DBG2 parser [Zhichao]
v1:
- Modify DumpGasStruct() signature [Krzysztof]
ShellPkg/Li
instead of a global static variable.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant ParseAcpi() call [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 18
--
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git
a
DbgDevInfoLen);
Replaced with
> DumpGasStruct (DataPtr, 4, GAS_LENGTH);
Is that ok?
Kind regards,
Krzysztof
-Original Message-
From: Gao, Zhichao
Sent: Friday, July 19, 2019 9:09
To: Krzysztof Koch
Subject: RE: [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to
DumpGasStruct
Controller Structures (for all interrupt models
which can be represented in MADT). Check if the controller length
specified is shorter than the byte size of the first two fields
('Type' and 'Length') present in every valid Interrupt Controller
Structure.
Signed-off-by: Krzysz
Minor changes to the SRAT parser code to conform with the EDKII coding
style and to make it consistent with other ACPI table parsers.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- minor code style enhancements [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat
parsing and is limited to
a single table field in scope, therefore, it is better to keep it away
from the code responsible for traversing the table.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- refactor PMCG node mapping count validation [Krzysztof]
ShellPkg/Library
effectively means that no more ACPI tables will be parsed because
of this RSDP table content error.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- minor code style enhancements [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 11
+--
1 file
instead of a global static variable.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant ParseAcpi() call [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c | 18
--
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git
a
rsers.
Update all existing DumpGasStruct() calls in acpiview to add the
length argument.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Modify DumpGasStruct() signature [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 26
+++-
ShellPkg/Li
/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_enhance_v1
Krzysztof Koch (6):
ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()
ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call
ShellPkg: acpiview: RSDP: Make code consistent with other parsers
ShellPkg: acpiview: SRAT
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
icate declarations, so this set of patches makes the code structure
consistent across all acpiview parsers.
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/tree/612_remove_forward_decl_v1
Krzysztof Koch (8):
ShellPkg: acpiview: RSDP: Remove redundant forward declarations
She
Reposition blocks of code to remove redundant forward function
declarations in order to reduce the code size.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
Remove redundant forward function declarations by repositioning
blocks of code. This way the code structure is consistent across
ACPI table parsers and the code becomes more concise.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof
.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- remove redundant forward function declarations [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c | 91
+++-
1 file changed, 33 insertions(+), 58 deletions(-)
diff --git
a/ShellPkg/Library
.groups.io On Behalf Of Carsey, Jaben
via Groups.Io
Sent: Friday, July 12, 2019 15:27
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: Ni, Ray ; Gao, Zhichao ; Sami
Mujawar ; Matteo Carlini ; nd
Subject: Re: [edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate
global pointers before use
. Remove redundant forward function declarations by repositioning
blocks of code.
5. Convert a 'do-while' loop for parsing GTDT table body into a 'while'
block for consistency with other table parsers.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://githu
against buffer overrruns are
simpler to implement.
5. Modify the signature of DumpGasStruct() function inside AcpiParser.c
to facilitate protection against buffer overruns in the DBG2 parser.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/commit
: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/commit/0b398f116f7aed99dbec4090b5c2c0ed93273ef7
Notes:
v1:
- improve the logic in the IORT parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 419
this
check, there is a possibility for the parser to enter an ifninite loop.
3. Test against buffer overruns.
4. Allow silencing ACPI table content validation errors which do not
cause table parsing to fail.
Signed-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com
-off-by: Krzysztof Koch
---
Changes can be seen at:
https://github.com/KrzysztofKoch1/edk2/commit/ef11738efc94a9c3d7270d376a2cb273bbadbba2
Notes:
v1:
- improve the logic in the MADT parser [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 187
1 - 100 of 151 matches
Mail list logo
