Sure! I don't mind changing the commit message. Shall I resubmit the patch?
Kind regards, Krzysztof -----Original Message----- From: Philippe Mathieu-Daudé <phi...@redhat.com> Sent: Monday, January 20, 2020 9:15 To: devel@edk2.groups.io; Krzysztof Koch <krzysztof.k...@arm.com> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Leif Lindholm <leif.lindh...@linaro.org>; Michael D Kinney <michael.d.kin...@intel.com>; Sami Mujawar <sami.muja...@arm.com>; Matteo Carlini <matteo.carl...@arm.com>; nd <n...@arm.com> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables On 1/9/20 10:35 AM, Krzysztof Koch wrote: > Fix 'mAcpiRegistration defined but not used' compiler error for > Dynamic Tables Framework builds. > > Do not declare the mAcpiRegistration variable in the Dynamic Tables > Framework context. > > An earlier patch made mAcpiRegistration variable STATIC. Reducing the Can we change "An earlier patch" -> "Commit 484a683ab9f"? > scope made scope resolution simpler, thus, the 'defined but not used' > error got raised. > > Signed-off-by: Krzysztof Koch <krzysztof.k...@arm.com> Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> > --- > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_v > ariable_juno_dxe_v1 > > Notes: > v1: > - Fix 'defined but not used' Dynamic Tables build error > [Krzysztof] > > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > index > e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cfd744dd > 5c22df726c99 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2013-2019, ARM Limited. All rights reserved. > +* Copyright (c) 2013-2020, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -30,9 +30,9 @@ > #ifndef DYNAMIC_TABLES_FRAMEWORK > // This GUID must match the FILE_GUID in > ArmPlatformPkg/ArmJunoPkg/AcpiTables/AcpiTables.inf > STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, > 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } }; -#endif > - > STATIC VOID *mAcpiRegistration = NULL; > +#endif > + > STATIC VOID *mPciIoNotificationRegistration = NULL; > > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53399): https://edk2.groups.io/g/devel/message/53399 Mute This Topic: https://groups.io/mt/69576071/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
