On Thu, Jul 06, 2023 at 02:36:54PM +0800, Sheng Wei via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3413
>
The title, "Support RSA 512 and RSA 384", looks very strange. I assume
it should be "Support SHA 512 and SHA 384"?
Gary Lin
> Cc:
Update Gary's email address from HPE to SUSE.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
On Tue, Jul 20, 2021 at 02:52:12PM +0800, Gary Lin via groups.io wrote:
> On Mon, Jul 19, 2021 at 05:07:21PM +0100, Anthony PERARD wrote:
> > It would have been nice to have this patch in a patch series with
> > "OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe", mostly
nest, I don't have Xen environment and didn't realize that it's
about direct kernel boot until looking into another bug report. I just
compared InitializeXenPlatform() with InitializePlatform() and my
colleague told me OvmfXen works again after setting PcdAcpiS3Enable.
> On Thu, Jul 08,
Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download
the kernel, initrd, and kernel command line from QEMU's fw_cfg.
Cc: Ard Biesheuvel
cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
Cc: Jim Fehlig
Signed-off-by: Gary Lin
---
OvmfPkg/OvmfXen.dsc | 1
x27;m not sure which one is
the right fix.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
Cc: Jim Fehlig
Signed-off-by: Gary Lin
---
OvmfPkg/XenPlatformPei/Platform.c | 10 ++
OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 3 +++
On Mon, Apr 19, 2021 at 02:32:25PM +0200, Laszlo Ersek wrote:
> On 04/19/21 11:54, Gary Lin via groups.io wrote:
> > Hi,
> >
> > Years ago, the bug(*) for PEI variable driver was filed against OVMF
> > and it used to be one reason to block S4 support in OVMF. The bug
ed as unsupported due to some other bugs?
Thanks,
Gary Lin
(*) https://bugzilla.tianocore.org/show_bug.cgi?id=386
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74269): https://edk2.groups.io/g/devel/message/74269
Mute This Topic:
or to customize the their firmware rather than
a general check for all platforms in the future?
Thanks,
Gary Lin
(*) https://bugzilla.tianocore.org/show_bug.cgi?id=1402
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65716): https:/
ot;OvmfPkg/README".
Looks good to me :)
Reviewed-by: Gary Lin
>
> Cc: Ard Biesheuvel
> Cc: Gary Lin
> Cc: Jordan Justen
> Cc: Philippe Mathieu-Daudé
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2852
> Signed-off-by: Laszlo Ersek
> ---
> OvmfPkg/RE
boot.
>
> V2:
> 1. Add description of the different behavior between grub boot from MBR path
> and
> from CD path
> 2. change patch #2 to revert "MdeModulePkg/PartitionDxe: Skip the MBR that
> add for CD-ROM"
I've tested the following ISO images and all booted
oot.
>
Thanks for the patches. After applying this patch series, the firmware
recognizes openSUSE/SUSE iso images again.
Tested-by: Gary Lin
> Cc: Jian J Wang
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Gary Lin
> Cc: Andrew Fish
> Signed-off-by: Zhichao Gao
> Zhichao Gao (3)
tional check.
Change it to EFI_DEVICE_ERROR. Also update the comment to reflect the
change.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Gary Lin
---
SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 9 +
SecurityPkg/Library/Tpm2DeviceL
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
Maintainers.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 32c9003a6209..075a8d0ea763 100644
--- a/Maintainers.txt
+++ b
to access
SenseData
- Improve the error handling in LsiScsiProcessRequest()
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 64
OvmfPkg/LsiScsiDxe/LsiScsi.c |
mit and PcdLsiScsiMaxLunLimit
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 148 +-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 2 +
OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 6 ++
OvmfPkg/OvmfPkg.
: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 21
OvmfPkg/LsiScsiDxe/LsiScsi.c | 136 -
OvmfPkg/LsiScsiDxe/LsiScsi.h | 3 +
3 files changed, 159 insertions
f the instructions for the script.
- Improve the error handling in LsiScsiProcessRequest()
- Calculate the transferred bytes after the execution of the script
Gary Lin (11):
OvmfPkg/LsiScsiDxe: Create the empty driver
OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding
OvmfPkg/LsiS
Implement the dummy functions for EFI Driver Binding protocol.
v2: Remove "STATIC" from LsiScsiControllerSupported()
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 98
OvmfPkg/LsiScsiDxe/LsiScsi.h | 4 ++
2 files changed, 102 insertions(+)
diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
index 52c224aad9a5
Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName()
to report the name of the driver.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++--
OvmfPkg
Implement LsiScsiControllerSupported() to probe the PCI ID and look for
LSI 53C895A.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 +
OvmfPkg/LsiScsiDxe/LsiScsi.c
Create the driver with only a dummy LsiScsiEntryPoint() for the further
implementation of the driver for LSI 53C895A SCSI controller.
v2: Fix the mixed-case GUID string
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg
euvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 62 +++-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 14
2 files changed, 75 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 164 +-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 78 ++
OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 3 +
3 files changed, 244 insertions
On Thu, Jul 16, 2020 at 08:21:46PM +0200, Laszlo Ersek wrote:
> On 07/16/20 09:46, Gary Lin wrote:
> > Calculate the transferred bytes during data phases based on the
> > Cumulative SCSI Byte Count (CSBC) and update
> > InTransferLength/OutTransferLength of the request packet
On Thu, Jul 16, 2020 at 07:37:09PM +0200, Laszlo Ersek wrote:
> On 07/16/20 09:46, Gary Lin wrote:
> > This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is
> > added to translate the SCSI Request Packet into the LSI 53C895A
> > commands. This function u
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 98
OvmfPkg/LsiScsiDxe/LsiScsi.h | 4 ++
2 files changed, 102 insertions(+)
diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
index 4e84afa40085
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
Maintainers.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 32c9003a6209..075a8d0ea763 100644
--- a/Maintainers.txt
+++ b
Calculate the transferred bytes during data phases based on the
Cumulative SCSI Byte Count (CSBC) and update
InTransferLength/OutTransferLength of the request packet.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h
of the script size at the end of the script
- Always set SenseDataLength to 0 to avoid the caller to access
SenseData
- Improve the error handling in LsiScsiProcessRequest()
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStand
Create the driver with only a dummy LsiScsiEntryPoint() for the further
implementation of the driver for LSI 53C895A SCSI controller.
v2: Fix the mixed-case GUID string
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg
Implement LsiScsiControllerSupported() to probe the PCI ID and look for
LSI 53C895A.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 +
OvmfPkg/LsiScsiDxe/LsiScsi.c
Partially implement LsiScsiControllerStart() and LsiScsiControllerStop()
to insert the scaffolding of EXT_SCSI_PASS_THRU functions.
v2: Remove the closing of PciIo protocol from LsiScsiControllerStop().
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by
Implement the dummy functions for EFI Driver Binding protocol.
v2: Remove "STATIC" from LsiScsiControllerSupported()
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c
euvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 62 +++-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 14
2 files changed, 75 insertions(+), 1 deletion(-)
diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName()
to report the name of the driver.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
Reviewed-by: Laszlo Ersek
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++--
OvmfPkg
array
- Remove DUAL_ADDRESS_CYCLE from PciIo since we don't really need
64-bit DMA address
- Fix a typo
- Fix the coding style of the instructions for the script.
- Improve the error handling in LsiScsiProcessRequest()
- Calculate the transferred bytes after the execution of th
.
v2:
- Zero out (*Target) in LsiScsiGetTargetLun()
- Use CopyMem() instead of the one-byte shortcut to copy target from
ScsiDevicePath->Pun
- Add asserts for PcdLsiScsiMaxTargetLimit and PcdLsiScsiMaxLunLimit
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary
: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 21
OvmfPkg/LsiScsiDxe/LsiScsi.c | 136 -
OvmfPkg/LsiScsiDxe/LsiScsi.h | 3 +
3 files changed, 159 insertions
t this patch breaks the loading of openSUSE iso images[*].
Would you mind to take a look at it?
Thanks,
Gary Lin
[*]
http://download.opensuse.org/distribution/leap/15.2/iso/openSUSE-Leap-15.2-NET-x86_64.iso
>
> Cc: Hao A Wu
> Cc: Ray Ni
> Signed-off-by: Zhichao Gao
The toke value of PcdMptScsiStallPerPollUsec should be 0x3a since the
previous toke value is 0x39.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Liran Alon
Cc: Nikita Leshenko
Signed-off-by: Gary Lin
---
OvmfPkg/OvmfPkg.dec | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On Wed, Jul 08, 2020 at 02:02:27PM +0800, Gary Lin via groups.io wrote:
> On Tue, Jul 07, 2020 at 02:46:14PM +0200, Laszlo Ersek wrote:
> > On 07/01/20 06:04, Gary Lin wrote:
> > > This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is
> > > added to
On Tue, Jul 07, 2020 at 02:49:48PM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Cc: Jordan Justen
> > Cc: Laszlo Ersek
> > Cc: Ard Biesheuvel
> > Signed-off-by: Gary Lin
> > ---
> > Maintainers.txt | 4
> > 1 file c
On Tue, Jul 07, 2020 at 02:46:14PM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is
> > added to translate the SCSI Request Packet into the LSI 53C895A
> > commands. This function u
On Tue, Jul 07, 2020 at 12:17:21PM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > This is the first part of LsiScsiPassThru(). Before processing the SCSI
> > Request packet, we have to make sure whether the packet is valid or not.
> >
> > Cc: Jo
On Tue, Jul 07, 2020 at 11:59:57AM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Map DMA buffer and perpare for the implementation of LsiScsiPassThru().
> >
> > Cc: Jordan Justen
> > Cc: Laszlo Ersek
> > Cc: Ard Biesheuvel
> > Signed
On Tue, Jul 07, 2020 at 11:46:28AM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Open PciIo protocol and use it to initialize the device. The
> > initialization of LSI 53C895A is simple: just set the SRST bit in
> > Interrupt Status Zero registe
On Tue, Jul 07, 2020 at 11:04:21AM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Implement LsiScsiGetNextTargetLun(), LsiScsiBuildDevicePath(),
> > LsiScsiGetTargetLun(), and LsiScsiGetNextTarget() to report Targets and
> > LUNs and build the device path.
On Tue, Jul 07, 2020 at 10:06:59AM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Implement the dummy functions for EFI Driver Binding protocol.
> >
> > Cc: Jordan Justen
> > Cc: Laszlo Ersek
> > Cc: Ard Biesheuvel
> > Signed
On Tue, Jul 07, 2020 at 09:59:04AM +0200, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
> > Create the driver with only a dummy LsiScsiEntryPoint() for the further
> > implementation of the driver for LSI 53C895A SCSI controller.
> >
> > Cc: Jordan Justen
&
Create the driver with only a dummy LsiScsiEntryPoint() for the further
implementation of the driver for LSI 53C895A SCSI controller.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 25 +
OvmfPkg
Implement LsiScsiControllerSupported() to probe the PCI ID and look for
LSI 53C895A.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 +
OvmfPkg/LsiScsiDxe/LsiScsi.c | 48
Implement the dummy functions for EFI Driver Binding protocol.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 72 ++-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 50 +
OvmfPkg
.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 143 +-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 3 +
OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 6 ++
OvmfPkg/OvmfPkg.dec | 5 ++
4 files
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
Maintainers.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 32c9003a6209..666d3af4d76a 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -400,6 +400,10
Partially implement LsiScsiControllerStart() and LsiScsiControllerStop()
to insert the scaffolding of EXT_SCSI_PASS_THRU functions.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 171
se
add "-D LSI_SCSI_ENABLE" when building OvmfPkg.
The patch series is also available in my git branch:
https://github.com/lcp/edk2/tree/ovmf-lsi-v1
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Gary Lin (11):
OvmfPkg/LsiScsiDxe: Create the empty driver
OvmfPkg/LsiScsiDxe: Install th
Map DMA buffer and perpare for the implementation of LsiScsiPassThru().
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 85 +++-
OvmfPkg/LsiScsiDxe/LsiScsi.h | 10 +
2 files changed, 94
the Scripts Interrupt Instruction Received (SIR) bit
sets. Once the script is done, the SCSI Request Packet will be modified
to reflect the result of the script.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include/IndustryStandard/LsiScsi.h | 39
Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName()
to report the name of the driver.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++--
OvmfPkg/LsiScsiDxe/LsiScsi.h | 31
This is the first part of LsiScsiPassThru(). Before processing the SCSI
Request packet, we have to make sure whether the packet is valid or not.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/LsiScsiDxe/LsiScsi.c | 100
Open PciIo protocol and use it to initialize the device. The
initialization of LSI 53C895A is simple: just set the SRST bit in
Interrupt Status Zero register to reset the device.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
OvmfPkg/Include
On Mon, Jun 15, 2020 at 01:27:22PM +0200, Laszlo Ersek wrote:
> Hello Gary,
>
Hi Laszlo,
> On 06/12/20 12:04, Gary Lin wrote:
> > This commit introduces the driver for LSI 53C895A SCSI Controller
> > which, so that OVMF can access the devices attached to the emulated
>
This commit introduces the driver for LSI 53C895A SCSI Controller which,
so that OVMF can access the devices attached to the emulated "lsi" SCSI
controller.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Gary Lin
---
Although lsi is now considered obsolete
g this patch, gcc 10 can build ArmVirtPkg without the
linking error.
Tested-by: Gary Lin
> ---
> v2:
> - add missing .globl to export the functions from the object file
> - add function end markers so the size of each is visible in the ELF metadata
> - add some comments to d
;s a transitional issue, but I would really prefer to have
> > the intrinsics included in the release.
>
> OK, let's delay the release then, by a few days. I agree the present
> patch may qualify as a bugfix, but the other patch with the assembly
> language intrinsics doesn't
rt about the executable bit of MpLib.h while
packaging ovmf. It turned out that this patch accidentally changed the
file mode. It would be nice if the mode can be corrected.
Thanks,
Gary Lin
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Leo Duran
> ---
On Wed, Feb 12, 2020 at 06:31:46AM +, Sun, Zailiang wrote:
> Hi Lin,
>
> Next time you might need have Mike Kinney in the cc list:)
>
Ok, will do that if I have patches for Vlv2TbltDevicePkg.
Thanks,
Gary Lin
> Reviewed-by: Zailiang Sun
>
> -Original Message-
Clean up the script.
Cc: Zailiang Sun
cc: Yi Qian
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py | 97
1 file changed, 97 deletions(-)
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PreBuild.py
b/Platform/Intel/Vlv2TbltDevicePkg
Signed-off-by: Gary Lin
---
.../Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule/GenerateCapsule/GenCapsuleAll.py
b/Platform/Intel/Vlv2TbltDevicePkg/Feature
gt;
Actually the TPM document can be found in the qemu package:
https://github.com/qemu/qemu/blob/master/docs/specs/tpm.txt
I also maintained a wiki page for openSUSE:
https://en.opensuse.org/Software_TPM_Emulator_For_QEMU
Hope this helps.
Cheers,
Gary Lin
> > -Original Message-
On Tue, Aug 13, 2019 at 11:17:08AM -0700, Kinney, Michael D wrote:
> Update the integrated UEFI Shell to include the acpiview,
> ping6, and ifconfig6 commands.
>
Those commands are useful. Thanks for the patch.
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Gary Lin
on.
>
Looks reasonable to me.
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Gary Lin
> Signed-off-by: Michael D Kinney
> ---
> .../Intel/Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --gi
.
>
> https://github.com/tianocore/edk2-platforms/commit/6738c654c8eddccc2a1230a4541bc2cb74c10ea5
>
> The call to SetupInfo() is added back.
>
The system info is back after applying this patch.
Tested-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Gary Lin
> Signed-off-by:
into this
> tomorrow.
>
> 1) Device Manager -> System Setup -> Main
>
> 2) Device Manager -> System Setup -> Main -> Platform Information
>
I built another firmware without my patches and those information were
still missing, so the bug is probably introdu
LVFS assumes the GUIDs in the metainfo.xml are lowercase, so fwupdmgr
may fail to match the devices. Convert the GUIDs to lowercase to be
compatible with LVFS.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Feature/Capsule
MSG_URI_DP to sort HTTP Boot options
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
| 29 ++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git
a
date the description
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 3 ++-
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 +
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 +
3 file
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
| 57
1 file changed, 11 insertions(+), 46 deletions(-)
diff --git
a/Platform/I
:
TargetContentDistributionEnabled, UefiSpecificationSupported, and
VirtualMachineSupported to complete the table.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/DataHubRecords.h | 5 -
Platform/Intel/Vlv2TbltDevicePkg
of the function only for the very first boot.
* Update the string in IsNeedSortBootOption() to match the description
of BootManagerMenuApp.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib
4th patches
* Add the 5th and 6th patches
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Gary Lin (6):
Vlv2TbltDevicePkg: Adjust the device priority
Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp
Vlv2TbltDevicePkg: Only sort boot options when necessary
Vlv2TbltDevicePkg
On Fri, Jul 26, 2019 at 07:06:35AM +, Gary Lin wrote:
> After switching to MdeModulePkg BdsDxe, the boot option created by OS
> was always put at the end of BootOrder after reboot. Besides, the PXE
> boot options were always the first boot options.
>
> This series fixes the p
On Fri, Jul 26, 2019 at 07:06:39AM +, Gary Lin wrote:
> BootManagerMenuApp wasn't imported so the Boot Device Menu never showed
> correctly.
>
I should add more details for the fix below.
> Also fix the description of UiApp.
In the "Rule.Common.UEFI_APPLICATION.UI&q
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
| 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git
a/Platform/Intel/Vlv2TbltDevicePkg/Library
er used. So we can remove it altogether
with mHotKeypressed and HotKeyEvent.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/PlatformBootOption.c
| 57
1 file changed, 11 in
of the function only for the very first boot.
* Update the string in IsNeedSortBootOption() to match the descriptions
of BootManagerMenuApp.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib
BootManagerMenuApp wasn't imported so the Boot Device Menu never showed
correctly.
Also fix the description of UiApp.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Michael D Kinney
Signed-off-by: Gary Lin
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkg.fdf | 3 ++-
Platform/Intel/Vlv2TbltDevi
missing BootManagerMenuApp is
also added back.
The last patch cleans up PlatformBootOption.c to remove the unused
variables and function.
The patches are also available in my github branch:
https://github.com/lcp/edk2-platforms/tree/fix-minnowboard-bds
Gary Lin (4):
Vlv2TbltDevicePkg: Adjust
regression bug introduced by a recent commit that broke the detection of the
> BOOT_ON_FLASH_UPDATE boot mode has also been fixed. Capsules are detected and
> processed correctly again.
>
It's nice to see those build scripts are unified. I've tested the gcc
build and it works as expec
On Mon, Jul 22, 2019 at 03:58:59PM -0700, Michael D Kinney wrote:
> Update to use S3BootScriptWidth enum values instead of
> EfiBootScriptWidth enum values when calling S3BootScriptLib
> services. This fixes an XCODE5 build failure.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
On Mon, Jul 22, 2019 at 03:58:54PM -0700, Michael D Kinney wrote:
> Update calls to S3BootScriptxxx() services to use type
> S3_BOOT_SCRIPT_LIB_WIDTH instead of EFI_BOOT_SCRIPT_WIDTH.
> Fixes XCODE5 build failures.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qi
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qian
> Cc: Gary Lin
> Signed-off-by: Michael D Kinney
> ---
> .../Intel/Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c | 2 +-
> Platform/Intel/Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 4 ++--
> 2 files c
On Mon, Jul 22, 2019 at 03:58:51PM -0700, Michael D Kinney wrote:
> Convert all the BAT/sh files used to generate capsules to
> OS independent Python script.
>
Reviewed-by: Gary Lin
> Cc: Zailiang Sun
> Cc: Yi Qian
> Cc: Gary Lin
> Signed-off-by: Michael D Kinney
> R
s good to me.
Reviewed-by: Gary Lin
Gary Lin
> generates the BiosId file. Standard EDK II build
> commands are used to build FW images and capsules.
>
> * Sample VS2015x86 commands for IA32/X64 and DEBUG/RELEASE
> build -a IA32 -a X64 -t VS2015x86 -p Vlv2TbltDevicePkg\PlatformPk
cePkg/PlatformPkgX64.dsc
> build -a IA32-n 5 -t GCC5 -p Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> build -a IA32-n 5 -t GCC5 -p Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
>
Hi Mike,
I found some errors in Readme.md
> Cc: Zailiang Sun
> Cc: Yi Qian
> Cc: Gar
ing,
I'm using openSUSE Tumbleweed which basically uses the latest stable
version of everything. The current gcc version is 9.1.1.
Thanks,
Gary Lin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#43580): https://edk2.groups.io/g/deve
On Thu, Jul 11, 2019 at 04:52:10AM +, Sun, Zailiang wrote:
> Gary,
>
> I suggest remove the first line "From: Gary Lin " from the
> description section since you have appended the "signed-off-by" declaration.
>
Hi Zailiang,
That is added by Mike. I&#
-* Build Release Image
+* Build IA32 Debug Image
```
-cd Vlv2TbltDevicePkg
-./Build_IFWI.sh MNW2 Release
+cd edk2-platforms/Platform/Intel/Vlv2TbltDevicePkg
+Build_IFWI.bat /m /IA32 MNW2 Debug
```
This is the section of Linux, so the build script is Build_IFWI.sh, not
Bui
1 - 100 of 127 matches
Mail list logo
