Hello Tianocore Stewards,
I am trying to upstream a change into edk2-non-osi with a Pull Request
https://github.com/tianocore/edk2-non-osi/pull/6 but not sure if the process on
this repo is same as on edk2 repo. I am unable to add reviewers to the PR. Can
someone please help with this?
Thanks
: Leif Lindholm ; devel@edk2.groups.io
; Ashish Singhal ;
gaolim...@byosoft.com.cn ; Jeff Brasen
; Kinney, Michael D ;
af...@apple.com
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print
Reset Data
External email: Use caution opening links or attachments
Reviewed-by
Adding tianocore stewards to see if we can get some traction on this.
From: Ashish Singhal
Sent: Monday, January 1, 2024 10:17 PM
To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn
; Jeff Brasen
Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print
Replied too soon. I saw you had already closed mine.
Thanks
Ashish
From: Ashish Singhal
Sent: Friday, January 19, 2024 7:23 AM
To: Kinney, Michael D ; Kasbekar, Saloni
; devel@edk2.groups.io ;
Clark-williams, Zachary ; Jeff Brasen
; Gao, Liming
Subject: Re
, Saloni ; Ashish Singhal
; devel@edk2.groups.io ;
Clark-williams, Zachary ; Jeff Brasen
; Gao, Liming
Cc: Kinney, Michael D
Subject: RE: [PATCH] NetworkPkg/Ip4Dxe: Fix Reset To Default
External email: Use caution opening links or attachments
Acked-by: Michael D Kinney
I will prepare PR
Hello,
Checking back for an update on when this PR can be merged or if there are any
other changes you recommend.
Thanks
Ashish
From: Ashish Singhal
Sent: Saturday, January 6, 2024 5:53 AM
To: Kasbekar, Saloni ; devel@edk2.groups.io
; Clark-williams, Zachary
Thanks Saloni. PR for getting this merged is available at
https://github.com/tianocore/edk2/pull/5150
Thanks
Ashish
From: Kasbekar, Saloni
Sent: Saturday, January 6, 2024 1:31 AM
To: Ashish Singhal ; devel@edk2.groups.io
; Clark-williams, Zachary
; Jeff
I do not recommend doing that. Setting policy via SetData does enough to wipe
out any previous manual configuration and that is the goal for reset to default.
From: Kasbekar, Saloni
Sent: Friday, January 5, 2024 2:30 AM
To: Ashish Singhal ; devel@edk2.groups.io
behavior that we see without any
configuration done manually.
Thanks
Ashish
From: Kasbekar, Saloni
Sent: Tuesday, January 2, 2024 1:47 PM
To: Ashish Singhal ; devel@edk2.groups.io
; Clark-williams, Zachary
; Jeff Brasen
Subject: RE: [PATCH] NetworkPkg/Ip4Dxe
Hello,
Checking again for some feedback on this.
Thanks
Ashish
From: Ashish Singhal
Sent: Thursday, December 14, 2023 4:42 PM
To: devel@edk2.groups.io ; saloni.kasbe...@intel.com
; zachary.clark-willi...@intel.com
; Jeff Brasen
Cc: Ashish Singhal
Subject
Hello,
Checking again for some feedback on this.
Thanks
Ashish
From: Ashish Singhal
Sent: Thursday, December 14, 2023 4:30 PM
To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn
; Jeff Brasen
Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset
Exercising reset to default does not reset the settings.
Add handler code for the case where configuration is
disabled.
Signed-off-by: Ashish Singhal
---
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/NetworkPkg/Ip4Dxe
Hello Gao,
Checking if you have any feedback on this.
Thanks
Ashish
From: Ashish Singhal
Sent: Wednesday, December 6, 2023 5:21 PM
To: devel@edk2.groups.io ; gaolim...@byosoft.com.cn
; Jeff Brasen
Cc: Ashish Singhal
Subject: [PATCH] MdeModulePkg
ResetSystem runtime call allows for sending reset data that
starts with a NULL terminated string. Add support to print
that string on console.
Signed-off-by: Ashish Singhal
---
.../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8
1 file changed, 8 insertions(+)
diff --git a
ber 29, 2023 7:13:24 PM
To: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; g...@danielschaefer.me
; Jeff Brasen
Subject: RE: [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot Command Line Length
Bug
External email: Use caution opening links or attac
Hello,
Checking if there is a timeline for this patchset to be merged.
Thanks
Ashish
From: Chang, Abner
Sent: Monday, November 20, 2023 6:57 PM
To: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; g
From: Chang, Abner
Sent: Monday, November 20, 2023 5:13 AM
To: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; g...@danielschaefer.me
; Jeff Brasen
Subject: RE: [PATCH v2 1/2] EmbeddedPkg: Fix Android Boot
From: Chang, Abner
Sent: Monday, November 20, 2023 5:30 AM
To: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; g...@danielschaefer.me
; Jeff Brasen
Subject: RE: [PATCH v2 2/2] EmbeddedPkg: Allow longer android
: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; sami.muja...@arm.com
; Jeff Brasen
Cc: Michael Kinney ; Liming Gao (Byosoft address)
Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
External email: Use caution opening
From: Laszlo Ersek
Sent: Friday, November 17, 2023 2:20 AM
To: devel@edk2.groups.io ; Ashish Singhal
; quic_llind...@quicinc.com
; ardb+tianoc...@kernel.org
; sami.muja...@arm.com ; Jeff
Brasen
Cc: Michael Kinney ; Liming Gao (Byosoft address)
Subject: Re
From: Leif Lindholm
Sent: Wednesday, November 15, 2023 10:20 AM
To: devel@edk2.groups.io ; Ashish Singhal
Cc: ardb+tianoc...@kernel.org ; sami.muja...@arm.com
; Jeff Brasen
Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
External
From: Leif Lindholm
Sent: Wednesday, November 15, 2023 9:21 AM
To: Ashish Singhal
Cc: devel@edk2.groups.io ; ardb+tianoc...@kernel.org
; sami.muja...@arm.com ; Jeff
Brasen
Subject: Re: [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
External email: Use
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
Signed-off-by: Ashish Singhal
---
.../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
a/DynamicTablesPkg/Library/Acpi
Hello Abner,
Thanks for the feedback. I have pushed v2 of the patch set.
Thanks
Ashish
From: Chang, Abner
Sent: Thursday, November 9, 2023 7:06 PM
To: Ashish Singhal ; devel@edk2.groups.io
; quic_llind...@quicinc.com ;
ardb+tianoc...@kernel.org ; g
Curently, AndroidBootImgLib expects input kernel command line
to never exceed 256 unicode characters where the image header
allows for 512 ascii characters. If image header allows 512
ascii characters, similar number of unicode characters should be
allowed at the minimum.
Signed-off-by: Ashish
addition to what the image header
specifies.
Signed-off-by: Ashish Singhal
---
EmbeddedPkg/EmbeddedPkg.dec | 5 +
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 2 +-
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf | 3 ++-
3 files
Hello,
Hoping to get some feedback on these 2 patches this week.
Thanks
Ashish
From: Ashish Singhal
Sent: Monday, October 30, 2023 2:24 PM
To: devel@edk2.groups.io ; quic_llind...@quicinc.com
; ardb+tianoc...@kernel.org
; abner.ch...@amd.com ;
g
addition to what the image header
specifies.
Signed-off-by: Ashish Singhal
---
EmbeddedPkg/EmbeddedPkg.dec | 5 +
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 2 +-
EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf | 3 ++-
3 files
Curently, AndroidBootImgLib expects input kernel command line
to never exceed 256 unicode characters where the image header
allows for 512 ascii characters. If image header allows 512
ascii characters, similar number of unicode characters should be
allowed at the minimum.
Signed-off-by: Ashish
Hello Hao/Ray/Jian/Gao,
Any feedback on this patch?
Thanks
Ashish
From: Rick Tseng
Sent: Sunday, September 24, 2023 7:54 PM
To: devel@edk2.groups.io
Cc: hao.a...@intel.com ; ray...@intel.com
; jian.j.w...@intel.com ;
gaolim...@byosoft.com.cn ; Ashish Singhal
Ashish
From: Ni, Ray
Sent: Thursday, May 26, 2022 7:29 AM
To: Ashish Singhal ; devel@edk2.groups.io
; Wang, Jian J ; Gao, Liming
; Gao, Zhichao
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable
New Boot Options
External email: Use
I understand that. What do you suggest then? Using
EfiBootManagerSortLoadOptionVariable() is an option only if we update all code
paths where we refresh the boot options.
From: Ni, Ray
Sent: Thursday, May 26, 2022 7:15 AM
To: Ashish Singhal ; devel@edk2
Ray,
Any update on this?
Thanks
Ashish
From: Ashish Singhal
Sent: Tuesday, May 17, 2022 10:08 AM
To: Ni, Ray ; devel@edk2.groups.io ;
Wang, Jian J ; Gao, Liming ;
Gao, Zhichao
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable
lease let me know what you think.
Thanks
Ashish
From: Ni, Ray
Sent: Tuesday, May 17, 2022 8:11 AM
To: devel@edk2.groups.io ; Ashish Singhal
; Wang, Jian J ; Gao, Liming
; Gao, Zhichao
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable
Add a new PCD to be able to configure whether newly detected boot options
are to be added at the beginning of the current boot options list or at
the end.
Signed-off-by: Ashish Singhal
---
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c| 6 +-
.../Library/UefiBootManagerLib
tches I have sent for this issue till now.
Thanks
Ashish
____
From: Ashish Singhal
Sent: Saturday, February 26, 2022 2:48 PM
To: Marc Zyngier
Cc: devel@edk2.groups.io ; quic_llind...@quicinc.com
; ardb+tianoc...@kernel.org
; sami.muja...@arm.com
Subject: Re: [PATC
or the problem being discussed
on the email chain for the first version of this patch where you are already
there.
Thanks
Ashish
From: Marc Zyngier
Sent: Saturday, February 26, 2022 2:18 PM
To: Ashish Singhal
Cc: devel@edk2.groups.io ; quic_llind...@quicinc.com
er solution to the problem and I am open to
working with you or anyone else from ARM on that. Please let me know if you
want me to try something else.
Thanks
Ashish
____
From: Ashish Singhal
Sent: Wednesday, February 23, 2022 11:01 PM
To: Ard Biesheuvel
Cc: edk2-deve
fetched earlier has been discarded.
This is specially helpful when the memory attributes of a
region in MMU are being changed and some instructions
operating on the region are prefetched in the instruction
cache.
Signed-off-by: Ashish Singhal
---
ArmPkg/Library/ArmLib/AArch64/AArch64Support.S
have a look at that again.
Thanks
Ashish
From: Ard Biesheuvel
Sent: Wednesday, February 23, 2022 3:54 PM
To: Ashish Singhal
Cc: edk2-devel-groups-io ; Marc Zyngier
; Sami Mujawar ; Ard Biesheuvel
; Leif Lindholm
Subject: Re: [edk2-devel] [PATCH] ArmPkg
Ashish
From: Ard Biesheuvel
Sent: Wednesday, February 23, 2022 10:40 AM
To: edk2-devel-groups-io ; Ashish Singhal
Cc: Marc Zyngier ; Sami Mujawar ; Ard
Biesheuvel ; Leif Lindholm
Subject: Re: [edk2-devel] [PATCH] ArmPkg: Invalidate Instruction Cache On MMU
dnesday, February 23, 2022 1:58 AM
To: Ard Biesheuvel ; Ashish Singhal
Cc: edk2-devel-groups-io ; Sami Mujawar
; Ard Biesheuvel ; Leif
Lindholm
Subject: Re: [PATCH] ArmPkg: Invalidate Instruction Cache On MMU Enable
External email: Use caution opening links or attachments
On Wed, 23 Feb 2022
+ @Samer El-Haj-Mahmoud<mailto:samer.el-haj-mahm...@arm.com>
Hello Leif/Ard/Sami/Samer,
Can you please look at this patch and provide some feedback?
Thanks
Ashish
From: Ashish Singhal
Sent: Monday, February 21, 2022 7:42 PM
To: devel@edk2.groups.io ; sam
fetched earlier has been discarded.
This is specially helpful when the memory attributes of a
region in MMU are being changed and some instructions
operating on the region are prefetched in the instruction
cache.
Signed-off-by: Ashish Singhal
---
ArmPkg/Library/ArmLib/AArch64/AArch64Support.S
, please refer to
https://github.com/tianocore/edk2/commit/239b50a863704f7960525799eda82de061c7c458
I do not think this will be apply for ArmPkg/TimerDxe.
If one real issue happened on platform, it seems that interrupt was reenabled
by reigstered timer event functions.
Jeff
From: Ashish Singhal
From: Ashish Singhal
Sent: Tuesday, October 12, 2021 10:32 AM
To: Marc Zyngier
Cc: Shanker Donthineni ; Ard Biesheuvel
; edk2-devel-groups-io ; Leif Lindholm
; Ard Biesheuvel
Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
From: Marc Zyngier
Sent: Tuesday
From: Marc Zyngier
Sent: Tuesday, October 12, 2021 10:27 AM
To: Ashish Singhal
Cc: Shanker Donthineni ; Ard Biesheuvel
; edk2-devel-groups-io ; Leif Lindholm
; Ard Biesheuvel
Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
External email: Use caution opening
From: Marc Zyngier
Sent: Tuesday, October 12, 2021 9:44 AM
To: Ashish Singhal
Cc: Ard Biesheuvel ; edk2-devel-groups-io
; Leif Lindholm ; Ard Biesheuvel
Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
External email: Use caution opening links or attachments
+ Shaker
Get Outlook for iOS<https://aka.ms/o0ukef>
From: Ashish Singhal
Sent: Tuesday, October 12, 2021 8:56:58 AM
To: Marc Zyngier ; Ard Biesheuvel
Cc: edk2-devel-groups-io ; Leif Lindholm
; Ard Biesheuvel
Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Del
c Zyngier
Sent: Tuesday, October 12, 2021 2:57 AM
To: Ard Biesheuvel ; Ashish Singhal
Cc: edk2-devel-groups-io ; Leif Lindholm
; Ard Biesheuvel
Subject: Re: [PATCH v2] ArmPkg/TimerDxe: Delay End Of Interrupt Signal
External email: Use caution opening links or attachments
On Mon, 11 Oct 2021
In an interrupt handler for the timers, it is important that
software clears the interrupt before deactivating the interrupt
in the GIC. Otherwise the GIC will re-signal the same interrupt
again.
Signed-off-by: Ashish Singhal
---
ArmPkg/Drivers/TimerDxe/TimerDxe.c | 9 +
1 file changed
Timer interrupts are level triggered. Hence, signal end of
interrupt only after current interrupt has been cleared
after setting updated compare value.
Signed-off-by: Ashish Singhal
---
ArmPkg/Drivers/TimerDxe/TimerDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Hello Michael/Gao/Zhiguang,
Any update on this?
Thanks
Ashish
From: Samer El-Haj-Mahmoud
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io ; Ashish Singhal
; michael.d.kin...@intel.com
; gaolim...@byosoft.com.cn
; zhiguang@intel.com
Cc: Samer
Add macros for NVIDIA 16550 UART specific debug port subtype in both
DBG2 as well as SPCR header file.
Signed-off-by: Ashish Singhal
---
MdePkg/Include/IndustryStandard/DebugPort2Table.h| 1 +
.../IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +
2 files changed
This patch adds macro for NVIDIA 16550 UART subtype for ACPI
tables as documented by Microsoft.
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Ashish Singhal (1):
MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
MdePkg/Include
I have picked up the patches this morning and they are working as expected.
Thanks, Leif.
Thanks
Ashish
From: Leif Lindholm
Sent: Thursday, February 25, 2021 1:07 PM
To: Ashish Singhal
Cc: ardb+tianoc...@kernel.org ; devel@edk2.groups.io
Subject: Re: [PATCH
Incorrect register is being set for configuring interrupt
priority. Correct register is located in SGI space and not
in RD space.
Signed-off-by: Ashish Singhal
---
ArmPkg/Drivers/ArmGic/ArmGicLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Drivers/ArmGic
have a conditional flag outside the include directive.
Thanks
Ashish
From: Laszlo Ersek
Sent: Monday, April 20, 2020 6:05 AM
To: devel@edk2.groups.io ; Ashish Singhal
; Bob Feng ; Gao, Liming
Subject: Re: [edk2-devel] Conditionally Include FDF File
External email
Spoke to soon. My change works for the case where BUILD_PLATFORM_XYZ is not
defined but the case where it is defined I guess INCLUDE_XYZ_FDF needs to be
defined in a different way with proper escape characters.
Thanks
Ashish
From: Ashish Singhal
Sent: Monday
: Ashish Singhal ; devel@edk2.groups.io
Subject: Re: [edk2-devel] Conditionally Include FDF File
External email: Use caution opening links or attachments
I saw this issue too.
The included file is always included no matter the condition is TRUE or FALSE.
```
!if FALSE
!include abc.fdf
!endif
Hello,
I am trying to change my top-level FDF file layout by conditionally including
an FDF depending on a build time define being passed or not. The behavior I am
seeing is as follows.
1. I am passing the build time define and the included fdf.inc file gets
included.
2. I am not passin
Patch set version 3 looks good to me. I have reviewed and tested the changes
locally.
Reviewed-by: Ashish Singhal
Tested-by: Ashish Singhal
Thanks
Ashish
From: Ard Biesheuvel
Sent: Wednesday, March 25, 2020 9:29 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel
Reviewed-by: Ashish Singhal
Tested-by: Ashish Singhal
From: Ard Biesheuvel
Sent: Wednesday, March 25, 2020 9:29 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Laszlo Ersek
; Leif Lindholm ; Ashish Singhal
Subject: [PATCH v3 1/3] ArmPkg/ArmMmuLib AARCH64
Reviewed-by: Ashish Singhal
Tested-by: Ashish Singhal
From: Ard Biesheuvel
Sent: Wednesday, March 25, 2020 9:29 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Laszlo Ersek
; Leif Lindholm ; Ashish Singhal
Subject: [PATCH v3 2/3] ArmPkg/ArmMmuLib AARCH64
Reviewed-by: Ashish Singhal
Tested-by: Ashish Singhal
From: Ard Biesheuvel
Sent: Wednesday, March 25, 2020 9:29 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Laszlo Ersek
; Leif Lindholm ; Ashish Singhal
Subject: [PATCH v3 3/3] ArmPkg/ArmMmuLib AARCH64
From: Ard Biesheuvel
Sent: Wednesday, March 25, 2020 5:38 AM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Laszlo Ersek
; Leif Lindholm ; Ashish Singhal
Subject: [PATCH v2 2/2] ArmPkg/ArmMmuLib AARCH64: preserve attributes when
replacing a table entry
External email: Use caution
Because of a bug, current EL gets passed to DC IVAC instruction instead
of the VA entry that needs to be invalidated.
Signed-off-by: Ashish Singhal
---
ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ArmPkg/Library/ArmLib/AArch64
Thanks Zhichao,
Just saw a bunch of ShellPkg changes got merged including mine.
Thanks
Ashish
-Original Message-
From: Gao, Zhichao
Sent: Monday, February 10, 2020 7:55 PM
To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ray
Subject: RE: [edk2-devel] [PATCH] ShellPkg
Hello Ray,
Any update on this one?
Thanks
Ashish
-Original Message-
From: Gao, Zhichao
Sent: Thursday, January 30, 2020 10:33 PM
To: Ashish Singhal ; devel@edk2.groups.io; Ni, Ray
Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
FADT Parser
External
Before writing data to FIFO, wait for the serial port to be ready,
to make sure both the transmit FIFO and shift register empty. Code
comment was saying the right thing but code was missing a check.
Signed-off-by: Ashish Singhal
---
.../Library/BaseSerialPortLib16550/BaseSerialPortLib16550.c
Hello Zhichao,
Do you know by when this may be merged?
Thanks
Ashish
-Original Message-
From: Gao, Zhichao
Sent: Monday, January 20, 2020 12:42 AM
To: devel@edk2.groups.io; Ashish Singhal ; Ni, Ray
Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Fix
FADT
FADT parser was checking for reduced ACPI flag incorrectly
leading to incorrect error message if FIRMWARE_CTRL and
X_FIRMWARE_CTRL are both 0.
Signed-off-by: Ashish Singhal
---
.../UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
, January 1, 2020 7:05 PM
To: devel@edk2.groups.io; Ashish Singhal ; Wang, Sunny
(HPS SW) ; Wang, Jian J ; Wu, Hao A
; Gao, Zhichao ; Kinney, Michael D
; af...@apple.com
Cc: Spottswood, Jason
Subject: RE: [edk2-devel] [PATCH v7] MdeModulePkg: Add EDK2 Platform Boot
Manager Protocol
External email
tswood, Jason
>
> Subject: RE: [edk2-devel] [PATCH v7] MdeModulePkg: Add EDK2 Platform
> Boot Manager Protocol
>
> Looks good enough to me. Thanks for addressing my comments, Ashish.
> Reviewed-by: Sunny Wang
>
> -Original Message-
> From: devel@edk2.groups.io [m
overridden by platform to not call it from anywhere except BDS.
Thanks
Ashish
-Original Message-
From: Wang, Sunny (HPS SW)
Sent: Monday, December 23, 2019 9:38 PM
To: Ni, Ray ; devel@edk2.groups.io; Ashish Singhal
; Wang, Jian J ; Wu, Hao A
; Gao, Zhichao ; Kinney, Michael D
; 'Andrew
Hi Ray,
Patch 7 has been submitted. Please let me know if there are any other changes
needed. I would wait for your patch acceptance email.
Thanks
Ashish
From: Ni, Ray
Sent: Monday, December 23, 2019 7:38 PM
To: devel@edk2.groups.io ; Ashish Singhal
; Wang
Add edk2 platform boot manager protocol which would have platform
specific refreshes to the auto enumerated as well as NV boot options
for the platform.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootManager.h | 82 ++
MdeModulePkg/Library
Hi Guys,
Do we have any feedback on this?
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Sunday, December 22, 2019 7:27 PM
To: devel@edk2.groups.io; ray...@intel.com; jian.j.w...@intel.com;
hao.a...@intel.com; zhichao@intel.com; michael.d.kin...@intel.com;
af
Please ignore patch 5. I have sent patch 6 for consideration.
Thanks
Ashish
-Original Message-
From: Ashish Singhal
Sent: Sunday, December 22, 2019 7:09 PM
To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J
; Wu, Hao A ; Gao, Zhichao
Subject: RE: [PATCH v4] MdeModulePkg: Add EDK2
Add edk2 platform boot manager protocol which would have platform
specific refreshes to the auto enumerated as well as NV boot options
for the platform.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootManager.h | 82 ++
MdeModulePkg/Library
Done. Have submitted patch 5 for consideration.
Thanks
Ashish
-Original Message-
From: Ni, Ray
Sent: Sunday, December 22, 2019 6:47 PM
To: Ashish Singhal ; devel@edk2.groups.io; Wang, Jian
J ; Wu, Hao A ; Gao, Zhichao
Subject: RE: [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot
Add edk2 platform boot manager protocol which would have platform
specific refreshes to the auto enumerated as well as NV boot options
for the platform.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootManager.h | 82 ++
MdeModulePkg/Library
;
'Andrew Fish (af...@apple.com)'
Cc: Ashish Singhal ; Wang, Sunny (HPS SW)
; Spottswood, Jason
Subject: RE: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot
Manager Protocol
External email: Use caution opening links or attachments
1. Is it a proper solution to the problem?
I have submitted a patch version 4.
Thanks
Ashish
-Original Message-
From: Ni, Ray
Sent: Wednesday, December 18, 2019 1:43 AM
To: Ashish Singhal ; devel@edk2.groups.io; Wang, Jian
J ; Wu, Hao A ; Gao, Zhichao
Subject: RE: [PATCH v3] MdeModulePkg: Add Platform Boot Options Protocol
Add edk2 platform boot manager protocol which would have platform
specific refreshes to the auto enumerated as well as NV boot options
for the platform.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootManager.h | 82 ++
MdeModulePkg/Library
with your suggestion about unifying both functions into a single one as
well.
Thanks
Ashish
-Original Message-
From: Ni, Ray
Sent: Tuesday, December 17, 2019 5:55 PM
To: Ashish Singhal ; devel@edk2.groups.io; Wang, Jian
J ; Wu, Hao A ; Gao, Zhichao
Subject: RE: [PATCH v3] MdeModulePkg
Add platform boot options protocol which would have platform specific
overrides to the auto enumerated boot options during the call to
EfiBootManagerRefreshAllBootOption function in UefiBootManagerLib.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootOptions.h | 116
: Ashish Singhal
---
.../Include/Protocol/PlatformBootOptions.h | 114 +
MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 52 --
.../Library/UefiBootManagerLib/InternalBm.h| 2 +
.../UefiBootManagerLib/UefiBootManagerLib.inf | 2
Add platform boot options protocol which would have platform specific
overrides to the auto enumerated boot options during the call to
EfiBootManagerRefreshAllBootOption function in UefiBootManagerLib.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/PlatformBootOptions.h | 114
, December 12, 2019 10:52 AM
To: Ni, Ray ; devel@edk2.groups.io ;
Laszlo Ersek ; af...@apple.com ;
disc...@edk2.groups.io
Cc: Ashish Singhal ; Wang, Jian J
; Wu, Hao A ; Gao, Zhichao
; Kinney, Michael D
Subject: Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration
Thanks for the
Hello Leif/Ard,
Any comments/suggestions on this one?
Thanks
Ashish
From: Ashish Singhal
Sent: Monday, November 4, 2019 10:49 AM
To: devel@edk2.groups.io ; leif.lindh...@linaro.org
; ard.biesheu...@linaro.org
Cc: Ashish Singhal
Subject: [PATCH] EmbeddedPkg
ing.
The custom BDS could could only create the variable for this device if it does
not exist.
Thanks,
Andrew Fish
Thanks,
Jeff
-Original Message-
From: Laszlo Ersek
Sent: Tuesday, November 5, 2019 12:24 PM
To: Ashish Singhal ; Andrew Fish
Cc: devel@edk2.groups.io; Ni, Ray ; Wa
attribute set
and delete the hidden one.
Thanks
Ashish
From: af...@apple.com on behalf of Andrew Fish
Sent: Tuesday, November 5, 2019 9:52 AM
To: Laszlo Ersek
Cc: devel@edk2.groups.io ; Ashish Singhal
; Ni, Ray ; Wang, Jian J
; Wu, Hao A ; Gao, Zhichao
; Mike Kinney
and custom description to identify
the boot option.
Please suggest the best way for this and I would make necessary changes at my
end.
Thanks
Ashish
From: af...@apple.com
Sent: Monday, November 4, 2019 10:22 PM
To: Ashish Singhal
Cc: devel@edk2.groups.io; Ni, Ray ; Laszlo Ersek
; Wang, Jian
platform side. If there is a different way to achieve what I am trying to do,
please let me know and I would be happy to adopt that.
Thanks
Ashish
From: af...@apple.com
Sent: Monday, November 4, 2019 10:01 PM
To: devel@edk2.groups.io; Ashish Singhal
Cc: Ni, Ray ; Laszlo Ersek ; Wang, Jian J
: Monday, November 4, 2019 7:42 PM
To: Laszlo Ersek ; devel@edk2.groups.io; Ashish Singhal
; Wang, Jian J ; Wu, Hao A
; Gao, Zhichao
Cc: Kinney, Michael D
Subject: RE: [edk2-devel] [PATCH] Support skipping automatic BM enumeration
+ Mike
With the UEFI driver model, if a device is not needed by
I sent 2 patches that day for 2 separate changes. I have resent those just now.
-Original Message-
From: Laszlo Ersek
Sent: Friday, November 1, 2019 4:58 PM
To: Ashish Singhal ; devel@edk2.groups.io;
jian.j.w...@intel.com; hao.a...@intel.com; Ray Ni ; Zhichao
Gao
Subject: Re: [edk2
Allow support for skipping auto enumeration of a BlockIO or
SimpleFileSystem or LoadFile protocol based on a new protocol
installed on the same handle. EdkiiSkipBmAutoEnumerate protocol
has been added for that purpose.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/SkipBmAutoEnumerate.h
Add a PCD to govern whether to use DT or ACPI in case the
variable governing this is not found or is not valid.
Signed-off-by: Ashish Singhal
---
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c | 16 ++--
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf | 3 +++
EmbeddedPkg
Please refer to https://edk2.groups.io/g/devel/message/49627 for the patch.
Thanks
Ashish
-Original Message-
From: Laszlo Ersek
Sent: Friday, November 1, 2019 3:42 PM
To: Ashish Singhal ; devel@edk2.groups.io;
jian.j.w...@intel.com; hao.a...@intel.com; Ray Ni ; Zhichao
Gao
Subject
1 - 100 of 121 matches
Mail list logo
