Re: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

2024-08-01 Thread Aithal, Srikanth via groups.io
On 8/2/2024 9:26 AM, Sami Mujawar wrote: Hi Shrikanth, It appears I had missed out passing the correct virtio-scsi request size when enqueuing the request. I have now fixed that in the pull request at https://github.com/tianocore/edk2/pull/6038. Can you try the patch in the pull request

Re: [edk2-devel] How to optimize boot time?

2024-08-01 Thread Andrew Fish via groups.io
> On Jul 3, 2024, at 4:52 AM, Hamit Can Karaca wrote: > > Hi, > > So I've a SBL+EDK2 customized firmware. This firmware enters the BIOS menu in > approximately 17 seconds. I haven't seen this as a problem for a long time, > but I've seen some CFL motherboards boot up the OS in 17 seconds. Th

Re: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

2024-08-01 Thread Sami Mujawar
Hi Shrikanth, It appears I had missed out passing the correct virtio-scsi request size when enqueuing the request. I have now fixed that in the pull request at https://github.com/tianocore/edk2/pull/6038. Can you try the patch in the pull request at and let me know if it fixes the issue, please

Re: [edk2-devel] Can't set the boot order of the USB boot device

2024-08-01 Thread Andrew Fish via groups.io
> On Jul 10, 2024, at 6:05 AM, Hamit Can Karaca wrote: > > Hello, > > We recently found a bug where we can't change the boot order of a USB boot > device. We are trying to set it on the top of the boot order but it keeps > going to the last place. Sometimes it works fine but most of the time

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: Detect FlashNvVarStore before validate it

2024-08-01 Thread Andrew Fish via groups.io
> On Jul 19, 2024, at 12:35 AM, Gerd Hoffmann wrote: > > On Thu, Jul 18, 2024 at 07:57:27PM GMT, Tom Lendacky wrote: >> On 7/16/24 21:30, 韩里洋 wrote: >>> Hi Tom, >>> >>> >>> >>> >>> Thank you for your response. >>> >>> In fact, I'm unable to proceed with the development of the fix patch >>

Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg

2024-08-01 Thread Oliver Smith-Denny
On 8/1/2024 3:49 PM, Michael D Kinney wrote: In order to make this a compatible change, look into updating MdeLibs.dsc.inc too so the lib mappings to the new locations are invisible to DSC files that include MdeLibs.dsc.inc. Sure, that is a good call out, I can do so. Oliver -=-=-=-=-=-=-=-

Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg

2024-08-01 Thread Michael D Kinney
In order to make this a compatible change, look into updating MdeLibs.dsc.inc too so the lib mappings to the new locations are invisible to DSC files that include MdeLibs.dsc.inc. Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Thursday, August 1, 2024 3:39 PM > To: devel@e

[edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg

2024-08-01 Thread Oliver Smith-Denny
CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler intrinsics and floating point functions required by OpenSSL, respectively. CompilerIntrinsicsLib is used almost in every DSC that builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds logic from OpenSSL. Together

Re: [edk2-devel] Map File for PEI and DXE Phases

2024-08-01 Thread Andrew Fish via groups.io
> On Jul 19, 2024, at 6:19 AM, bagcic via groups.io > wrote: > > I need map files for all phases for debug purpose. How can I generate these > files after build? Why do you think you need map files? Lots of code does not generally execute at its linked address? The PE/COFF images are loaded

[edk2-devel] [PATCH edk2-platforms v3 1/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Rebecca Cran
Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains mappings from name to email address and GitHub usernames, which will help people who want to email maintainers instead of using GitHub. Add .github/workflows/Assig

[edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Rebecca Cran
Changes from v2 to v3: Added note to AssignReviewers.yml to say where it was copied from. Sorted platforms in CODEOWNERS and REVIEWERS alphabetically. Sorted entries in CONTRIBUTORS.md by first name. Updated CONTRIBUTORS.md with some more GitHub usernames. Updated Readme.md to clarify that peopl

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
On 8/1/24 10:50, Rebecca Cran wrote: On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an ASSERT() on some XhciDxe control register read (or perhaps a timeout?) This might be the

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Ard Biesheuvel
On Thu, 1 Aug 2024 at 17:50, Rebecca Cran wrote: > > On 8/1/24 9:43 AM, Ard Biesheuvel wrote: > > > Haven't noticed this one myself. The only issue I hit once in a while > > (but only with DEBUG builds as far as I am aware) is an ASSERT() on > > some XhciDxe control register read (or perhaps a tim

Re: [edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

2024-08-01 Thread Sami Mujawar
Hi Srikanth, Thanks for reporting this issue. It is strange that the virtio-blk driver is working with a similar change. I am looking into why this may be failing. Regards, Sami Mujawar From: on behalf of "Aithal, Srikanth via groups.io" Reply to: "devel@edk2.groups.io" , "srikanth.ait...@a

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Rebecca Cran
On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an ASSERT() on some XhciDxe control register read (or perhaps a timeout?) This might be the XHCI bug where there's missing error h

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Rebecca Cran
On 8/1/24 8:51 AM, Leif Lindholm wrote: On 2024-08-01 13:49, Rebecca Cran wrote: Would you like me to add a note to .github/workflows/AssignReviewers.yml to say that's where it came from? I'd like to see it added *somewhere*. Where it came from and the (short) commit hash at the version you p

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Ard Biesheuvel
On Thu, 1 Aug 2024 at 17:19, Jeremy Linton wrote: > > Hi, > > > On 8/1/24 09:44, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > >> > >> On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > >>> > >>> Hi, > >>> > >>> On 7/31/24 11:33, Ard Biesheuvel wrote: > Swi

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

2024-08-01 Thread Nhi Pham via groups.io
For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120187): https://edk2.groups.io/g/devel/message/120187 Mute This Topic: https://groups.io/mt/10766

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform AARCH64: Move PrePeiCore users to Sec.inf

2024-08-01 Thread Nhi Pham via groups.io
For Silicon/Ampere/AmpereAltraPkg, Reviewed-by: Nhi Pham Tested-by: Nhi Pham Thanks, Nhi -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120186): https://edk2.groups.io/g/devel/message/120186 Mute This Topic: https://groups.io/mt/10764

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
Hi, On 8/1/24 09:44, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: Hi, On 7/31/24 11:33, Ard Biesheuvel wrote: Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg to the new versions called

Re: [edk2-devel] Can we do something about libspdm?

2024-08-01 Thread Leif Lindholm
Yes, all better now. Cloning the repo in 7 seconds. Thanks! / Leif On Thu, Aug 01, 2024 at 09:48:24 +, Yao, Jiewen wrote: > Thanks Leif. I saw the issue is closed. > > Please evaluate again, to see if the problem is resolved. > If not, you may reopen the issue at libspdm project. > > P

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

2024-08-01 Thread Leif Lindholm
On Thu, Aug 01, 2024 at 13:03:48 +0200, Ard Biesheuvel wrote: > Remove all the ArmPlatformLib routines that are no longer used now that > the MPCore SEC drivers have been retired. The prototypes will be removed > from the ArmPlatformLib library class in a subsequent EDK2 change. > > Cc: Leif Lindh

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

2024-08-01 Thread Leif Lindholm
On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: > This adds the SmbusRead() function designed for SMBUS transaction to > support the extraction of the data lenth byte from the initial byte of > the SMBUS Block Read, allowing the I2C master to accurately read the > SMBUS respon

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

2024-08-01 Thread Leif Lindholm
On Thu, Aug 01, 2024 at 16:36:14 +0700, Nhi Pham via groups.io wrote: > This adds the SmbusRead() function designed for SMBUS transaction to > support the extraction of the data lenth byte from the initial byte of length > the SMBUS Block Read, allowing the I2C master to accurately read the > SMB

Re: [edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

2024-08-01 Thread Leif Lindholm
On Thu, Aug 01, 2024 at 16:36:15 +0700, Nhi Pham wrote: > This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. > > Signed-off-by: Nhi Pham > --- > Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 > 1 file changed, 12 insertions(+) > > diff --git a/Silicon/

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/Library/MpInitLib: fix SEV-ES AP bootinng failure

2024-08-01 Thread Lendacky, Thomas via groups.io
On 7/31/24 05:22, Wencheng Yang via groups.io wrote: > According to SEV-ES Guest-Hypervisor Communication Block Standardization > section 4.3 SMP Booting, the subsequent reset requires the AP enters > Reset Hold state either by AP Reset Hold NAE event or > AP Reset Hold Request MSR Protocol. > > I

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Leif Lindholm
On 2024-08-01 13:49, Rebecca Cran wrote: Replies inline. On 8/1/24 3:45 AM, Leif Lindholm wrote: On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains ma

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Ard Biesheuvel
On Thu, 1 Aug 2024 at 16:11, Ard Biesheuvel wrote: > > On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > > > > Hi, > > > > On 7/31/24 11:33, Ard Biesheuvel wrote: > > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg > > > to the new versions called Sec or PeilessSec -

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Ard Biesheuvel
On Thu, 1 Aug 2024 at 15:49, Jeremy Linton wrote: > > Hi, > > On 7/31/24 11:33, Ard Biesheuvel wrote: > > Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg > > to the new versions called Sec or PeilessSec - these have been cleaned > > up and stripped of obsolete functionalit

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, August 1, 2024 #cal-notice

2024-08-01 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, August 1, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?sub

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Jeremy Linton
Hi, On 7/31/24 11:33, Ard Biesheuvel wrote: Switch all ARM platforms that use the SEC drivers in edk2/ArmPlatformPkg to the new versions called Sec or PeilessSec - these have been cleaned up and stripped of obsolete functionality related to multicore boot, which is not something UEFI should conc

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, August 1, 2024 #cal-reminder

2024-08-01 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, August 1, 2024 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@a

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Rebecca Cran
Replies inline. On 8/1/24 3:45 AM, Leif Lindholm wrote: On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains mappings from name to email address and GitH

[edk2-devel] Patch OvmfPkg: Use heap memory for virtio-scsi request causing regression

2024-08-01 Thread Aithal, Srikanth via groups.io
Hello all, After the patches [1fc55a39, b342070c] OvmfPkg: Use heap memory for virtio-blk request/OvmfPkg: Use heap memory for virtio-scsi request got merged, this regression is spotted. AMD SVM/SEV/SEVES guest boot fails with OVMF packages [Ia3264/X64] built from today's upstream edk2 repos

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/ ARM AARCH64: Remove ArmPlatformLib MPCore boilerplate

2024-08-01 Thread Ard Biesheuvel
Remove all the ArmPlatformLib routines that are no longer used now that the MPCore SEC drivers have been retired. The prototypes will be removed from the ArmPlatformLib library class in a subsequent EDK2 change. Cc: Leif Lindholm Cc: Abdul Lateef Attar Cc: Abner Chang Cc: Chuong Tran Cc: Graem

Re: [edk2-devel] Can we do something about libspdm?

2024-08-01 Thread Yao, Jiewen
Thanks Leif. I saw the issue is closed. Please evaluate again, to see if the problem is resolved. If not, you may reopen the issue at libspdm project. Please feel free to submit issue if you see anything could be improved. Thank you Yao, Jiewen > -Original Message- > From: devel@edk2.gr

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

2024-08-01 Thread Leif Lindholm
On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: > Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS > files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains > mappings from name to email address and GitHub usernames, which will > help people who want to ema

[edk2-devel] [edk2-platforms][PATCH 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check

2024-08-01 Thread Nhi Pham via groups.io
This adds the PlatformBmcReadyLib library instance, which provides a function to check whether the BMC is ready for transaction or not. The function checks the GPIO pin specified by the PcdBmcReadyGpio PCD and returns TRUE if the pin is set to a logic high level, indicating that the BMC is ready.

[edk2-devel] [edk2-platforms][PATCH 5/5] Ampere/Jade: Enable IPMI SSIF

2024-08-01 Thread Nhi Pham via groups.io
This adds the building of IPMI SSIf and associated modules. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 23 Platform/Ampere/JadePkg/Jade.dsc | 2 ++ Platform/Ampere/JadePkg/Jade.fdf | 17

[edk2-devel] [edk2-platforms][PATCH 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers

2024-08-01 Thread Nhi Pham via groups.io
This adds the implementation of SMBUS PPI and Protocol to produce SMBUS interface in both PEI and DXE phases for use by IPMI SSIF. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf | 43 +++ Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf |

[edk2-devel] [edk2-platforms][PATCH 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC

2024-08-01 Thread Nhi Pham via groups.io
This introduces fixed PCDs for SMBUS and BMC as specified to Ampere. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 12 1 file changed, 12 insertions(+) diff --git a/Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec b/Silicon/Ampere/AmpereSil

[edk2-devel] [edk2-platforms][PATCH 0/5] Add IPMI SSIF support

2024-08-01 Thread Nhi Pham via groups.io
This updates the I2C library and implements SMBUS PEI/DXE drivers to support IPMI SSIF in the Mt. Jade platform. Nhi Pham (5): AmpereAltraPkg/DwI2cLib: Add SmbusRead() function AmpereSiliconPkg: Define PCDs for SMBUS and BMC AmpereAltraPkg: Add SmbusHc PEI and DXE drivers JadePkg: Add Plat

[edk2-devel] [edk2-platforms][PATCH 1/5] AmpereAltraPkg/DwI2cLib: Add SmbusRead() function

2024-08-01 Thread Nhi Pham via groups.io
This adds the SmbusRead() function designed for SMBUS transaction to support the extraction of the data lenth byte from the initial byte of the SMBUS Block Read, allowing the I2C master to accurately read the SMBUS response with the exact data length. This addresses the issue where the SmbusLib:SmB

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

2024-08-01 Thread Sami Mujawar
Hi Ard, Thank you for this patch series. For Platform/ARM/*, these changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120161): https://edk2.groups.io/g/devel/messa

[edk2-devel] Can't get the random number with "GetRandomNumber64" in OpensslLib

2024-08-01 Thread eddie wang
Hi all, In our program, OpensslLib was utilized. Nevertheless, the random number could not be successfully obtained by the "GetRandomNumber64" (in OpensslLib/OpensslStub/rand_pool.c). It appears that our SoC (AmpereAltra) is not supported, based on our investigation (failed at https://github.co