Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-20 Thread Michael D Kinney
We are working on auto assignment. Right now, maintainers need to watch new PRs and do assignments. Mike From: Dhaval Sharma Sent: Thursday, June 20, 2024 10:16 PM To: Kinney, Michael D ; devel@edk2.groups.io Subject: Re: [edk2-devel] GitHub PR Code Review process now active Hi Michael, Just t

Re: [edk2-devel] GitHub PR Code Review process now active

2024-06-20 Thread Dhaval Sharma
Hi Michael, Just to clarify my understanding. Once a PR is submitted (or it moves from draft to regular PR state), it automatically gets reviewers assigned? I submitted this one https://github.com/tianocore/edk2/pull/5802 and was wondering if I should be sending maintainers an email or be assure

Re: [edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

2024-06-20 Thread Nhi Pham via groups.io
Thanks for the cleanup. For Ampere Altra, Reviewed-by: Nhi Pham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119663): https://edk2.groups.io/g/devel/message/119663 Mute This Topic: https://groups.io/mt/106780877/21656 Group Owner: d

Re: [edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019

2024-06-20 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Jayaprakash, N > Sent: Thursday, June 20, 2024 4:47 AM > To: devel@edk2.groups.io > Cc: Jayaprakash, N ; Rebecca Cran > ; Kinney, Michael D > Subject: [edk2-libc Patch v2 1/1] edk2-libc : add github actions workflow to > build P

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

2024-06-20 Thread Marcin Juszkiewicz
W dniu 20.06.2024 o 16:32, Leif Lindholm pisze: A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endings in otherwise CRLF files, so clean that up. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Marcin Wojtas Cc: Meenakshi Agga

Re: [edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

2024-06-20 Thread Ard Biesheuvel
On Thu, 20 Jun 2024 at 16:33, Leif Lindholm wrote: > > Related to https://github.com/tianocore/edk2/pull/5797 > > PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. > Its functionality has been partially broken, and mostly ignored, for > all AArch64 platforms since December 202

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

2024-06-20 Thread Leif Lindholm
Obvs I forgot to update the subject when I squashed a bunch of line ending fixups. I'll do that before I push if anyone gives me an R-b on this. / Leif On 2024-06-20 15:32, Leif Lindholm wrote: A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endings in o

[edk2-devel] [PATCH edk2-platforms 1/5] Platform/SbsaQemu: fix .dsc line endings

2024-06-20 Thread Leif Lindholm
A patch adding a mapping for ImagePropertiesRecordLib introduced a bunch of LF line endings in otherwise CRLF files, so clean that up. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme Gregory Cc: Marcin Juszkiewicz Cc: Marcin Wojtas Cc: Meenakshi Aggarwal Cc: Narinder Dhillon Cc: Nhi Pham Cc:

[edk2-devel] [PATCH edk2-platforms 5/5] Silicon/Marvell: drop use of PcdArmArchTimerFreqInHz

2024-06-20 Thread Leif Lindholm
Armada7k8k.dsc.inc, used by several platforms, explicitly sets PcdArmArchTimerFreqInHz, however the intended effect of that is not possible from AArch64 EL2/1, and has never been performed unless built for ARM. The Pcd is now being deleted, so drop the setting. This has however affected timer tim

[edk2-devel] [PATCH edk2-platforms 3/5] Platform/ARM: drop use of PcdArmArchTimerFreqInHz

2024-06-20 Thread Leif Lindholm
Some Arm ltd. platforms explicitly set PcdArmArchTimerFreqInHz, however the intended effect of that is not possible from AArch64 EL2/1, and has never been performed unless built for ARM. The Pcd is now being deleted, so drop the setting. This has however affected timer timout calculations, so cou

[edk2-devel] [PATCH edk2-platforms 2/5] Platform,Silicon: drop redundant uses of PcdArmArchTimerFreqInHz

2024-06-20 Thread Leif Lindholm
PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. Some platforms already explicitly set it to 0, which is the default. And some modules reference it in their .inf without actually ever using it. Drop these redundant uses first. Cc: Ard Biesheuvel Cc: Chuong Tran Cc: Graeme

[edk2-devel] [PATCH edk2-platforms 4/5] Platform/Hisilicon: drop D05 use of PcdArmArchTimerFreqInHz

2024-06-20 Thread Leif Lindholm
The D05 platform explicitly sets PcdArmArchTimerFreqInHz, however the intended effect of that is not possible from AArch64 EL2/1, and has never been performed unless built for ARM. The Pcd is now being deleted, so drop the setting. This has however affected timer timout calculations, so could lea

[edk2-devel] [PATCH edk2-platforms 0/5] Platform,Silicon: drop use of PcdArmArchTimerFreqInHz

2024-06-20 Thread Leif Lindholm
Related to https://github.com/tianocore/edk2/pull/5797 PcdArmArchTimerFreqInHz is about to be removed, as it is now obsolete. Its functionality has been partially broken, and mostly ignored, for all AArch64 platforms since December 2020. This set cleans up some broken line endings in .dsc* files,

[edk2-devel] [edk2-libc Patch v2 1/1] edk2-libc : add github actions workflow to build PyUEFI using VS2019

2024-06-20 Thread Jayaprakash, N
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4788 This commit adds github actions workflow to build python uefi interpreter with visual studio 2019 tool chain. The build-python-uefi-vs.yaml file under .github/workflows implements the build action for building the pyuefi interpreter with VS2

[edk2-devel] [edk2-libc Patch v2 0/1] add github actions workflow to build PyUEFI using VS2019

2024-06-20 Thread Jayaprakash, N
This patch adds github actions workflow to build python uefi interpreter with visual studio 2019 tool chain. The build-python-uefi-vs.yaml file under .github/workflows implements the build action for building the pyuefi interpreter with VS2019 tool chain. Please refer to BZ4788 for more details. J

[edk2-devel] uncompress peims during car phase

2024-06-20 Thread Yoshinoya
Hello A question about compressed peims in uefi bios. for example: Current x86 cache size is large enough. Is there possible to process compressed peim during cache as ram phase? Is there any limitations? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent