Sounds good, I will try it.
Thanks,
Yi
-Original Message-
From: Kinney, Michael D
Sent: Saturday, June 15, 2024 12:58 PM
To: Li, Yi1 ; Ard Biesheuvel ; Yao, Jiewen
Cc: Gerd Hoffmann ; devel@edk2.groups.io; Hou, Wenxing
; Pedro Falcato ; Kinney,
Michael D
Subject: RE: [edk2-devel] C
If the host test was updated to use GoogleTest/GoogleMock, then
the call to AsmCpuid() could be mocked instead of calling the
version of BaseLib that is safe to use from host envs. Then
all the code paths can be tested properly.
Mike
> -Original Message-
> From: Li, Yi1
> Sent: Friday,
Hi Jiewen,
Currently Host lib using a dummy AsmCpuid implementation:
BaseLib\X86UnitTestHost.c
AsmCpuid -> UnitTestHostBaseLibAsmCpuid -> Return all zero (BIT30 of ECX
hardcode to 1 after change of Gerd)
Did you mean prefer to use real AsmCpuid func in Host?
Or only use cpuid to check RdRand bit
Liming,
It is here, but needs some commit message updates
https://github.com/tianocore/edk2/pull/5760
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming via
> groups.io
> Sent: Friday, June 14, 2024 8:05 PM
> To: devel@edk2.groups.io; dha...@rivosinc.com
> Su
Zhihao:
I have no other comment for the change in MdeModulePkg. Please create pull
request for it.
Thanks
Liming
> -邮件原件-
> 发件人: Li, Zhihao
> 发送时间: 2024年6月11日 15:36
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: Chiu, Chasel ; Desimone, Nathaniel L
> ; Duggapu, Chinni B
> ; Chen, Gang
> I think we need follow 24 hour rule.
> Any patch requires at least 24 hours before merge, to give people chance to
> review and feedback.
Sure I will follow this rule future.
There is a critical Mbedtls bug based on this patch (blocked build) so I merged
this patch quickly to unblock CI.
https
Can you create pull request for this change? I will add my review for it.
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Dhaval Sharma
> 发送时间: 2024年6月11日 12:09
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao
> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Avoid efi memory
allocation
> for SP type
Comments below.
Mike
> -Original Message-
> From: Jayaprakash, N
> Sent: Friday, June 14, 2024 10:02 AM
> To: devel@edk2.groups.io
> Cc: Jayaprakash, N ; Rebecca Cran
> ; Kinney, Michael D
> Subject: [edk2-libc Patch 1/1] edk2-libc : add github actions workflow to
> build PyUEFI using V
On Fri, 14 Jun 2024 at 18:45, Yao, Jiewen wrote:
>
>
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Saturday, June 15, 2024 12:14 AM
> > To: Yao, Jiewen
> > Cc: Li, Yi1 ; Gerd Hoffmann ;
> > devel@edk2.groups.io; Hou, Wenxing ; Kinney, Michael
> > D ; Pedro Falcato
> > Subjec
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4788
This commit adds github actions workflow to build python uefi
interpreter with visual studio 2019 tool chain.
The build-python-uefi-vs.yaml file under .github/workflows
implements the build action for building the pyuefi interpreter
with VS2
This patch request enables the github actions workflow to build Python
UEFI interpreter using VS2019 tool chain.
Please refere to BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4788
Jayaprakash N (1):
edk2-libc : add github actions workflow to build PyUEFI using VS2019
.github/scripts/enab
> -Original Message-
> From: Ard Biesheuvel
> Sent: Saturday, June 15, 2024 12:14 AM
> To: Yao, Jiewen
> Cc: Li, Yi1 ; Gerd Hoffmann ;
> devel@edk2.groups.io; Hou, Wenxing ; Kinney, Michael
> D ; Pedro Falcato
> Subject: Re: [edk2-devel] CryptoPkg host test broken due to smoketest for
>
On Fri, 14 Jun 2024 at 18:09, Yao, Jiewen wrote:
>
> Hey
> This PR seems just a workaround.
>
> I don't feel it is right solution to hardcode BIT30.
> What if the host platform does not have such capability? You will get failure
> later.
>
Agreed. But that was already the case: RngLib assumed th
Hey
This PR seems just a workaround.
I don't feel it is right solution to hardcode BIT30.
What if the host platform does not have such capability? You will get failure
later.
To fix this function, can we call real CPUID instruction to return real value?
UINT32
EFIAPI
UnitTestHostBaseLibAsmCpui
Yes we did use PRNG(DRBG), the entropy pool is polled from HW RngLib. Seed is
generated by TSC.
Regards,
Yi
From: Ard Biesheuvel
Sent: Friday, June 14, 2024 3:52 PM
To: Li, Yi1
Cc: Yao, Jiewen ; devel@edk2.groups.io; Hou, Wenxing
; Kinney, Michael D ; Pedro
Falcato
Subject: Re: CryptoPkg ho
Approved, appreciate your quick response.
Thanks,
Yi
-Original Message-
From: Gerd Hoffmann
Sent: Friday, June 14, 2024 6:41 PM
To: devel@edk2.groups.io; Li, Yi1
Cc: Hou, Wenxing ; Yao, Jiewen ;
Kinney, Michael D ; Pedro Falcato
; Ard Biesheuvel
Subject: Re: [edk2-devel] CryptoPkg
On Fri, Jun 14, 2024 at 07:07:41AM GMT, Li, Yi wrote:
> All crypto host tests which consumed randlib broken due to:
> https://github.com/tianocore/edk2/pull/5714
> Not sure why this issue not reported by CI when merge this PR.
>
> The reason is that the ```BaseRngLibConstructor``` of rnglib is no
For crypto unit tests, it is generally better to use a pseudo-random RNG,
with a known (but not constant) seed, so that potential failures can be
diagnosed more easily. E.g., the seed could be logged in the test output.
On Fri, 14 Jun 2024 at 09:24, Li, Yi1 wrote:
> Yes, we can create a host te
Yes, we can create a host test specific lib if no better ways.
Regards,
Yi
From: Yao, Jiewen
Sent: Friday, June 14, 2024 3:20 PM
To: Li, Yi1 ; devel@edk2.groups.io
Cc: Hou, Wenxing ; Kinney, Michael D
; Pedro Falcato ; Ard
Biesheuvel
Subject: RE: CryptoPkg host test broken due to smoketest fo
Can we use a host test specific RngLib?
From: Li, Yi1
Sent: Friday, June 14, 2024 3:08 PM
To: devel@edk2.groups.io
Cc: Hou, Wenxing ; Yao, Jiewen ;
Kinney, Michael D ; Pedro Falcato
; Ard Biesheuvel
Subject: CryptoPkg host test broken due to smoketest for RDRAND
All crypto host tests which
All crypto host tests which consumed randlib broken due to:
https://github.com/tianocore/edk2/pull/5714
Not sure why this issue not reported by CI when merge this PR.
The reason is that the ```BaseRngLibConstructor``` of rnglib is not called in
host test, so ```mRdRandSupported``` is not enabled
21 matches
Mail list logo
