On Fri, 14 Jun 2024 at 18:09, Yao, Jiewen <jiewen....@intel.com> wrote: > > Hey > This PR seems just a workaround. > > I don't feel it is right solution to hardcode BIT30. > What if the host platform does not have such capability? You will get failure > later. >
Agreed. But that was already the case: RngLib assumed that RDRAND was implemented without checking CPUID at all, and so the code was already broken on systems without RDRAND. > > To fix this function, can we call real CPUID instruction to return real value? > That would be better. But this change just restores the old behavior. And on top of that, Yi Li already merged it. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119575): https://edk2.groups.io/g/devel/message/119575 Mute This Topic: https://groups.io/mt/106666288/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
