Hi Michael! Thanks for answer.
> Converting these to a flexible array member would not be
a backwards compatible change.
That's the point. But at least when I see the compiler used in tool_def.txt,
there's no compiler which doesn't support to flexible array member.
Do we still need to consider t
Hi Pierre,
Thank you for this series.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/02/2024 12:42 pm, Pierre Gondois wrote:
Following the discussion at:
https://edk2.groups.io/g/devel/message/115378
remove ArmCortexA5x.h and ArmCortexA9.h files.
A pat
Merged as 8b29c9255d44..ff3c7adf0785
Thanks.
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117451): https://edk2.groups.io/g/devel/message/117451
Mute This Topic: https://groups.io/mt/104351721/21656
Group Owner:
Hi Pierre,
Thank you for this series.
Apologies for the delay. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 14/02/2024 12:43 pm, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Following the discussion at:
https://edk2.groups.io/g/devel/message/115
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file ConformanceProfiles.h (Cc'd maintainers of
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
Notes:
v4:
- changed Image Execution output to matc
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Added new entry to the help command for the -verbose option
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file ConformanceProfil
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
Notes:
v4:
- changed Image
Reviewed-by: Stuart Yoder
On 4/3/24 4:19 PM, Sam Kaynor via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Added new entry to the help command for the -verbose option
Cc: Ray Ni
Cc: Zhichao Gao
On 4/3/2024 4:28 PM, Kinney, Michael D wrote:
MdeModulePkg has many different reviewers for different subsets.
We should also consider seeing if any of those reviewers that
are responsible for different subsets of MdeModulePkg would be
willing to be a backup maintainer for the MdeModulePkg.
Zhi
The patch series looks good to me. Thanks for your contributions to edk2-test,
Abhi.
I directly added some suggestions/comments to its Github pull request
https://github.com/tianocore/edk2-test/pull/90. No need to update the patch
series. My suggestions/comments can be addressed in a separate ne
Can you please fix the following typo? "PcdEnableSpdmDeviceAuthenticaion"
Thanks,
Michael
On 4/1/2024 10:31 PM, Wenxing Hou wrote:
Add EV_EFI_SPDM_DEVICE_POLICY support for MeasureVariable.
Cc: Liming Gao
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdeModulePkg/MdeModulePkg.dec
On Wed, Apr 3, 2024 at 11:02 PM Oliver Smith-Denny
wrote:
>
> On 4/3/2024 1:38 PM, Michael D Kinney wrote:
> > Hi Oliver,
> >
> > I missed this response. Did not show up in thread for some reason.
>
> No worries.
>
> >
> > But we can continue these topics on email.
> >
> > The TianoCore roles and
Reviewed-by: Felix Polyudov
-Original Message-
From: Ming Tan
Sent: Tuesday, April 2, 2024 4:32 AM
To: devel@edk2.groups.io
Cc: Min Xu ; Jiewen Yao ; Dandan Bi
; Felix Polyudov
Subject: [EXTERNAL] [PATCH v4] SecurityPkg/SecureBootConfigDxe: Update UI
according to UEFI spec
**CAUTION
[AMD Official Use Only - General]
Thanks Igor. This patch set is merged.
Abner
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Thursday, April 4, 2024 9:34 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Nickle Wang
> Subject: RE: [EXTERNAL] [PATCH V3 0/6] Config language sear
*TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, April 4, 2024
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon
*Organizer:*
Edhaya Chandran
edhaya.chand...@arm.com (
edhaya.chand...@arm.com?subj
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, April 4, 2024
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/94348061758?pwd=Q3RDeFA5K2JFaU5jdWUxc1FnaGdyUT09&from=addon
*Organizer:*
Edhaya Chandran
edhaya.chand...@arm.com (
edhaya.chand...@ar
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V3 4/6] RedfishPkg/RedfishPlatformConfigDxe: HII
string is deleted unex
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nickle
Wang
Subject: [EXTERNAL] [PATCH V3 6/6] RedfishPkg/RedfishPlatformConfigDxe: support
men
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V3 1/6] RedfishPkg/RedfishPlatformConfigDxe: Config
language searching
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V3 3/6] RedfishPkg/RedfishPlatformConfigDxe:Add
RefishDebugLib support
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V3 0/6] Config language searching algorithm
enhancement and the bug fix
Reviewed-by: Igor Kulchytskyy
Regards,
Igor
-Original Message-
From: abner.ch...@amd.com
Sent: Thursday, April 4, 2024 6:18 AM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [EXTERNAL] [PATCH V3 2/6] RedfishPkg/RedfishDebugLib: Introduce
Redfish DEBUG macro
**C
From: Nickle Wang
"MenuPath" is the attribute in BIOS attribute registry. To support
reporting this attribute, we need to include the formset without
x-uefi-redfish support in database. So driver can find menu path to
target attribute in BIOS menu.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Nickle Wang
Reviewed-by: Nickle Wang
---
EmulatorPkg/EmulatorPkg.dsc | 21 +
1 file changed, 21 insertions(+)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 85134b07816..5fa1ed345a3 100644
---
From: Abner Chang
Add the condition check when delete HII string.
Only when the HiiStatement operand equal to "EFI_IFR_STRING_OP"
and the statement value type = EFI_IFR_TYPE_STRING.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
.../
From: Abner Chang
Add RedfishPlatformConfigDxe debug capability that aligns
with edk2 Redfish debug mechanism.
- PcdRedfishPlatformConfigDebugProperty, add PCD to control
RedfishPlatformConfigDxe subordinate of Redfish debug
capabilities.
- PcdRedfishPlatformConfigFeatureProperty, add PCD to
From: abnchang
Build up the x-uefi-redfish string database for the Redfish confg
language searching, instead of using HII String protocol.
This can improve the time consumption lot on searching strings.
Signed-off-by: Abner Chang
Co-authored-by: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: N
From: Abner Chang
PR # 5517
In V3, adddressed comments from Nickle and Igor.
In V2, add patch 6/6 contibuted by Nvidia for updating BIOS
menu path implementation based on the performance improvement.
In this patch set,
1 We enhance the config language searching algorithm.
As the performance o
From: Abner Chang
Introduce DEBUG_REDFISH macro for the debug message
of edk2 Redfish components.
DEBUG_REDFISH can be used in any edk2 Redfish component
with Redfish DebugCatagory as the first parameter.
Whether the debug message is output or not depends on
the platform setting of PcdRedfishDebu
On Thu, Mar 21, 2024 at 04:53:03PM +0100, Pierre Gondois wrote:
> Following [1] and [2], other architectures than Arm aim to leverage
> the DynamicTablesPkg. The package uses namespaces/domains to split
> objects IDs. Currently most of the objects are part of the Arm
> namespace. Some objects are g
The wrmsr function always writes 0s to the higher 32 bits of the msr register.
This issue has been fixed by this PR.
Jayaprakash N (1):
edk2-libc: wrmsr function available in edk2module is not working as
expected
.../Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c| 2 +-
1 fil
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4745
This commit fixes the issue reported in the BZ4745.
The wrmsr function was always writing 0 to the higher 32 bits of
the msr register. This was due to a logical flaw in the code,
where the input variable of type unsigned int was left shitted
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Maintainers.txt | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 799f27f914c..7d9cdca611f 100644
--- a/Maintainers.txt
+++ b/Maintai
From: abnchang
BZ#: 4471
SPI NOR Flash JEDEC Serial Flash Discoverable Driver
implementation.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdeModulePkg/MdeModulePkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMod
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
.
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdePkg/Include/Protocol/SpiConfiguration.h | 10 +-
MdePkg/Include/Protocol/Spi
From: Abner Chang
Sending V4 for review as SPI related ECR is approved by
PIWG in PI spec 1.8A
In V5: Correct patch 6/6, as some source files are fixed in this patch.
In RESEND V4: Add Cc in patch 6/6
In V4: Enhance timeout algorithm
In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
MdeM
From: abnchang
BZ#: 4471
SPI NOR Flash JEDEC Serial Flash Discoverable Driver
implementation.
Signed-off-by: Abner Chang
Cc: Jian J Wang
Cc: Liming Gao
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdeModulePkg/MdeModulePkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -
From: Abner Chang
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
.../Bus/Spi/SpiNorFlashJedecSfdp/SpiNorFlash.c | 12 ++--
.../Spi/SpiNorFlashJedecSfdp/SpiNorFlashJedecSfdp.c | 12 ++--
Maintainers.txt
From: Abner Chang
BZ#: 4473
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Jian J Wang
Cc: Abdul Lateef Attar
---
MdeModulePkg/MdeModulePkg.dec | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMod
From: abnchang
BZ#: 4472
Add definition of JEDEC Serial Flash Discoverable Parameters
(SFDP) specification.
https://www.jedec.org/standards-documents/docs/jesd216b
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
.
From: Abner Chang
Sending V4 for review as SPI related ECR is approved by
PIWG in PI spec 1.8A
In RESEND V4: Add Cc in patch 6/6
In V4: Enhance timeout algorithm
In V3: Relocate GUIDs/PCDs for SPI SFDP drivers to
MdeModulePkg.dec.
In V2: Add maintainer entry for Bus/Spi.
This patch fixes
From: abnchang
BZ#: 4471
Update definitions according to PI spec 1.8 errata A
Signed-off-by: Abner Chang
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Abdul Lateef Attar
Cc: Brit Chesley
---
MdePkg/Include/Protocol/SpiConfiguration.h | 10 +-
MdePkg/Include/Protocol/Spi
46 matches
Mail list logo