Re: [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build

2024-01-20 Thread Li, Yi
Looks good to me. Reviewed-by: Yi Li -Original Message- From: Hou, Wenxing Sent: Saturday, January 20, 2024 9:45 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Li, Yi1 ; Jiang, Guomin Subject: [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build REF:https://bugzilla.tia

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-20 Thread Ni, Ray
> The worry I have here is that it becomes a maintenance concern having to > update the list of leaves with sub-leaves whenever a new CPUID leaf with > sub-leaves is introduced. Intel SDM or AMD equivalent "SDM" should not change a CPUID leaf in a way that it does not consume ECX today but consume

[edk2-devel] [PATCH v2 0/2] Move NestedInterruptTplLib to MdeModulePkg

2024-01-20 Thread Michael Brown
NestedInterruptTplLib provides a way for timer interrupt handlers (which must support nested interrupts) to prevent unbounded stack consumption. The underlying issue was first observed in OvmfPkg, since interrupt storms can arise more easily in virtual machines due to CPU starvation. However, car

[edk2-devel] [PATCH v2 2/2] MdeModulePkg: Add missing Iret.h to NestedInterruptTplLib sources list

2024-01-20 Thread Michael Brown
Suggested-by: Ray Ni Signed-off-by: Michael Brown --- .../Library/NestedInterruptTplLib/NestedInterruptTplLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Library/NestedInterruptTplLib/NestedInterruptTplLib.inf b/MdeModulePkg/Library/NestedInterruptTplLib/NestedInt

[edk2-devel] [PATCH v2 1/2] MdeModulePkg: Move NestedInterruptTplLib to MdeModulePkg

2024-01-20 Thread Michael Brown
NestedInterruptTplLib provides a way for timer interrupt handlers (which must support nested interrupts) to prevent unbounded stack consumption. The underlying issue was first observed in OvmfPkg, since interrupt storms can arise more easily in virtual machines due to CPU starvation. However, car

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Move NestedInterruptTplLib to MdeModulePkg

2024-01-20 Thread Michael Brown
On 20/01/2024 07:03, Ni, Ray wrote: Can you submit another patch to add Iret.h to the INF file [Sources] section? Without that, incremental build might not work if changes are made in Iret.h. Good catch, thank you. I will send a v2. It doesn't support non-x86 CPU. Will ARM have similar prob

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Use AsmCpuidEx() for CPUID_EXTENDED_TOPOLOGY leaf

2024-01-20 Thread Lendacky, Thomas via groups.io
On 1/20/24 00:48, Ni, Ray via groups.io wrote: Mike, Tom, How about AsmCpuId() adds ASSERT() to reject those CPUID leaves that do not have sub-leaf? Do you mean those CPUID leaves that do have a sub-leaf? The worry I have here is that it becomes a maintenance concern having to update the lis

Re: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in SmramSaveState module.

2024-01-20 Thread Abdul Lateef Attar via groups.io
[AMD Official Use Only - General] Why overriding the PiSmmCpuDxeSmm driver? UefiCpuPkg has AMD specific SaveStatelib library "UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf". Thanks AbduL -Original Message- From: devel@edk2.groups.io On Behalf Of duke.zhai via groups.io Sent:

[edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build

2024-01-20 Thread Wenxing Hou
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642 When use Mbedtls, there is a clang build error. Add dummy inttypes header to fix clang build. Cc: Jiewen Yao Cc: Yi Li Cc: Guomin Jiang Signed-off-by: Wenxing Hou --- CryptoPkg/CryptoPkg.ci.yaml | 1 + CryptoPkg/Library/Include