Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Wei6 Xu > Sent: Tuesday, October 31, 2023 11:08 AM > To: devel@edk2.groups.io > Cc: Wei6 Xu ; Chang, Abner ; > Nate DeSimone ; Liming Gao > > Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIp

Re: [edk2-devel] [PATCH v3 0/5] StarFive/VisionFive2: Add VisionFive 2 platform

2023-11-01 Thread Sunil V L
On Tue, Oct 31, 2023 at 06:17:05PM -0700, John Chew wrote: > Hi Sunil, > > Okay, I will update the "Maintainers.txt" file in patch v4. > > By the way, I wonder if you also review this series? > > [PATCH v2 0/5] Designware MMCDXE changes and enhancement > Hi John, Ard and Leif are maintainers f

[edk2-devel] [edk2-platforms PATCH v2 0/1] Marvell package restructure

2023-11-01 Thread Narinder Dhillon
From: Narinder Dhillon Current Silicon/Marvell package structure does not allow sharing of components that are common to different SoC's. This restructure will increase shared code and better seperation. Credit to Leif Lindholm for providing this new structure. v2: - Remove three lines for lib

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-01 Thread Nickle Wang via groups.io
This change looks good to me. Just minor comments: > DEBUG ((DEBUG_INFO, "%a: all required protocols are found on this controller > handle: %p.\n", __func__, ControllerHandle)); Could we use DEBUG_MANAGEABILITY to replace DEBUG_INFO in Redfish driver? This gives us the way to show manageability

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, November 2, 2023 #cal-reminder

2023-11-01 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, November 2, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88

Re: [edk2-devel] [PATCH v3 2/2] BaseTools: GenFw: auto-set nxcompat flag

2023-11-01 Thread Rebecca Cran
I'm still working on this! The last hurdle is fixing PatchCheck.py to allow .rtf files written by Notepad etc. to be committed as-is, without requiring line endings to be fixed, trailing whitespace to be removed etc. Once that's in, I'll merge these two patches. -- Rebecca Cran On 10/17/2

[edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to allow whitespace issues in .rtf files

2023-11-01 Thread Rebecca Cran
Allow .rtf files created by applications such as Notepad to be committed as-is without further manual editing by skipping the requirements for CRLF, no tabs and no trailing whitespace. Signed-off-by: Rebecca Cran --- BaseTools/Scripts/PatchCheck.py | 5 - 1 file changed, 4 insertions(+), 1 d

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Pedro Falcato
On Wed, Nov 1, 2023 at 9:51 PM Michael Brown wrote: > > On 01/11/2023 20:17, Joe L wrote: > > Thanks for the discussion, > > > > Are we saying that DataSynchronizationBarrier () before the return > > from RootBridgeIoPciAccess() is not strong enough to determine that > > the final ECAM write would

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Michael Brown
On 01/11/2023 20:17, Joe L wrote: Thanks for the discussion, Are we saying that DataSynchronizationBarrier () before the return from RootBridgeIoPciAccess() is not strong enough to determine that the final ECAM write would have completed? According to Learn the architecture - ARMv8-A memory s

[edk2-devel] TianoCore Community Meeting Agenda Topics

2023-11-01 Thread Michael D Kinney
Any agenda topics for the meeting this week? If no topics, we will cancel. Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110492): https://edk2.groups.io/g/devel/message/110492 Mute This Topic: https://groups.io/mt/102329310/21656

Re: [edk2-devel] [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

2023-11-01 Thread Andrei Warkentin
Hi Dhaval, Yes, that is what I’m suggesting. But I’m not telling you that your current implementation needs to be adjusted, but I am providing my feedback, that IMHO continued /use and evolution/ of the added PCD may to be messy because it’s untyped. I already gave you a Reviewed-by, so you’re

[edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-01 Thread Igor Kulchytskyy via groups.io
Supported function of the driver changed to wait for all newtwork interface to be installed. Filer out the network interfaces which are not supported by Redfish Host Interface. Cc: Abner Chang Cc: Nickle Wang Cc: Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Joe L
Thanks for the discussion, Are we saying that DataSynchronizationBarrier () before the return from RootBridgeIoPciAccess() is not strong enough to determine that the final ECAM write would have completed? According to Learn the architecture - ARMv8-A memory systems ( https://developer.arm.com/d

Re: [edk2-devel] [PATCH v4 11/14] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

2023-11-01 Thread Taylor Beebe
This patch is the final in this series which needs a review. Can someone take a look? On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote: From: Taylor Beebe The function EnforceMemoryMapAttribute() in the SMM MAT logic will ensure that the CODE and DATA memory types have the desired attri

Re: [edk2-devel] [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

2023-11-01 Thread Dhaval Sharma
Hi Andrei, Are you suggesting: 1. We have a generic PCD to store the address of RVFeatures bitfield. 2. It gets populated at some point during initialization with let's say some kind of global variable address which keeps this bitfield. 3. SEC/DXE phases deref this address and use wher

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Ard Biesheuvel
On Wed, 1 Nov 2023 at 14:24, Michael Brown wrote: > > On 01/11/2023 12:51, Ard Biesheuvel wrote: > > On Wed, 1 Nov 2023 at 13:25, Michael Brown wrote: > >> By my reading, the PCIe specification seems to therefore require > >> something stronger than an ordering guarantee: it requires the ability

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, November 2, 2023 #cal-reminder

2023-11-01 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, November 2, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams |

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, November 2, 2023 #cal-reminder

2023-11-01 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, November 2, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/3] RedfishClientPkg/RedfishFeatureUtilityLib: fix issues and enhancement

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 3/3] > RedfishClientPkg

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/3] RedfishClientPkg/RedfishConfigLangMapDxe: uninitialized variable issue

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/3] > RedfishClientPkg

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/RedfishETagDxe: fix uninitialized variable issue

2023-11-01 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, October 31, 2023 3:45 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/3] RedfishClientPkg/R

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Michael Brown
On 01/11/2023 12:51, Ard Biesheuvel wrote: On Wed, 1 Nov 2023 at 13:25, Michael Brown wrote: By my reading, the PCIe specification seems to therefore require something stronger than an ordering guarantee: it requires the ability for software to make a standalone determination that the write has

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv: Fix syntax issue in markdown manual

2023-11-01 Thread Ashraf Ali S
Reviewed-by: Ashraf Ali S Thanks., S, Ashraf Ali -Original Message- From: Ni, Ray Sent: Wednesday, November 1, 2023 3:00 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Duggapu, Chinni B ; Ng, Ray Han Lim ; Zeng, Star ; Kuo, Ted ; S, Ashraf Ali ; Mohapatra, S

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Ard Biesheuvel
On Wed, 1 Nov 2023 at 13:25, Michael Brown wrote: > > On 01/11/2023 09:56, Ard Biesheuvel wrote: > > On Wed, 1 Nov 2023 at 03:09, Pedro Falcato wrote: > >> On Wed, Nov 1, 2023 at 12:40 AM Joe L wrote: > >>> Our CMN TRM showcases an example where ECAM and MMIO are two different > >>> regions in

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Michael Brown
On 01/11/2023 09:56, Ard Biesheuvel wrote: On Wed, 1 Nov 2023 at 03:09, Pedro Falcato wrote: On Wed, Nov 1, 2023 at 12:40 AM Joe L wrote: Our CMN TRM showcases an example where ECAM and MMIO are two different regions in the HN-I SAM. The implication is that we would expect a DSB between the

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser

2023-11-01 Thread levi.yun
Reviewed-by: levi.yun (yeoreum@arm.com) From: Sami Mujawar Sent: 01 November 2023 10:28 To: devel@edk2.groups.io Cc: Sami Mujawar; Pierre Gondois; Yeo Reum Yun; quic_llind...@quicinc.com; Akanksha Jain; Sibel Allinson; nd Subject: [PATCH v1 1/1] Dynam

Re: [edk2-devel] CodeQL and Apache Licensed Files

2023-11-01 Thread Leif Lindholm
On 2023-10-31 19:49, Pedro Falcato wrote: On Tue, Oct 31, 2023 at 7:43 PM Kinney, Michael D wrote: Hi Pedro, SPDX is only for licenses, not copyrights. IANAL, but several FOSS projects (including Linux) have generally replaced the "Copyright (c) ..." verbiage with SPDX. They may have deci

[edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser

2023-11-01 Thread Sami Mujawar
The patch "f81ee47513e5 DynamicTablesPkg: Add an ET info object parser" updates the Configuration Manager object parser to add support for parsing CM_ARM_ET_INFO object. However, the GicC info structure also has an ET Reference token that points to the CM_ARM_ET_INFO object. Therefore, update the

Re: [edk2-devel] [RFC] Ordering of Arm PCI ECAM and MMIO operations

2023-11-01 Thread Ard Biesheuvel
(cc Ray) On Wed, 1 Nov 2023 at 03:09, Pedro Falcato wrote: > > +CC ARM maintainers > > On Wed, Nov 1, 2023 at 12:40 AM Joe L wrote: > > > > Hello, > > > > During experimentation on an AARCH64 platform with a PCIe endpoint that > > supports option ROM, it was found that the ordering of transacti

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-01 Thread Mike Maslenkin
On Wed, Nov 1, 2023 at 6:24 AM Igor Kulchytskyy wrote: > > Hi Mike, > Thank you for review. > Please see my answers below the text. > > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, October 31, 2023 9:00 PM > To: devel@edk2.groups.io; Igor Kulchytskyy > Cc: Abner Chang ; Nic

[edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv: Fix syntax issue in markdown manual

2023-11-01 Thread Ni, Ray
According to the markdown language syntax, headings should be after number signs (#). The number of number signs correspond to the heading level. But current PatchFvUserManual.md doesn't insert a space between the number signs and the heading title, resulting the markdown file is not rendered well

Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations

2023-11-01 Thread Jingyu Li via groups.io
On Tue, Oct 31, 2023 at 05:55 PM, Dhaval Sharma wrote: > > I am posting an update on behalf of Jingyu as he had trouble with posting. > CC'ing him here: > In summary what we have verified so far: > * I have verified that instructions/op codes are okay. I have also > verified on Qemu that function

[edk2-devel] edk2-platforms: developing Whitley Lake package

2023-11-01 Thread Alireza Banejad
Hello everyone, I am trying to port edk2-platforms for an IceLake-SP board which uses a C621a chipset. digging into the repo I found out that the most compatible board inside WhitelyLakePkg is the WilsonCityRvp (The ReadMe file inside Platform/Intel explicitly says it is IceLake-SP ). I built it bu