Hi Ard, Oliver,
I'm investigating the crash on grub2/shim loader due to the added
EFI_MEMORY_ATTRIBUTE_PROTOCOL when rebasing. I found this interesting
patch and went through on the discussion, I am still not sure the
conclusion on this patch.
This issue impacts many platforms, and any downs
Hi Mike,
I earlier assumed that both the fallthrough were intentional and just made
it evident by writing the comment. It was hence written actually for the
code reader and not the static analyzer. The comment was similar in nature
and style to existing No/1-byte/... data comments. *Incidentally,
On Wed, Oct 04, 2023 at 11:34:26AM -0700, Tuan Phan wrote:
> Introduce a PCD to control the maximum SATP mode that MMU allowed
> to use. This PCD helps RISC-V platform set bare or minimum SATP mode
> during bring up to debug memory map issue.
>
> Signed-off-by: Tuan Phan
> Reviewed-by: Dhaval Sha
[AMD Official Use Only - General]
> -Original Message-
> From: disc...@edk2.groups.io On Behalf Of
> Konstantin Aladyshev via groups.io
> Sent: Thursday, October 5, 2023 1:57 AM
> To: Chang, Abner
> Cc: devel@edk2.groups.io; disc...@edk2.groups.io
> Subject: Re: [edk2-devel] [edk2-discus
Hello Siva,
When looking into the NetworkPkg Ip6ConfigImpl.c and PxeBcDriver.c we are
setting the IAID as you stated below, though Ip6ConfigImpl does check if the
IAID IpSb Instance is already created before it generates its own.
Because the PxeBcDriver creates the Instance and profile first th
Fixes serial output on platforms using coreboot and a non-default
clock rate such as AMD Picasso and newer Zen-based platforms.
Signed-off-by: Matt DeVillier
Change-Id: I91290397852176754e9a34ec6e5829044f41d15a
---
UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c | 5 +
UefiPayload
Extract and use the serial port clock rate provided by coreboot via
the InputHertz field.
Signed-off-by: Matt DeVillier
Change-Id: If764bd7c0b691cf887205471d0343fdf62372141
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/UefiPayloadPkg/U
Add the ClockRate field to the UNIVERSAL_PAYLOAD_SERIAL_PORT_INFO
struct, so that the field can be used by UefiPayloadPkg to properly
set up the serial port on boards using a non-standard clock rate.
Signed-off-by: Matt DeVillier
Change-Id: I9bcaf03ab63f6a45d2cf25a580f7a2eba388cbbd
---
MdeModule
Looks good to me.
Reviewed-by: Andrei Warkentin
From: Tuan Phan
Sent: Wednesday, October 4, 2023 1:44 PM
To: devel@edk2.groups.io; Warkentin, Andrei
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang ;
suni...@ventanamicro.com; g...@danielschaefer.me; ardb+tianoc...@kernel.org
Subject: Re:
I do not prefer special comments for one static analyzer.
Is there an alternative design/implementation of this code
to make it more readable and not trigger any static analysis
false positives?
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ranbir
> Singh
> Sent: T
https://github.com/pttuan/edk2.git
branch: tphan/riscv_mmu_new_pcd
From: devel@edk2.groups.io on behalf of Andrei Warkentin
Date: Wednesday, October 4, 2023 at 11:42 AM
To: Tuan Phan , devel@edk2.groups.io
Cc: Kinney, Michael D , Gao, Liming
, Liu, Zhiguang ,
suni...@ventanamicro.com , g...
Do you happen to have a link to a Github tree?
A
> -Original Message-
> From: Tuan Phan
> Sent: Tuesday, October 3, 2023 4:00 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ;
> suni...@ventanamicro.com; g...@danielschaefer.me; Warkentin, Andrei
> ;
Introduce a PCD to control the maximum SATP mode that MMU allowed
to use. This PCD helps RISC-V platform set bare or minimum SATP mode
during bring up to debug memory map issue.
Signed-off-by: Tuan Phan
Reviewed-by: Dhaval Sharma
---
Changes:
V2
- Changed default mode to SV57
UefiCpuPkg/Libra
> That is great, and I'm surprised there are some build errors at your end.
I'm surprised your compiler didn't catch that since it is all basic
syntax errors.
I've used your
https://github.com/changab/edk2-platforms/tree/MCTP_OVER_KCS_UPDATE
directly.
> How do you think we just send it to the ma
On 10/4/23 1:46 AM, Gerd Hoffmann wrote:
On Fri, Sep 29, 2023 at 12:52:35PM -0700, Taylor Beebe wrote:
I can also update ArmVirtPkg to disable execution protection
for EfiLoaderData by default until fw_cfg parsing
support is added to ArmVirtPkg. Let me know if you think
this is necessary.
Wit
On Wed, Oct 04, 2023 at 16:30:44 +0100, Leif Lindholm wrote:
> On Wed, Oct 04, 2023 at 14:56:55 +, Ard Biesheuvel wrote:
> > On Tue, 3 Oct 2023 at 17:22, Leif Lindholm
> > wrote:
> > >
> > > +Zhiguang
> > >
> > > Tested-by: Leif Lindholm
> > >
> > > MdePkg maintainers - this is currently bre
Hi Chang!
Thanks!
There were a couple of trivial compilation errors, but after I've
fixed them everything seems to work fine!
Just in case I've tested the OpenBMC side with the mctp Linux kernel
driver approach
(https://github.com/Kostr/PLDM/tree/master/mctp-kernel)
The latest kernel patches can b
On Wed, Oct 04, 2023 at 14:56:55 +, Ard Biesheuvel wrote:
> On Tue, 3 Oct 2023 at 17:22, Leif Lindholm wrote:
> >
> > +Zhiguang
> >
> > Tested-by: Leif Lindholm
> >
> > MdePkg maintainers - this is currently breaking several platforms in
> > edk2-platforms.
> >
>
> Acked-by: Ard Biesheuvel
If we agree that default should be 10 then i will change it in the next
version.
On Wed, Oct 4, 2023 at 4:36 AM Sunil V L wrote:
> Hi Tuan,
>
> Thanks for the patch!. Adding UefiCpuPkg maintainers.
>
> On Tue, Oct 03, 2023 at 02:00:21PM -0700, Tuan Phan wrote:
> > Introduce a PCD to control the
On Tue, 3 Oct 2023 at 17:22, Leif Lindholm wrote:
>
> +Zhiguang
>
> Tested-by: Leif Lindholm
>
> MdePkg maintainers - this is currently breaking several platforms in
> edk2-platforms.
>
Acked-by: Ard Biesheuvel
Please just merge this - it is an obvious and trivial bugfix, and it
is affecting m
Anyone have any thoughts on this patch?
Thanks,
Jeff
> -Original Message-
> From: Jeff Brasen
> Sent: Monday, September 11, 2023 2:14 PM
> To: devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; gaolim...@byosoft.com.cn;
> dandan...@intel.com; Ashish Singhal
> Subject: RE: [PATCH] MdeMod
Anything else needed on this to get it merged?
Thanks,
Jeff
> -Original Message-
> From: Ard Biesheuvel
> Sent: Thursday, September 7, 2023 8:17 AM
> To: devel@edk2.groups.io; Jeff Brasen
> Cc: quic_llind...@quicinc.com; ardb+tianoc...@kernel.org;
> rebe...@bsdio.com
> Subject: Re: [edk
Anything else needed on this to get it merged?
Thanks,
Jeff
> -Original Message-
> From: gaoliming
> Sent: Tuesday, September 12, 2023 6:59 AM
> To: Jeff Brasen ; devel@edk2.groups.io
> Cc: jian.j.w...@intel.com; dandan...@intel.com; zhichao@intel.com
> Subject: 回复: [PATCH v2 0/2] dp
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, October 5, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@
On 10/4/23 11:20, Gerd Hoffmann wrote:
> Trying to configure the TLS ciphers can lead to TLS handshake failures
> because TlsCipherMappingTable is not in line with the ciphers actually
> supported by OpensslLib.
>
> Fix that by removing TlsCipherMappingTable altogether. Use
> SSL_get_ciphers() in
[AMD Official Use Only - General]
Hi Aladyshev,
I have updated the change you made and put those code on below link,
https://github.com/changab/edk2-platforms/commit/1c8d0d3fa403b47a34667f7f690add7822163111
I combined MCTP over KCS changes and IPMI over KCS functionality in
KcsCommonLib.c. I als
Hi Tuan,
Thanks for the patch!. Adding UefiCpuPkg maintainers.
On Tue, Oct 03, 2023 at 02:00:21PM -0700, Tuan Phan wrote:
> Introduce a PCD to control the maximum SATP mode that MMU allowed
> to use. This PCD helps RISC-V platform set bare or minimum SATA mode
SATA -> SATP
> during bring up to
Thanks. I'll submit a v2 with that change.
From: Kinney, Michael D
Sent: Tuesday, October 3, 2023 12:00 PM
To: Name j...@nvidia.com ; devel@edk2.groups.io
Cc: Gao, Liming ; Liu, Zhiguang
; Jake Garver ; Kinney, Michael D
Subject: RE: [PATCH] BaseStackCheckLib
Trying to configure the TLS ciphers can lead to TLS handshake failures
because TlsCipherMappingTable is not in line with the ciphers actually
supported by OpensslLib.
Fix that by removing TlsCipherMappingTable altogether. Use
SSL_get_ciphers() instead to get the stack of ciphers supported by
open
Hi,
> > + CHAR8 *CipherString;
> > + CHAR8 *CipherStringPosition;
> > +
> > + STACK_OF (SSL_CIPHER) *OpensslCipherStack;
>
> Surprisingly, this does pass uncrustify. :) OK.
Wasn't my idea, uncrustify actually formatted it that way for me ;)
> > -Mapping = T
On Fri, Sep 29, 2023 at 12:52:35PM -0700, Taylor Beebe wrote:
> Sorry for the slow reply :)
>
>
> Additional profiles which fit general use cases can be added to
> SetMemoryProtectionsLib, but because this is a profile for grub
> compatibility I'd say it's better suited for platform code making
>
31 matches
Mail list logo
