Re: [edk2-devel][PATCH v1 1/1] ArmPkg: CpuDxe: Sync GCD Capabilities With Page Table Attributes

2023-07-07 Thread Oliver Smith-Denny
On 6/7/2023 11:03 AM, Oliver Smith-Denny wrote: On 6/7/2023 10:31 AM, Ard Biesheuvel wrote: On Wed, 7 Jun 2023 at 18:10, Oliver Smith-Denny wrote: Per the discussion in the memory protections design meeting this morning, I am kicking this patch back to the top of the inbox for review. If folk

[edk2-devel] [PATCH 0/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

2023-07-07 Thread Michael Büchler
Hi, this is my first message to this list and the first time I am using git send-email. Please let me know if I messed something up. For example, I have to use `git am --keep-cr` to apply the patch myself. Regards, Michael Michael Büchler (1): UefiPayloadPkg: Match BAR if framebuffer is at an

[edk2-devel] [PATCH 1/1] UefiPayloadPkg: Match BAR if framebuffer is at an offset

2023-07-07 Thread Michael Büchler
When the framebuffer region (starting address and address range) from the GraphicsInfo HOB is fully enclosed within a BAR region, but does not start on the same address as the BAR, it does not get matched to that BAR. The driver fails to bind to the graphics device and no graphics output is possibl

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: UsbBusDxe: Rebuild Descriptor Table

2023-07-07 Thread brit.chesley via groups.io
From: Britton Chesley Fixed a bug which led to an ASSERT due to the USB device context being maintained after a port reset, but the underlying XHCI context was uninitialized. Specifically, Xhc->UsbDevContext is freed after a reset and only re-allocates the default [0] enpoint transfer ring. Added

Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] Platform/SbsaQemu: use XHCI to replace EHCI

2023-07-07 Thread Marcin Juszkiewicz
W dniu 7.07.2023 o 12:20, Yuquan Wang pisze: This patchset implements XHCI on sbsa-ref board to replace EHCI. As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI that only has 32-bit DMA capablity. Now this board has XHCI as an available usb controller with 64-bit DMA capablity. Hist

Re: [edk2-devel] [PATCH v3 1/1] UnitTestFrameworkPkg: UnitTestPersistenceLib: Save Unit Test Cache Option

2023-07-07 Thread Kun Qin
Hi Mike, It has been a week since the last movement on this. Could you please provide feedback on this patch when you have a chance? Any input is appreciated. Regards, Kun On 6/30/2023 4:00 PM, Michael Kubacki wrote: Reviewed-by: Michael Kubacki I haven't seen Mike Kinney acknowledge the cha

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread Yao, Jiewen
I think a better way is to define a new library instance in other package with the new ARM APIs. The old one can be kept as is. That will limit the impact to existing platform. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday, July 7, 2023 10:2

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread Yao, Jiewen
Thanks Pierre. Yes, I agree to move it to other package to resolve dependency issue. > -Original Message- > From: Pierre Gondois > Sent: Friday, July 7, 2023 10:25 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Wang, > Jian J ; Ard Bi

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread PierreGondois
Hello Jiewen, We have the following dependency issue: - the BaseRngTimerLib is in the MdePkg - we need a GUID to describe the BaseRngTimerLib algorithm - we cannot add the gEdkiiRngAlgorithmUnSafe in the MdePkg, and the gZeroGuid is also not in the MdePkg - the MdePkg should not have dependencie

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread Yao, Jiewen
FYI: I filed https://bugzilla.tianocore.org/show_bug.cgi?id=4497 to track the gEdkiiMemoryAcceptProtocolGuid issue. Thank you Yao, Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday, July 7, 2023 8:57 PM > To: Pierre Gondois ; devel@edk2.gr

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread Yao, Jiewen
I don’t think MdePkg should have Edkii- style protocol. I am not sure why gEdkiiMemoryAcceptProtocolGuid is in MdePkg. It should be in MdeModulePkg, IMHO. Thank you Yao, Jiewen > -Original Message- > From: Pierre Gondois > Sent: Friday, July 7, 2023 8:49 PM > To: devel@edk2.groups.io; Y

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread PierreGondois
Hello Jiewen, The gEfiRngAlgorithmArmRndr GUID is to be added to the UEFI spec with: - https://bugzilla.tianocore.org/show_bug.cgi?id=4441 - https://mantis.uefi.org/mantis/view.php?id=2386 the gEdkiiMemoryAcceptProtocolGuid GUID should not be in the UEFI spec, so I used the 'gEdkii' prefix as al

Re: [edk2-devel] [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename RedfishResourceIdentifyLibComuterSystem

2023-07-07 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Merged. Thanks! Abner > -Original Message- > From: Mike Maslenkin > Sent: Friday, July 7, 2023 5:07 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; nick...@nvidia.com; ig...@ami.com > Subject: Re: [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: re

Re: [edk2-devel] [PATCH 0/4] Sync BSP's APIC mode to APs in MP init flow

2023-07-07 Thread Gerd Hoffmann
On Fri, Jul 07, 2023 at 09:25:39AM +, Ni, Ray wrote: > Gerd, > No. I don't plan to add PCD. > I thought that initially but in the end I figured out: > * PCD is a way to let platform configure the common logic behavior. > * Why not treat "X2 APIC status in BSP" as a "hardware" PCD? A PCD has th

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg: RngDxe: Fixing mAvailableAlgoArray allocator

2023-07-07 Thread Kun Qin
Hi Sami, Jiewen & Jian, Just a gentle ping on this. Could you please provide further feedback on this patch and/or merge the patch? Thanks in advance! Regards, Kun On 7/3/2023 1:09 PM, Kun Qin via groups.io wrote: Hi Sami, Would you prefer to have input from Jiewen or Jian to review this

[edk2-devel] [PATCH edk2-platforms v2 1/3] Platform/Qemu/SbsaQemu/SbsaQemu.dsc: define XHCI Pcd settings

2023-07-07 Thread Yuquan Wang
Define the pcd settings for identifying the base address of XHCI and XHCI's mmio size, and remove relevant EHCI settings. Signed-off-by: Yuquan Wang --- Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 ++-- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)

[edk2-devel] [PATCH edk2-platforms v2 3/3] SbsaQemu: AcpiTables: Add XHCI info into DSDT

2023-07-07 Thread Yuquan Wang
As sbsa-ref board uses xhci to replace ehci, the DSDT is updated to match the platform xhci controller. This also removes previous ehci structure. Signed-off-by: Yuquan Wang --- .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 +- Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 125 ++

[edk2-devel] [PATCH edk2-platforms v2 2/3] SbsaQemu: Drivers: Add initial support for XHCI

2023-07-07 Thread Yuquan Wang
This registers the non-discoverable XHCI for sbsa-ref. Signed-off-by: Yuquan Wang --- .../SbsaQemuPlatformDxe.inf | 2 + .../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 41 +++ 2 files changed, 34 insertions(+), 9 deletions(-) diff --git a/Silicon/Qemu/SbsaQe

[edk2-devel] [PATCH edk2-platforms v2 0/3] Platform/SbsaQemu: use XHCI to replace EHCI

2023-07-07 Thread Yuquan Wang
This patchset implements XHCI on sbsa-ref board to replace EHCI. As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI that only has 32-bit DMA capablity. Now this board has XHCI as an available usb controller with 64-bit DMA capablity. History: v1 -> v2: - rebased on master as v1 did

Re: [edk2-devel] [PATCH 0/4] Sync BSP's APIC mode to APs in MP init flow

2023-07-07 Thread Ni, Ray
Gerd, No. I don't plan to add PCD. I thought that initially but in the end I figured out: * PCD is a way to let platform configure the common logic behavior. * Why not treat "X2 APIC status in BSP" as a "hardware" PCD? With above thoughts, I prefer (a). Platform can choose whether to define a "pla

Re: [edk2-devel] [PATCH v3 3/6] MdePkg/Rng: Add GUIDs to describe Rng algorithms

2023-07-07 Thread Yao, Jiewen
MdePkg can only add UEFI defined API. Is below defined by UEFI? Thank you Yao, Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Thursday, July 6, 2023 4:52 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguan

Re: [edk2-devel] [RFC][PATCH][edk2-redfish-client] RedfishClientPkg: rename RedfishResourceIdentifyLibComuterSystem

2023-07-07 Thread Mike Maslenkin
Pull request is ready: https://github.com/tianocore/edk2-redfish-client/pull/44 Regards, Mike. On Wed, Jul 5, 2023 at 5:46 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Abner Chang > > Thanks for catching this, all good except the [RFC] tag in the subject. 😊 > A

Re: [edk2-devel] [PATCH 0/4] Sync BSP's APIC mode to APs in MP init flow

2023-07-07 Thread Gerd Hoffmann
On Fri, Jul 07, 2023 at 01:28:57PM +0800, Ni, Ray wrote: [ empty cover letter ] Summary of the patch series changes would be nice. If I read things correctly this series will: (a) allow platforms use x2apic mode by simply switching the BSP into x2apic mode early enough (for example in P

Re: [edk2-devel] [PATCH v3 0/6] SecurityPkg/MdePkg: Update RngLib GUID identification

2023-07-07 Thread Sami Mujawar
Dear MdePkg & SecurityPkg maintainers, This series and Kun's patch at https://edk2.groups.io/g/devel/message/106547 are both required to fix the RNG implementation for Arm. Is it possible to provide feedback for this series and Kun's patch, please? I plan to merge this series and Kun's patch

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg: RngDxe: Fixing mAvailableAlgoArray allocator

2023-07-07 Thread Sami Mujawar
For some reason the reply to this thread were not linked. Please see the discussion at https://edk2.groups.io/g/devel/message/106720 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106721): https://edk2.groups.io/g

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg: RngDxe: Fixing mAvailableAlgoArray allocator

2023-07-07 Thread Sami Mujawar
Hi Kun, This patch and Pierre's series at https://edk2.groups.io/g/devel/message/106711 are both required to fix the RNG implementation for Arm. I will wait for the MdePkg and SecurityPkg maintainers for any feedback by end of next week. If there are no futher comments, I will merge both th

Re: [edk2-devel] [PATCH v3 5/6] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-07-07 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 06/07/2023 09:51 am, pierre.gond...@arm.com wrote: From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151 The EFI_RNG_PROTOCOL can rely on the Rng