Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Ard Biesheuvel
On Tue, 23 May 2023 at 02:44, Kinney, Michael D wrote: > > I have set push label. It is merged now. > > During hard freeze, the release owner and stewards are the only once that can > set the label. > Yeah that seems fair. Thanks. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messa

Re: [edk2-devel] [PATCH 3/3] CloudHv:arm: add kernel load driver into dsc/fdf

2023-05-22 Thread Jianyong Wu
Hello Sami, Any comments about the memory layout below? Thanks Jianyong From: Jianyong Wu Sent: 2023年4月24日 10:37 To: devel@edk2.groups.io; Jianyong Wu ; Sami Mujawar Cc: ardb+tianoc...@kernel.org; Justin He ; nd Subject: RE: [edk2-devel] [PATCH 3/3] CloudHv:arm: add kernel load driver into d

Re: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Let's talk to Liming to see if we have chance to make this included in 202305 as the review process of this patch set looks to me close to finish. Thanks Abner > -Original Message- > From: Ni, Ray > Sent: Tuesday, May 23, 2023 2:30 PM > To: Chang, Abne

Re: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-22 Thread Ni, Ray
Abner, Sure. I will review the new patch set. But I am afraid this patch set cannot be included in 202305 stable release because the edk2 repo has been locked for quite a while for 202305 release and is about to unlocked. Thanks, Ray > -Original Message- > From: Chang, Abner > Sent: Tu

Re: [edk2-devel] [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib

2023-05-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi @Ray Ni, We are almost there... We need your help to review this patch set as we need this library to be part of 202305 stable release. Thanks Abner > -Original Message- > From: Abdul Lateef Attar > Sent: Friday, May 12, 2023 8:32 PM > To: devel@e

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 23, 2023 #cal-cancelled

2023-05-22 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20230407T050750Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 23, 2023 #cal-reminder

2023-05-22 Thread gaoliming via groups.io
Few new issues are submitted. I will cancel this week meeting. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2023年5月23日 9:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 23, 2023 #cal-reminder Reminder: TianoC

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Ni, Ray
Revision: 8bd2028f9ac391144c67eaf6eb08c3f727c32498 Author: Kuo, Ted Date: 12/16/2022 8:46:27 PM Message: MdeModulePkg: Supporting S3 in 64bit PEI https://bugzilla.tianocore.org/show_bug.cgi?id=4195 Transfer from DXE to OS waking vector by calling SwitchStack() when both are in the same execution

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Laszlo Ersek
On 5/23/23 06:49, Gerd Hoffmann wrote: > On Mon, May 22, 2023 at 11:20:16PM +, Ni, Ray wrote: >> Gerd, >> The S3 path has been 64bit ready. >> Can you check if OVMF pei64 image can do s3? >> >> At least internally in some real platform we tested s3 flow with 64bit PEI. > > Tested on OVMF, pass

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Laszlo Ersek
On 5/22/23 14:06, Gerd Hoffmann wrote: >> So my questions are: >> - do we need to retain mixed IA32 / X64 support, and if so, why? (I >> think it is related to SMM emulation but I need someone to confirm >> this) > > Yes, it's SMM related. S3 suspend in SMM-enabled builds requires > 32bit PEI. >

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Ni, Ray
> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, May 23, 2023 1:31 PM > To: Ard Biesheuvel ; edk2-devel-groups-io > ; Ni, Ray ; Yao, Jiewen > ; Gerd Hoffmann ; Taylor Beebe > ; Oliver Smith-Denny > Subject: Re: managing memory attributes in PEI > > On 5/22/23 13:31, Ard Biesh

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Laszlo Ersek
On 5/22/23 13:31, Ard Biesheuvel wrote: > Hello all, > > (OVMF specific questions below - please keep reading) > > As a follow-up to the discussion we had last week regarding DXE core, > I'd like to raise the issue of managing memory permissions in PEI, > including the mapping attributes of the c

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Gerd Hoffmann
On Mon, May 22, 2023 at 11:20:16PM +, Ni, Ray wrote: > Gerd, > The S3 path has been 64bit ready. > Can you check if OVMF pei64 image can do s3? > > At least internally in some real platform we tested s3 flow with 64bit PEI. Tested on OVMF, passed too. Which are the commits implementing this?

[edk2-devel] [PATCH v1] StandaloneMmPkg: Add StandaloneMmIplPei driver.

2023-05-22 Thread Zhang, Hongbin1
Add StandaloneMmIplPei IA32/X64 driver at PEI stage. FSP will use this driver to load Standalone MM code to dispatch other Standalone MM drivers. Signed-off-by: Hongbin1 Zhang Cc: Jiewen Yao Cc: Ray Ni Cc: Star Zeng Cc: Jiaxin Wu Cc: Sami Mujawar Cc: Ard Biesheuvel Cc: Supreeth Venkatesh -

[edk2-devel] GoogleTest Compatibility with MdePkg's IndustyStandard header files

2023-05-22 Thread Aaron Pop via groups.io
Google Test, and CPP, has more keywords C uses. Tpm12.h and Tpm20.h have references to struct names that are `operator` and `xor`, both of which trigger build errors because they conflict with CPP's keywords. Operator triggered a build error in MSVC. Xor only triggered a build error under GCC

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, May 23, 2023 #cal-reminder

2023-05-22 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, May 23, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4

Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Michael D Kinney
I have set push label. It is merged now. During hard freeze, the release owner and stewards are the only once that can set the label. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Monday, May 22, 2023 9:19 AM > To: Kinney, Michael D > Cc

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, May 22, 2023 #cal-notice

2023-05-22 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, May 22, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890535 ) *Description:* TianoCore communit

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Ni, Ray
Gerd, The S3 path has been 64bit ready. Can you check if OVMF pei64 image can do s3? At least internally in some real platform we tested s3 flow with 64bit PEI. Thanks, Ray thanks, ray From: Gerd Hoffmann Sent: Monday, May 22, 2023 8:06:46 PM To: Ard Biesheuvel

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, May 22, 2023 #cal-reminder

2023-05-22 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, May 22, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1890535 ) *Description:* TianoCor

Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Ard Biesheuvel
PR here: https://github.com/tianocore/edk2/pull/4418 I cannot set the 'push' label myself, it seems. On Mon, 22 May 2023 at 16:10, Kinney, Michael D wrote: > > Acked-by: Michael D Kinney > > No objection to merging for the stable tag. > > Mike > > > -Original Message- > > From: devel@

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3

2023-05-22 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Tan, Ming > Sent: Sunday, May 21, 2023 11:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Duggapu, Chinni B > > Subject: [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3 > > REF: https://bugzill

Re: 回复: [edk2-devel] [PATCH] MdePkg Include: Fix typos

2023-05-22 Thread Michael Kubacki
In audit mode, it will not cause a build failure whether for new or existing code. It simply puts the results in the build log. Note that "audit mode" is enabled on a per-package basis and some edk2 packages have it disabled such as DynamicTablesPkg, FatPkg, FmpDevicePkg, PcAtChipsetPkg, PrmPk

[edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

2023-05-22 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew --- ShellPkg/Library/Ue

[edk2-devel] [PATCH V3 2/3] ShellPkg: acpiview: Add routine to print 16 chars

2023-05-22 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.

[edk2-devel] [PATCH V3 1/3] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-05-22 Thread Rohit Mathew
From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryStandard/Acpi65.h | 7 +- MdePkg/Include/IndustryStandard/Mpam.h | 260 2 files changed, 266 insertions

[edk2-devel] [PATCH V3 0/3] MPAM ACPI definitions and parser

2023-05-22 Thread Rohit Mathew
This series adds the following - definitions corresponding to MPAM ACPI 2.0 specification. - MPAM parser An MPAM ACPI table formulated using the newly added MPAM ACPI definitions were validated on the linux kernel tree at [1]. The same table was parsed via acpiview using the newly added parser

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-05-22 Thread Gerd Hoffmann
Hi, > > Recent clang does have a '-fdirect-access-external-data' switch which > > should suppress these references, maybe in combination with > > -fvisibility=hidden? > > I'll try that. Works (test patch below for reference). thanks, Gerd diff --git a/BaseTools/Conf/tools_def.template b/B

Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Michael D Kinney
Acked-by: Michael D Kinney No objection to merging for the stable tag. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif > Lindholm > Sent: Monday, May 22, 2023 3:56 AM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Oliver S

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-05-22 Thread Gerd Hoffmann
On Mon, May 22, 2023 at 02:55:43PM +0200, Ard Biesheuvel wrote: > On Mon, 22 May 2023 at 14:28, Gerd Hoffmann wrote: > > > > Hi, > > > > So, after a way to long time gap, I finally found the time to look at > > this again. This time tried both gcc and clang. > > > > Just dropping the visibility

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg/PlatformInitLib: dynamic mmio window size

2023-05-22 Thread Fiona Ebner
Am 22.05.23 um 13:12 schrieb Gerd Hoffmann:> The patch below fixes it for me. Can you confirm this? Yes, it fixes the issue for me too :) Best Regards, Fiona -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105125): https://edk2.groups.

Re: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-22 Thread Sami Mujawar
Hi Rohit, Please send an updated series with the issues fixed. Regards, Sami Mujawar From: Rohit Mathew Date: Monday, 22 May 2023 at 14:08 To: Sami Mujawar , "devel@edk2.groups.io" Cc: Michael D Kinney , Liming Gao , Thomas Abraham , James Morse , nd Subject: RE: [PATCH V2 1/3] MdePkg/Ind

Re: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-22 Thread Rohit Mathew
Hi Sami, Thank you for the review. Please find my comments inline. Regards, Rohit From: Sami Mujawar Sent: Monday, May 22, 2023 1:17 PM To: Rohit Mathew ; devel@edk2.groups.io Cc: Michael D Kinney ; Liming Gao ; Thomas Abraham ; James Morse ; nd Subject: Re: [PATCH V2 1/3] MdePkg/IndustryStan

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-05-22 Thread Ard Biesheuvel
On Mon, 22 May 2023 at 14:28, Gerd Hoffmann wrote: > > Hi, > > So, after a way to long time gap, I finally found the time to look at > this again. This time tried both gcc and clang. > > Just dropping the visibility hidden #pragma works fine for gcc. It also > works with clang for DEBUG and RE

Re: [edk2-devel] [PATCH v4 01/10] BaseTools: add BASETOOLS define

2023-05-22 Thread Gerd Hoffmann
Hi, So, after a way to long time gap, I finally found the time to look at this again. This time tried both gcc and clang. Just dropping the visibility hidden #pragma works fine for gcc. It also works with clang for DEBUG and RELEASE builds, but not for NOOPT builds. > > Automatically detecti

Re: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-22 Thread Sami Mujawar
Hi Rohit, Just to be clear, I am looking at the following spec https://documentation-service.arm.com/static/638757e5e1ed1c2162fc75b2?token= Regards, Sami Mujawar On 22/05/2023 01:16 pm, Sami Mujawar wrote: Hi Rohit, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On

Re: [edk2-devel] [PATCH V2 1/3] MdePkg/IndustryStandard: add definitions for MPAM ACPI specification

2023-05-22 Thread Sami Mujawar
Hi Rohit, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 18/05/2023 04:06 pm, Rohit Mathew wrote: From: Rohit Mathew add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew --- MdePkg/Include/IndustryS

Re: [edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Gerd Hoffmann
> So my questions are: > - do we need to retain mixed IA32 / X64 support, and if so, why? (I > think it is related to SMM emulation but I need someone to confirm > this) Yes, it's SMM related. S3 suspend in SMM-enabled builds requires 32bit PEI. Intel seems to be working on removing the IA32 dep

[edk2-devel] [PATCH v2 1/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

2023-05-22 Thread Guo, Gua
From: Gua Guo RTC runtime is unable to get dynamic PCD value after booting to OS using runtime services. Resolution: Cache the dynamic PCD value in RTC driver entry point Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Gua Guo --- .../PcatRealTimeClockRuntimeDxe/PcRtc.c | 38 ++

[edk2-devel] [PATCH v2 0/1] PcAtChipsetPkg: RTC Runtime unable to get correct IO port by PCD

2023-05-22 Thread Guo, Gua
From: Gua Guo PR: https://github.com/tianocore/edk2/pull/4416 V2: Add more dynamic PCD for runtime service support instead of taking for FixedAtBuild case V1: After https://bugzilla.tianocore.org/show_bug.cgi?id=4193 RTC Runtime Services unable to get correct RTC time. Solution: Cache RTC data

[edk2-devel] managing memory attributes in PEI

2023-05-22 Thread Ard Biesheuvel
Hello all, (OVMF specific questions below - please keep reading) As a follow-up to the discussion we had last week regarding DXE core, I'd like to raise the issue of managing memory permissions in PEI, including the mapping attributes of the code and data regions of DXE core itself. This is abou

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3

2023-05-22 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali -Original Message- From: devel@edk2.groups.io On Behalf Of Tan, Ming Sent: Monday, May 22, 2023 11:43 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Duggapu, Chinni B Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Fix ASSERT when FSP-S/M use FFS3 REF: h

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: check PcdUse1GPageTable

2023-05-22 Thread Gerd Hoffmann
On Mon, May 22, 2023 at 12:37:51PM +0200, Ard Biesheuvel wrote: > On Wed, 17 May 2023 at 12:24, Gerd Hoffmann wrote: > > > > If PcdUse1GPageTable is not enabled restrict the physical address space > > used to 1TB, to limit the amount of memory needed for identity mapping > > page tables. > > > > T

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg/PlatformInitLib: dynamic mmio window size

2023-05-22 Thread Gerd Hoffmann
> The errors for the virtio devices are: > > virtio_scsi virtio1: virtio: device uses modern interface but does not > > have VIRTIO_F_VERSION_1 > > virtio_scsi: probe of virtio1 failed with error -22 > > virtio_net virtio2: virtio: device uses modern interface but does not have > > VIRTIO_F

Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Leif Lindholm
On Sat, May 20, 2023 at 11:19:58 +0200, Ard Biesheuvel wrote: > The helper that updates live page table entries writes a zero entry, > invalidates the covered address range from the TLBs, and finally writes > the actual entry. This ensures that no TLB conflicts can occur. > > Writing the final ent

Re: [edk2-devel] [PATCH 1/3] OvmfPkg/PlatformInitLib: check PcdUse1GPageTable

2023-05-22 Thread Ard Biesheuvel
On Wed, 17 May 2023 at 12:24, Gerd Hoffmann wrote: > > If PcdUse1GPageTable is not enabled restrict the physical address space > used to 1TB, to limit the amount of memory needed for identity mapping > page tables. > > The same already happens in case the processor has no support for > gigabyte pa

Re: [edk2-devel] [PATCH 0/3] OvmfPkg: gigabyte page tweaks

2023-05-22 Thread Gerd Hoffmann
On Thu, May 18, 2023 at 12:16:21AM +0100, Pedro Falcato wrote: > On Wed, May 17, 2023 at 11:24 AM Gerd Hoffmann wrote: > The Intel SDM and AMD manuals both mention possible bad side effects > for having large pages (2MB/4MB/1GB) spanning multiple MTRRs. qemu takes care to use gigabyte-alignment

[edk2-devel] [PATCH v2 2/2] AMD/AmdMinBoardkPkg: Implements PeiReportFvLib Library

2023-05-22 Thread Abdul Lateef Attar via groups.io
Customize PeiReportFvLib library for AMD platforms by adding below changes. Installs Advanced Security FV. Adds facility to install FV above 4GB address space. Cc: Abner Chang Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 8 + .../AMD/AmdMinBoardPk

[edk2-devel] [PATCH v2 1/2] AMD/AmdMinBoardPkg: Implements PCI hotplug init protocol

2023-05-22 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Implements PCI hotplug init protocol. Adds resources padding based on PCD values. Cc: Abner Chang Signed-off-by: Abdul Lateef Attar --- .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 16 + .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 14 +- .../PciHotPlug/PciHo

[edk2-devel] [PATCH v2 0/2] AMD/AmdMinBoardPkg: ReportFvLib library and

2023-05-22 Thread Abdul Lateef Attar via groups.io
Implements ReportFvLibLirary. Implements PciHotPlugInit protocol. Cc: Abner Chang Abdul Lateef Attar (2): AMD/AmdMinBoardPkg: Implements PCI hotplug init protocol AMD/AmdMinBoardkPkg: Implements PeiReportFvLib Library .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dec | 24 ++ .../AMD/AmdMinBo

Re: [edk2-devel] [PATCH edk2-stable202305] ArmPkg/ArmMmuLib: Add missing ISB after page table update

2023-05-22 Thread Ard Biesheuvel
Any objections to this? If not, I will push it later today. Thanks. On Sat, 20 May 2023 at 11:20, Ard Biesheuvel wrote: > > The helper that updates live page table entries writes a zero entry, > invalidates the covered address range from the TLBs, and finally writes > the actual entry. This ens

Re: [edk2-devel] [edk2-platforms][PATCH 2/3] AmpereAltraPkg: Fix PCIe link training sequence

2023-05-22 Thread Tinh Nguyen via groups.io
Reviewed-by: Tinh Nguyen @Leif, @Ard, Please help us to merge this series Thanks, - Tinh On 11/05/2023 14:51, Minh Nguyen wrote: Currently, the implementation starts link training and put device out-of-reset right away. This make LinkStat and BlockEventStat registers indicate that link is n

Re: [edk2-devel] [edk2-platforms][PATCH 1/3] AmpereAltraPkg: Remove PCIe "DevMapModeAuto" case in retrieving Devmap mode

2023-05-22 Thread Tinh Nguyen via groups.io
Reviewed-by: Tinh Nguyen On 11/05/2023 14:51, Minh Nguyen wrote: Because PCIe Auto bifurcation feature doesn't depend on the default Devmap mode so that "DevMapModeAuto" is unnecessary in retrieving the PCIe Devmap default mode. Signed-off-by: Minh Nguyen --- Silicon/Ampere/AmpereAltraPkg/D