BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements SmmSmramSaveStateLib library interfaces
to read and write save state
registers for Intel processor family.
Moves Intel and AMD common functionality to common area.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eri
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Uses new SmmSmramSaveStateLib library.
Removes old code.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Signed-o
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds initial defination for AMD's SmmCpuFeaturesLib
library implementation.
All function's body either empty or just returns
value. Its initial skeleton of library implementation.
Cc: Paul Grimes
Cc: Garrett Kirke
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements SmmSmramSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Latee
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Garrett Kirkendall
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Garrett Kirkendall
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul
PR: https://github.com/tianocore/edk2/pull/4251
V7 delta changes:
Adds SmmSmramSaveStateLib for Intel processor.
Integrate SmmSmramSaveStateLib library.
V6 delta changes:
Addressed review comments for Ray NI.
removed unnecessary EFIAPI.
V5 delta changes:
rebase to master branch.
Reviewed-by: Gua Guo
-Original Message-
From: Rebecca Cran
Sent: Friday, April 7, 2023 6:23 AM
To: devel@edk2.groups.io; Gao, Liming ; Kinney,
Michael D ; Jiang, Guomin ;
Xu, Wei6 ; Dong, Guo ; Ni, Ray
; Rhodes, Sean ; Lu, James
; Guo, Gua ; Andrew Fish
; Wu, Hao A ; Maciej Rabeda
Reviewed-by: Nickle Wang
Regards,
Nickle
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Liming Gao ; Michael
> D Kinney ; Guomin Jiang
> ; Wei6 Xu ; Guo Dong
> ; Ray Ni ; Sean Rhodes
> ; James Lu ; Gua Guo
> ; Andrew Fish ; Ha
Thanks Sunil, I have in fact missed your email.
Will apply your feedback, retest and resend.
A
> -Original Message-
> From: Sunil V L
> Sent: Thursday, April 6, 2023 12:00 AM
> To: Warkentin, Andrei
> Cc: devel@edk2.groups.io; Daniel Schaefer ;
> Kinney, Michael D ; Gao, Liming
> ; Liu
Reviewed-by: Ray Ni
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Gao, Liming ;
> Kinney, Michael D ; Jiang, Guomin
> ; Xu, Wei6 ; Dong, Guo
> ; Ni, Ray ; Rhodes, Sean
> ; Lu, James ; Guo, Gua
> ; Andrew Fish ; Wu, Hao A
> ; M
Reviewed-by: Ray Ni
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Gao, Liming ;
> Kinney, Michael D ; Jiang, Guomin
> ; Xu, Wei6 ; Dong, Guo
> ; Ni, Ray ; Rhodes, Sean
> ; Lu, James ; Guo, Gua
> ; Andrew Fish ; Wu, Hao A
> ; M
Reviewed-by: Ray Ni
> -Original Message-
> From: Rebecca Cran
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Gao, Liming ;
> Kinney, Michael D ; Jiang, Guomin
> ; Xu, Wei6 ; Dong, Guo
> ; Ni, Ray ; Rhodes, Sean
> ; Lu, James ; Guo, Gua
> ; Andrew Fish ; Wu, Hao A
> ; M
> -Original Message-
> From: Lin, MillerX
> Sent: Monday, March 13, 2023 10:30 AM
> To: devel@edk2.groups.io
> Cc: Lin, MillerX ; Ni, Ray ; Gao,
> Zhichao
> Subject: [PATCH] ShellPkg: Update smbiosview type 0/4/17/41 with SMBIOS
> 3.5 fields
>
> Cc: Signed-off-by: MillerX Lin
> Cc: R
*Reminder: TianoCore Community Meeting - APAC/NAMO*
*When:*
Thursday, April 6, 2023
7:30pm to 8:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e3
On Friday, April 7, 2023 4:29 AM, Tom Lendacky wrote:
> On 4/5/23 20:42, Xu, Min M wrote:
> > On April 3, 2023 7:21 PM, Gerd Hoffmann wrote:
> I agree that the efi variable store is not secure without smm. But
> after 58eb8517ad7b be introduced, the -D SECURE_BOOT_ENABLE
> doesn't
>
New code should use the C99 macro __func__ instead of the pre-Standard
macro __FUNCTION__. Update PatchCheck.py to reject patches with the
latter.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 4
1 file changed, 4 insertions(+)
diff --git a/BaseTools/Scripts/PatchCheck.
To help people format patches with the correct options, add an alias
named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
--stat-graph-width=20'.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/SetupGit.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/Scripts
On Wed, Mar 15, 2023 at 04:57:43PM -0500, Michael Roth wrote:
> (Rebased series and resending due to merge conflict with previous
> submission.)
Ping.
>
> Here are a number of fixes related to OVMF handling of the SEV-SNP
> Confidential Computing blob and CPUID table.
>
> Patch #1 is a fix for
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
FmpDevicePkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to com
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
UefiPayloadPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to c
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
EmulatorPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to comp
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
SourceLevelDebugPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
NetworkPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compi
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
CryptoPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compil
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
StandaloneMmPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
PrmPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compile.
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
UnitTestFrameworkPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fai
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
ArmPlatformPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to c
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
RedfishPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compi
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
EmbeddedPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to comp
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
SecurityPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to comp
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
MdeModulePkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to com
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
UefiCpuPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compi
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
ArmVirtPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compi
__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.
Since it's more standard, replace __FUNCTION__ with __func__ throughout
ArmPkg.
Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compile.
Following on from commit b17a3a133b18fb41493fba7d86e9b5804ea6a8cf which
updated MdePkg to be more C11 compliant by replacing the pre-standard
__FUNCTION__ with __func__ which was introduced in C99, this patch
series updates the remaining packages in edk2.
The changes were generated by using "Repla
Looks good - thanks.
There are a few style issues:
First, this patch came through as quoted-printable, with some lines
wrapped. I'd be interested to learn how other people are dealing with
this, since I've not seen complaints since Lazslo left the project.
Are people saving the _formatted_
On 4/5/23 20:42, Xu, Min M wrote:
On April 3, 2023 7:21 PM, Gerd Hoffmann wrote:
I agree that the efi variable store is not secure without smm. But
after 58eb8517ad7b be introduced, the -D SECURE_BOOT_ENABLE doesn't
work with SEV. System just hangs in "NvVarStore FV headers were invalid."
Hi, J
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Rebecca Cran
> Sent: Thursday, April 6, 2023 9:43 AM
> To: devel@edk2.groups.io; Leif Lindholm ; Ard
> Biesheuvel ; Demeter,
> Miki ; Kinney, Michael D
> Cc: Rebecca Cran
> Subject: [PATCH tianocore-docs edk2-InfSpecificatio
Since we no longer use GitBook to publish our documentation, delete the
section with the text "Published with GitBook" that links to
gitbook.com in _layouts/website/summary.html.
Contributed-Under: TianoCore Contribution Agreement 1.1
Signed-off-by: Rebecca Cran
---
_layouts/website/summary.html
Thanks for the nice feedback Pedro, Gerd and Andrei! Yeah it seems like a
valid concern here as Mik mentioned on edk2-libc, and it seems to fits edk2
long term interest on this.
Can we file this as an issue in Bugzilla for tracking or something? Since
this will take some time to work on this as it
Hi Leif,
I am not sure. The current contributors agreement has support for code and
documentation.
The specific sections on documents are:
*
https://github.com/tianocore-docs/edk2-BuildSpecification/blob/db69f5661caec977fac9730e21e5a1132f6ff80b/CONTRIBUTIONS.txt#L29
*
https://github.com/tiano
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Thursday, April 6, 2023 6:46 AM
> To: devel@edk2.groups.io; Leif Lindholm ; Ard
> Biesheuvel ; Demeter,
> Miki ; Kinney, Michael D
> Cc: Rebecca Cran
> Subject: [edk2-dev
On 4/6/23 3:47 AM, Leif Lindholm wrote:
On Thu, Apr 06, 2023 at 10:42:34 +0100, Leif Lindholm wrote:
On Wed, Apr 05, 2023 at 19:06:18 -0600, Rebecca Cran wrote:
We no longer use Gitbook for publishing the documentation.
Update the section to direct users to use the mailing list to
send feedbac
Hello liming
Same error, I used another computer to build with python 2.7 seems ok
But failed build in the server, any possible reason?
Active Platform =
/home/luming/01_work/01_project/8295/rse/sa8295p-hqx-4-5-5-1_amss_standard_oem.git/boot/boot_images/boot/QcomPkg/SocPkg/Makena/AU/Core.
*TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, April 6, 2023
8:00am to 9:00am
(UTC-07:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join
on the
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
> Sent: Thursday, April 6, 2023 1:14 AM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang
> Subject: [edk2-devel] [PATCH V2 0/5] Delete UefiCpuLib usage
>
> Delete UefiCpuLib usage b
*Reminder: TianoCore Community Meeting EMEA/NAMO*
*When:*
Thursday, April 6, 2023
8:00am to 9:00am
(UTC-07:00) America/Los Angeles
*Where:*
Microsoft Teams meeting Join on your computer or mobile app Click here to join
the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Joi
*TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, April 6, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@arm.com?subj
Add links to the following draft documents:
o EDK II Module Writer's Guide
o EDK II Secure Coding Guide
o EDK II Secure Code Review Guide
o EDK II Python Development Process and Coding Standard Specification
o EDK II Minimum Platform Specification
o Understanding the Trusted Boot Chain Implementat
*Reminder: TianoCore edk2-test Bug Triage Meeting*
*When:*
Thursday, April 6, 2023
10:00pm to 11:00pm
(UTC+08:00) Asia/Shanghai
*Where:*
https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon
*Organizer:* Edhaya Chandran edhaya.chand...@arm.com (
edhaya.chand...@ar
On Thu, Apr 06, 2023 at 03:00:38AM +, Yao, Jiewen wrote:
> Thanks Leif. Your understanding is right.
> The openssl fork will be used by edk2-staging repo only.
> The openssl fork will NOT be by edk2 repo.
Ok, fine with me then.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
On Thu, Apr 06, 2023 at 10:42:34 +0100, Leif Lindholm wrote:
> On Wed, Apr 05, 2023 at 19:06:18 -0600, Rebecca Cran wrote:
> > We no longer use Gitbook for publishing the documentation.
> > Update the section to direct users to use the mailing list to
> > send feedback, and since we use GitHub Flav
On Wed, Apr 05, 2023 at 19:06:18 -0600, Rebecca Cran wrote:
> We no longer use Gitbook for publishing the documentation.
> Update the section to direct users to use the mailing list to
> send feedback, and since we use GitHub Flavored Markdown, remove the
> link to Gitbook.
>
> Contributed-under:
W dniu 4.04.2023 o 20:29, Michael D Kinney pisze:
Add GCC and leave GCC5 for now and give time for all downstream
consumers to accommodate the name change.
At a later date, remove GCC5.
In meantime you may also have message "GCC5 is deprecated, please switch
to GCC" + few seconds delay.
We
This introduces the EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL_REVISION2,
which adds a new UpdateBootOrder() function to support customizing
the boot options order according to the platform-specific policy.
Signed-off-by: Tinh Nguyen
---
Changes since v1: Correct the format of the email.
MdeModulePk
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
Cc: Zailiang Sun
Cc: Yi Qian
Cc: Nate DeSimone
Reviewed-by: Michael D Kinney
Signed-off-by: Zhiguang Liu
---
Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 +--
Platform/Intel/Vlv2TbltDevicePkg/Platfo
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
Cc: Michael D Kinney
Cc: Kelly Steele
Cc: Nate DeSimone
Reviewed-by: Michael D Kinney
Signed-off-by: Zhiguang Liu
---
Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 +--
1 file changed, 1 insertion(+), 2 deletio
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
Cc: Michael D Kinney
Cc: Kelly Steele
Cc: Nate DeSimone
Reviewed-by: Michael D Kinney
Signed-off-by: Zhiguang Liu
---
Platform/Intel/QuarkPlatformPkg/Quark.dsc| 3 +--
Platform/Intel/QuarkPlatformPkg/QuarkM
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Reviewed-by: Chasel Chiu
Reviewed-by: Michael D Kinney
Signed-off-by: Zhiguang Liu
---
Platform/Intel/MinPlatformPkg/Include/Dsc/
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
Currently, UefiCpuLib is a dummy library to avoid build issue, after
this patch set, UefiCpuLib can be completely removed from Edk2.
V2: only change the patch NO.1 to let SecMain link CpuLib
Zhiguang Liu (5):
Simi
Delete UefiCpuLib usage because UefiCpuPkg/UefiCpuLib is merged
to MdePkg/CpuLib.
V2:
Let SecMain file use CpuLib
Cc: Nate DeSimone
Signed-off-by: Zhiguang Liu
---
Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 4 ++--
Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 4 ++--
2
Hi Rebecca,
Thanks for your information, I will update it in v2
Thanks,
Tinh
On 4/6/2023 6:05 AM, Rebecca Cran wrote:
Tinh,
You appear to be sending emails in quoted-printable format, while we
prefer them in 8bit encoding: quoted-printable causes issues such as
equals signs being replaced
On Thu, 6 Apr 2023 at 04:49, Rebecca Cran wrote:
>
> Okay, I'll do that.
>
> Do I need to do the same with the CLANG35 and CLANG38 toolchains,
> marking them deprecated before removing them?
>
>From the ARM side (as the person having introduced them in the past),
I have no problems with just drop
67 matches
Mail list logo
