Reviewed-by: Ray Ni <[email protected]> > -----Original Message----- > From: Rebecca Cran <[email protected]> > Sent: Friday, April 7, 2023 6:23 AM > To: [email protected]; Gao, Liming <[email protected]>; > Kinney, Michael D <[email protected]>; Jiang, Guomin > <[email protected]>; Xu, Wei6 <[email protected]>; Dong, Guo > <[email protected]>; Ni, Ray <[email protected]>; Rhodes, Sean > <[email protected]>; Lu, James <[email protected]>; Guo, Gua > <[email protected]>; Andrew Fish <[email protected]>; Wu, Hao A > <[email protected]>; Maciej Rabeda <[email protected]>; > Siyuan Fu <[email protected]>; Yao, Jiewen <[email protected]>; > Wang, Jian J <[email protected]>; Lu, Xiaoyu1 <[email protected]>; > Ard Biesheuvel <[email protected]>; Sami Mujawar > <[email protected]>; Supreeth Venkatesh > <[email protected]>; Michael Kubacki > <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Sean Brogan > <[email protected]> > Cc: Rebecca Cran <[email protected]>; Leif Lindholm > <[email protected]>; Abner Chang <[email protected]>; > Nickle Wang <[email protected]>; Igor Kulchytskyy <[email protected]>; > Daniel Schaefer <[email protected]>; Xu, Min M > <[email protected]>; Justen, Jordan L <[email protected]>; Gerd > Hoffmann <[email protected]>; Peter Grehan <[email protected]>; > Aktas, Erdem <[email protected]>; James Bottomley > <[email protected]>; Tom Lendacky <[email protected]>; > Michael Roth <[email protected]>; Sunil V L > <[email protected]>; Warkentin, Andrei > <[email protected]> > Subject: [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 > compliant by using __func__ > > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. > > Since it's more standard, replace __FUNCTION__ with __func__ throughout > SourceLevelDebugPkg. > > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : > > #define __func__ __FUNCTION__ > > Signed-off-by: Rebecca Cran <[email protected]> > --- > > SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu > nicationLibUsb3Dxe.c | 4 ++-- > > SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu > nicationLibUsb3Pei.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > index 4490526273c9..d37fb991f1f2 100644 > --- > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > +++ > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > @@ -186,7 +186,7 @@ Usb3DxeSmmReadyToLockNotify ( > { > USB3_DEBUG_PORT_HANDLE *Instance; > > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); > > Instance = GetUsb3DebugPortInstance (); > ASSERT (Instance != NULL); > @@ -290,7 +290,7 @@ Usb3PciIoNotify ( > // > // Found the PciIo for USB3 debug port. > // > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); > if (Usb3GetIoMmu () != NULL) { > Instance = GetUsb3DebugPortInstance (); > ASSERT (Instance != NULL); > diff --git > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > index 15842a317ef0..aa04442918d2 100644 > --- > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > +++ > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > @@ -35,7 +35,7 @@ Usb3IoMmuPpiNotify ( > { > USB3_DEBUG_PORT_HANDLE *Instance; > > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); > > Instance = GetUsb3DebugPortInstance (); > ASSERT (Instance != NULL); > -- > 2.34.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102660): https://edk2.groups.io/g/devel/message/102660 Mute This Topic: https://groups.io/mt/98115253/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
