Timothy:
Thanks for your report. This is a real issue in Brotli decompress library.
Which tool chain has been verified? GCC5 or VS2019 or Both?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Lin, Kuei-Hung
(Timothy) via groups.io
发送时间: 2023年1月13日 6:18
收件人: He, Jiangang ; Chang, Abner
; Kinney,
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Chao Li
> 发送时间: 2023年1月17日 21:00
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题: [edk2-devel] [PATCH v1 0/2] Add ACPI 6.5 header
>
> ACPI specification 6.5 has been released in August
>
> > +UINT32 mBspApicId = 0;
>
> This should be moved to a separate patch with commit message explaining
> the reasons for the change. My guess would be this is required to allow
> processors running SmmInitHandler in parallel.
>
Yes, it's part of work to combine 2 SMIs (gcSmmInitTemp
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Robert Phelps
> 发送时间: 2023年1月13日 4:07
> 收件人: devel@edk2.groups.io
> 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com
> 主题: [PATCH v2 0/2] Added AfterReadyToBoot Event
>
> In the UEFI Specification version 2.9 a ne
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Name
> 发送时间: 2023年1月26日 2:41
> 收件人: devel@edk2.groups.io; sami.muja...@arm.com;
> alexei.fedo...@arm.com; pierre.gond...@arm.com;
> michael.d.kin...@intel.com; gaolim...@byosoft.com.cn;
> zhiguang@intel.com
> 抄送: Swatisri Kantamsetti
> 主题: [PA
>
> * Why do you want do it in PEI instead? The cover letter claims this
>improves boot performance. I don't buy that. You are not skipping
>the relocation process, you are just doing it somewhere else.
I clarified why it can improves boot performance, it's not just do somewhere
else
Acked-by: Liming Gao
> -邮件原件-
> 发件人: Rohit Mathew
> 发送时间: 2023年1月25日 8:39
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Sami Mujawar
> ; Liming Gao ;
> Zhiguang Liu ; Thomas Abraham
> ; Swatisri Kantamsetti
> 主题: [edk2][PATCH V1 1/1] MdePkg/IndustryStandard: add definitions for
>
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2023年1月28日 1:20
> 收件人: devel@edk2.groups.io; michael.d.kin...@intel.com
> 抄送: rebe...@bsdio.com; Gao, Liming ; Feng,
> Bob C ; Leif Lindholm ;
> Chen, Christine ; Marvin Häuser
>
> 主题: Re: [edk2-dev
Thanks Gerd raise this open -- how to support more processors due to hob size
limitation.
Looks multiple hobs is the only way since we have to store each cpu's info?
Sorry, allow me ask a stupid question: why DataLength in hob defined as UINT16
causing the hob size limitation? Any design backg
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Dionna Amalie Glaze
> 发送时间: 2023年1月28日 8:02
> 收件人: Xu, Min M
> 抄送: devel@edk2.groups.io; Yao, Jiewen ; Kinney,
> Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Wang,
> Jian J
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Correct memory type in
> PreP
>
> For the smbase case it might also be possible to store the base
> address and the per-cpu entry size, then use
>
> smbase = base + size * cpuindex
>
> to calculate the per-cpu base address. Puts some restrictions on the
> memory allocation (must be one big block), not sure this is pos
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: Ard Biesheuvel
> 发送时间: 2023年1月27日 22:00
> 收件人: pierre.gond...@arm.com
> 抄送: devel@edk2.groups.io; Bob Feng ; Liming Gao
> ; Yuwei Chen ; Leif
> Lindholm ; Sami Mujawar
> ; Laszlo Ersek
> 主题: Re: [PATCH 1/1] tools_def: Remove duplicated -Os
>
> On
With this change, does GenFv pass build on Linux environment?
> -邮件原件-
> 发件人: tlaro...@polynum.com
> 发送时间: 2023年1月26日 18:03
> 收件人: devel@edk2.groups.io
> 抄送: Bob Feng ; Liming Gao
> ; Yuwei Chen
> 主题: [PATCH 1/1] BaseTools: remove useless header inclusion
>
> GenFvInternalLib.c: useless
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
> 发送时间: 2023年1月27日 22:00
> 收件人: pierre.gond...@arm.com
> 抄送: devel@edk2.groups.io; Bob Feng ; Liming Gao
> ; Yuwei Chen ; Leif
> Lindholm ; Sami Mujawar
> ; Laszlo Ersek
> 主题: Re: [edk2-devel] [PATCH 1/1] t
Main Changes :
1.Null-checking first before a pointer is dereferenced.
Wenyi Xie (1):
NetworkPkg/Ip4Dxe:Null-checking before dereference
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--
2.20.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Grou
Null-checking first before a pointer is dereferenced.
Cc: Maciej Rabeda
Cc: Siyuan Fu
Signed-off-by: Wenyi Xie
---
NetworkPkg/Ip4Dxe/Ip4Config2Nv.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/NetworkPkg/Ip4Dxe/Ip4Config2Nv.c b/NetworkPkg/Ip4Dxe/Ip4Confi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add infrastructure files to build edk2 for RISC-V qemu virt machine.
- It follows PEI less design.
- EDK2 for qemu virt is booted in S-mode as a payload for M-mode FW
- Leveraged from ArmVirtQemu
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jor
Add PciCpuIo2Dxe driver to implement EFI_CPU_IO2_PROTOCOL
to add the translation for IO access. This is copied from
ArmPciCpuIo2Dxe driver.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfPkg/RiscVVirt/PciCpuIo2Dxe
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RiscVVirt is created to support EDK2 for RISC-V qemu
virt machine platform. Add maintainer entries.
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Signed-off-by: Sunil V L
---
Maintainers.txt | 4
1 file changed, 4 inserti
Add the SEC module for RISC-V Qemu virt machine support.
It uses the PEI less design.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfPkg/RiscVVirt/Sec/SecMain.inf | 66 +
OvmfPkg/RiscVVirt/Sec/SecMain.h | 1
Qemu NOR flash driver needs this library. Add this
library for RISC-V leveraged from SbsaQemu.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.inf
RISC-V Qemu virt uses SBI calls to implement the reset.
Add the base class library.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfPkg/RiscVVirt/Library/ResetSystemLib/BaseResetSystemLib.inf | 38 ++
OvmfPkg/
Add the PrePiHobListPointerLib required for RISC-V Qemu Virt machine
since it follows PEIless design.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfPkg/RiscVVirt/Library/PrePiHobListPointerLib/PrePiHobListPointer
RISC-V Qemu Virt platfform needs the PlatformBootManagerLib similar
to the one in ArmVirtPlatform. Add the library in OvmfPkg/RiscVVirt
leveraging the one from Arm.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
OvmfP
This PCD is required to be enabled so that PrePiLib
can be used in RISC-V.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Abner Chang
Cc: Daniel Schaefer
Signed-off-by: Sunil V L
---
EmbeddedPkg/EmbeddedPkg.dec | 3 +++
1 file changed, 3 insertions(+)
diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/Em
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
PlatformHasAcpiDtDxe is required by other architectures also.
Hence, it is moved to OvmfPkg. So, update the consumers of this
module with the new location.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-o
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This module is required by other architectures like RISC-V.
Hence, move this to OvmfPkg.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
---
ArmVirtPkg/ArmVirtPkg.dec
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RISC-V register names do not follow the EDK2 formatting.
So, add it to ignore list for now.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/UefiCpuPkg.ci.yaml |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is mostly copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVTimerLib
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This is copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuPkg/UefiCpuPkg.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add Cpu Exception Handler library for RISC-V. This is copied
from edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVExceptionLib
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Gerd Hoffmann
Sign
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This DXE module initializes the timer interrupt handler
and installs the Arch Timer protocol.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
UefiCpuP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL.
Add this protocol GUID definition and the header file required.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Daniel Schaefer
Cc: Gerd Hoffmann
Signed-off-by: Sunil V
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
This library is required to make SBI ecalls from the S-mode EDK2.
This is mostly copied from
edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVEdk2SbiLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Sunil V L
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add support for RISC-V qemu virt machine. Most of the changes are migrated from
edk2-platforms repo and added qemu specific libraries under OvmfPkg.
The series has passed CI tests (https://github.com/tianocore/edk2/pull/3962)
The series
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Few of the basic helper functions required for any
RISC-V CPU were added in edk2-platforms. To support
qemu virt, they need to be added in BaseLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Daniel Schaefer
Signed-off-by:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076
Add register definitions and access routines for RISC-V. These
headers are leveraged from opensbi repo.
Cc: Daniel Schaefer
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Sunil V L
Acked-by: Abner Chang
---
MdePk
Hi Ray
Would it be possible to merge this?
Thanks
Sean
On Fri, 16 Dec 2022, 09:03 Ni, Ray, wrote:
> Reviewed-by: Ray Ni
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Sean
> Rhodes
> > Sent: Friday, December 16, 2022 4:58 PM
> > To: devel@edk2.groups.io
> > C
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
This patch enables Tdx measurement in OvmfPkgX64 with below changes:
1) TDX_MEASUREMENT_ENABLE is introduced in OvmfPkgX64.dsc. This flag
indicates if Intel TDX measurement is enabled in OvmfPkgX64. Its
default value is
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperBuildGuidHobForTdxMeasurement is called in PlatformPei to build
GuidHob for Tdx measurement.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Cc: Michael Roth
Acked-by: Ger
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdHob and Configuration FV (Cfv) are external inputs from VMM. From the
security perspective, they should be measured before they're consumed.
This patch measures TdHob and Cfv and stores the measurement values in
WorkArea.
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
PeiTdxHelperLib is the PEI instance of TdxH
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
After TdHob and Configuration FV (Cfv) are measured in SecMain, the
same measurements in PeilessStartupLib should be deleted.
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Tom Lendacky
Cc: Mic
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdHob and Configuration FV (Cfv) are external inputs from VMM. From the
security perspective, they should be measured before they're consumed.
This patch measures TdHob and Cfv and stores the measurement values in
WorkArea.
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
ProcessHobList once was implemented in PlatformInitLib and it walks thru
TdHob list and accept un-accepted memories.
This patch moves the codes to SecTdxHelperLib and rename ProcessHobList
as TdxHelperProcessTdHob
After Tdx
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
MeasureFvImage once was implemented in PeilessStartupLib and it does
measurement and logging for Configuration FV (Cfv) image in one go,
using TpmMeasureAndLogData(). But it doesn't work in SEC.
This patch splits MeasureFvIm
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
MeasureHobList once was implemented in PeilessStartupLib and it does
measurement and logging for TdHob in one go, using TpmMeasureAndLogData().
But it doesn't work in SEC.
This patch splits MeasureHobList into 2 functions an
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
FV_HANDOFF_TABLE_POINTERS2 once was defined in IntelTdx.c. Its structure
is same as PLATFORM_FIRMWARE_BLOB2_STRUCT which is defined in
Library/TcgEventLogRecordLib.h. So this patch reuse the define of
PLATFORM_FIRMWARE_BLOB2_
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
SecTdxHelperLib is the SEC instance of TdxH
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
TdxHelperLib provides below helper functions for a td-guest.
- TdxHelperProcessTdHob
- TdxHelperMeasureTdHob
- TdxHelperMeasureCfvImage
- TdxHelperBuildGuidHobForTdxMeasurement
TdxHelperLibNull is the NULL instance of Td
From: Min M Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
>From the perspective of security any external input should be measured
and extended to some registers (TPM PCRs or TDX RTMR registers).
There are below 2 external input in a Td guest:
- TdHob
- Configuration FV (CFV)
TdH
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
Tdx measurement (RTMR based measurement) is enabled in OvmfPkg/IntelTdx.
This patch-set enables the feature in OvmfPkgX64 as well.
Patch #1:
Introduce TDX_MEASUREMETNS_DATA in SEC_TDX_WORK_AREA. That is because
the RTMR measurement of Td
On January 27, 2023 3:54 PM, Gerd Hoffmann wrote:
> On Fri, Jan 27, 2023 at 08:11:00AM +0800, Min Xu wrote:
> > From: Min M Xu
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243
> >
> > 2 new functions are added in PeilessStartupLib/IntelTdx.c.
> > - BuildTdxMeasurementGuidHob
> > -
53 matches
Mail list logo
