Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] I hit the same issue when verifying USB ECM driver and temporarily change the MNP_SYS_POLL_INTERVAL to 5 sec to make system boots to EFI shell. ECM has USB interrupt endpoint however not sure if it triggers when the packet sent from another end. If it does, the

Re: [edk2-devel] [PATCH v2 09/12] ShellPkg: Fix conditionally uninitialized variables

2022-11-29 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Wednesday, November 30, 2022 1:33 AM > To: devel@edk2.groups.io > Cc: Erich McMillan ; Kinney, Michael D > ; Michael Kubacki > ; Ni, Ray ; Gao, Zhichao > > Subject: [PATCH v2 09/1

[edk2-devel] [PATCH] IntelSiliconPkg/VTd: Use 256-bit invaildation queue descriptor

2022-11-29 Thread Sheng Wei
256-bit invaildation queue descriptor could be used for both abort DMA mode and legacy mode. Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../VTd/IntelVTdDmarPei/IntelVTdDmar.c| 188 - .../VTd/IntelVTdDmarPei/IntelV

[edk2-devel] [PATCH v3] UefiCpuPkg: Check SMM Delayed/Blocked AP Count

2022-11-29 Thread Wu, Jiaxin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173 Due to more core count increasement, it's hard to reflect all APs state via AP bitvector support in the register. Actually, SMM CPU driver doesn't need to check each AP state to know all CPUs in SMI or not, one alternative method is to check

Re: [edk2-devel] [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not

2022-11-29 Thread Wu, Jiaxin
Thanks Ray. I added the comments in patch v2 (https://edk2.groups.io/g/devel/message/96722) to clarify the expected value of "SmmRegSmmEnable" & "SmmRegSmmDelayed" & "SmmRegSmmBlocked" returned from SmmCpuFeaturesLib. That can answer the questions. Due to more core count increasement, it's hard

[edk2-devel] [PATCH v2] UefiCpuPkg: Check SMM Delayed/Blocked AP Count

2022-11-29 Thread Wu, Jiaxin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173 Due to more core count increasement, it's hard to reflect all APs state via AP bitvector support in the register. Actually, SMM CPU driver doesn't need to check each AP state to know all CPUs in SMI or not, one alternative method is to check

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 29, 2022 #cal-reminder

2022-11-29 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, November 29, 2022 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] [PATCH] UefiCpuPkg: Bug fix in 5LPage handling

2022-11-29 Thread Wu, Jiaxin
Glad to see this fix, could you add/include the existing Bugzilla in the comment? REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4168 Thanks, Jiaxin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, November 16, 2022 8:57 AM > To: devel@ed

Re: [edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs

2022-11-29 Thread Sean
Oliver, Thanks for this changeset and i think this is getting closer but over the past few months there have been a few changes that I don't think this series takes into account. A few comments i hope we can address quickly (since 18.04 is going offline tomorrow). 1. Can the whole block at

Re: [edk2-devel] [PATCH 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

2022-11-29 Thread Kun Qin
Thanks for the update, Rebecca. I will also keep an eye on the cache issue when I have a chance to run this on FVP models. Regards, Kun On 11/28/2022 4:04 PM, Rebecca Cran wrote: On 11/28/22 15:59, Kun Qin wrote: Hi Rebecca/Ard, I was trying to reach out regarding the original patches earlie

Re: [edk2-devel] 1024 VCPU limitation

2022-11-29 Thread Paweł Poławski
Hi all I did fast experiment already and it looks like this Itanium data structure removal solves my issue. Later this week I should have access to machine with 200 physical CPU so I will be able to run test against 1600 vCPU using Qemu. To reproduce test 3 things are needed: 1) Change in th

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Rebecca Cran
On 11/29/22 13:51, Andrew Fish via groups.io wrote: On Nov 29, 2022, at 11:47 AM, Rebecca Cran wrote: On 11/29/22 12:43, Andrew Fish via groups.io wrote: On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One problem

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
> On Nov 29, 2022, at 11:47 AM, Rebecca Cran wrote: > > On 11/29/22 12:43, Andrew Fish via groups.io wrote: >>> On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: >>> >>> I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. >>> One problem I've run into is that since we

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/MetronomeDxe: Update TickPeriod doc to remove mention of lower bound

2022-11-29 Thread Leif Lindholm
On Tue, Nov 29, 2022 at 05:40:56 -0700, Rebecca Cran wrote: > There was previously a lower bound on the value of TickPeriod such that > it couldn't be less than 10 us. However, that was removed from the PI > Specification in the 1.0 errata released in 2007. From the revision > history: > > "M171 R

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Rebecca Cran
On 11/29/22 12:43, Andrew Fish via groups.io wrote: On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One problem I've run into is that since we poll for bulk requests, most of the time they will timeout - and curren

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
> On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: > > I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One > problem I've run into is that since we poll for bulk requests, most of the > time they will timeout - and currently both EHCI and XHCI drivers log errors >

[edk2-devel] [PATCH v7 5/6] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-11-29 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 --

[edk2-devel] [PATCH v7 6/6] CI: use latest vm_image (Linux only)

2022-11-29 Thread Oliver Steffen
Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI/

[edk2-devel] [PATCH v7 4/6] CI: Use Fedora 35 container (Linux only)

2022-11-29 Thread Oliver Steffen
Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v7 3/6] CI: Allow running in a container.

2022-11-29 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file changed, 4 i

[edk2-devel] [PATCH v7 2/6] CI: add ~/.local/bin to PATH (Linux only)

2022-11-29 Thread Oliver Steffen
Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-bui

[edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs

2022-11-29 Thread Oliver Steffen
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom containers. This decouples the CI environment from the virtual machine images that Azure DevOps provides. The currently used ubuntu-18.04 image has been deprecated for a while now and will finally be removed on Dec 1st 2022. The con

[edk2-devel] [PATCH v7 1/6] CI: make Python version configurable

2022-11-29 Thread Oliver Steffen
Add a new parameter "usePythonVersion" to the CI job templates. This makes it possible to specify the version of Python to use. The default value is ">=3.10.6". If '' is specified, Python will not be downloaded at runtime and the one provided by the VM/container image will be used. Signed-off-by:

[edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Rebecca Cran
I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. One problem I've run into is that since we poll for bulk requests, most of the time they will timeout - and currently both EHCI and XHCI drivers log errors when that happens, which results in log spam and makes interactin

Re: [edk2-devel] [PATCH v1 1/1] .github/ISSUE_TEMPLATE/config.yml: Add initial issue template

2022-11-29 Thread Sean
Reviewed-by: Sean Brogan On 11/15/2022 5:47 PM, Michael Kubacki wrote: From: Michael Kubacki Adds a GitHub issue template to direct contributors familiar with GitHub's issue tracker to the external resources used by TianoCore. Cc: Sean Brogan Cc: Michael D Kinney Signed-off-by: Michael Kub

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: migration of edk2module from chipsec repo

2022-11-29 Thread Jayaprakash, N
Sure Mike. Thanks for your inputs and recommendations. Regards, JP -Original Message- From: Kinney, Michael D Sent: 29 November 2022 23:28 To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, Michael D Cc: Rebecca Cran ; Kadapathri, Ajay ; Frinzell, Aaron Subject: RE: [edk2-libc Patc

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: migration of edk2module from chipsec repo

2022-11-29 Thread Michael D Kinney
I recommend leaving it in Chipsec project until the port to MdePkg libs can be completed. Mike > -Original Message- > From: Jayaprakash, N > Sent: Tuesday, November 29, 2022 8:22 AM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Rebecca Cran ; Kadapathri, Ajay > ; Frinzell, Aaron

[edk2-devel] [PATCH v2 03/12] BaseTools/VfrCompile: Fix potential buffer overwrites

2022-11-29 Thread Michael Kubacki
From: Michael Kubacki While more portable methods exist to handle these cases, this change does not attempt to do more than fix the immediate problem and follow the conventions already established in this code. `snprintf()` is introduced as the minimum improvement apart from making the buffers l

[edk2-devel] [PATCH v2 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list

2022-11-29 Thread Michael Kubacki
From: Michael Kubacki Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ pasted into BaseTools/Source/C/VfrCompile/Pccts/. The code contains tab characters instead of spaces. PatchCheck.py gives an error on modifications to files that contain tabs. This change adds that dire

Re: [edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

2022-11-29 Thread Michael Kubacki
Updated patch with antlr4 release info in commit message here: https://edk2.groups.io/g/devel/message/96686 Thanks, Michael On 11/29/2022 11:37 AM, Michael Kubacki wrote: Sure. Dependabot was added to find these old dependencies and keep the project on more current releases in the future. Bob

[edk2-devel] [PATCH v3 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

2022-11-29 Thread Michael Kubacki
From: Michael Kubacki Bumps [antlr4-python3-runtime](http://www.antlr.org) from 4.7.1 to 4.11.1. Original automated dependabot PR: https://github.com/tianocore/edk2/pull/3672 For reference: antlr4 release history: https://github.com/antlr/antlr4/releases For reference: antlr4 4.7.1 to 4.11.1

Re: [edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

2022-11-29 Thread Michael Kubacki
Sure. Dependabot was added to find these old dependencies and keep the project on more current releases in the future. Bob and Christine, I filed the following BZ to track your feedback: https://bugzilla.tianocore.org/show_bug.cgi?id=4174 If you approve the changes, please go ahead and send you

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: migration of edk2module from chipsec repo

2022-11-29 Thread Jayaprakash, N
Hi Mike, Thanks Mike for your feedback. I completely agree with your suggestions. Having said that, the code in PR is an existing well tested code from Chipsec git repo and it was probably written quite a few years ago. This is probably the reason that it is not following the edk2 conventions

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: migration of edk2module from chipsec repo

2022-11-29 Thread Michael D Kinney
Hi JP, Many of these APIs are already available from the MdePkg BaseLib, IoLib, and PciLib. Why would we add custom ASM implementations of there here? Why ASM and not NASM. edk2 projects have consolidated on NASM for all IA32/X64 assembly code. I think the best approach is to port the Python

Re: [edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

2022-11-29 Thread Michael D Kinney
Hi Michael, Dependabot did not pick up the change list between those two versions. I think this is a link to the release notes that contains the change list from 4.7.1.to 4.11.1. https://github.com/antlr/antlr4/releases This update pulls in 5 years of changes. That is a large leap. I reco

[edk2-devel] [PATCH v2 1/1] pip: bump antlr4-python3-runtime from 4.7.1 to 4.11.1

2022-11-29 Thread Michael Kubacki
From: Michael Kubacki Bumps [antlr4-python3-runtime](http://www.antlr.org) from 4.7.1 to 4.11.1. Original automated dependabot PR: https://github.com/tianocore/edk2/pull/3672 Cc: Sean Brogan Cc: Michael D Kinney Cc: Liming Gao Co-authored-by: dependabot[bot] Signed-off-by: Michael Kubacki

[edk2-devel] [PATCH edk2-platforms 3/3] Platform/ARM/JunoPkg: Set PcdArmArchTimerFreqInHz to 0 to read from CNTFRQ_EL0

2022-11-29 Thread Rebecca Cran
If PcdArmArchTimerFreqInHz is zero, the value of the timer frequency will be read from CNTFRQ_EL0. Avoid hard-coding the value in ArmJuno.dsc and instead let the ArmArchTimerLib driver read it from the SoC. Signed-off-by: Rebecca Cran --- Platform/ARM/JunoPkg/ArmJuno.dsc | 3 ++- 1 file changed,

[edk2-devel] [PATCH edk2-platforms 2/3] Platform/ARM/JunoPkg: Override PcdTimerPeriod to be 10000

2022-11-29 Thread Rebecca Cran
The PCD PcdTimerPeriod is used in TimerDxe to calculate how many ticks to wait between timer interrupts. The default value of 10 results in waiting 10 ms, while the driver wants interrupts to occur every 1ms. Override the value of PcdTimerPeriod in ArmJuno.dsc to be 1. Signed-off-by: Rebe

[edk2-devel] [PATCH edk2-platforms 0/3] Platform/ARM/JunoPkg: Timer fixes

2022-11-29 Thread Rebecca Cran
The use of the EmbeddedPkg/MetronomeDxe driver on Juno can cause problems with drivers that use gBS->Stall, since it takes 10x longer than requested. For example requesting a timeout of 1 ms when doing a USB bulk transfer results in it taking 100 ms. Switching to the MdeModulePkg/Universal/Metrono

[edk2-devel] [PATCH edk2-platforms 1/3] Platform/ARM/JunoPkg: Switch to MdeModulePkg/Universal/Metronome driver

2022-11-29 Thread Rebecca Cran
The MetronomeDxe driver uses the PCD PcdMetronomeTickPeriod to calculate how many ticks to wait in MicroSecondDelay. Given that the timer clock on Juno runs at 50 MHz, it ticks every 20 ns; therefore, a setting of 1000 is wrong: for example it causes a call to gBS->Stall (1) to take 10 us. The dri

[edk2-devel] [PATCH 1/1] EmbeddedPkg/MetronomeDxe: Update TickPeriod doc to remove mention of lower bound

2022-11-29 Thread Rebecca Cran
There was previously a lower bound on the value of TickPeriod such that it couldn't be less than 10 us. However, that was removed from the PI Specification in the 1.0 errata released in 2007. From the revision history: "M171 Remove 10 us lower bound restriction for the TickPeriod in the Metronome"

[edk2-devel] [PATCH 1/1] MdePkg: Fix typo of EFI_INVALID_PARAMETER in Protocol/UsbIo.h

2022-11-29 Thread Rebecca Cran
Fix typo of EFI_INVALID_PARAMETER in Protocol/UsbIo.h by adding a missing 'R'. Signed-off-by: Rebecca Cran --- MdePkg/Include/Protocol/UsbIo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Protocol/UsbIo.h b/MdePkg/Include/Protocol/UsbIo.h index 4816b9039

[edk2-devel] [PATCH 1/1] MdePkg: Fix typos and spacing in Library/PerformanceLib.h

2022-11-29 Thread Rebecca Cran
- Fix typos of "disable". - Fix typos of "performance". - Fix missing spaces. - Use comma instead of period when the sentence continues on the next line. - Fix typo of "PERF_CORE_LOAD_IMAGE". Signed-off-by: Rebecca Cran --- MdePkg/Include/Library/PerformanceLib.h | 62 ++-- 1 f

回复: [edk2-devel] [PATCH 1/1] BaseSynchronizationLib: Fix RISC-V helper name

2022-11-29 Thread gaoliming via groups.io
Create PR https://github.com/tianocore/edk2/pull/3676 for this patch. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming via > groups.io > 发送时间: 2022年11月29日 13:45 > 收件人: devel@edk2.groups.io; suni...@ventanamicro.com > 抄送: 'Abner Chang' ; 'Zhihao Li' > ; 'Michael D Kinney' ; > 'Zhiguang L

Re: [edk2-devel] [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not

2022-11-29 Thread Ni, Ray
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173 > > The blocked register might return the counter instead of bitvector. This > request > is to update the code to handle the case by checking SMM Delayed/Blocked > AP Count > to decide all CPUs in SMI or not. The code change actually assu

[edk2-devel] [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not

2022-11-29 Thread Wu, Jiaxin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173 The blocked register might return the counter instead of bitvector. This request is to update the code to handle the case by checking SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not. Cc: Eric Dong Cc: Ray Ni Signed-off-by:

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Check for memory below 4G

2022-11-29 Thread G Edhaya Chandran
Hi Dimitrije, For some cases, the above solution may not scale for a system that is capable of allocating 64 bit addresses (> 4 GiB). This may prevent the test from running the full coverage on 64 bit system. A possible case: The UEFI-SCT is executing this test on a 64 bit machine. So far, the m