> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173
> 
> The blocked register might return the counter instead of bitvector. This
> request
> is to update the code to handle the case by checking SMM Delayed/Blocked
> AP Count
> to decide all CPUs in SMI or not.

The code change actually assumes the SmmRegSmmBlocked, SmmRegSmmDelayed
and SmmRegSmmEnable registers return the number of threads that are in
blocked, delayed or disabled state.
Can you provide suggestions regarding how to change those close source 
CpuSmmFeaturesLib
implementation which still returns the bitmap value instead of count in the 
commit message?


> +UINT32                       *mPackageBspInfo = NULL;

The variable name is confusing. Can you rename it to "mPackageFirstThreadIndex"?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96672): https://edk2.groups.io/g/devel/message/96672
Mute This Topic: https://groups.io/mt/95330478/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to