Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL

2022-11-06 Thread G Edhaya Chandran
Reviewed-by: G Edhaya Chandran The solution is upstreamed by the commit:  https://github.com/tianocore/edk2-test/commit/18a8ca0dda79a9348157d77083ba1e1b9b18081b -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96022): https://edk2.groups.i

Re: [edk2-devel] 回复: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi for host tools

2022-11-06 Thread Michael D Kinney
Hi Liming, That seems like a bigger change. I see no harm in always producing symbols when build C host tools. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming via > groups.io > Sent: Sunday, November 6, 2022 8:23 PM > To: Kinney, Michael D ; devel@edk2.

[edk2-devel] [PATCH] UefiCpuPkg/ResetVector:Add Option to reserve 4K region at 4GB

2022-11-06 Thread cbduggap
From: "Duggapu, Chinni B" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4140 Some implementations may need to keep the initial Reset code to be separated out from rest of the code.This request is to add padding at lower 4K region below 4 GB which will result having only few jmp instruction

Re: [edk2-devel] [PATCH V3 0/9] Rename VmgExitLib to CcExitLib

2022-11-06 Thread Ni, Ray
Better to rename instead of duplicating then deleting even the commit may change multiple packages. Lib API can be "CcExit..". No need to put "Lib" as part of the API. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96019): https://ed

[edk2-devel] 回复: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi for host tools

2022-11-06 Thread gaoliming via groups.io
Mike: I suggest to remove /Zi and /DEBUG option for BaseTools C tool generation, because only tool developer may require the debug version C tool. Thanks Liming > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2022年11月6日 4:36 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Ch

回复: [edk2-devel] 回复: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 data under smbiosview

2022-11-06 Thread gaoliming via groups.io
Sainadh: The change is good to me. Reviewed-by: Liming Gao Thanks Liming 发件人: devel@edk2.groups.io 代表 Sainadh Nagolu via groups.io 发送时间: 2022年11月4日 19:32 收件人: gaoliming ; devel@edk2.groups.io 主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH] ShellPkg:Improved Smbios Type 9 data under smbiosv

回复: [edk2-devel] 回复: [PATCH v3 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-06 Thread gaoliming via groups.io
Create https://github.com/tianocore/edk2/pull/3604 to merge this patch. Thanks Liming 发件人: devel@edk2.groups.io 代表 Pedro Falcato 发送时间: 2022年11月5日 8:25 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn 抄送: Vitaly Cheptsov ; Marvin Häuser ; Michael D Kinney ; Zhiguang Liu ; Jiewen Yao 主题:

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 7, 2022 #cal-reminder

2022-11-06 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 7, 2022 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1623293 ) *Description:* Tian

[edk2-devel] [PATCH V3 9/9] Maintainers: Update the VmgExitLib to CcExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib is renamed as CcExitLib. The related section in Maintainers.txt should be updated as well. Cc: Michael D Kinney Cc: Liming Gao Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Len

[edk2-devel] [PATCH V3 8/9] UefiCpuPkg: Delete VmgExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib is replaced by CcExitLib. So it is deleted from UefiCpuPkg. Cc: Guo Dong Cc: Ray Ni Signed-off-by: Min Xu --- UefiCpuPkg/Include/Library/VmgExitLib.h | 173 -- .../Library/VmgExitLibNull/

[edk2-devel] [PATCH V3 7/9] OvmfPkg: Delete VmgExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 Delete VmgExitLib because it is replaced by CcExitLib. Cc: Brijesh Singh Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Min Xu --- .../VmgExitLib/PeiDxeVmgExitVcH

[edk2-devel] [PATCH V3 6/9] OvmfPkg: Use CcExitLib instead of VmgExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib is renamed as CcExitLib. See the description in BZ4123. So OvmfPkg should be updated to this rename. Cc: Brijesh Singh Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Si

[edk2-devel] [PATCH V3 5/9] UefiPayloadPkg: Use CcExitLib instead of VmgExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib is renamed as CcExitLib. So UefiPayloadPkg.dsc should be updated as well. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Reviewed-by: James Lu Reviewed-by: Gua Guo Signed-off-by: Min Xu -

[edk2-devel] [PATCH V3 4/9] UefiCpuPkg: Use CcExitLib instead of VmgExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib once was designed to provide interfaces to support #VC handler and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is introduced, this library is updated to support #VE as well. Now the name of V

[edk2-devel] [PATCH V3 3/9] OvmfPkg: Add CcExitLib in *.dsc

2022-11-06 Thread Min Xu
From: Min M Xu https://bugzilla.tianocore.org/show_bug.cgi?id=4123 CcExitLib is designed to replace VmgExitLib. This patch adds CcExitLib in *.dsc which import VmgExitLib. VmgExitLib in these *.dsc will be deleted in the follwing patch so that the build will not be broken. Cc: Brijesh Singh Cc

[edk2-devel] [PATCH V3 2/9] OvmfPkg: Implement CcExitLib

2022-11-06 Thread Min Xu
From: Min M Xu https://bugzilla.tianocore.org/show_bug.cgi?id=4123 The base CcExitLib library provides a default limited interface. As it does not provide full support, create an OVMF version of this library to begin the process of providing full support of Cc guest (such as SEV-ES, TDX) within

[edk2-devel] [PATCH V3 1/9] UefiCpuPkg: Add CcExitLib

2022-11-06 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 CcExitLib is designed to support handling #VC/#VE exceptions and issuing VMGEXIT instructions. It can be used to perform these: - Handling #VC exceptions - Handling #VE exceptions - Preparing for and issuing a VMGEXIT

[edk2-devel] [PATCH V3 0/9] Rename VmgExitLib to CcExitLib

2022-11-06 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123 VmgExitLib once was designed to provide interfaces to support #VC handler and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is introduced, this library is updated to support #VE as well. Now the name of VmgExitLib cannot

Re: [edk2-devel] 回复: [PATCH v9 00/19] Add Raw algorithm support using Arm TRNG interface

2022-11-06 Thread Ard Biesheuvel
On Fri, 4 Nov 2022 at 18:34, Ard Biesheuvel wrote: > > On Fri, 4 Nov 2022 at 02:16, gaoliming via groups.io > wrote: > > > > Sami, Leif, Ard: > > Can you give your Reviewed-by for this patch set this week? If so, this > > feature can catch stable tag 202211. > > > > Stable202211 tag soft feat

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 18/30] UefiCpuPkg/CpuDxe: Add support for RISC-V

2022-11-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] This change follows the Directory/File naming guidance for Processor archs/vendors. Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Sunday, October 30, 2022 9:29 PM > To: devel@edk2

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 17/30] UefiCpuPkg/CpuDxe: Refactor to allow other architectures

2022-11-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] This change follows the Directory/File naming guidance for Processor archs/vendors. Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Sunday, October 30, 2022 9:28 PM > To: devel@edk2

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 15/30] UefiCpuPkg/CpuExceptionHandlerLib: Refactor to allow other architectures

2022-11-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] This change follows the Directory/File naming for the Processor archs/Vendors. Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Sunday, October 30, 2022 9:28 PM > To: devel@edk2.group

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 13/30] UefiCpuPkg/CpuTimerLib: Refactor to allow other architectures

2022-11-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sunil V L > via groups.io > Sent: Sunday, October 30, 2022 9:28 PM > To: devel@edk2.groups.io > Cc: Eric Dong ; Ray Ni ; Rahul > Kumar > Subject: [edk2-devel] [edk2-st

[edk2-devel] [PATCH v5 02/19] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Added NameSize and State to AUTH_VARIABLE_INFO struct. The size of the name and state is needed when creating the variable digest. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C M

[edk2-devel] [PATCH v5 17/19] SecurityPkg: Add EncryptionVariable lib with AES

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Change AllocateZeroPool() with AllocatePages() and FreePool() with FreePages(). FreePool() is not supported in PEI phase so this was causing a memory leak. Reverse the order of the FreePages() call. V1: Add encryption/decryption of prot

[edk2-devel] [PATCH v5 19/19] SecurityPkg: Add references to new *.inf files

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add references to the different *ProtectedVariableLib.inf. Also add references to VariableKeyLibNull.inf, EncryptionVariableLibNull.inf, ProtectedVariableNull.inf. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J

[edk2-devel] [PATCH v5 16/19] SecurityPkg: Add VariableKey library function

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V5: Applied code review comments. Add PEIM to library class V1: Provide function that retrieves the key for protected variables. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mi

[edk2-devel] [PATCH v5 12/19] SecurityPkg: Add new variable types and functions

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new variable encryption/decryption function prototypes. Add new variable digest structure. Add new Protected variable function prototypes. Update RPMC APIs to Add an index because there is could more than one counter. Cc: Jian J Wang C

[edk2-devel] [PATCH v5 14/19] SecurityPkg: Fix GetVariableKey API

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review - function comments need to match function prototype. V1: Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Ni

[edk2-devel] [PATCH v5 07/19] MdeModulePkg: Add new Variable functionality

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V5: Add PEI Variable Protection into a new directory and leave the existing PEI Variable unchanged. V3: Update GetNvVariableStore() to call GetVariableFlashNvStorageInfo() and SafeUint64ToUint32(). V1: Provide new APIs for retrieving varia

[edk2-devel] [PATCH v5 15/19] SecurityPkg: Add null encryption variable libs

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review - Remove empty Guids section from .inf file. Update description in *.c. Remove *.uni file and reference to it. V1: Provide null ecryption variable libraries. These will be used by default for platforms that don't sup

[edk2-devel] [PATCH v5 10/19] SecurityPkg: Add new GUIDs for

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 The gEdkiiProtectedVariableGlobalGuid HOB contains the global configuration data structure which is verified in PEI Phase. The gEdkiiMetaDataHmacVariableGuid is used for saving the meta data HMAC variable. The gEdkiiProtectedVariableContextG

[edk2-devel] [PATCH v5 11/19] SecurityPkg: Add new KeyService types and defines

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: revert copyright date change. V1: Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Inc

[edk2-devel] [PATCH v5 13/19] SecurityPkg: Update RPMC APIs with index

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Update RPMC APIs with index parameter because sometimes there are more than 1 RPMC counter on the platform. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: J

[edk2-devel] [PATCH v5 05/19] MdeModulePkg: Add new GUID for Variable Store Info

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Discover if Variable Store Info HOB has been published by platform driver. It contains information in regards to HOB or NV Variable Store availability Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed

[edk2-devel] [PATCH v5 04/19] MdeModulePkg: Add new include files

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Updated with review comments for misspellings, mismatch function prototype, missing function header comments, incorrect function description. V1: Add EncryptionVariableLib.h for providing encryption and decryption services for protected

[edk2-devel] [PATCH v5 06/19] MdeModulePkg: Add Null ProtectedVariable Library

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review comments - removed APIs that are not being used. V1: Add Null versions of the ProtectedVariable Library. This will be the default libraries for platforms that do not support ProtectedVariable. Cc: Jian J Wang Cc: L

[edk2-devel] [PATCH v5 00/19] UEFI variable protection

2022-11-06 Thread Judah Vang
Patch 07 - Add PEI Variable Protection into a new directory and leave the existing PEI Variable unchanged. Patch 08 - Add RuntimeDxe Variable Protection into a new directory and keep existing Variable for RuntimeDxe unchanged. Patch 09 - Add reference to new Protected Variable libs. Patch 16 - A

[edk2-devel] [PATCH v5 03/19] MdeModulePkg: Add new ProtectedVariable GUIDs

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Reviewed-

[edk2-devel] [PATCH v5 01/19] MdePkg: Add reference to new Ppi Guid

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid which contains information whether variable store is available. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signe

[edk2-devel] [PATCH v5 09/19] MdeModulePkg: Reference Null ProtectedVariableLib

2022-11-06 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V5: Add reference to new Protected Variable libs. V1: Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signe