Sean provided a sample PR that adds a PCD.
I think we agree that a PCD is not required. The existing logic that centers
the logo should be updated to use the 38.2% rule.
Mike
From: Ni, Ray
Sent: Tuesday, October 25, 2022 7:32 PM
To: Kinney, Michael D ; devel@edk2.groups.io;
Rhodes, Sean
Cc:
On 26/10/2022 12:35, Alexey Kardashevskiy wrote:
On 26/10/2022 12:07, Dionna Amalie Glaze wrote:
On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy
wrote:
Hi Dionna,
Thanks for updating the tree, builds nicely now! However the VM's kernel
does not boot - the guest kernel reports
EFI
Are you suggesting that the exiting logic be updated for this use case without
adding a new enum?
* yes.
From: Kinney, Michael D
Sent: Wednesday, October 26, 2022 12:21 AM
To: devel@edk2.groups.io; Ni, Ray ; Rhodes, Sean
; Kinney, Michael D
Cc: Gao, Zhichao ; Wang, Jian J ;
Gao, Liming
Pavamana:
The code change looks good. Now, is FIT spec 1.4 public to be downloaded?
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Hv, Pavamana
发送时间: 2022年10月26日 5:50
收件人: devel@edk2.groups.io; Gao, Liming
抄送: Feng, Bob C ; Holland, Michael
主题: Re: [edk2-devel] [PATCH v2] edk2Platforms-Sili
On 26/10/2022 12:07, Dionna Amalie Glaze wrote:
On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote:
Hi Dionna,
Thanks for updating the tree, builds nicely now! However the VM's kernel
does not boot - the guest kernel reports
EFI stub: ERROR: exit_boot() failed!
and hangs. I am no
Min:
Thanks for the update. I have no other comments for MdePkg changes in this
patch set.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Min Xu
> 发送时间: 2022年10月25日 9:08
> 收件人: Dionna Amalie Glaze ; Gao, Liming
>
> 抄送: devel@edk2.groups.io; Gao, Zhichao ; Ni, Ray
> ; Aktas, Er
Liming,
Thanks for you to merge this change.
Thanks,
Chao
On 10月 26 2022, at 9:14 上午, "gaoliming via groups.io"
wrote:
> Create https://github.com/tianocore/edk2/pull/3534 to merge it.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: Kinney, Michael D
> > 发送时间: 2022年10月21日 2:30
> > 收件人
Paul:
How do you find this issue? Are they reported by the compiler or code
analyzer?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Paul via
> groups.io
> 发送时间: 2022年10月23日 0:00
> 收件人: devel@edk2.groups.io
> 抄送: Zhiguang Liu ; Ray Ni ;
Gua
> Guo ; Qi Zhang ; Rahul Kumar
>
> 主题
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
10/25/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77
Create https://github.com/tianocore/edk2/pull/3534 to merge it.
Thanks
Liming
> -邮件原件-
> 发件人: Kinney, Michael D
> 发送时间: 2022年10月21日 2:30
> 收件人: Chao Li ; devel@edk2.groups.io; Kinney,
> Michael D
> 抄送: Gao, Liming ; Baoqi Zhang
> ; Dongyan Qian
> 主题: RE: [PATCH v2] Maintainers.txt: Upda
Pierre:
edk2-stable202211 tag is coming. If this patch plans to catch this stable
tag, it needs to pass review before 2022-11-07.
Here is release planning
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.i
Pierre:
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表
> PierreGondois
> 发送时间: 2022年10月21日 15:29
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Sami Mujawar' ; 'Leif Lindholm'
> ; 'Ard Biesheuvel' ;
> 'Rebecca Cran' ; 'Michael D Kinney'
> ; 'Jiewen Yao' ; 'Jian J
> Wang'
> 主题: Re: 回复: [edk2-dev
[AMD Official Use Only - General]
Hi all,
In order to having the full edk2 driver stack for the server manageability, we
are going to propose a new package ManageabilityPkg under
edk2-platforms/Features. We would like to have a package that can provide a
simple framework to flexibly accommodate
On Tue, Oct 25, 2022 at 5:23 PM Alexey Kardashevskiy wrote:
>
> Hi Dionna,
>
> Thanks for updating the tree, builds nicely now! However the VM's kernel
> does not boot - the guest kernel reports
>
> EFI stub: ERROR: exit_boot() failed!
>
> and hangs. I am not quite sure how it is supposed to work
Patch merged:
https://github.com/tianocore/edk2/commit/26638d2aa399e436f47d629f877e581ed402020a
Thanks,
Chasel
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, October 25, 2022 3:19 PM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Zeng, Star
> Subject: RE: [PATC
Hi Dionna,
Thanks for updating the tree, builds nicely now! However the VM's kernel
does not boot - the guest kernel reports
EFI stub: ERROR: exit_boot() failed!
and hangs. I am not quite sure how it is supposed to work (still
learning) but "Accepting all memory" happens twice (should it?) a
Thanks for the review Michael, I've sent a V4 patch with the added @return
> From: Michael Kubacki
> Sent: Tuesday, October 25, 2022 3:03 PM
> To: Desimone, Nathaniel L ;
> devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in
> CapsuleRuntimeDxe
Pushed: https://github.com/tianocore/edk2/commit/7464db4
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Tuesday, October 25, 2022 2:42 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ;
> Wang, Jian J ; Gao, Liming
> ; Kinney, Michael D
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4112
In AllocateReservedMemoryBelow4G(), if gBS->AllocatePages()
returns an error, and ASSERTs are disabled, then the
function will overwrite memory from 0x -> (0x + Size).
Cc: Liming Gao
Cc: Guomin Jiang
Cc: Jian J Wang
Cc: M
Hi Chasel,
There is a spelling error in your commit message. IntelFsp2WrapprPkg should be
IntelFsp2WrapperPkg. Please fix this during the push. No need to send a 2nd
review.
With that change...
Reviewed-by: Nate DeSimone
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, Oct
It would be nice to update @return for AllocateReservedMemoryBelow4G() to
indicate NULL should be expected if an internal memory allocation fails.
Other than that:
Reviewed-by: Michael Kubacki
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Onli
Hi Liming,
Any update on this? Please treat this with urgency as we have a release coming
up and needs this change.
-Pavamana
From: Hv, Pavamana
Sent: Monday, October 24, 2022 10:05 AM
To: devel@edk2.groups.io; Gao, Liming
Subject: RE: [PATCH v2] edk2Platforms-Silicon:Add VAB FIT record types s
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, October 25, 2022 2:42 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao ; Wang,
> Jian J ; Gao, Liming
> ; Kinney, Michael D
> Subject: [PATCH V1] MdeModulePkg: Fix spelling error
gSerialDevTempate should be gSerialDevTemplate
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Jian J Wang
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Nate DeSimone
---
MdeModulePkg/Bus/Pci/PciSioSerialDxe/Serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/P
Modern platforms that use TF-A should use PrePeiCoreUniCore, since
any secondary cores will be put in the TF-A holding pen and won't
reach EDK2.
Update the Morello and N1Sdp files to use PrePeiCoreUniCore instead of
PrePeiCoreMPCore.
Signed-off-by: Rebecca Cran
---
Platform/ARM/Morello/MorelloP
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4119
Earlier version of FSP header may not have MultiPhase fields present in
the FspInfoHeader so the handler should verify header revision before
accessing the MultiPhase fields from the header.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by:
Hi Mike/Ray
Thanks - so you mean something like
https://github.com/tianocore/edk2/pull/3528? (
https://github.com/tianocore/edk2/pull/3528 ) (Just for example)
If not, I'm not sure how to control it without the PCD?
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
On Mon, Oct 24, 2022 at 19:01:22 +0200, Ard Biesheuvel wrote:
> The NorFlashDxe driver in ArmPlatformPkg was shared between development
> platforms built by ARM Ltd, and virtual platforms that were once modeled
> after Versatile Express, but have very little in common with actual bare
> metal imple
On Tue, Oct 25, 2022 at 07:46:13 -0600, Rebecca Cran wrote:
> Thanks, that's a good change.
>
> Reviewed-by: Rebecca Cran
(I won't add an R-b from you on your own patch.)
Reviewed-by: Leif Lindholm
After fixing a couple of style issues in my diff below:
Pushed as 56035d1c8b25.
Thanks!
/
Adding Jiewen Yao.
Mike
> -Original Message-
> From: Pedro Falcato
> Sent: Monday, October 24, 2022 3:43 PM
> To: devel@edk2.groups.io
> Cc: Pedro Falcato ; Vitaly Cheptsov
> ; Marvin Häuser ;
> Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: [PATCH v2 1/1] MdePkg/BaseLib
Reviewed-by: Michael D Kinney
> -Original Message-
> From: abner.ch...@amd.com
> Sent: Tuesday, October 25, 2022 9:17 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Leif Lindholm ;
> Kinney, Michael D ;
> Nickle Wang ; Igor Kulchytskyy
> Subject: [PATCH] Maintainers.txt: Update mai
Ray,
Are you suggesting that the exiting logic be updated for this use case without
adding a new enum?
Sean, can you provide a revised patch that does this?
Thanks,
Mike
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent: Tuesday, October 25, 2022 12:58 AM
To: devel@edk2.groups.io; Rhodes,
From: Abner Chang
Update maintainers.txt to add Igor from AMI
as the reviewer of RedfishPkg.
Signed-off-by: Abner Chang
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maint
Thanks, that's a good change.
Reviewed-by: Rebecca Cran
On 10/25/22 05:41, Leif Lindholm wrote:
On Tue, Oct 11, 2022 at 14:59:52 -0600, Rebecca Cran wrote:
Copy code from PrePi to PrePeiCore that prints the firmware version
and build date early in the boot process.
I'm good with this, but I'
Hello Jiewen and Jian,
Does the patch-set look ok for SecurityPkg ?
Regards,
Pierre
On 10/18/22 15:20, PierreGondois via groups.io wrote:
From: Pierre Gondois
Bugzilla: Bug 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0
Hello Sami,
Reviewed-by: Pierre Gondois
Regards,
Pierre
On 10/18/22 17:33, Sami Mujawar wrote:
Some SMBIOS tables have dependencies on other SMBIOS tables. These
dependencies are established using handles pointing to the dependent
SMBIOS tables.
This requires the dependent SMBIOS table to be
Hi Leif,
This change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 25/10/2022 12:41 pm, Leif Lindholm wrote:
On Tue, Oct 11, 2022 at 14:59:52 -0600, Rebecca Cran wrote:
Copy code from PrePi to PrePeiCore that prints the firmware version
and build date early in the bo
On Tue, Oct 11, 2022 at 14:59:52 -0600, Rebecca Cran wrote:
> Copy code from PrePi to PrePeiCore that prints the firmware version
> and build date early in the boot process.
I'm good with this, but I'd prefer to break the printout into a helper
function in order to reduce clutter in CEntryPoint.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4081
INF [Sources] section Feature Flag Expressions do not use
override values from build --pcd option currently.
This patch fix this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/Workspace/InfBuildData.py |
Thanks for your review comments, Abner! I will update new version patch later.
The CI build error will be handled together.
> please add Igor as reviewer too
Sure!
> + *UserId = AllocateZeroPool (sizeof (CHAR8) * USERNAME_MAX_SIZE);
> + if
[Chang, Abner]
Allocation memory with the size (USER
I need a reason of adding EdkiiPlatformLogoDisplayAttributeMicrosoftRecommended.
In my opinion, without adding this new enum value, it’s still possible to
support MS recommendation.
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Tuesday, October 25, 2022 3:27 PM
To: Ni, Ray
Cc: devel
Hi Ray
Where would you suggest this code goes? edk2 should support both Microsoft
recommended and "normal". The original patch handled this well.
Thanks
Sean
On Mon, 10 Oct 2022 at 10:25, Ni, Ray wrote:
> The logic I shared below is from the LogoDxe driver which produces
> EDKII_PLATFORM_LOGO
Hi Ray
Done
Thank you
On Tue, 25 Oct 2022 at 07:04, Ni, Ray wrote:
> Can you update the PR to rebase to latest trunk?
>
> Also please modify commit message to capture Reviewed-by tags.
>
>
>
> *From:* devel@edk2.groups.io * On Behalf Of *Sheng
> Lean Tan
> *Sent:* Tuesday, October 25, 2022 10
43 matches
Mail list logo
