Min: Thanks for the update. I have no other comments for MdePkg changes in this patch set.
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Min Xu > 发送时间: 2022年10月25日 9:08 > 收件人: Dionna Amalie Glaze <dionnagl...@google.com>; Gao, Liming > <gaolim...@byosoft.com.cn> > 抄送: devel@edk2.groups.io; Gao, Zhichao <zhichao....@intel.com>; Ni, Ray > <ray...@intel.com>; Aktas, Erdem <erdemak...@google.com>; Gerd > Hoffmann <kra...@redhat.com>; James Bottomley <j...@linux.ibm.com>; > Yao, Jiewen <jiewen....@intel.com>; Tom Lendacky > <thomas.lenda...@amd.com>; Gao, Jiaqi <jiaqi....@intel.com>; Wang, Jian > J <jian.j.w...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com>; Kinney, > Michael D <michael.d.kin...@intel.com>; Ard Biesheuvel <a...@kernel.org>; > Xu, Min M <min.m...@intel.com> > 主题: Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept for > Tdx guest > > Hi, Liming > In Dionna's latest patch-sets the name of accept_all_unaccepted_memory > has been changed to BZ3987_MEMORY_ACCEPTANCE_PROTOCOL. > https://edk2.groups.io/g/devel/message/95525 > https://edk2.groups.io/g/devel/message/95530 > > So now these 2 protocols are named as > "BZ3987_MEMORY_ACCEPTANCE_PROTOCOL" and " > EDKII_MEMORY_ACCEPT_PROTOCOL". > Do you think they have addressed your concern? > > Thanks > Min > > > -----Original Message----- > > From: Dionna Amalie Glaze <dionnagl...@google.com> > > Sent: Friday, October 21, 2022 11:59 PM > > To: Xu, Min M <min.m...@intel.com> > > Cc: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>; Gao, > > Zhichao <zhichao....@intel.com>; Ni, Ray <ray...@intel.com>; Aktas, > Erdem > > <erdemak...@google.com>; Gerd Hoffmann <kra...@redhat.com>; James > > Bottomley <j...@linux.ibm.com>; Yao, Jiewen <jiewen....@intel.com>; > Tom > > Lendacky <thomas.lenda...@amd.com>; Gao, Jiaqi <jiaqi....@intel.com>; > > Wang, Jian J <jian.j.w...@intel.com>; Liu, Zhiguang > > <zhiguang....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; > > Ard Biesheuvel <a...@kernel.org> > > Subject: Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept > for > > Tdx guest > > > > > > Min: > > > > I understand that they are for the different purpose and usage. > > > > But, their protocol name are very similar. > > > Yes. They do look very similar. > > > > > > > If there is no better protocol name, I will also be fine. > > > Dionna, what's your thought? > > > > > > > The accept_all_unaccepted_memory name came from Ard's suggestion on > > an earlier patch series where I was using a Pcd. > > We're talking about the name over on the spec bug > > https://bugzilla.tianocore.org/show_bug.cgi?id=3987#c26 > > > > I think that any name concerning unaccepted memory is going to look a little > > same-y to others, so it's going to be troublesome if we require that they > > all > > strongly differ in name. I'm not strongly attached to the name, I just want > > to > > be conservative about what the name implies about the expected overall > > behavior of the system when that has not actually been decided upon. > > > > -- > > -Dionna Glaze, PhD (she/her) > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95586): https://edk2.groups.io/g/devel/message/95586 Mute This Topic: https://groups.io/mt/94573125/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
