[edk2-devel] [PATCH 3/3] CryptoPkg: add unit test for EC key interface.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4102 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- .../UnitTest/Library/BaseCryptLib/EcTests.c | 156 ++ 1 file changed, 156 insertions(+) diff --git a/CryptoPkg/Test/UnitTest/L

[edk2-devel] [PATCH 2/3] CryptoPkg: Add EC key interface to DXE and protocol

The implementation provide EC key interface for EFI driver nad EFI BaseCrypt protocol. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4102 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- CryptoPkg/Driver/Crypto.c | 143

[edk2-devel] [PATCH 1/3] CryptoPkg: Add EC key retrieving and signature interface.

This patch is used to retrieve EC key from PEM and X509 and carry out the EC-DSA signature and verify it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4102 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- CryptoPkg/Include/Library/BaseCryptLib

[edk2-devel] [PATCH 0/3] CryptoPkg: Add EC key retrieving and signature interface.

This patch is used to retrieve EC key from PEM and X509 and carry out the EC-DSA signature and verify it. The interface was tested by: 1. DeviceSecurity on edk2-staging https://github.com/tianocore/edk2-staging/tree/DeviceSecurity. 2. Unit test in CryptoPkg/Test REF: https://bugzilla.tianocore.or

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib:Support PAE paging for PageTableParse

I didn't enable the PAE support because I found slightly differences in logic that creates the PAE paging structure. I agree that PageTableParse() supporting PAE is more straightforward. Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Tuesday, October 11, 2022 2:00 P

[edk2-devel] [PATCH 3/3] UefiCpuPkg: Add Pei/DxeCpuExceptionHandlerLibUnitTest in dsc

Add Pei/DxeCpuExceptionHandlerLibUnitTest module in UefiCpuPkg.dsc Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/UefiCpuPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index f694b3a77c..3

[edk2-devel] [PATCH 2/3] UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib

Add target based unit tests for the PeiCpuExceptionHandlerLib. A PEIM is created to test PeiCpuExceptionHandlerLib. Four kinds of test cases are created in this module: 1.Test if exception handler can be registered/unregistered for no error code exception. 2.Test if exception handler can be registe

[edk2-devel] [PATCH 1/3] UefiCpuPkg: Add Unit tests for DxeCpuExceptionHandlerLib

Add target based unit tests for the DxeCpuExceptionHandlerLib. A DXE driver is created to test DxeCpuExceptionHandlerLib. Four kinds of test cases are created in this module: 1.Test if exception handler can be registered/unregistered for no error code exception. 2.Test if exception handler can be r

[edk2-devel] [PATCH 0/3] Add Pei/DxeCpuExceptionHandlerLibUnitTest

Add Pei/DxeCpuExceptionHandlerLibUnitTest Dun Tan (3): UefiCpuPkg: Add Unit tests for DxeCpuExceptionHandlerLib UefiCpuPkg: Add Unit tests for PeiCpuExceptionHandlerLib UefiCpuPkg: Add Pei/DxeCpuExceptionHandlerLibUnitTest in dsc UefiCpuPkg/CpuExceptionHandlerUnitTest/CpuExceptionHandlerTe

[edk2-devel] [PATCH] UefiCpuPkg:Add RegisterExceptionHandler in PeiCpuExceptionHandlerLib

Add RegisterExceptionHandler for PeiCpuExceptionHandlerLib instance Signed-off-by: Zhiguang Liu Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-

[edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib:Support PAE paging for PageTableParse

Support PAE paging for PageTableParse API in CpuPageTableLib. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableParse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/Cpu

Re: [edk2-devel] [PATCH v3 00/34] Add a new architecture called LoongArch in EDK II

Hi All, I have created a PR in EDK2 repo: https://github.com/tianocore/edk2/pull/3457 (https://link.getmailspring.com/link/8e708030-54f4-491f-8a87-08a00cc89...@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fpull%2F3457&recipient=ZGV2ZWxAZWRrMi5ncm91cHMuaW8%3D), and all

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Allocate the Ring segments at 64K aligned address to avoid the Rings crossing a 64K byte boundary.

According the Xhci Spec, TRB Rings may be larger than a Page, however they shall not cross a 64K byte boundary, so allocate the rings at 64K aligned address to avoid they crossing a 64K byte boundary. Signed-off-by: jdzhang --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 112 +++-

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

[AMD Official Use Only - General] Removing '_' seems make the folder hard to read, but not too bad to me though. I am fine with removing '_'. Leif and Mike, how do you think? Ex: Riscv64Ia32X64 compares Riscv64_Ia32_X64. ArmAArch64 compares to Arm_AArch64. Abner Get Outlook for Android

Re: [edk2-devel] The principles of EDK2 module reconstruction for archs

Abner, Mike, Leif, "Ia32_X64" is the first case in edk2 that underscore "_" is used as part of file path. Shall we use "Ia32X64" (removing "_")? I know that Sunil is following the guideline. https://edk2.groups.io/g/devel/message/94912?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CU

Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of > PierreGondois > Sent: Monday, October 10, 2022 5:48 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Alexei Fedorov > ; Ni, Ray ; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH 14/14] ShellPkg/Acpi

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 10/11/2022 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 10/11/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77

Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

HI Sean You are right that the purpose is NOT to expose *all* APIs. Our purpose is still to export *necessary* APIs only. This X.509 is for SPDM support. (https://www.dmtf.org/dsp/DSP0274). The BIOS may need collect the device identity (certificate) and validate the integrity of the certificate

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 10/10/2022 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* 10/10/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610034 ) *Description:* TianoCore community, Micros

[edk2-devel] Event: Tools, CI, Code base construction meeting series - 10/10/2022 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* 10/10/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610034 ) *Description:* TianoCore communit

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO - Thursday, October 20, 2022 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220816T024022Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

[edk2-devel] Updated Event: TianoCore Community Meeting EMEA/NAMO - Thursday, October 20, 2022 #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220816T024022Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

[edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic

Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 f

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros

Pushed as 45c2015953..66cef08cde -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, October 10, 2022 2:12 PM To: mikub...@linux.microsoft.com; devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Luo, Heng ; Gao, Liming ; Dong, Eric Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] Platform/Intel: Fix invalid DEBUG() macros

Series Reviewed-by: Isaac Oram -Original Message- From: mikub...@linux.microsoft.com Sent: Tuesday, October 4, 2022 8:35 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Oram, Isaac W ; Luo, Heng ; Gao, Liming ; Dong, Eric Subject: [edk2-platforms][PATCH v1 0/3

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header

Pushed as ad00518399..45c2015953 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Monday, October 10, 2022 1:59 PM To: devel@edk2.groups.io; mikub...@linux.microsoft.com Cc: S, Ashraf Ali ; Chaganty, Rangasai V ; Ni, Ray Subject: Re: [edk2-devel] [edk2-platfor

Re: [edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

Can you provide some context as to why we need to make all these x509 functions external? BaseCryptLib was intended to simplify crypto usage and not be a full featured crypto library interface. At some point we might as well just open up the openssl export table and wrap that in a dynamicall

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header

Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, October 5, 2022 8:23 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1]

[edk2-devel] [PATCH v1 0/1] BaseTools: Fix Python Formatting

Fix formatting of Python files in BaseTools to conform to PEP8 using autopep8. This does not fix all the warnings/errors from flake8, but I wanted to get this patch checked out first to see if ignoring those warnings is deliberate or not. The complete code can be found: https://github.com/Ayush13

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, Oct 10, 2022 at 06:16:28PM +0200, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 18:05, Sunil V L wrote: > > > > On Mon, Oct 10, 2022 at 05:29:15PM +0200, Ard Biesheuvel wrote: > > > On Mon, 10 Oct 2022 at 17:19, Sunil V L wrote: > > > > > > > > On Mon, Oct 10, 2022 at 12:39:21PM +0200, A

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString

On 10/10/2022 8:42 AM, Gerd Hoffmann wrote: Instead of using hard-coded string "0.0.0" for BiosVersion (which is quite useless) read PcdFirmwareVersionString and append that to the type0 entry string table. Signed-off-by: Gerd Hoffmann --- #define TYPE0_STRINGS \ "EFI Development Kit II

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, 10 Oct 2022 at 18:05, Sunil V L wrote: > > On Mon, Oct 10, 2022 at 05:29:15PM +0200, Ard Biesheuvel wrote: > > On Mon, 10 Oct 2022 at 17:19, Sunil V L wrote: > > > > > > On Mon, Oct 10, 2022 at 12:39:21PM +0200, Ard Biesheuvel wrote: > > > > On Mon, 10 Oct 2022 at 12:13, Sunil V L > > >

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, Oct 10, 2022 at 05:29:15PM +0200, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 17:19, Sunil V L wrote: > > > > On Mon, Oct 10, 2022 at 12:39:21PM +0200, Ard Biesheuvel wrote: > > > On Mon, 10 Oct 2022 at 12:13, Sunil V L wrote: > > > > > > > > REF: https://bugzilla.tianocore.org/show_bu

Re: [edk2-devel] 回复: [PATCH V4 00/10] Introduce Lazy-accept for Tdx guest

> > Can OS call AcceptMemory protocol for those ranges that are not accepted? > AcceptMemory is not specified to avoid accepting previously accepted memory. As I understand it, AcceptMemory is purely a hardware abstraction layer for CC technologies inside the UEFI implementation. It additionally i

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, 10 Oct 2022 at 17:19, Sunil V L wrote: > > On Mon, Oct 10, 2022 at 12:39:21PM +0200, Ard Biesheuvel wrote: > > On Mon, 10 Oct 2022 at 12:13, Sunil V L wrote: > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > > > RISC-V needs NorFlashDxe driver for qemu virt mach

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, Oct 10, 2022 at 12:39:21PM +0200, Ard Biesheuvel wrote: > On Mon, 10 Oct 2022 at 12:13, Sunil V L wrote: > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > > > RISC-V needs NorFlashDxe driver for qemu virt machine. The > > ArmPlatformPkg has this driver but migrating it t

[edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString

Instead of using hard-coded string "0.0.0" for BiosVersion (which is quite useless) read PcdFirmwareVersionString and append that to the type0 entry string table. Signed-off-by: Gerd Hoffmann --- .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 4 +++ .../XenSmbiosPlatformDxe.inf

[edk2-devel] [PATCH v2] UefiCpuPkg/Test: Add unit tests for MP service PPI and Protocol

From: Jason Lou The code changes add unit tests based on current UnitTestFramework. EdkiiPeiMpServices2PpiPeiUnitTest PEI module is used to test EdkiiPeiMpServices2Ppi and EfiMpServiceProtocolDxeUnitTest DXE driver is used to test EfiMpServiceProtocol. Signed-off-by: Jason Lou Cc: Ray Ni Cc: E

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header

Reviewed-by: Ashraf Ali S Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Wednesday, October 5, 2022 8:53 PM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Oram, Isaac W ; Chaganty, Rangasai V ; Ni,

[edk2-devel] [edk2-platforms][PATCH V1 2/2] Platform/Sgi: Enable virtio-p9 device on RD-N2 platform variants

Enable the virtio-p9 device that is present as part of the RoS peripherals on RD-N2 platform variants. This will allow filesystem sharing between the Host PC and target platform. Signed-off-by: Vivek Gautam --- Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 8 ++-- Platform/ARM/SgiP

[edk2-devel] [edk2-platforms][PATCH V1 1/2] Platform/Sgi: add SSDT table for Virtio-P9

Some of the Arm reference design FVP platforms support the Virtio-p9 device as part of the RoS subsystem. Add an entry for this device in the SSDT acpi table. The device entry is listed in a new SSDT file as only some of the reference design FVP platforms support it and so this file is included in

[edk2-devel] [edk2-platforms][PATCH V1 0/2] Enable Virtio-P9 on RD-N2 platforms

Few Arm reference design Fixed Virtual Platforms (FVPs) support Virtio-P9 device as part of the RoS subsystem. The Virtio-P9 device implements a subset of the Plan 9 file protocol over a virtio transport that enables accessing a shared directory on the host's filesystem from a running FVP platform.

[edk2-devel] [PATCH V2 3/4] CryptoPkg: add new X509 function to Crypto Service.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- CryptoPkg/Driver/Crypto.c | 432 +- .../Pcd/PcdCryptoServiceFamilyEnable.h| 34 +- .../BaseCryptLibO

[edk2-devel] [PATCH V2 2/4] CryptoPkg: add new X509 function.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 1036 + .../Library/BaseCryptLib/Pk/CryptX509Null.c | 429 +++ .../BaseCry

[edk2-devel] [PATCH V2 4/4] CryptoPkg: add Unit Test for X509 new function.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- .../BaseCryptLib/BaseCryptLibUnitTests.c | 1 + .../Library/BaseCryptLib/TestBaseCryptLib.h | 4 + .../BaseCryptLib/TestBaseCryptLibHo

[edk2-devel] [PATCH V2 1/4] CryptoPkg: add new X509 function definition.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Qi Zhang --- CryptoPkg/Include/Library/BaseCryptLib.h | 374 +++ 1 file changed, 374 insertions(+) diff --git a/CryptoPkg/Include/Library

[edk2-devel] [PATCH V2 0/4] CryptoPkg: add more X509 functions.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082 This patch serial is to add more CryptoX509 functions. Tested by: 1. https://github.com/tianocore/edk2-staging/tree/DeviceSecurity. 2. Unit test: CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c Review PR: https://github.com/tianoc

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

On Mon, 10 Oct 2022 at 12:13, Sunil V L wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > RISC-V needs NorFlashDxe driver for qemu virt machine. The > ArmPlatformPkg has this driver but migrating it to generic > package like MdeModulePkg introduces circular dependencies. > So

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioNetDxe: Check ChildHandle argument in GetControllerName

On Wed, 28 Sept 2022 at 15:32, Samer El-Haj-Mahmoud wrote: > > Hi Ard, > > Any luck getting this one merged? > Merged #3460 into master. Thanks, > > -Original Message- > > From: Sunny Wang > > Sent: Friday, August 19, 2022 10:47 AM > > To: Dimitrije Pavlov ; devel@edk2.groups.io > > Cc

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 26/29] OvmfPkg: Add generic Qemu NOR flash DXE driver

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 RISC-V needs NorFlashDxe driver for qemu virt machine. The ArmPlatformPkg has this driver but migrating it to generic package like MdeModulePkg introduces circular dependencies. So, add a simplified version of the NorFlashDxe driver in OvmfP

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 29/29] UefiCpuPkg/UefiCpuPkg.ci.yaml: Ignore RISC-V file

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 RISC-V register names do not follow the EDK2 formatting. So, add it to ignore list for now. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Sunil V L --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 28/29] Maintainers.txt: Add entry for OvmfPkg/RiscVVirt

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 RiscVVirt is created to support EDK2 for RISC-V qemu virt machine platform. Add maintainer entries. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Sunil V L --- Maintainers.txt | 4 1 file changed, 4 inserti

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 27/29] OvmfPkg: RiscVVirt: Add Qemu Virt platform support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Add infrastructure files to build edk2 for RISC-V qemu virt machine. - EDK2 will boot as S-mode payload of opensbi. - It supports building either code and variables in unified flash or in two separate drives via build time option UNIFIE

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 25/29] OvmfPkg: Add NorFlashQemuLib library

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is copied from ArmVirtPkg since it is required for other architectures also. It also adds the instance for single flash drive which has both code and variables. This is copied from SbsaQemu. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jor

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 24/29] ArmVirtPkg: Fix up the paths to PlatformBootManagerLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 PlatformBootManagerLib has been moved to OvmfPkg so that other CPU architectures can reuse. So, update existing paths with the new location. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Sunil V

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 23/29] ArmVirtPkg/PlatformBootManagerLib: Move to OvmfPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 PlatformBootManagerLib in ArmVirtPkg is required for RISC-V also. So, move it to OvmfPkg. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Jordan Justen Signed-off-by: Sunil V L --- OvmfPkg/

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 22/29] ArmVirtPkg: Fix up the location of PlatformHasAcpiDtDxe

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 PlatformHasAcpiDtDxe is required by other architectures also. Hence, it is moved to OvmfPkg. So, update the consumers of this module with the new location. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-o

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 21/29] ArmVirtPkg/PlatformHasAcpiDtDxe: Move to OvmfPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This module is required by other architectures like RISC-V. Hence, move this to OvmfPkg. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Sunil V L --- ArmVirtPkg/ArmVirtPkg.dec

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 20/29] UefiCpuPkg: Add CpuTimerDxe module

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This DXE module initializes the timer interrupt handler and installs the Arch Timer protocol. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Signed-off-by: Sunil V L --- UefiCpuPkg/UefiCpuPkg.dsc| 3 +

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 17/29] UefiCpuPkg/CpuDxe: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, CpuDxe supports only X86 architecture. To add support for other architectures like RISC-V, this need to be refactored. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Sunil V L --- UefiCpuPkg/CpuDxe/CpuDxe.inf

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 19/29] UefiCpuPkg/CpuDxe: Add RISC-V Boot protocol support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 RISC-V UEFI platforms need to support RISCV_EFI_BOOT_PROTOCOL. Add the support for this protocol which is defined in the spec: https://github.com/riscv-non-isa/riscv-uefi/releases/download/1.0.0/RISCV_UEFI_PROTOCOL-spec.pdf Cc: Eric Dong C

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 18/29] UefiCpuPkg/CpuDxe: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is migrated from edk2-platforms/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Signed-off-by: Sunil V L --- UefiCpuPkg/CpuDxe/CpuDxe.inf | 11 ++ UefiCpuPkg/CpuDxe

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 16/29] UefiCpuPkg/CpuExceptionHandlerLib: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Signed-off-by: Sunil V L --- .../DxeCpuExceptionHandlerLib.inf | 7 +- .../SecPeiCpuExceptionHandlerLib.inf | 7 +- .../RiscV64/CpuExceptionHandlerLi

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 15/29] UefiCpuPkg/CpuExceptionHandlerLib: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, the CpuExceptionHandlerLib library supports only X86. Refactor the library to allow adding other CPU architectures. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Sunil V L --- .../DxeCpuExceptionHandlerLib.inf

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 14/29] UefiCpuPkg/CpuTimerLib: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is mostly copied from edk2-platforms/Silicon/RISC-V/ProcessorPkg/Library/RiscVTimerLib Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Signed-off-by: Sunil V L --- .../Library/CpuTimerLib/BaseCpuTimerLib.inf | 3

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 13/29] UefiCpuPkg/CpuTimerLib: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, CpuTimerLib library supports only X86 architecture. Refactor to allow other CPU architectures. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Sunil V L --- UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 12/29] OvmfPkg/PlatformPei: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is mostly copied from edk2-platforms/Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Signed-off-by: Sunil V L --- OvmfPkg/PlatformPe

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 11/29] OvmfPkg/PlatformPei: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, PlatformPei supports only X86 architecture. So, refactor it to allow other CPU architectures. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Sunil V L --- OvmfPkg/PlatformPei/PlatformPe

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 10/29] OvmfPkg/Sec: Add RISC-V support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Add the SEC module for RISC-V. EDK2 is launched as the payload for machine mode firmware in RISC-V. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Min X

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 09/29] OvmfPkg/Sec: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, the Sec module supports only X86 architecture. Refactor the module to allow other CPU architectures. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomle

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 08/29] OvmfPkg/ResetSystemLib: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is mostly copied from edk2-platforms/Platform/RISC-V/PlatformPkg/Library/ResetSystemLib Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan Cc: Daniel Schaefer Signed-off-by: S

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 07/29] OvmfPkg/ResetSystemLib: Refactor to allow other architectures.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, the ResetSystemLib library supports only X86 architecture. Refactor it to allow adding other CPU architectures like RISC-V. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Gre

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 06/29] OvmfPkg/PlatformInitLib: Add support for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This is copied from edk2-platforms/Platform/RISC-V/PlatformPkg/Universal/FdtPeim but added as part of library instead of a separate module. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Daniel Schaefer Signe

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 05/29] OvmfPkg/PlatformInitLib: Refactor to allow other architectures

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Currently, PlatformInitLib supports only X86 architecture. So, refactor to allow adding other architectures like RISC-V. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Sunil V L --- .../PlatformIn

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 04/29] MdePkg: Add BaseRiscVSbiLib Library for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 This library is required to make SBI ecalls from the S-mode EDK2. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sunil V L --- MdePkg/MdePkg.dec | 4 + MdePkg/MdePkg.dsc

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 03/29] MdePkg/BaseLib: RISC-V: Add few more helper functions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Few of the basic helper functions required for any RISC-V CPU were added in edk2-platforms. To support qemu virt, they need to be added in BaseLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Daniel Schaefer Signed-off-by:

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 02/29] MdePkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL. Add this protocol GUID definition and the header file required. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sunil V L --- MdePkg/MdePkg.dec

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 01/29] MdePkg/Register: Add register definition header files for RISC-V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Add register definitions and access routines for RISC-V. These headers are leveraged from opensbi repo. Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Sunil V L --- .../Include/Register/RiscV64

[edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH 00/29] Add support for RISC-V virt machine

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 Add support for RISC-V qemu virt machine. Most of the changes are migrated from edk2-platforms repo and followed the latest guidelines for EDK2 code structuring. The changes at a high level are, 1) MdePkg: - Add RISC-V register de

Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

+ Ray Ni + Zhichao Gao as the patch wasn't sent to them. On 10/10/22 11:20, PierreGondois via groups.io wrote: From: Pierre Gondois The ACPI specification updated some terms in accordance with: s1.1.1 Principle of Inclusive Terminology Update the PCCT parser accordincly with these new terms.

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

+ Matt @Matt DeVillier Does Ray's code work for you? On Mon, 10 Oct 2022 at 10:25, Ni, Ray wrote: > The logic I shared below is from the LogoDxe driver which produces > EDKII_PLATFORM_LOGO_PROTOCOL. > > This driver should know the image size and it can account for the image > size. > > > > Th

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

The logic I shared below is from the LogoDxe driver which produces EDKII_PLATFORM_LOGO_PROTOCOL. This driver should know the image size and it can account for the image size. Thanks, Ray From: Sean Rhodes Sent: Monday, October 10, 2022 4:51 PM To: Ni, Ray Cc: devel@edk2.groups.io; Gao, Zhichao

[edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

From: Pierre Gondois The ACPI specification updated some terms in accordance with: s1.1.1 Principle of Inclusive Terminology Update the PCCT parser accordincly with these new terms. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Pierre Gondois --- .../UefiShellAcpiViewCommandLib/Parsers/Pcct/Pcc

[edk2-devel] [PATCH 13/14] DynamicTablesPkg: Readme.md: Update available tables for generation

From: Pierre Gondois The following tables can now be generated by the DynamicTablesPkg: - PCCT - PPTT - SRAT Update the documentation accordingly. Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Readme.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/DynamicTablesPkg/Readme.md

[edk2-devel] [PATCH 12/14] DynamicTablesPkg/AmlLib: Allow larger AccessSize for Pcc address space

From: Pierre Gondois For Pcc address space, the AccessSize field of a Register is used to delcare the Pcc Subspace Id. This Id can be up to 256. Cf. ACPI 6.4, s14.7 Referencing the PCC address space Signed-off-by: Pierre Gondois --- .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c |

[edk2-devel] [PATCH 11/14] DynamicTablesPkg: Add PCCT Generator

From: Pierre Gondois The Platform Communication Channel Table (PCCT) generator collates the relevant information required for generating a PCCT table from configuration manager using the configuration manager protocol. The DynamicTablesManager then install the PCCT table. >From ACPI 6.4, s14 PLA

[edk2-devel] [PATCH 10/14] DynamicTablesPkg: Add PCCT related objects

From: Pierre Gondois Introduce the following CmObj in the ArmNameSpaceObjects: - CM_ARM_MAILBOX_REGISTER_INFO - CM_ARM_PCC_SUBSPACE_CHANNEL_TIMING_INFO - CM_ARM_PCC_SUBSPACE_GENERIC_INFO - CM_ARM_PCC_SUBPSACE_TYPE0_INFO - CM_ARM_PCC_SUBPSACE_TYPE1_INFO - CM_ARM_PCC_SUBPSACE_TYPE2_INFO - CM

[edk2-devel] [PATCH 09/14] DynamicTablesPkg: Fix Ssdt PCI generation comments

From: Pierre Gondois The second model of the _PRT object is used. Indeed: - the interrupts described are not re-configurable - OSes are aware of the polarity of PCI legacy interrupts, so there is no need to accurately describe the polarity. Also, fix a comment for the CM_ARM_PCI_INTERRUPT_MAP_

[edk2-devel] [PATCH 08/14] DynamicTablesPkg: FdtHwInfoParserLib: Remove wrong comment

From: Pierre Gondois commit 13136cc3111f ("DynamicTablesPkg: FdtHwInfoParserLib: Parse Pmu info") adds support for pmu parsing. Thus, remove the wrong comment. Signed-off-by: Pierre Gondois --- .../Library/FdtHwInfoParserLib/Gic/ArmGicCParser.c | 3 --- .../Library/FdtHwInfoParserL

[edk2-devel] [PATCH 07/14] DynamicTablesPkg: Remove deprecated APIs

From: Pierre Gondois commit 691c5f776274 ("DynamicTablesPkg: Deprecate Crs specific methods in AmlLib") deprecates some APIs. Finally remove them. Signed-off-by: Pierre Gondois --- .../Include/Library/AmlLib/AmlLib.h | 138 -- .../Library/Common/AmlLib/Api/AmlApi.c

[edk2-devel] [PATCH 01/14] DynamicTablesPkg: Use correct print formatter

From: Pierre Gondois In C, the 'long long' types are 64-bits. The 'll' printf length specifier should be used to pring these values. Just '%x' allows to print values that are on 16-bits or more. Use that instead. Signed-off-by: Pierre Gondois --- .../ConfigurationManagerObjectParser.c

[edk2-devel] [PATCH 06/14] DynamicTablesPkg: Fix wrong/missing fields in CmObjParser

From: Pierre Gondois Add missing fields to the following CmObjParser objects: - EArmObjGicDInfo - EArmObjCacheInfo and fix wrong formatting of: - EArmObjLpiInfo Signed-off-by: Pierre Gondois --- .../ConfigurationManagerObjectParser.c| 24 ++- 1 file changed, 13 insertio

[edk2-devel] [PATCH 05/14] DynamicTablesPkg: Fix GTBlock and GTBlockTimerFrame CmObjParsers

From: Pierre Gondois The CmObjParsers of the following objects was inverted, probably due to a wrong ordering placement in the file defining the structures: -EArmObjGTBlockTimerFrameInfo -EArmObjPlatformGTBlockInfo Assign the correct parser for each object, and re-order the structures in the fil

[edk2-devel] [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision

From: Pierre Gondois commit 0d23c447d6f5 ("DynamicTablesPkg: Add support to specify FADT minor revision") adds new 'MinorRevision' field to CM_STD_OBJ_ACPI_TABLE_INFO. Reflect the change in this patch to the CmObjectParser. Signed-off-by: Pierre Gondois --- .../Common/TableHelperLib/Configurat

[edk2-devel] [PATCH 03/14] DynamicTablesPkg: Update CmObjParser for IORT Rev E.d

From: Pierre Gondois commit de200b7e2c3c ("DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.d") adds new CmObj structures and fields to the ArmNameSpaceObjects. Update the CmObjectParser accordingly. Signed-off-by: Pierre Gondois --- .../ConfigurationManagerObjectParser.c| 5

[edk2-devel] [PATCH 02/14] DynamicTablesPkg: Add PrintString to CmObjParser

From: Pierre Gondois Add a PrintString to print strings in the CmObjParser. String must be NULL terminated and no buffer overrun check is done by this function. Signed-off-by: Pierre Gondois --- .../ConfigurationManagerObjectParser.c| 26 +++ 1 file changed, 26 insertio

[edk2-devel] [PATCH 00/14] Add PCCT generator and various fixes

From: Pierre Gondois The Platform Communications Channel Table (Pcct) allows to communicate by describing mailboxes. Make use of the DynamicTablesPkg to generate this table. This patch-set also contains: - Fixes for the CmObjParser, - Removal of deprecated APIs - Renaming for some of the PCCT fi

Re: [edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: fix pci DT node address in SyncPcie()

On Fri, 7 Oct 2022 at 22:39, Jeremy Linton wrote: > > Hi, > > On 10/6/22 12:46, Adrien Thierry wrote: > > To make sure the XHCI controller does not get reset by Linux in DT mode, > > we remove its pci parent node from the device tree. However, the pci > > node address has been updated in the Raspb

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Hi Ray Thank you, it does, and I think it will work for most splash images. However, the way it's written in my patch accounts for the Image size. This will handle splash images that are equal to, or larger than the resolution of the display. Thanks Sean On Sat, 8 Oct 2022 at 03:02, Ni, Ray wr

Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

Hi liming: I checked the code, and found the root cause of the issue. As the following code in edk2,   in my code,  after the  first time to read the variable in PEI phase,  it cached the variable store info  IndexTable into  a Hob in a special non-volatile memory,  but after the code running in

  1   2   >