Pushed as ad00518399..45c2015953
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Monday, October 10, 2022 1:59 PM
To: devel@edk2.groups.io; mikub...@linux.microsoft.com
Cc: S, Ashraf Ali <ashraf.al...@intel.com>; Chaganty, Rangasai V
<rangasai.v.chaga...@intel.com>; Ni, Ray <ray...@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1]
IntelSiliconPkg/SpiFvbService: Read FV header length from header
Reviewed-by: Isaac Oram <isaac.w.o...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Wednesday, October 5, 2022 8:23 AM
To: devel@edk2.groups.io
Cc: S, Ashraf Ali <ashraf.al...@intel.com>; Oram, Isaac W
<isaac.w.o...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>;
Ni, Ray <ray...@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1]
IntelSiliconPkg/SpiFvbService: Read FV header length from header
From: Michael Kubacki <michael.kuba...@microsoft.com>
Bug Fix: Read the FV header length from the Firmware Volume Block
(FVB) information structure as opposed to EFI_FIRMWARE_VOLUME_HEADER to account
for a variable number of block map entries.
Cc: Ashraf Ali S <ashraf.al...@intel.com>
Cc: Isaac Oram <isaac.w.o...@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaga...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
---
Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c
b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c
index 634a44218c7a..ab1cb2ef1622 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.
+++ c
@@ -115,7 +115,7 @@ GetFvbInfo (
Status = mFvbMediaInfoGenerators[Index](&FvbMediaInfo);
ASSERT_EFI_ERROR (Status);
if (!EFI_ERROR (Status) && (FvbMediaInfo.BaseAddress == FvBaseAddress)) {
- FvHeader = AllocateCopyPool (sizeof (EFI_FIRMWARE_VOLUME_HEADER),
&FvbMediaInfo.FvbInfo);
+ FvHeader = AllocateCopyPool (FvbMediaInfo.FvbInfo.HeaderLength,
+ &FvbMediaInfo.FvbInfo);
//
// Update the checksum value of FV header.
--
2.28.0.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94758): https://edk2.groups.io/g/devel/message/94758
Mute This Topic: https://groups.io/mt/94137814/1492418
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.o...@intel.com]
-=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94953): https://edk2.groups.io/g/devel/message/94953
Mute This Topic: https://groups.io/mt/94137814/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
