Re: [edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000

I agree this is good, but an alternate option is to EfiBootManagerGetBootManagerMenu(), as I've implemented here: https://edk2.groups.io/g/devel/topic/84876596. Then, the boot menu is guaranteed to have it's boot option. However, as Nate mentioned, there's the issue of https://github.com/tiano

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add code coverage support for GCC

@Sean Brogan I go through the code Merged PR 5008: Initial implementation or code coverage on basecore u… · microsoft/mu_basecore@f6af51f (github.com)

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add code coverage support for GCC

For local scenarios the plug-in generates the html report for viewing the c code with coverage annotations. The intermediate files are available so I would think they could be loaded in all sorts of viewers but I haven’t tried. I have just used the html and it seemed acceptable. For ci the pip

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add code coverage support for GCC

Does that pytool plugin support viewing the code coverage visually in C source files? Either HTML or preferably an Visual Studio Code plugin? Can it be updated to support VS compilers tool? Mie From: Sean Brogan Sent: Tuesday, September 13, 2022 6:18 PM To: devel@edk2.groups.io; Guo, Gua Cc:

Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Yao, Jiewen > Sent: Thursday, September 8, 2022 2:11 PM > To: devel@edk2.groups.io; Luo, Heng > Cc: Wang, Jian J ; Gao, Liming > ; Liu, Zhiguang ; Bi, > Dandan ; Zeng, Star ; Gao, > Zhichao > Subject: RE: [edk2-deve

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add code coverage support for GCC

Hi Gua Guo, I would propose that we make this easier for both the local user and the CI system to get coverage metrics. Can you review this commit as it uses the same Edk2 plugins but adds code coverage support with GCC5: Merged PR 5008: Initial implementation or code coverage on basecore u

[edk2-devel] [PATCH v2] UnitTestFrameworkPkg: Add code coverage support for GCC

From: Gua Guo In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Gua Guo --- UnitTestFramework

Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

Series-Reviewed-by: Pedro Falcato On Tue, Sep 13, 2022 at 10:32 PM Theo Jehl wrote: > QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64 > It can boots UEFI Linux and Windows, and works on PIIX4 and Q35 > This board port provides a simple starting place for investigating edk2 and > MinPlat

Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

Series Acked-by: Michael D Kinney > -Original Message- > From: Oram, Isaac W > Sent: Tuesday, September 13, 2022 2:46 PM > To: Theo Jehl ; devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > ; Pedro Falcato > ; Gerd Hoffmann ; Stefan Hajnoczi > > Subject: RE: [edk2-devel][e

Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

Series Reviewed-by: Isaac Oram -Original Message- From: Theo Jehl Sent: Tuesday, September 13, 2022 2:32 PM To: devel@edk2.groups.io Cc: Leif Lindholm ; Kinney, Michael D ; Oram, Isaac W ; Pedro Falcato ; Gerd Hoffmann ; Stefan Hajnoczi Subject: [edk2-devel][edk2-platforms][PATCH V3

[edk2-devel][edk2-platforms][PATCH V3 4/4] QemuOpenBoardPkg: Enable stage 4

Enable MinPlatform stage 4 (OS boot) functionality. It adds ACPI, SMBIOS and SMM drivers required for stage 4. This should boot Windows and Linux with PIIX4 or Q35 configurations. In the current state, SMM only works on Qemu Q35 system if you set SMM_REQUIRED = TRUE in QemuOpenBoardPkg.dsc or via c

[edk2-devel][edk2-platforms][PATCH V3 3/4] QemuOpenBoardPkg: Enable stage 3

This patch adds MinPlatform stage 3 (UEFI boot) functionality Stage 3 adds DxeMain, drivers and modules necessary to reach UEFI shell. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Isaac Oram Cc: Pedro Falcato Cc: Gerd Hoffmann Cc: Stefan Hajnoczi Signed-off-by: Theo Jehl --- .../Include/Dsc

[edk2-devel][edk2-platforms][PATCH V3 2/4] QemuOpenBoardPkg: Enable stage 2

Enables MinPlatform stage 2 (memory init) functionality. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Isaac Oram Cc: Pedro Falcato Cc: Gerd Hoffmann Cc: Stefan Hajnoczi Signed-off-by: Theo Jehl --- .../Include/Dsc/Stage2.dsc.inc| 31 +++ .../QemuOpenBoardPkg/

[edk2-devel][edk2-platforms][PATCH V3 1/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

QemuOpenBoardPkg adds a MinPlatform port to QEMU x86_64. This port brings a starting place for understanding the MinPlatform, and board porting. This patch adds the base for QemuOpenBoardPkg. It also enables MinPlatform stage 1 (debug) functionality which includes serial debug messages. Cc: Leif

[edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg

QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64 It can boots UEFI Linux and Windows, and works on PIIX4 and Q35 This board port provides a simple starting place for investigating edk2 and MinPlatform Arch. Currently we implement up to stage 4 of the MinPlatform spec and can boot Windows/Lin

[edk2-devel] [PATCH v2 0/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000

This version has the fix for previous coding style. Code changes can be found here: https://github.com/JamesWangAmiTw/edk2-platforms/tree/F7OverwriteBoot James Wang (1): BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardB

[edk2-devel] [PATCH v2 1/1] BoardModulePkg/BoardBdsHookLib: Fix F7 overwrites Boot0000

Check if mBootMenuOptionNumber is valid or not before calling RegisterBootOptionHotkey to avoid overwriting Boot Cc: Eric Dong Cc: Isaac Oram Cc: Liming Gao Signed-off-by: James Wang --- Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c | 17 +++-- 1 fil

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Sure, thanks for replying quickly, let me update readme.md file in my next patch. -Original Message- From: Kinney, Michael D Sent: Tuesday, September 13, 2022 11:10 PM To: Guo, Gua ; devel@edk2.groups.io; Kinney, Michael D Cc: Sean Brogan ; Barkelew, Bret ; Michael Kubacki Subject:

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Is there a Visual Studio Code plugin to view the code coverage too? Thanks, Mike > -Original Message- > From: Guo, Gua > Sent: Tuesday, September 13, 2022 6:28 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Sean Brogan > ; Barkelew, Bret > ; Michael Kubacki > Subject: RE: [PA

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Hi, This change looks safe because it is scoped to host-based unit tests that include this file in the DSC file that builds host-based tests. Can you also update the UnitTestFrameworkPkg/ReadMe.md to describe how a developer can enable/use the code coverage feature for GCC host-based tests? Mike

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

Hi All I want to follow below steps to generate code coverage data based the default build. But I notice currently GCC compiler flags won't generate *gcda and *.gcno. So add the CC flags to generate necessary data that require by "lcov" tool. I'm not sure whether have any concern to add the fla

[edk2-devel] [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC

From: Gua Guo In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Gua Guo --- UnitTestFramework

Re: [edk2-devel] [edk2-platforms][PATCH V1 06/16] Platform/Loongson: Add StableTimerLib.

Hi，Mike: "I see a mix of inline assembly and .S files. Recommend avoiding inline assembly." I think I misunderstood the meaning of your sentence,I'll re-explain it here: Instructions such as csrrd and csrwr require immediate numbers in their operands, which means that instructions like c

[edk2-devel] [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 4/4] Clean up header file inclusion

From: Abner Chang Remove the header files those are already included in CpuFeatureLib.h. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Garrett Kirkendall Cc: Paul Grimes Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Library/SmmCpuFeaturesLib/X86/SmmStm.c | 3 --- 1 file

[edk2-devel] [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 3/4] Relocate STM files

From: Abner Chang Relocate STM related files to under \X86. Those are mainly for X86 Intel. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Garrett Kirkendall Cc: Paul Grimes Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf

[edk2-devel] [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 2/4] Abstract arch dependent code

From: Abner Chang This change strips away Intel X86 implementation to a separate file under \X86. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Garrett Kirkendall Cc: Paul Grimes Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 6 +-

[edk2-devel] [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 1/4] Add X86 folder

From: Abner Chang 1. Add X86 folder under SmmCpuFeaturesLib to accommodate X86 implementation. 2. Move Ia32 and X64 to under \X86. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Garrett Kirkendall Cc: Paul Grimes Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar --- .../SmmCpuFeaturesLi

[edk2-devel] [edk2-staging/SmmCpuFeaturesLib_AMD][PATCH 0/4] Reconstruction on SmmCpuFeaturesLib

From: Abner Chang This is the reconstruction on SmmCpuFeaturesLib to accommodate AMD implementation of SmmCpuFeaturesLib. A new folder \X86 under SmmCpuFeaturesLib is created for X86 architecture, this gives SmmCpuFeaturesLib a well folder structure for not only X86 but also for other processor a

Re: [edk2-devel] [PATCH] MdeModulePkg SmbiosMeasurementDxe: Add Type4 CurrentSpeed to filter table

Reviewed-by: James Lu -Original Message- From: devel@edk2.groups.io On Behalf Of Heng Luo Sent: Thursday, September 8, 2022 1:41 PM To: devel@edk2.groups.io Cc: Wang, Jian J ; Gao, Liming ; Liu, Zhiguang ; Bi, Dandan ; Zeng, Star ; Gao, Zhichao Subject: [edk2-devel] [PATCH] MdeModule