Hi, This change looks safe because it is scoped to host-based unit tests that include this file in the DSC file that builds host-based tests.
Can you also update the UnitTestFrameworkPkg/ReadMe.md to describe how a developer can enable/use the code coverage feature for GCC host-based tests? Mike > -----Original Message----- > From: Guo, Gua <gua....@intel.com> > Sent: Tuesday, September 13, 2022 6:24 AM > To: devel@edk2.groups.io > Cc: Guo, Gua <gua....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; > Barkelew, > Bret <bret.barke...@microsoft.com>; Michael Kubacki > <mikub...@linux.microsoft.com> > Subject: [PATCH] UnitTestFrameworkPkg: Add code coverage support for GCC > > From: Gua Guo <gua....@intel.com> > > In order to collect code coverage after running executable > file, generate *.gcda and *.gcno file that require by lcov tool > to generate code coverage report. > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Sean Brogan <sean.bro...@microsoft.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Cc: Michael Kubacki <mikub...@linux.microsoft.com> > Signed-off-by: Gua Guo <gua....@intel.com> > --- > UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > index 4dd8d4ac67..8623aecb33 100644 > --- a/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > +++ b/UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc > @@ -19,7 +19,7 @@ > > MemoryAllocationLib|UnitTestFrameworkPkg/Library/Posix/MemoryAllocationLibPosix/MemoryAllocationLibPosix.inf > > > > [BuildOptions] > > - GCC:*_*_*_CC_FLAGS = -fno-pie > > + GCC:*_*_*_CC_FLAGS = -fno-pie -ftest-coverage -fprofile-arcs > > !ifdef $(UNIT_TESTING_DEBUG) > > MSFT:*_*_*_CC_FLAGS = -D UNIT_TESTING_DEBUG=1 > > GCC:*_*_*_CC_FLAGS = -D UNIT_TESTING_DEBUG=1 > > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93716): https://edk2.groups.io/g/devel/message/93716 Mute This Topic: https://groups.io/mt/93654981/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
