[edk2-devel] [PATCH v4 26/28] OvmfPkg: Add ProtectedVariableLib reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1 fil

[edk2-devel] [PATCH v4 27/28] OvmfPkg: Add ProtectedVariable reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1 fil

[edk2-devel] [PATCH v4 28/28] IntelTdx: Add ProtectedVariable reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/IntelTdx/IntelTdxX64.dsc | 1 + 1 file c

[edk2-devel] [PATCH v4 25/28] OvmfPkg: Add ProtectedVariableLib reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc |

[edk2-devel] [PATCH v4 24/28] OvmfPkg: Add ProtectedVariableLib reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Jiewen Yao Cc: Min Xu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Tom Lendacky Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C M

[edk2-devel] [PATCH v4 23/28] OvmfPkg: Add ProtectedVariable reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah V

[edk2-devel] [PATCH v4 21/28] UefiPayloadPkg: Add ProtectedVariable reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib so build is successful. Cc: Jian J Wang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry

[edk2-devel] [PATCH v4 22/28] EmulatorPkg: Add ProtectedVariable reference

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to null ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3 ++-

[edk2-devel] [PATCH v4 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib otherwise build fails. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- ArmVi

[edk2-devel] [PATCH v4 19/28] SecurityPkg: Add references to new *.inf files

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add references to the different *ProtectedVariableLib.inf. Also add references to VariableKeyLibNull.inf, EncryptionVariableLibNull.inf, ProtectedVariableNull.inf. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J

[edk2-devel] [PATCH v4 17/28] SecurityPkg: Add EncryptionVariable lib with AES

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Change AllocateZeroPool() with AllocatePages() and FreePool() with FreePages(). FreePool() is not supported in PEI phase so this was causing a memory leak. Reverse the order of the FreePages() call. V1: Add encryption/decryption of prot

[edk2-devel] [PATCH v4 15/28] SecurityPkg: Add null encryption variable libs

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review - Remove empty Guids section from .inf file. Update description in *.c. Remove *.uni file and reference to it. V1: Provide null ecryption variable libraries. These will be used by default for platforms that don't sup

[edk2-devel] [PATCH v4 16/28] SecurityPkg: Add VariableKey library function

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide function that retrieves the key for protected variables. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/Variabl

[edk2-devel] [PATCH v4 13/28] SecurityPkg: Update RPMC APIs with index

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Update RPMC APIs with index parameter because sometimes there are more than 1 RPMC counter on the platform. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: J

[edk2-devel] [PATCH v4 14/28] SecurityPkg: Fix GetVariableKey API

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review - function comments need to match function prototype. V1: Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Ni

[edk2-devel] [PATCH v4 12/28] SecurityPkg: Add new variable types and functions

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new variable encryption/decryption function prototypes. Add new variable digest structure. Add new Protected variable function prototypes. Update RPMC APIs to Add an index because there is could more than one counter. Cc: Jian J Wang C

[edk2-devel] [PATCH v4 11/28] SecurityPkg: Add new KeyService types and defines

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: revert copyright date change. V1: Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Inc

[edk2-devel] [PATCH v4 10/28] SecurityPkg: Add new GUIDs for

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 The gEdkiiProtectedVariableGlobalGuid HOB contains the global configuration data structure which is verified in PEI Phase. The gEdkiiMetaDataHmacVariableGuid is used for saving the meta data HMAC variable. The gEdkiiProtectedVariableContextG

[edk2-devel] [PATCH v4 09/28] MdeModulePkg: Reference Null ProtectedVariableLib

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib. The null ProtectedVariableLib is used by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang

[edk2-devel] [PATCH v4 05/28] MdeModulePkg: Add new GUID for Variable Store Info

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Discover if Variable Store Info HOB has been published by platform driver. It contains information in regards to HOB or NV Variable Store availability Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed

[edk2-devel] [PATCH v4 07/28] MdeModulePkg: Add new Variable functionality

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V3: Update GetNvVariableStore() to call GetVariableFlashNvStorageInfo() and SafeUint64ToUint32(). V1: Provide new APIs for retrieving variable information. Add new function stubs for retrieving Protected variable information. Cc: Jian J Wa

[edk2-devel] [PATCH v4 06/28] MdeModulePkg: Add Null ProtectedVariable Library

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Applied code review comments - removed APIs that are not being used. V1: Add Null versions of the ProtectedVariable Library. This will be the default libraries for platforms that do not support ProtectedVariable. Cc: Jian J Wang Cc: L

[edk2-devel] [PATCH v4 03/28] MdeModulePkg: Add new ProtectedVariable GUIDs

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 New ProtectVariable GUIDs for passing variable information from PEI phase to SMM phase. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signed-off-by: Judah Vang Reviewed-

[edk2-devel] [PATCH v4 02/28] MdeModulePkg: Add reference to new Ppi Guid

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid which contains information whether variable store is available. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C Mistry Signe

[edk2-devel] [PATCH v4 04/28] MdeModulePkg: Add new include files

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 V4: Updated with review comments for misspellings, mismatch function prototype, missing function header comments, incorrect function description. V1: Add EncryptionVariableLib.h for providing encryption and decryption services for protected

[edk2-devel] [PATCH v4 01/28] MdeModulePkg: Update AUTH_VARIABLE_INFO struct

2022-08-10 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Added NameSize and State to AUTH_VARIABLE_INFO struct. The size of the name and state is needed when creating the variable digest. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Jian J Wang Signed-off-by: Nishant C M

[edk2-devel] [PATCH v4 00/28] UEFI variable protection

2022-08-10 Thread Judah Vang
Patch 04 - Updated with code review for misspellings, mismatch function prototype, missing function header comments, incorrect function description. Patch 06 - Applied code review - removed APIs that are not being used. Patch 08 - Applied code review - remove unreferenced library from *.inf. Upda

[edk2-devel] [PATCH] UefiPayloadPkg: Fix Coverity report defect

2022-08-10 Thread GregX Yeh
From: Gregx Yeh https://bugzilla.tianocore.org/show_bug.cgi?id=4018 Coverity report FORWARD_NULL and OVERFLOW_BEFORE_WIDEN potential defect in UefiPayloadPkg. Signed-off-by: Gregx Yeh Cc: Guo Dong Cc: Ray Ni --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++-- UefiPayload

[edk2-devel] [edk2-platforms PATCH v1 1/1] RISC-V/RiscVExceptionLib: Follow new CpuExceptionHandlerLib APIs

2022-08-10 Thread Daniel Schaefer
CpuExceptionHandlerLib (in EDK2) has been refactored with following changes 1. Removed InitializeCpuInterruptHandlers in 2a09527ebcb459b40 2. Removed InitializeCpuExceptionHandlersEx and added InitializeSeparateExceptionStacks in e7abb94d1fb8a0e7 The patch updates RISC-V version of CpuException

[edk2-devel] [PATCH] UefiPayloadPkg: Fix Coverity report defect

2022-08-10 Thread GregX Yeh
From: Gregx Yeh https://bugzilla.tianocore.org/show_bug.cgi?id=4018 Coverity report FORWARD_NULL and OVERFLOW_BEFORE_WIDEN potential defect in UefiPayloadPkg. Signed-off-by: Gregx Yeh --- UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++-- UefiPayloadPkg/PayloadLoaderPeim/ElfL

Re: [edk2-devel] [Patch V3 0/2] Remove mInternalCr3 and Add a new mIsShadowStack

2022-08-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Thursday, August 11, 2022 11:51 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/2] Remove mInternalCr3 and Add a new > mIsShadowStack > > Modify type of mIsShadowStack to

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

2022-08-10 Thread Kun Qin
Thank you for the review, Daniel! Regards, Kun On 8/10/2022 8:02 PM, Daniel Schaefer wrote: Hi Kun, sorry for the late reply. The change is okay - thanks for making sure to change this platform, too! Reviewed-by: Daniel Schaefer Thanks, Daniel On 8/11/22 06:52, Kun Qin wrote: Hi U5SeriesP

[edk2-devel] [Patch V3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove mInternalCr3 in PiSmmCpuDxeSmm

2022-08-10 Thread duntan
This patch is code refactoring and doesn't change any functionality. Remove mInternalCr3 in PiSmmCpuDxe pagetable related code. In previous code, mInternalCr3 is used to pass address of page table which is different from Cr3 register in different level of SetMemoryAttributes function. Now remove it

[edk2-devel] [Patch V3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add a new mIsShadowStack flag

2022-08-10 Thread duntan
This patch is code refactoring and doesn't change any functionality. Add a new mIsShadowStack flag to identify whether current memory is shadow stack. Previous smm code logic regards a RO range as shadow stack and set the dirty bit in corresponding page table entry if mInternalCr3 is not 0, which m

[edk2-devel] [Patch V3 0/2] Remove mInternalCr3 and Add a new mIsShadowStack

2022-08-10 Thread duntan
Modify type of mIsShadowStack to BOOLEAN. Move m5LevelPagingNeeded from X64 file to common file to fix IA32 build failure Dun Tan (2): UefiCpuPkg/PiSmmCpuDxeSmm: Add a new mIsShadowStack flag UefiCpuPkg/PiSmmCpuDxeSmm: Remove mInternalCr3 in PiSmmCpuDxeSmm UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/Page

Re: [edk2-devel] [PATCH v4 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-08-10 Thread Daniel Schaefer
Hi Oliver, I assume you made sure that the build still works on at least one platform per arch? For example did you build a RISCV64 platform? Thanks, Daniel On 8/10/22 20:03, Oliver Steffen wrote: > Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop > downloading gcc from external locations;

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported

2022-08-10 Thread Igor Kulchytskyy via groups.io
Hi Abner, I had the issues when I tried to check third patch with PatchCheck.py. And I've only fixed them and sent it now. Thank you, Igor From: Chang, Abner Sent: Wednesday, August 10, 2022 8:33 PM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: nickle.w...@hpe.com Subject: RE: [EXTERNAL] RE: [

[edk2-devel] [PATCH V2] RedfishPkg: Redfish functions for REST requests are not fully spec complied

2022-08-10 Thread Igor Kulchytskyy via groups.io
There is no function to send POST request with the ContentType different from "application\json". There is no function to send DELETE request with the body. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishLib.h

Re: [edk2-devel] [PATCH 00/14] Introduce Lazy-accept for Tdx guest

2022-08-10 Thread Min Xu
Hi, All Since the lazy-accept patch-set was sent for review, there are a lot of discussions in multiple OpenSource-Communities (EDK2/QEMU/LinuxKernel). Below are the summaries of the discussions/proposals 1. Accept memory under 4G - Tom Lendacky's suggestion for SEV-SNP is to pre-accept all me

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

2022-08-10 Thread Daniel Schaefer
Hi Kun, sorry for the late reply. The change is okay - thanks for making sure to change this platform, too! Reviewed-by: Daniel Schaefer Thanks, Daniel On 8/11/22 06:52, Kun Qin wrote: > Hi U5SeriesPkg maintainers, > > Can you please review the patch below and let me know if any feedback? > P

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL

2022-08-10 Thread Liu, KasimX
Hi @Ni, Ray Thanks for the reply and reviewed-by. I've created the PR, could you help me add push label when you're available. I think we're better to check in the solution. https://github.com/tianocore/edk2/pull/3188 -Original Message- From: Guo, Gua Sent: Wednesday, August 10, 2022

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL

2022-08-10 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Ni, Ray Sent: Wednesday, August 10, 2022 1:30 PM To: Liu, KasimX ; devel@edk2.groups.io Cc: Dong, Guo ; Lu, James ; Guo, Gua Subject: RE: [PATCH v2] MdeModulePkg: Update the SMBIOS version by UPL Reviewed-by: Ray Ni > -Original Mess

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to control NvmExpressDxe

2022-08-10 Thread Guo, Gua
Reviewed-by: Gua Guo -Original Message- From: Sravanthi, K KavyaX Sent: Wednesday, August 10, 2022 4:37 PM To: devel@edk2.groups.io Cc: Sravanthi, K KavyaX ; Dong, Guo ; Ni, Ray ; Rhodes, Sean ; Guo, Gua Subject: [PATCH] UefiPayloadPkg: Add macro to control NvmExpressDxe Add NVME_EN

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported

2022-08-10 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Igor, you sent two patches or three? Seems I only got two patches. If you missed the third one, then please resend it with the prefix [PATCH V2 RESEND]. And please also have the numbered patch such as 1/3, 2/3 and 3/3, you can have the numbered patch using

Re: [edk2-devel] [edk2-platforms][PATCH v4 4/6] Socionext: Platform Build: Resolving newly introduced dependency

2022-08-10 Thread Kun Qin
Hi Ard, Could you please help review this patch? Any feedback in appreciated. Regards, Kun On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote: The new changes in SecureBootVariableLib brought in a new dependency of PlatformPKProtectionLib. This change added the new library instance from Securit

Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency

2022-08-10 Thread Kun Qin
Hi U5SeriesPkg maintainers, Can you please review the patch below and let me know if any feedback? Platform build could be broken without this change. Any input is appreciated. Regards, Kun On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote: The new changes in SecureBootVariableLib brought in a

[edk2-devel][edk2-platforms][PATCH V1 0/3] Update PlatformPayloadPkg to match feature conventions

2022-08-10 Thread Oram, Isaac W
The integration of the PlatformPayloadPkg breaks the AdvancedFeaturePkg build. The first patch fixes the build issue with executing build -a IA32 -a X64 -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc The PlatformPayloadPkg doesn't match advanced feature build and naming conventions. The second p

[edk2-devel][edk2-platforms][PATCH V1 3/3] PlatformPayloadFeaturePkg: Update contents to match feature conventions

2022-08-10 Thread Oram, Isaac W
Rename gPlatformPayloadPkgTokenSpaceGuid to gPlatformPayloadFeaturePkgTokenSpaceGuid Rename PcdPayloadPackageFeatureEnable to PcdPlatformPayloadFeatureEnable Update Readme including format improvements Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by:

[edk2-devel][edk2-platforms][PATCH V1 1/3] PlatformPayloadPkg: Fix AdvancedFeaturePkg build issue

2022-08-10 Thread Oram, Isaac W
Feature packages should build with -a IA32 -a X64. The commonly board selected libraries were moved to the PlatformPayloadPkg build so as not to conflict with other advanced features. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by: Isaac Oram --- ...

[edk2-devel][edk2-platforms][PATCH V1 2/3] PlatformPayloadPkg: Rename to match other feature conventions

2022-08-10 Thread Oram, Isaac W
Rename PlatformPayloadPkg to PlatformPayloadFeaturePkg. Rename Package DEC, DSC, FDF and py scripts to match. Search and replace PlatformPayloadPkg with PlatformPayloadFeaturePkg. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Ray Ni Cc: Guo Dong Signed-off-by: Isaac Oram --- .../Inc

Re: [edk2-devel] [PATCH v3 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space

2022-08-10 Thread Kun Qin
Hi Pierre/Sami, Thanks for your feedback. We modified the routine to be based on `CM_ARM_PCI_CONFIG_SPACE_INFO` and sanity checked the table outputs from UEFI shell and verified the system bootabilty on VDK based ARM platform. The new patch can be found here: https://edk2.groups.io/g/devel/messa

Re: [edk2-devel] [PATCH v3 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed tables

2022-08-10 Thread Kun Qin
Hi Sami, Thanks for your Acks below. The updated patch is sent here: https://edk2.groups.io/g/devel/message/92317 Please let me know if there is any further feedback/issues. Regards, Kun On 8/9/2022 2:01 AM, Sami Mujawar wrote: Hi Kun, Please find my response inline marked [SAMI]. Regards,

[edk2-devel] [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 This change added a switch case handling for PCI_SS_CONFIG during SSDT generation. This will allow PCI config case return EFI_SUCCESS instead of EFI_INVALID_PARAMETER. Cc: Sami Mujawar Cc: Alexei Fedorov Co-authored-by: Joe Lopez Signed

[edk2-devel] [PATCH v4 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 Certain OSes will complain if the ECAM config space is not reserved in the ACPI namespace. This change adds a function to reserve PNP motherboard resources for a given PCI node. Co-authored-by: Joe Lopez Signed-off-by: Kun Qin --- Notes

[edk2-devel] [PATCH v4 3/6] DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 This change added more token fixers for other node types, including NamedComponentNode, RootComplexNode, and SmmuV3Node. The corresponding entries for tokenFixer functions table is also updated. Cc: Sami Mujawar Cc: Alexei Fedorov Co-au

[edk2-devel] [PATCH v4 4/6] DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed tables

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 This change added an extra step to allow check for installed ACPI tables. For FADT, MADT, GTDT, DSDT, DBG2 and SPCR tables, either pre-installed or supplied through AcpiTableInfo can be accepted. An extra check for FADT ACPI table existenc

[edk2-devel] [PATCH v4 2/6] DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 The content of token should be derived from the data section of the `CmObject` instead of the object itself. This change fixed the issue by dereferencing the token value from the data buffer of input CmObject. Cc: Sami Mujawar Cc: Alexei

[edk2-devel] [PATCH v4 1/6] DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 The DynamicPlatRepoLib has multiple reference to MemoryAllocationLib, such as DynamicPlatRepo.c and TokenMapper.c. Not including it in the library inf file could lead to potential build break. This change added the MemoryAllocationLib into

[edk2-devel] [PATCH v4 0/6] Enhance DynamicTablesPkg modules

2022-08-10 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998 This patch series is a follow-up of previous submission: https://edk2.groups.io/g/devel/message/91995 The main changes between

Re: [edk2-devel] [PATCH v1] From: Mateusz Mówka Subject: [edk2-libc] Add strnlen function wrapper

2022-08-10 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Mowka, Mateusz > Sent: Wednesday, August 10, 2022 2:24 AM > To: devel@edk2.groups.io > Cc: rebe...@nuviainc.com; Kinney, Michael D ; > Mowka, Mateusz > Subject: [PATCH v1] From: Mateusz Mówka Subject: > [edk2-libc] Add strn

[edk2-devel] [PATCH V2] RedfishPkg: Redfish third party modules may need to use the functions tat are currently private

2022-08-10 Thread Igor Kulchytskyy via groups.io
Definitions of the required functions to send requests to BMC are in the PrivateInclude folder. So, they cannot be used by the other packages. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/Include/Library/RedfishLib.h| 616 RedfishP

[edk2-devel] [PATCH V2] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported

2022-08-10 Thread Igor Kulchytskyy via groups.io
Host Interface details are described by the SMBIOS Type 43 table. The table is published by the RedfishHostInterfaceDxe driver. That driver supports PCI-E and USB host interface types. The table is comsumed by the RedfishGetHostInterfaceProtocolData function in the RedfishDiscoverDxe driver. The fu

Re: [edk2-devel] Building C static Library for UEFI

2022-08-10 Thread Ayush Singh
Hi Andrew. I did find out one solution that should work for Rust. The one I tried was number 3 [1]. Basically, you can use the native Windows target and it should be fine to link against. However, the C code I was trying to compile at that time (rust_test_helper), is not compatible with UEFI (u

[edk2-devel] [PATCH v4 3/4] CI: Use Fedora 35 container (Linux only)

2022-08-10 Thread Oliver Steffen
Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v4 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-08-10 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21 --

[edk2-devel] [PATCH v4 2/4] CI: add ~/.local/bin to PATH (Linux only)

2022-08-10 Thread Oliver Steffen
Fix pip install. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b/.azur

[edk2-devel] [PATCH v4 1/4] CI: don't force python verison (Linux only)

2022-08-10 Thread Oliver Steffen
Use the Python supplied by the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 1 + .azurepipelines/templates/pr-gate-steps.yml| 1 + 2 files changed, 2 insertions(+) diff --git a/.azurepipelines/templates/platform-build-ru

[edk2-devel] [PATCH v4 0/4] CI: Use Fedora 35 container for Linux jobs

2022-08-10 Thread Oliver Steffen
Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom containers. The container image provides the required compiler toolchains and Qemu for the supported architectures. These are then no longer downloaded at runtime, avoiding CI failures due to download errors. This approach also make

Re: [edk2-devel] [Patch V2 2/2] UefiPayloadPkg: Remove clearing CR0.WP when protecting pagetable

2022-08-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Wednesday, August 10, 2022 1:34 PM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Maurice > Ma ; You, Benjamin ; > Rhodes, Sean > Subject: [Patch V2 2/2] UefiPayloadPkg: Remove clearing CR0.WP when > protecting pa

Re: [edk2-devel] [Patch V2 1/2] MdeModulePkg/DxeIpl: Remove clearing CR0.WP when protecting pagetable

2022-08-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Wednesday, August 10, 2022 1:34 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming > ; Ni, Ray > Subject: [Patch V2 1/2] MdeModulePkg/DxeIpl: Remove clearing CR0.WP > when protecting pagetable > > Remove cleari

Re: [edk2-devel] [Patch V2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove mInternalCr3 in PiSmmCpuDxeSmm

2022-08-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Wednesday, August 10, 2022 1:37 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R > Subject: [edk2-devel] [Patch V2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: > Remove mInter

[edk2-devel] [PATCH v1] From: Mateusz Mówka Subject: [edk2-libc] Add strnlen function wrapper

2022-08-10 Thread mateusz-mowka
This patch adds strnlen function wrapper that internally calls AsciiStrnLenS defined in BaseLib. Signed-off-by: Mateusz Mówka --- StdLib/Include/string.h | 11 +++ StdLib/LibC/String/Misc.c | 14 ++ 2 files changed, 25 insertions(+) diff --git a/StdLib/Include/string.h b/S

Re: [edk2-devel] [PATCH v3 5/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM space

2022-08-10 Thread PierreGondois
On 8/8/22 17:39, Sami Mujawar wrote: Hi Kun, I have just tried testing your patch with Kvmtool guest firmware and think this patch may need some modifications. Also, the patch 4/6 may need some adjustment, which I will reply back on that patch separately. Regards, Sami Mujawar On 08/08/

[edk2-devel] [PATCH] UefiPayloadPkg: Add macro to control NvmExpressDxe

2022-08-10 Thread kavya
Add NVME_ENABLE macro to control NvmExpressDxe driver. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: Gua Guo Signed-off-by: Kavya --- UefiPayloadPkg/UefiPayloadPkg.dsc | 3 +++ UefiPayloadPkg/UefiPayloadPkg.fdf | 2 ++ 2 files changed, 5 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPk

[edk2-devel] [PATCH v1 1/1] OvmfPkg: increase max debug message length to 512

2022-08-10 Thread Oliver Steffen
From: Laszlo Ersek Increase the maximum line length for debug messages. While log messages should be short, they can still get quite long, for example when printing device paths or config strings in HII routing. 512 chars is an empirically good value. Signed-off-by: Laszlo Ersek Signed-off-by:

[edk2-devel] [PATCH v1 0/1] OvmfPkg: increase max debug message length to 512

2022-08-10 Thread Oliver Steffen
Increase the maximum line length for debug messages. While log messages should be short, they can still get quite long, for example when printing device paths or config strings in HII routing. 512 chars is an empirically good value. This change has been proposed aleady a few years ago. I am repost

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Enhance bus scan for all root bridge instances

2022-08-10 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Foster > Nong > Sent: Friday, July 22, 2022 5:10 PM > To: devel@edk2.groups.io > Cc: Nong, Foster > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: Enhance bus scan for all > root bridge instances > > Re