[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 06/02/2022 #cal-reminder

2022-06-02 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* 06/02/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 06/02/2022 #cal-reminder

2022-06-02 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* 06/02/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/AmdSev: remove unused SMM bits from .dsc and .fdf files

2022-06-02 Thread Dov Murik
Gerd, thanks for the cleanup. Tested-by: Dov Murik Reviewed-by: Dov Murik On 02/06/2022 12:11, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 47 > OvmfPkg/AmdSev/AmdSevX64.fdf | 15 > 2 files cha

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 06/02/2022 #cal-reminder

2022-06-02 Thread Group Notification
*Reminder: TianoCore Community Meeting - EMEA / NAMO* *When:* 06/02/2022 9:00am to 10:00am (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-84

[edk2-devel] [PATCH] fix: F7 key can register Boot0000 if error happens getting mBootMenuOptionNumber

2022-06-02 Thread JamesWang [王家明] via groups . io
From: JamesWang --- .../Library/BoardBdsHookLib/BoardBootOption.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c b/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/Boa

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 06/02/2022 #cal-reminder

2022-06-02 Thread Group Notification
*Reminder: TianoCore Community Meeting - EMEA / NAMO* *When:* 06/02/2022 9:00am to 10:00am (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-84

Re: [edk2-devel] gcc 12, RiscV64 fence.i instruction missing

2022-06-02 Thread Daniel Schaefer
Hi Steffen, No, I don't think we've tried GCC12 yet. Hm, I don't quite understand the bug report but it sounds like something that'll be fixed by GCC? Thanks, Daniel From: devel@edk2.groups.io on behalf of Oliver Steffen Sent: Thursday, June 2, 2022 21:50 To:

Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseLib: Add CRC16-ANSI and CRC32c implementations

2022-06-02 Thread Pedro Falcato
Hi Liming, No problem. CRC32c is a CRC32 variant with a different polynomial, so unfortunately we can't reuse the current mCrcTable. Note that technically we could further optimize the CRC32c code to detect and use the current Intel and ARM CRC32c extensions' instructions, but I didn't bother as

Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Ard Biesheuvel
On Thu, 2 Jun 2022 at 15:15, Gerd Hoffmann wrote: > > Hi, > > > I did a quick test with both ArmVirtQemu and microvm (using this > > series but omitting the MdeModulePkg), and I can confirm that not > > having a I/O resource window at all seems to work fine if none of the > > PCI devices have I/

[edk2-devel] gcc 12, RiscV64 fence.i instruction missing

2022-06-02 Thread Oliver Steffen
Hi, has anyone tied building EDK2 (e.g. MdePkg) for RiscV64 with gcc 12? I get: /edk2/Build/Mde/DEBUG_GCC5/RISCV64/MdePkg/Library/BaseLib/BaseLib/OUTPUT/RiscV64/FlushCache.:16: Error: unrecognized opcode `fence.i' I found this gcc bug: Bug 104853 - [RISC-V] -march=rv64g not including extens

Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Gerd Hoffmann
Hi, > I did a quick test with both ArmVirtQemu and microvm (using this > series but omitting the MdeModulePkg), and I can confirm that not > having a I/O resource window at all seems to work fine if none of the > PCI devices have I/O BARs. > > Gerd, do you remember why exactly this patch is nee

Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Ard Biesheuvel
On Thu, 2 Jun 2022 at 12:14, Ni, Ray wrote: > > Gerd, > The fix should work. But I am curious why the if in blow is not hit. > https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c#L922 > > The RootBridge->ResAllocNode[TypeIo].Status is assigned as Res

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/Microvm: drop CODE and VARS files

2022-06-02 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, June 2, 2022 5:35 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Oliver Steffen > ; Gerd Hoffmann ; Ard Biesheuvel > ; Justen, Jordan L ; > Pawel Polawski > Subject: [PATCH 1/1] OvmfPkg/Microvm: drop CO

Re: [edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Ni, Ray
Gerd, The fix should work. But I am curious why the if in blow is not hit. https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c#L922 The RootBridge->ResAllocNode[TypeIo].Status is assigned as ResNone in: https://github.com/TianoCore/edk2/blob/master/M

Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Ni, Ray
> This doesn't work currently because the code > considers a pcie host bridge without I/O window a hard failure even in > case there are no I/O allocation requests. For fixing that the five > lines above should be enough I think. That's a real bug we should fix. I agree!! -=-=-=-=-=-=-=-=-=-=

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses

2022-06-02 Thread Yao, Jiewen
Sounds good, thanks! > -Original Message- > From: Boeuf, Sebastien > Sent: Thursday, June 2, 2022 5:29 PM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: kra...@redhat.com; Justen, Jordan L > Subject: Re: [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses > > On Thu, 2022-06-02 a

[edk2-devel] [PATCH 1/1] OvmfPkg/Microvm: drop CODE and VARS files

2022-06-02 Thread Gerd Hoffmann
microvm doesn't support pflash and loads the firmware via -bios, so we can't use the separate CODE and VARS files. Remove them. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.fdf | 26 -- 1 file changed, 26 deletions(-) diff --git a/OvmfPkg/Microvm/MicrovmX

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses

2022-06-02 Thread Boeuf, Sebastien
On Thu, 2022-06-02 at 11:04 +0200, Sebastien Boeuf wrote: > On Thu, 2022-06-02 at 08:57 +, Yao, Jiewen wrote: > > Acked-by: Jiewen Yao > > > > I notice the PR failed - > > https://github.com/tianocore/edk2/pull/2875 > > > > I just want to double confirm, do you have a success PR for this > >

Re: [edk2-devel] [PATCH 0/2] Fix 2 issues in TDVF

2022-06-02 Thread Yao, Jiewen
https://github.com/tianocore/edk2/pull/2937 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, June 2, 2022 4:48 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Aktas, Erdem ; Gerd Hoffmann > ; James Bottomley ; Tom Lendacky > > Subject: Re: [edk

[edk2-devel] [PATCH v2 1/1] OvmfPkg/AmdSev: remove unused SMM bits from .dsc and .fdf files

2022-06-02 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- OvmfPkg/AmdSev/AmdSevX64.dsc | 47 OvmfPkg/AmdSev/AmdSevX64.fdf | 15 2 files changed, 62 deletions(-) diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc index fc1fdb2e2297..6b3827f7f6ed 1006

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses

2022-06-02 Thread Boeuf, Sebastien
On Thu, 2022-06-02 at 08:57 +, Yao, Jiewen wrote: > Acked-by: Jiewen Yao > > I notice the PR failed - https://github.com/tianocore/edk2/pull/2875 > > I just want to double confirm, do you have a success PR for this > patch set? Let me repush the PR once rebased on latest master. I think the

Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

2022-06-02 Thread Ni, Ray
I guess this is to follow Liming's recommendation said in the bugzilla. But I don't understand why reset is better than deadloop(). reset IMO is a silent failure if S3Resume2 PPI doesn't exist. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: CloudHv: Reduce PIO and MMIO accesses

2022-06-02 Thread Yao, Jiewen
Acked-by: Jiewen Yao I notice the PR failed - https://github.com/tianocore/edk2/pull/2875 I just want to double confirm, do you have a success PR for this patch set? Thank you Yao Jiewen > -Original Message- > From: Boeuf, Sebastien > Sent: Tuesday, May 10, 2022 8:51 PM > To: devel@ed

Re: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3898 S3 Resume flow may result in executing garbage address.

2022-06-02 Thread cbduggap
HI all, Please help to review the changes Thanks, Chinni. -Original Message- From: devel@edk2.groups.io On Behalf Of cbduggap Sent: Friday, May 20, 2022 3:20 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Wang, Jian J Subject: [edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bu

Re: [edk2-devel] [PATCH 0/2] Fix 2 issues in TDVF

2022-06-02 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Tuesday, May 31, 2022 10:31 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; Gerd Hoffmann ; James > Bottomley ; Yao, Jiewen ; Tom > Lendacky > Subject: [PATCH 0/2] Fix 2 issues in TDVF > > During th

[edk2-devel] [PATCH v7 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress

2022-06-02 Thread Gerd Hoffmann
Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we want use that library. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 4 +++- OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- OvmfPkg/Library/PlatformInitLib/MemDetect.c

[edk2-devel] [PATCH v7 6/6] OvmfPkg/Microvm/pcie: add pcie support

2022-06-02 Thread Gerd Hoffmann
Link in pcie and host bridge bits. Enables support for PCIe in microvm (qemu-system-x86_64 -M microvm,pcie=on). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 40 +- OvmfPkg/Microvm/READM

[edk2-devel] [PATCH v7 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak

2022-06-02 Thread Gerd Hoffmann
microvm places the 64bit mmio space at the end of the physical address space. So mPhysMemAddressWidth must be correct, otherwise the pci host bridge setup throws an error because it thinks the 64bit mmio window is not addressable. On microvm we can simply use standard cpuid to figure the address

[edk2-devel] [PATCH v7 4/6] OvmfPkg/Microvm/pcie: no vbeshim please

2022-06-02 Thread Gerd Hoffmann
Those old windows versions which need the vbeshim hack will not run on microvm anyway. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c index 8faa146b6cce..2a04821

[edk2-devel] [PATCH v7 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-02 Thread Gerd Hoffmann
io range is not mandatory according to pcie spec, so allow pcie host bridge configurations without io window in case there are no io reservations. Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 6 ++ 1 file changed, 6 ins

[edk2-devel] [PATCH v7 0/6] OvmfPkg/Microvm/pcie: add pcie support

2022-06-02 Thread Gerd Hoffmann
Needs two little tweaks in PCI code because microvm supports mmio only. Other than that just wire up the existing code (the PCIe host adapter used by microvm is the same (virtual) hardware used by the arm/aarch64 virtual machines). v7: - allow non-existing io address space only in case there a

[edk2-devel] [PATCH v7 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory

2022-06-02 Thread Gerd Hoffmann
io range is not mandatory according to pcie spec, so allow host bridges without io address space. Signed-off-by: Gerd Hoffmann --- .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/OvmfPkg/Fdt/FdtPciHostBridgeL

Re: [edk2-devel] [PATCH 00/12] Introduce Bootlog DEBUG() output

2022-06-02 Thread Gerd Hoffmann
Hi, > > Hmm. Maybe it's time to tackle the log performance problem for virtual > > machines? Create a debug log device with DMA support, so we don't need > > a vmexit for every single character we want log? > > Of course, that doesn't work for native systems. Yep. Maybe we should have both ;)