On Thu, 2 Jun 2022 at 12:14, Ni, Ray <ray...@intel.com> wrote: > > Gerd, > The fix should work. But I am curious why the if in blow is not hit. > https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c#L922 > > The RootBridge->ResAllocNode[TypeIo].Status is assigned as ResNone in: > https://github.com/TianoCore/edk2/blob/master/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c#L263 > > Or maybe your OVMF platform doesn't execute the above code path? > > Then I guess maybe the Base/Limit of Aperture is not set properly so that > below if is hit? > https://github.com/tianocore/edk2/blob/64706ef761273ba403f9cb3b7a986bfb804c0a87/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c#L249 >
I did a quick test with both ArmVirtQemu and microvm (using this series but omitting the MdeModulePkg), and I can confirm that not having a I/O resource window at all seems to work fine if none of the PCI devices have I/O BARs. Gerd, do you remember why exactly this patch is needed? Is it related to devices that have I/O BARs but don't actually require them to function correctly? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90158): https://edk2.groups.io/g/devel/message/90158 Mute This Topic: https://groups.io/mt/91495635/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
