[edk2-devel] [PATCH V2 1/1] OvmfPkg: Add README for TDVF

2022-05-03 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3249 Add README for TDVF. Cc: Brijesh Singh Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Min Xu --- OvmfPkg/IntelTdx/README | 88 + 1 file ch

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

2022-05-03 Thread Rebecca Cran
I think with the PL111 being such old technology now it should be safe to just remove them. -- Rebecca Cran On 5/3/22 13:43, Ard Biesheuvel wrote: Hi Rebecca, On Tue, 3 May 2022 at 21:31, Rebecca Cran wrote: The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using the console

[edk2-devel] [PATCH v2 1/1] ArmPlatformPkg: Remove overly verbose DEBUG lines in LcdGraphicsBlt

2022-05-03 Thread Rebecca Cran
The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using the console difficult, for example when using the UiApp. Since the extra output should no longer be needed, delete the DEBUG lines. Signed-off-by: Rebecca Cran --- ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutput

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

2022-05-03 Thread Ard Biesheuvel
Hi Rebecca, On Tue, 3 May 2022 at 21:31, Rebecca Cran wrote: > > The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using > the console difficult, for example when using the UiApp. > > To allow for easy inclusion for future debugging, comment out but don't > remove the DEBUG lines. >

[edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt

2022-05-03 Thread Rebecca Cran
The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using the console difficult, for example when using the UiApp. To allow for easy inclusion for future debugging, comment out but don't remove the DEBUG lines. Signed-off-by: Rebecca Cran --- ...utBlt.c | 22 +++--- 1 file changed,

Re: [edk2-devel] [PATCH 00/10] Multiple packages: Remove RVCT support

2022-05-03 Thread Ard Biesheuvel
On Tue, 3 May 2022 at 20:48, Rebecca Cran wrote: > > RVCT is obsolete, no longer supported and only supports 32-bit systems. > Since it's no longer used, remove it. > > Personal PR: https://github.com/tianocore/edk2/pull/2833 > > Rebecca Cran (10): > ArmPkg: Remove RVCT support > ArmPlatformPk

[edk2-devel] [PATCH 10/10] BaseTools: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- BaseTools/Conf/build_rule.template | 42 ++ BaseTools/Conf/tools_def.template| 157 BaseTools/Scripts/Rvct-Align32.sct | 19 --- Base

[edk2-devel] [PATCH 09/10] OvmfPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- OvmfPkg/Library/XenHypercallLib/XenHypercallLib.inf | 3 --- 1 file changed, 3 deletions(-) diff --git a/OvmfPkg/Library/XenHypercallLib/XenHypercallLib.inf b/OvmfPkg/Library/XenHypercallLib/XenHypercal

[edk2-devel] [PATCH 08/10] EmbeddedPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- EmbeddedPkg/EmbeddedPkg.dsc | 1 - EmbeddedPkg/GdbStub/Arm/Processor.c | 10 -- 2 files changed, 11 deletions(-) diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc in

[edk2-devel] [PATCH 07/10] ArmVirtPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- ArmVirtPkg/ArmVirt.dsc.inc | 4 1 file changed, 4 deletions(-) diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index ba711deac025..5784509224e4 100644 --- a/ArmVirtPkg/ArmVirt.d

[edk2-devel] [PATCH 06/10] NetworkPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- NetworkPkg/NetworkBuildOptions.dsc.inc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/NetworkPkg/NetworkBuildOptions.dsc.inc b/NetworkPkg/NetworkBuildOptions.dsc.inc index 738da222

[edk2-devel] [PATCH 05/10] FatPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- FatPkg/FatPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc index 4ddb5c3e004b..6fa439e440cb 100644 --- a/FatPkg/FatPkg.dsc +++ b/FatPkg/FatPkg.dsc @@ -24,7

[edk2-devel] [PATCH 04/10] MdePkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- MdePkg/Include/Arm/ProcessorBind.h | 4 +- MdePkg/Include/Base.h| 42 +--- MdePkg/Library/BaseCpuLib/BaseCpuLib.

[edk2-devel] [PATCH 03/10] CryptoPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- CryptoPkg/CryptoPkg.dsc | 1 - CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 4 CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 ---

[edk2-devel] [PATCH 02/10] ArmPlatformPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- ArmPlatformPkg/Library/ArmPlatformLibNull/Arm/ArmPlatformHelper.asm| 62 - ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 1 - ArmPlatformPkg/Library/ArmPlatformS

[edk2-devel] [PATCH 01/10] ArmPkg: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete and no longer used. Remove support for it. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/ArmGic/ArmGicLib.inf| 1 - ArmPkg/Drivers/ArmGic/GicV3/Arm/ArmGicV3.asm | 82 -- ArmPkg/Include/AsmMacroExport.inc

[edk2-devel] [PATCH 00/10] Multiple packages: Remove RVCT support

2022-05-03 Thread Rebecca Cran
RVCT is obsolete, no longer supported and only supports 32-bit systems. Since it's no longer used, remove it. Personal PR: https://github.com/tianocore/edk2/pull/2833 Rebecca Cran (10): ArmPkg: Remove RVCT support ArmPlatformPkg: Remove RVCT support CryptoPkg: Remove RVCT support MdePkg:

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/OvmfPkg*.dsc: Increase ACPI Reclaim memory size

2022-05-03 Thread Ard Biesheuvel
On Tue, 3 May 2022 at 17:54, annie li wrote: > > Adding maintainers into the CC list... > > On 5/2/2022 5:05 PM, annie li wrote: > > Hello > > > > I am wondering if anyone will review this patch please? Any comments > > are welcome. > > > > Thanks > > > > Annie > > > > On 4/15/2022 5:15 PM, annie

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/OvmfPkg*.dsc: Increase ACPI Reclaim memory size

2022-05-03 Thread annie li
Adding maintainers into the CC list... On 5/2/2022 5:05 PM, annie li wrote: Hello I am wondering if anyone will review this patch please? Any comments are welcome. Thanks Annie On 4/15/2022 5:15 PM, annie li wrote: The current ACPI Reclaim memory size is set as 0x10(64k). The ACPI table s

Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

2022-05-03 Thread Yao, Jiewen
Hi Gerd Thanks for the patch. Some initial thought: I have no concern on OVMF package update. We can update if we want. However, I do have concern for crypto package to enable ECC *unconditionally*. I am not convinced that "EC is hard requirement for EDKII" just because "EC is a hard requirement

[edk2-devel] [QUESTION] API for more reliable memory

2022-05-03 Thread Ard Biesheuvel
Hello all, While looking into how to support EFI_MORE_RELIABLE in Linux/arm64, I noticed that, apart from the memory attribute, there is absolutely nothing in terms of API support. So how is one supposed to allocate this type of memory? Traverse the memory map by hand to look for a suitable slot,

Re: [edk2-devel] [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile

2022-05-03 Thread Ard Biesheuvel
On Wed, 20 Apr 2022 at 02:43, Rebecca Cran wrote: > > Could I get some reviews on this please? > Merged as #2849 Thanks, > > -- > > Rebecca Cran > > > On 4/10/22 19:16, Rebecca Cran wrote: > > I ran into some problems debugging EDK2 code using Development Studio with > > the files under ArmPlat

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Remove SLC entry from PPTT table

2022-05-03 Thread Ard Biesheuvel
On Wed, 20 Apr 2022 at 09:45, Pranav Madhu wrote: > > Hi Ard, > > Please find my response inline. > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Wednesday, April 20, 2022 1:05 PM > > To: Pranav Madhu > > Cc: edk2-devel-groups-io ; Ard Biesheuvel > > ; Sami Mujawar > > Subje

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-05-03 Thread Ard Biesheuvel
On Wed, 9 Feb 2022 at 13:26, Ming Huang wrote: > > The heap space will be rewrote if a StandloneMmPkg module create HOB > by BuildGuidHob() interface and write data to HOB space. Can you elaborate? What is supposed to happen and why, and what is happening instead? > Add a PCD PcdMemoryHobSize fo

Re: [edk2-devel] ArmPlatformPkg: understanding PrePi vs PrePeiCore

2022-05-03 Thread Ard Biesheuvel
On Tue, 12 Apr 2022 at 18:01, Rebecca Cran wrote: > > I've been working on cleaning up some of the code in ArmPlatformPkg and > have been trying to understand the differences between PrePi and PrePeiCore. > It looks like PrePi was added to save space over PrePeiCore, but I'm > wondering if we stil

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-05-03 Thread Ard Biesheuvel
(+ Rebecca) On Tue, 8 Mar 2022 at 12:55, Rohit Mathew wrote: > > PrePeiCore's CEntry function calls DebugLib library's print API before > the library is initialized. So, invoke the constructor in the SEC phase > to call into initialization functions associated with libraries linked > with this pa

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-05-03 Thread Ard Biesheuvel
Hello Rebecca, Apologies for the delay. I'm a bit behind on review, and few other people appear to take an interest in these changes, unfortunately. On Thu, 14 Apr 2022 at 00:46, Rebecca Cran wrote: > > Copy code from PrePi to PrePeiCore that prints the firmware version > and build date early i

Re: [edk2-devel] [Patch v2 27/28] OvmfPkg: Add ProtectedVariable reference

2022-05-03 Thread Ard Biesheuvel
On Fri, 29 Apr 2022 at 20:05, Judah Vang wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Add reference to null ProtectedVariableLib. > > Cc: Jian J Wang > Cc: Sebastien Boeuf > Cc: Nishant C Mistry > Signed-off-by: Jian J Wang > Signed-off-by: Nishant C Mistry > Signed

Re: [edk2-devel] [Patch v2 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

2022-05-03 Thread Ard Biesheuvel
On Fri, 29 Apr 2022 at 20:05, Judah Vang wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Need reference to ProtectVariableNullLib otherwise build fails. > > Cc: Jian J Wang > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Nishant C Mistry > Signed-off-by: Jian J Wang > S