Re: [edk2-devel] [PATCH v2 0/3] add and use more video modes

2022-04-22 Thread Ard Biesheuvel
On Fri, 22 Apr 2022 at 15:29, Ard Biesheuvel wrote: > > On Fri, 22 Apr 2022 at 14:41, Gerd Hoffmann wrote: > > > > v2: > > - rebase to latest master > > - add review tags > > > > Thanks Gerd, I'll pick these up later today. > Merged as #2819 Thanks all, > > > Gerd Hoffmann (3): > > MdeModu

Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

2022-04-22 Thread Michael D Kinney
Hi Michael, 1) This patch series is dependent on the edk2 repo patch series that adds the VariableFlashInfoLib. This patch series cannot be committed until the edk2 changes are committed because it will break all the edk2-platforms if this one is committed first. 2) The related edk2 c

[edk2-devel] Status of GSoC 2022 proposal; status of currently implemented functions and protocols related to USB and USB audio

2022-04-22 Thread Ethin Probst
So this message is a bit of a question and an information dump; if you want me to split this off into two separate discussions that's fine by me. First, I'm writing to inquire about the status of my proposal; I received some feedback and believe I corrected my proposal as directed, but unless it

Re: [edk2-devel] [PATCH v5 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory

2022-04-22 Thread Abner Chang
Gerd, I have some comments in line. With those fixes, Reviewed-by: Abner Chang > -Original Message- > From: Gerd Hoffmann > Sent: Friday, April 22, 2022 3:37 PM > To: devel@edk2.groups.io > Cc: Pawel Polawski ; Ard Biesheuvel > ; Liming Gao ; > Hao A Wu ; Ray Ni ; Oliver Steffen > ; Lei

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Add Azure DevOps UI debug instructions

2022-04-22 Thread Michael Kubacki
PR with R-b tag is ready to push: https://github.com/tianocore/edk2/pull/2799 On 4/21/2022 5:08 PM, Sean wrote: Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89236): https://edk2.groups.io/g/devel/message/8

Re: [edk2-devel] [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

2022-04-22 Thread Michael Kubacki
Thanks for testing it. On 4/22/2022 10:41 AM, Jeremy Linton wrote: Hi, On 4/20/22 15:44, mikub...@linux.microsoft.com wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced

Re: [edk2-devel] [edk2-platforms][PATCH v1 06/10] RaspberryPi: Add VariableFlashInfoLib

2022-04-22 Thread Jeremy Linton
Hi, On 4/20/22 15:44, mikub...@linux.microsoft.com wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Adds an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This change is made to allow the new variable drive

Re: [edk2-devel] [PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

2022-04-22 Thread Michael Kubacki
PR with R-b tag is ready to push: https://github.com/tianocore/edk2/pull/2818 On 4/21/2022 5:07 PM, Sean wrote: Reviewed-by: Sean Brogan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89233): https://edk2.groups.io/g/devel/message/

[edk2-devel] [PATCH 2/2] ShellPkg/SmbiosView: Print BIOS extension size

2022-04-22 Thread Hsu, Roger
Update for printing BIOS extension size information. Signed-off-by: Roger Hsu Cc: Ray Ni Cc: Zhichao Gao Cc: Abner Chang --- .../SmbiosView/PrintInfo.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1C

[edk2-devel] [PATCH 1/2] MdePkg/Include: Update SMBIOS type 0

2022-04-22 Thread Hsu, Roger
Update SMBIOS type 0 to support BIOS extended size. Signed-off-by: Roger Hsu Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abner Chang --- MdePkg/Include/IndustryStandard/SmBios.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Indu

[edk2-devel] [PATCH 0/2] Update SMBIOS type 0

2022-04-22 Thread Hsu, Roger
Update for supporting SMBIOS type zero extended size. Signed-off-by: Roger Hsu Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abner Chang Cc: Ray Ni Cc: Zhichao Gao Hsu, Roger (2): MdePkg/Include: Update SMBIOS type 0 ShellPkg/SmbiosView: Print BIOS extension size MdePkg/In

[edk2-devel] [PATCH 0/2] Update SMBIOS type 0

2022-04-22 Thread Hsu, Roger
Update for supporting SMBIOS type zero extended size. Signed-off-by: Roger Hsu Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abner Chang Cc: Ray Ni Cc: Zhichao Gao Hsu, Roger (2): MdePkg/Include: Update SMBIOS type 0 ShellPkg/SmbiosView: Print BIOS extension size MdePkg/In

[edk2-devel] [PATCH 0/2] Update SMBIOS type 0

2022-04-22 Thread Hsu, Roger
Update for supporting SMBIOS type zero extended size. Signed-off-by: Roger Hsu Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Abner Chang Cc: Ray Ni Cc: Zhichao Gao Hsu, Roger (2): MdePkg/Include: Update SMBIOS type 0 ShellPkg/SmbiosView: Print BIOS extension size MdePkg/In

Re: [edk2-devel] [edk2-platforms][PATCH v1 00/10] Add variableFlashInfoLib

2022-04-22 Thread Michael Kubacki
Reminder to all to review this series for your package. It is a simple change needed to keep your package building. So far, only Abner Chang has responded for U5SeriesPkg. On 4/20/2022 4:44 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id

Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

2022-04-22 Thread Michael Kubacki
Reminder to review this series. Ankit Sinha has reviewed it but need a maintainer to review and merge. On 4/11/2022 4:58 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3543 Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consume

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Add support for VariableFlashInfoLib

2022-04-22 Thread Michael Kubacki
Reminder to review this patch. On 4/18/2022 7:43 PM, Michael Kubacki wrote: From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3478 Adds support for getting the variable flash information from VariableFlashInfoLib. This library abstracts the source of flash information

Re: [edk2-devel] [PATCH v2 0/3] add and use more video modes

2022-04-22 Thread Ard Biesheuvel
On Fri, 22 Apr 2022 at 14:41, Gerd Hoffmann wrote: > > v2: > - rebase to latest master > - add review tags > Thanks Gerd, I'll pick these up later today. > Gerd Hoffmann (3): > MdeModulePkg/GraphicsConsoleDxe: add modes > OvmfPkg: clear PcdConOut{Row,Column} > ArmVirtPkg: clear PcdConOu

[edk2-devel] [PATCH v2 3/3] ArmVirtPkg: clear PcdConOut{Row,Column}

2022-04-22 Thread Gerd Hoffmann
ConSplitterDxe will pick the highest available resolution then, thereby making better use of the available display space. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao --- ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 ++ 2 files changed, 4 insertions(+)

[edk2-devel] [PATCH v2 0/3] add and use more video modes

2022-04-22 Thread Gerd Hoffmann
v2: - rebase to latest master - add review tags Gerd Hoffmann (3): MdeModulePkg/GraphicsConsoleDxe: add modes OvmfPkg: clear PcdConOut{Row,Column} ArmVirtPkg: clear PcdConOut{Row,Column} ArmVirtPkg/ArmVirtQemu.dsc | 2 ++ ArmVirtPkg/ArmVirtQemuKernel.dsc

[edk2-devel] [PATCH v2 2/3] OvmfPkg: clear PcdConOut{Row,Column}

2022-04-22 Thread Gerd Hoffmann
ConSplitterDxe will pick the highest available resolution then, thereby making better use of the available display space. Signed-off-by: Gerd Hoffmann Reviewed-by: Liming Gao --- OvmfPkg/AmdSev/AmdSevX64.dsc | 2 ++ OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++ OvmfPkg/OvmfPkgIa32.dsc| 2 ++

[edk2-devel] [PATCH v2 1/3] MdeModulePkg/GraphicsConsoleDxe: add modes

2022-04-22 Thread Gerd Hoffmann
Add modes for a few common display resolutions higher than 800x600, specifically 1024x768, 1280x800 and 1920x1080, so ConSplitterDxe has more options available. The mode list is not use as-is, InitializeGraphicsConsoleTextMode() will check the list and filter out any modes which don't fit to the s

[edk2-devel] [PATCH v1 1/1] MdePkg: add SmmCpuRendezvousLib.h and SmmCpuRendezvousLibNull implement.

2022-04-22 Thread Li, Zhihao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3912 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm and VariableStandaloneMM driver in

[edk2-devel] [PATCH v5 2/6] OvmfPkg/FdtPciHostBridgeLib: io range is not mandatory

2022-04-22 Thread Gerd Hoffmann
io range is not mandatory according to pcie spec, so allow host bridges without io address space. Signed-off-by: Gerd Hoffmann --- .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/OvmfPkg/Fdt/FdtPciHostBridgeL

[edk2-devel] [PATCH] .pytool: Fix python command error in self introduction doc

2022-04-22 Thread Chao Li
Fix misspelling of word "Prerequisites". In the step 5 of the Prerequisites section, the python command was missing the "-r" option, what the command really meant was to install from the given requirements file, so fix that. Cc: sean.bro...@microsoft.com Cc: bret.barke...@microsoft.com Cc: michae

[edk2-devel] [PATCH v5 6/6] OvmfPkg/Microvm/pcie: add pcie support

2022-04-22 Thread Gerd Hoffmann
Link in pcie and host bridge bits. Enables support for PCIe in microvm (qemu-system-x86_64 -M microvm,pcie=on). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 40 +- OvmfPkg/Microvm/READM

[edk2-devel] [PATCH v5 3/6] OvmfPkg/Platform: unfix PcdPciExpressBaseAddress

2022-04-22 Thread Gerd Hoffmann
Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we want use that library. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/PlatformInitLib.inf | 4 +++- OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- OvmfPkg/Library/PlatformInitLib/MemDetect.c

[edk2-devel] [PATCH v5 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak

2022-04-22 Thread Gerd Hoffmann
microvm places the 64bit mmio space at the end of the physical address space. So mPhysMemAddressWidth must be correct, otherwise the pci host bridge setup throws an error because it thinks the 64bit mmio window is not addressable. On microvm we can simply use standard cpuid to figure the address

[edk2-devel] [PATCH v5 4/6] OvmfPkg/Microvm/pcie: no vbeshim please

2022-04-22 Thread Gerd Hoffmann
Those old windows versions which need the vbeshim hack will not run on microvm anyway. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c index 8faa146b6cce..2a04821

[edk2-devel] [PATCH v5 0/6] OvmfPkg/Microvm/pcie: add pcie support

2022-04-22 Thread Gerd Hoffmann
Needs two little tweaks in PCI code because microvm supports mmio only. Other than that just wire up the existing code (the PCIe host adapter used by microvm is the same (virtual) hardware used by the arm/aarch64 virtual machines). v5: - codestyle (uncrustify) fix. v4: - update PciHostBridge ch

[edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-04-22 Thread Gerd Hoffmann
io range is not mandatory according to pcie spec, so allow bridge configurations without io address space assigned. Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModule