Re: [edk2-devel] [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify

2022-03-21 Thread Laszlo Ersek
On 03/22/22 02:58, mikub...@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 > > The following files: > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h > OvmfPkg/QemuVideoDxe/VbeShim.h > > Are auto generated by the following generators: >

Re: [edk2-devel] [PATCH v1 3/4] OvmfPkg: Revert Uncrustify formatting in VbeShim.h files

2022-03-21 Thread Laszlo Ersek
On 03/22/22 02:58, mikub...@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 > > Reverts changes automatically applied by Uncrustify in commit > ac0a286. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffm

Re: [edk2-devel] [PATCH V9 14/47] UefiCpuPkg: Enable Tdx support in MpInitLib

2022-03-21 Thread Min Xu
Hi, Ray Can you help to review this patch? https://edk2.groups.io/g/devel/message/87690 Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87815): https://edk2.groups.io/g/devel/message/87815 Mute This Topic: https://groups.io/mt/

Re: [edk2-devel] [PATCH V9 02/47] MdePkg: Update Cpuid.h for Tdx

2022-03-21 Thread Min Xu
Hi, Liming Can you help to review this patch? https://edk2.groups.io/g/devel/message/87678 Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87814): https://edk2.groups.io/g/devel/message/87814 Mute This Topic: https://groups.io

[edk2-devel] [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify

2022-03-21 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 The following files: OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h OvmfPkg/QemuVideoDxe/VbeShim.h Are auto generated by the following generators: OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh OvmfPkg/QemuVideoDxe/VbeShim.sh The

[edk2-devel] [PATCH v1 2/4] .pytool/Plugin/UncrustifyCheck: Add ignore file support

2022-03-21 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880 Currently UncrustifyCheck.py provides the following exclusion options: 1. Override the type of files UncrustifyCheck operates against by default (.c and .h files). Using the "IgnoreStandardPaths" configuration option.

[edk2-devel] [PATCH v1 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths

2022-03-21 Thread Michael Kubacki
From: Michael Kubacki Currently, UncrustifyCheck._get_git_ignored_paths() is documented to return a list of absolute file paths but it currently returns a list of relative file paths. This change updates the function to return a list of absolute file paths. The result is later compared to the li

[edk2-devel] [PATCH v1 0/4] UncrustifyCheck Ignore Support

2022-03-21 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3880 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 This patch series: 1. Updates ignore handling in UncrustifyCheck including adding a new CI plugin configuration option to ignore files in a package. 2. Reverts Un

Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css

2022-03-21 Thread Mara Sophie Grosch via groups.io
Will do tomorrow (UTC+1), thanks for reviewing :) Am 22. März 2022 01:28:45 UTC schrieb "Wu, Hao A" : >The change is good to me. > >Could you help to apply this change to the code in >MdeModulePkg\Bus\Pci\NvmExpressPei\ as well? >Really sorry for missing the above comment in previous reply. > >Be

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 03/22/2022 #cal-reminder

2022-03-21 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css

2022-03-21 Thread Wu, Hao A
The change is good to me. Could you help to apply this change to the code in MdeModulePkg\Bus\Pci\NvmExpressPei\ as well? Really sorry for missing the above comment in previous reply. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mara > Sophie Gros

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 03/21/2022 #cal-notice

2022-03-21 Thread devel@edk2.groups.io Calendar
*Tools, CI, Code base construction meeting series* *When:* 03/21/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1463508 ) *Description:* TianoCore community, Micros

Re: [edk2-devel] [PATCH 1/2] Add filesystem drivers

2022-03-21 Thread Sean Rhodes
Hi Pedro/Patrick Thank you, I'll adjust it for that :) Kind regards, Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87804): https://edk2.groups.io/g/devel/message/87804 Mute This Topic: https://groups.io/mt/89924170/21656 Group Ow

[edk2-devel] [PATCH v2 3/3] BaseTools: Scripts/efi_lldb.py: Add lldb EFI commands and pretty Print

2022-03-21 Thread Rebecca Cran
https://bugzilla.tianocore.org/show_bug.cgi?id=3500 Use efi_debugging.py Python Classes to implement EFI gdb commands: efi_symbols, guid, table, hob, and devicepath You can attach to any standard gdb or kdp remote server and get EFI symbols. No modifications of EFI are required. Example usage: O

[edk2-devel] [PATCH v2 0/3] BaseTools: Add support for gdb and lldb

2022-03-21 Thread Rebecca Cran
This patch set adds debugging support for gdb and lldb. It also adds generic debugging classes that use a file like object to make it easy to import into any debugger that supports Python. Changes from v1 to v2: - Moved scripts from the root of the repo into BaseTools/Scripts. - Fixed typo of "RIS

[edk2-devel] [PATCH v2 2/3] BaseTools: Scripts/efi_gdb.py: Add gdb EFI commands and pretty Print

2022-03-21 Thread Rebecca Cran
https://bugzilla.tianocore.org/show_bug.cgi?id=3500 Use efi_debugging.py Python Classes to implement EFI gdb commands: (gdb) help efi Commands for debugging EFI. efi List of efi subcommands: efi devicepath -- Display an EFI device path. efi guid -- Display info about EFI GUID's. efi hob -- Dump

[edk2-devel] [PATCH v2 1/3] BaseTools: efi_debugging.py: Add debugger agnostic dbg Python Classes

2022-03-21 Thread Rebecca Cran
Add Scripts/efi_debugging.py to provide debugger agnostic debugging utility Python classes. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Hao A Wu Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Rebecca Cran --- BaseTools/Scripts/efi_debugging.py | 2185 1 file

Re: [edk2-devel][PATCH 1/2] MdeModulePkg: StackOffset must be aligned to a 16-byte boundary in X64

2022-03-21 Thread Marvin Häuser
Good day, Thanks for the update! On 21.03.22 13:43, Kuo, Ted wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3865 For X64, StackOffset must be aligned to a 16-byte boundary as well as old stack and new stack. Otherwise, it'll get wrong data from Private pointer after switching from ol

[edk2-devel] [PATCH] MdeModulePkg/NvmExpressDxe: fix check for Cap.Css

2022-03-21 Thread Mara Sophie Grosch via groups.io
Fix the check for NVMe command set being supported by the controller. Was problematic with qemu (6.2.0, Debian 1:6.2+dfsg-3), which sets 0xC1 in that register, making the OVMF think the NVMe controller does not support NVMe. Uncovered by commit 9dd14fc91c174eae87fd122c7ac70073a363527f, which cha

[edk2-devel] [PATCH] UefiPayloadPkg: Fix architecture in the build instruction

2022-03-21 Thread Akihiko Odaki
Signed-off-by: Akihiko Odaki --- UefiPayloadPkg/BuildAndIntegrationInstructions.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiPayloadPkg/BuildAndIntegrationInstructions.txt b/UefiPayloadPkg/BuildAndIntegrationInstructions.txt index 61d31f1020..01b3d7f992 100644 ---

[edk2-devel][PATCH 2/2] IntelFsp2Pkg: Ensure new stack is aligned to old stack for X64

2022-03-21 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3865 Ensure bit3:0 of NewStack is aligned with bit3:0 of OldStack for X64 before switching stack. Otherwise, RSP may not be aligned to a 16-byte boundary after returning from SecTemporaryRamSupport. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star Zen

[edk2-devel][PATCH 1/2] MdeModulePkg: StackOffset must be aligned to a 16-byte boundary in X64

2022-03-21 Thread Kuo, Ted
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3865 For X64, StackOffset must be aligned to a 16-byte boundary as well as old stack and new stack. Otherwise, it'll get wrong data from Private pointer after switching from old stack to new stack. Cc: Michael D Kinney Cc: Dandan Bi Cc: Liming G

[edk2-devel][PATCH 0/2] Ensure RSP is aligned to a 16-byte boundary for PEI 64bit

2022-03-21 Thread Kuo, Ted
The changes ensure the same stack alignment is kept before and after swithing stack in X64. Ted Kuo (2): MdeModulePkg: StackOffset must be aligned to a 16-byte boundary in X64 IntelFsp2Pkg: Ensure new stack is aligned to old stack for X64 IntelFsp2Pkg/FspSecCore/SecMain.c | 8 ++

[edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: Add Pcd to prioritize internal devices

2022-03-21 Thread Sean Rhodes
From: Matt DeVillier Add Pcd to allow configuring internal devices to be prioritized over internally-attached USB devices, such as card readers, over SATA, NVMe and eMMC drives. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Matt DeVillier Signed-off-by: Sean Rhodes --- MdeModulePkg/Library/

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Hookup Prioritise Internal build option

2022-03-21 Thread Sean Rhodes
Hook PRIORITISE_INTERNAL build option to PrioritiseInternal PCD. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc

Re: [edk2-devel] [PATCH 15/18] UefiPayloadPkg/Library/PlatformBootManagerLib: Remove broken VGA detection

2022-03-21 Thread Sean Rhodes
Hey Guo Can I chase when this patch will be merged? Many thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87788): https://edk2.groups.io/g/devel/message/87788 Mute This Topic: https://groups.io/mt/89056153/21656 Group Owner:

[edk2-devel] [PATCH 2/2] UefiPayloadPkg: Use new filesystem drivers

2022-03-21 Thread Sean Rhodes
From: Patrick Rudolph Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Patrick Rudolph --- UefiPayloadPkg/UefiPayloadPkg.fdf | 15 +++ 1 file changed, 15 insertions(+) diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/UefiPayloadPkg.fdf inde

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 43/43] MdeModulePkg/BmBoot: skip secondary eMMC entries

2022-03-21 Thread Sean Rhodes
Hi Liming This is how the entries appear for multiple MMC drives. Can you advise how you'd like me to adjust the patch? Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87785): https://edk2.groups.io/g/devel/message/87785 Mu

Re: [edk2-devel] [PATCH 1/2] SecurityPkg: Add RNG support

2022-03-21 Thread Sean Rhodes
Hi Jiewen/Jian Would you be able to review please? Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87784): https://edk2.groups.io/g/devel/message/87784 Mute This Topic: https://groups.io/mt/89353220/21656 Group Owner: devel+o

Re: [edk2-devel] [edk2-platform][PATCH] UefiPayloadPkg: Fix PciHostBridgeLib

2022-03-21 Thread Sean Rhodes
Hi Can I follow up on this patch being merged? Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87783): https://edk2.groups.io/g/devel/message/87783 Mute This Topic: https://groups.io/mt/88968466/21656 Group Owner: devel+ow..

[edk2-devel] [PATCH 4/5] UefiPayloadPkg: Add SmmStoreLib

2022-03-21 Thread Sean Rhodes
From: Patrick Rudolph Implement all of the FVB protocol functions on top of the SmmStore as a library. The library consumes the introduced gEfiSmmStoreInfoHobGuid. The SMI handler uses a fixed communication buffer in reserved DRAM. To initiate a transaction you must write to the I/O APM_CNT port

[edk2-devel] [PATCH 1/5] UefiPayloadPkg/UefiPayloadPkg.ci.yaml: Remove duplicated entry

2022-03-21 Thread Sean Rhodes
From: Patrick Rudolph Remove a duplicated entry to fix a CI error. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Signed-off-by: Patrick Rudolph --- UefiPayloadPkg/UefiPayloadPkg.ci.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayload

[edk2-devel] [PATCH 5/5] UefiPayloadPkg: Add support for Firmware Volume Block Protocol

2022-03-21 Thread Sean Rhodes
This adds support for FVB in order to support a platform independent and non-volatile variable store on UefiPayloadPkg. The variable store makes use the SmmStoreLib to provide an unauthenticed variable store. Since commit bc744f5893fc4d53275ed26dd8d968011c6a09c1 coreboot supports the SMMSTORE v2 f

[edk2-devel] [PATCH 3/5] UefiPayloadPkg: Add SmmStoreInfoGuid

2022-03-21 Thread Sean Rhodes
From: Patrick Rudolph Add a new InfoHob that contains the SmmStore information passed from coreboot tables when the SMMSTOREV2 feature is enabled. This will be used to implement the FVB in top of the MM installed by coreboot. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean

[edk2-devel] [PATCH 2/5] UefiPayloadPkg/Include/Coreboot: Add headers for SMMSTOREv2 table

2022-03-21 Thread Sean Rhodes
From: Patrick Rudolph Since commit bc744f5893fc4d53275ed26dd8d968011c6a09c1 coreboot supports the SMMSTORE v2 feature. It implements a SMI handler that is able to write, read and erase pages in the boot media (SPI flash). The existence of this optional feature is advertised by a coreboot table.

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Fix build error

2022-03-21 Thread Sean Rhodes
The patch looks good to me, and it has been confirmed by several others from the coreboot community. However, I don't have the capability to merge. Thanks Sean -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#8): https://edk2.groups.io