Re: [edk2-devel] [PATCH] ArmPkg: Invalidate Instruction Cache On MMU Enable

@Marc Zyngier I have addressed your comment regarding the type of data synchronization barrier and have posted v2 of the patch set. @Ard Biesheuvel I am still looking for a better solution to the prob

[edk2-devel] [PATCH v2] ArmPkg: Invalidate Instruction Cache On MMU Enable

Even with MMU turned off, instruction cache can speculate and fetch instructions. This can cause a crash if region being executed has been modified recently. With this patch, we ensure that instruction cache is invalidated right after MMU has been enabled and any potentially stale instruction fetch

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

Hi Rebecca, Sorry for the delay, I was out of office. The diff will appear in /Build/TestSuites.xml. Here, I have intentionally introduced an error in UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c: Uncrustify executed against 21 files in UnitTestFrameworkPkg in 0

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Huge Thanks for "You can submit PR to edk2 mater branch directly to check for CI bugs(will not be reviewed or merged)." I am fixing them. Regarding the style(extra spaces and tabs), It is actually coming from openssl when we run CryptoPkg/Library/OpensslLib/process_files.pl Not sure if there a w

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Readme.md: Fix link to the edk2 Readme.rst file

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca Cran > Sent: Friday, February 25, 2022 7:42 AM > To: devel@edk2.groups.io; Kinney, Michael D ; > Leif Lindholm > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH edk2-platforms v2 1/1]

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtMemoryInitPeiLib: avoid redundant cache invalidation

On Mon, 31 Jan 2022 at 14:21, Alexander Graf wrote: > > > On 29.01.22 16:13, Ard Biesheuvel wrote: > > Alex reports that the cache invalidation performed by > > ArmVirtMemoryInitPeiLib takes a non-negligible amount of time at boot. > > This cache invalidation used to be necessary to avoid inconsis

Re: [edk2-devel] [PATCH] ArmVirtPkg/ArmVirtKvmTool: wire up configurable timeout

On Wed, 2 Feb 2022 at 11:04, Sami Mujawar wrote: > > Hi Ard, > > Thank you for this patch. > > The timeout value 5 appears to be standard across platforms, so it looks good > to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > Merged as #2547 (with a mention of the change to 5

[edk2-devel] [PATCH edk2-platforms v2 1/1] Readme.md: Fix link to the edk2 Readme.rst file

The Readme file in the edk2 repo was changed from Readme.md to Readme.rst. Signed-off-by: Rebecca Cran --- Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Readme.md b/Readme.md index 62876b4b7d75..991acd53ae03 100644 --- a/Readme.md +++ b/Readme.md @@ -9,7 +9,7 @@ p

[edk2-devel] [PATCH edk2-platforms 1/1] Readme.md: Fix links to the edk2 Readme.rst file

The Readme file in the edk2 repo was changed from Readme.md to Readme.rst. Signed-off-by: Rebecca Cran --- Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Readme.md b/Readme.md index 62876b4b7d75..58ab835b1174 100644 --- a/Readme.md +++ b/Readme.md @@ -4,12 +4,1

Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification

Thank you Jiewen :) From: Yao, Jiewen Sent: Friday, February 25, 2022 3:21 PM To: Boeuf, Sebastien ; kra...@redhat.com ; devel@edk2.groups.io Cc: Justen, Jordan L Subject: RE: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification I updated release pl

Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification

I updated release planning page for you. Thank you Yao Jiewen > -Original Message- > From: Boeuf, Sebastien > Sent: Friday, February 25, 2022 7:10 PM > To: kra...@redhat.com; Yao, Jiewen ; > devel@edk2.groups.io > Cc: Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH 0/3] CloudHv: Re

Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Fri, 2022-02-25 at 14:00 +0100, Gerd Hoffmann wrote: > > +++ b/OvmfPkg/CloudHv/CloudHvX64.fdf > > @@ -14,8 +14,8 @@ > >  !include OvmfPkg/OvmfPkgDefines.fdf.inc > >   > >  # > > -# Build the variable store and the firmware code as one unified > > flash device > > -# image. > > +# This will allow

Re: [edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

> +++ b/OvmfPkg/CloudHv/CloudHvX64.fdf > @@ -14,8 +14,8 @@ > !include OvmfPkg/OvmfPkgDefines.fdf.inc > > # > -# Build the variable store and the firmware code as one unified flash device > -# image. > +# This will allow the flash device image to be recognize as an ELF, with > first > +# an ELF

Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification

On Wed, 2022-02-23 at 14:14 +, Yao, Jiewen wrote: > Yes, justification in bugzilla and README, please. I've just created a bug in Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3848 But I don't have the permissions to edit the wiki https://github.com/tianocore/tianocore.github.io/wi

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Fri, 2022-02-25 at 10:29 +0100, kra...@redhat.com wrote: >   Hi, > > > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert > > > this. > > > Maybe add this to VarStore.fdf.inc instead, and add a > > > PVH_HEADER_ENABLE > > > option to turn it on and off? > > > > It's quite hard to

[edk2-devel] [PATCH v4 6/7] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS

From: Sebastien Boeuf Instead of using the CMOS, the CloudHv platform relies on the list of memmap entries provided through the PVH boot protocol to determine the last RAM address below 4G. Acked-by: Gerd Hoffmann Signed-off-by: Sebastien Boeuf --- OvmfPkg/PlatformPei/MemDetect.c | 73 +++

[edk2-devel] [PATCH v4 7/7] OvmfPkg: CloudHv: Add README

From: Sebastien Boeuf Add some documentation to the CloudHv target in order to clarify how to use it and what to expect from it. Signed-off-by: Sebastien Boeuf --- OvmfPkg/CloudHv/README | 67 ++ 1 file changed, 67 insertions(+) create mode 100644 OvmfP

[edk2-devel] [PATCH v4 5/7] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

From: Sebastien Boeuf Instead of hardcoding the address of the RSDP in the firmware, let's rely on the PVH structure hvm_start_info to retrieve this information. Acked-by: Gerd Hoffmann Signed-off-by: Sebastien Boeuf --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 ++ OvmfPkg/AcpiPlatfor

[edk2-devel] [PATCH v4 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

From: Sebastien Boeuf Following the model from the Xen target, CloudHv is generated as a PVH ELF binary to take advantage of the PVH specification, which requires less emulation from the VMM. The fdf include file CloudHvElfHeader.fdf.inc has been generated from the following commands: $ gcc -D

[edk2-devel] [PATCH v4 3/7] OvmfPkg: Xen: Generate fdf include file from ELF header generator

From: Sebastien Boeuf Updating the fdf include file based on the run of the ELF header generator. The diff from this patch is the result of: $ gcc -o elf_gen OvmfPkg/OvmfXenElfHeaderGenerator.c $ ./elf_gen 2097152 OvmfPkg/XenElfHeader.fdf.inc Acked-by: Gerd Hoffmann Signed-off-by: Sebastien Bo

[edk2-devel] [PATCH v4 2/7] OvmfPkg: Xen: Use a new fdf include for the PVH ELF header

From: Sebastien Boeuf Instead of having the PVH ELF header part of the fdf file directly, we move it to a dedicated include file. This is the first step in automating the generation of the header. Acked-by: Gerd Hoffmann Signed-off-by: Sebastien Boeuf --- OvmfPkg/OvmfXen.fdf | 57 ++-

[edk2-devel] [PATCH v4 1/7] OvmfPkg: Make the Xen ELF header generator more flexible

From: Sebastien Boeuf Adding some flexibility to the program through optional parameters and global define, so that other targets can use the generator. * A global define is added so that we can choose at build time if we want to use 32-bit or 64-bit base structures. * A first optional paramet

[edk2-devel] [PATCH v4 0/7] CloudHv: Rely on PVH boot specification

From: Sebastien Boeuf Cloud Hypervisor aims at emulating the minimal amount of legacy devices and this is why the PVH boot specification is supported. The point is to be able to share some information with the guest without the need for emulating devices that would be present on real hardware. S

Re: [edk2-devel] [PATCH v3 7/7] OvmfPkg: CloudHv: Add README

On Fri, 2022-02-25 at 10:43 +0100, Gerd Hoffmann wrote: > On Thu, Feb 24, 2022 at 03:28:26PM +0100, > sebastien.bo...@intel.com wrote: > > From: Sebastien Boeuf > > > > Add some documentation to the CloudHv target in order to clarify > > how to > > use it and what to expect from it. > > > > Sign

Re: [edk2-devel] [PATCH v3 7/7] OvmfPkg: CloudHv: Add README

On Thu, Feb 24, 2022 at 03:28:26PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Add some documentation to the CloudHv target in order to clarify how to > use it and what to expect from it. > > Signed-off-by: Sebastien Boeuf > --- > OvmfPkg/CloudHv/README | 66 +++

Re: [edk2-devel] [PATCH v3 6/7] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS

On Thu, Feb 24, 2022 at 03:28:25PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Instead of using the CMOS, the CloudHv platform relies on the list of > memmap entries provided through the PVH boot protocol to determine the > last RAM address below 4G. Acked-by: Gerd Hoffma

Re: [edk2-devel] [PATCH v3 5/7] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

On Thu, Feb 24, 2022 at 03:28:24PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Instead of hardcoding the address of the RSDP in the firmware, let's > rely on the PVH structure hvm_start_info to retrieve this information. Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 4/7] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Thu, Feb 24, 2022 at 03:28:23PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Following the model from the Xen target, CloudHv is generated as a PVH > ELF binary to take advantage of the PVH specification, which requires > less emulation from the VMM. > > The fdf include

Re: [edk2-devel] [PATCH v3 3/7] OvmfPkg: Xen: Generate fdf include file from ELF header generator

On Thu, Feb 24, 2022 at 03:28:22PM +0100, Boeuf, Sebastien wrote: > From: Sebastien Boeuf > > Updating the fdf include file based on the run of the ELF header > generator. The diff from this patch is the result of: > > $ gcc -o elf_gen OvmfPkg/OvmfXenElfHeaderGenerator.c > $ ./elf_gen 2097152 Ov

Re: [edk2-devel] [PATCH v3 2/7] OvmfPkg: Xen: Use a new fdf include for the PVH ELF header

On Thu, Feb 24, 2022 at 03:28:21PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Instead of having the PVH ELF header part of the fdf file directly, we > move it to a dedicated include file. This is the first step in > automating the generation of the header. > > Signed-off

Re: [edk2-devel] [PATCH v3 1/7] OvmfPkg: Make the Xen ELF header generator more flexible

On Thu, Feb 24, 2022 at 03:28:20PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Adding some flexibility to the program through optional parameters and > global define, so that other targets can use the generator. > > * A global define is added so that we can choose at buil

Re: [edk2-devel] [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

Hi, > > I'm wondering whenever there are plans for cloudhv to also support > > sev > > and/or tdx some day.  If so, then it probably isn't a good idea to > > switch to the xen reset vector.   > > Well Cloud Hypervisor aims at supporting TDX, but based on a separate > firmware. We're not trying

Re: [edk2-devel] [PATCH v2 2/5] OvmfPkg: Generate CloudHv as a PVH ELF binary

Hi, > > Hmm, VarStore.fdf.inc reduces duplication, and now you revert this. > > Maybe add this to VarStore.fdf.inc instead, and add a > > PVH_HEADER_ENABLE > > option to turn it on and off? > > It's quite hard to use VarStore.fdf.inc since I would need to replace > only the first DATA section.

Re: [edk2-devel] [PATCH v5] MdeModulePkg: Correct high-memory use in NvmExpressDxe

Acked-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: Tomas Pilar > Sent: Friday, February 25, 2022 12:22 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Ard Biesheuvel > ; Leif Lindholm ; > Wu, Hao A ; Ard Biesheuvel > Subject: [PATCH v5] MdeModulePkg: Correct high-memory