Re: [edk2-devel] [PATCH] ArmPkg: Invalidate Instruction Cache On MMU Enable

2022-02-22 Thread Ard Biesheuvel
(+ Marc) On Tue, 22 Feb 2022 at 03:42, Ashish Singhal wrote: > > Even with MMU turned off, instruction cache can speculate > and fetch instructions. This can cause a crash if region > being executed has been modified recently. With this patch, > we ensure that instruction cache is invalidated rig

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg: Extend SMM CPU Service with rendezvous support.

2022-02-22 Thread Li, Zhihao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3815 This patch define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. A new library SmmCpuRendezvousLib is provided

Re: [edk2-devel] [PATCH] ArmPkg: Invalidate Instruction Cache On MMU Enable

2022-02-22 Thread Ashish Singhal via groups.io
+ @Samer El-Haj-Mahmoud Hello Leif/Ard/Sami/Samer, Can you please look at this patch and provide some feedback? Thanks Ashish From: Ashish Singhal Sent: Monday, February 21, 2022 7:42 PM To: devel@edk2.groups.io ; sami.muja..

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

2022-02-22 Thread yi1 li
Good news, Thanks for your work. Thanks! Yi Li From: Vineel Kovvuri Sent: Wednesday, February 23, 2022 10:46 AM To: devel@edk2.groups.io; Li, Yi1 ; Vineel Kovvuri Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms Hi, Thanks f

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

2022-02-22 Thread Vineel Kovvuri via groups.io
Hi, Thanks for providing the inputs here. Really appreciated. I will try to resume the work(had to put it aside due to other priorities). Please expect the patch by EOW. Thanks, Vineel From: devel@edk2.groups.io On Behalf Of yi1 li via groups.io Sent: Tuesday, February 22, 2022 6:33 PM To: Vin

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

2022-02-22 Thread yi1 li
Hi Vineel, Are you still working on this issue? I'm glad to see that edk2 will enable EC and other crypto features and would like some advice. I found from the previous discussion that there are only some issues with Ovmf binary size left, Have you tried enlarging the size of DXEFV in OvmfPkgIa

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 02/22/2022 #cal-reminder

2022-02-22 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [PATCH V6 06/42] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

2022-02-22 Thread Min Xu
Hi, Ray & Eric I am doing the TDVF upstreaming and this commit is in UefiCpuPkg. You're the maintainer/reviewer of UefiCpuPkg. Your comments to this patch is great helpful. The complete code is at: https://github.com/mxu9/edk2/tree/tdvf_wave2.v6 Thanks Min > RFC: https://bugzilla.tianocore.org/

Re: [edk2-devel] [PATCH V6 04/42] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception

2022-02-22 Thread Min Xu
Hi, Ray & Eric I am doing the TDVF upstreaming and this commit is in UefiCpuPkg. You're the maintainer of UefiCpuPkg. Your comments to this patch is great helpful. The complete code is at: https://github.com/mxu9/edk2/tree/tdvf_wave2.v6 Thanks Min > > RFC: https://bugzilla.tianocore.org/show_b

Re: [edk2-devel] [PATCH V6 03/42] MdePkg: Add TdxLib to wrap Tdx operations

2022-02-22 Thread Min Xu
Hi, Michael & Liming & Zhiguang I am doing the TDVF upstreaming and this commit is in MdeModulePkg. You're the maintainer/reviewer of MdeModulePkg. Your comments to this patch is great helpful. The complete code is at: https://github.com/mxu9/edk2/tree/tdvf_wave2.v6 Thanks Min > > RFC: https://

Re: [edk2-devel] [PATCH V6 02/42] MdePkg: Introduce basic Tdx functions in BaseLib

2022-02-22 Thread Min Xu
Hi, Michael & Liming & Zhiguang I am doing the TDVF upstreaming and this commit is in MdeModulePkg. You're the maintainer/reviewer of MdeModulePkg. Your comments to this patch is great helpful. The complete code is at: https://github.com/mxu9/edk2/tree/tdvf_wave2.v6 Thanks Min > RFC: https://bu

Re: [edk2-devel] [PATCH V6 01/42] MdePkg: Add Tdx.h

2022-02-22 Thread Min Xu
Hi, Michael & Liming & Zhiguang I am doing the TDVF upstreaming and this commit is in MdeModulePkg. You're the maintainer/reviewer of MdeModulePkg. Your comments to this patch is great helpful. The complete code is at: https://github.com/mxu9/edk2/tree/tdvf_wave2.v6 Thanks Min > RFC: https://b

Re: [edk2-devel] [PATCH V6 26/42] OvmfPkg: Add null instance of PlatformInitLib

2022-02-22 Thread Min Xu
On February 22, 2022 9:10 PM, Gerd Hoffmann wrote: > > > > Add null instance of PlatformInitLib. > > What is this library needed for? > In #25 (OvmfPkg: Update PlatformInitLib to process Tdx hoblist) ProcessTdxHobList is added in PlatformInitLib to process the Tdx HobList. This function is call

Re: [edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification

2022-02-22 Thread Yao, Jiewen
HI Sebastien Here is some feedback. 1) Since this seems a new feature, would you please file a Bugzilla https://bugzilla.tianocore.org/ ? 2) Please also include this new feature in release plan - https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning ? 3) A clarification

Re: [edk2-devel] [PATCH V6 24/42] OvmfPkg/PlatformPei: Update platform functions with PlatformInitLib

2022-02-22 Thread Min Xu
On February 22, 2022 9:04 PM, Gerd Hoffmann wrote: > > OvmfPkg/PlatformPei/Platform.c | 391 +++-- > > .. and again. please quash with patch #23 (also #21 + #22). > Sure. It will be squashed in the next version. Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Y

Re: [edk2-devel] [PATCH V6 20/42] OvmfPkg/PlatformPei: Update hob functions PlatformInitLib

2022-02-22 Thread Min Xu
On February 22, 2022 9:03 PM, Gerd Hoffmann wrote: > > OvmfPkg/PlatformPei/MemDetect.c | 20 +++ > > OvmfPkg/PlatformPei/Platform.c | 101 > > OvmfPkg/PlatformPei/Platform.h | 31 -- > > Same here, this patch should be squashed with #19 so git can det

Re: [edk2-devel] [PATCH V6 18/42] OvmfPkg/PlatformPei: Update Cmos functions with PlatformInitLib

2022-02-22 Thread Min Xu
On February 22, 2022 9:01 PM, Gerd Hoffmann wrote: > > OvmfPkg/PlatformPei/Cmos.c | 55 - > > OvmfPkg/PlatformPei/Cmos.h | 48 - > > That kills the git history. Better have adding the cmos function to > PlatformInitLib and remo

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Make Boot Manager Key configurable

2022-02-22 Thread Sean Rhodes
True - but the experience is better with F2 (on "normal" computers/non-Chromebooks). We've got a lot of feedback, and for most, people turn on their computers and start tapping Escape when they want Grub. If it's mapped, this gets intercepted by UiApp. Even if they exit, with BGRT in the equation,

Re: [edk2-devel] [edk2-platform PATCH] Intel/FitGen: Fixed overflow issue when overlap checking

2022-02-22 Thread Vin Xue
Hi Sir, Could you help to review this simple change? It was verified on Client BIOS. Thanks. From: Vin Xue Sent: Monday, January 24, 2022 5:09 PM To: devel@edk2.groups.io Cc: Bob Feng ; Liming Gao ; Yuwei Chen Subject: [edk2-platform PATCH] Intel/FitGen: Fixe

[edk2-devel] [PATCH v2] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks

2022-02-22 Thread Fedorowicz, Jakub
In BaseConfigBlockLib add function to get next config block from config blocks table in order to iterate over blocks of the same GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3700 Cc: Ray Ni Cc: Rangasai V Chaganty Signe

[edk2-devel] [PATCH 3/3] OvmfPkg: CloudHv: Rely on PVH memmap instead of CMOS

2022-02-22 Thread Boeuf, Sebastien
From: Sebastien Boeuf Instead of using the CMOS, the CloudHv platform relies on the list of memmap entries provided through the PVH boot protocol to determine the last RAM address below 4G. Signed-off-by: Sebastien Boeuf --- OvmfPkg/PlatformPei/MemDetect.c | 73

[edk2-devel] [PATCH 2/3] OvmfPkg: CloudHv: Retrieve RSDP address from PVH

2022-02-22 Thread Boeuf, Sebastien
From: Sebastien Boeuf Instead of hardcoding the address of the RSDP in the firmware, let's rely on the PVH structure hvm_start_info to retrieve this information. Signed-off-by: Sebastien Boeuf --- OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 ++ OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c

[edk2-devel] [PATCH 1/3] OvmfPkg: Generate CloudHv as a PVH ELF binary

2022-02-22 Thread Boeuf, Sebastien
From: Sebastien Boeuf Following the model from the Xen target, CloudHv is generated as a PVH ELF binary to take advantage of the PVH specification. Signed-off-by: Sebastien Boeuf --- OvmfPkg/CloudHv/CloudHvElfHeaderGenerator.c | 150 OvmfPkg/CloudHv/CloudHvX64.dsc

[edk2-devel] [PATCH 0/3] CloudHv: Rely on PVH boot specification

2022-02-22 Thread Boeuf, Sebastien
From: Sebastien Boeuf Cloud Hypervisor aims at emulating the minimal amount of legacy devices and this is why the PVH boot specification is supported. The point is to be able to share some information with the guest without the need for emulating devices that would be present on real hardware. S

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: BaseFspSwitchStackLib Support for X64 Build

2022-02-22 Thread Ma, Maurice
Several comments as below: 1. Need to ensure sufficient space to save IDT The following will only reserve 8 bytes on stack to save IDT. It is fine for x86, but for x64 mode, the SIDT needs at least 80 bits. So we might want to reserve 16 byte for the changes listed below to void buffer ov

[edk2-devel] [PATCH] edk2/MdeModulePkg/Debuglib: Add Standalone MM support

2022-02-22 Thread Xiaolu.Jiang
https://bugzilla.tianocore.org/show_bug.cgi?id=3844 This change added Standalone MM instance of DebugLib. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Xiaolu.Jiang --- .../PeiDxeDebugLibReportStatusCode.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [edk2-devel] [PATCH V6 26/42] OvmfPkg: Add null instance of PlatformInitLib

2022-02-22 Thread Gerd Hoffmann
On Sat, Feb 19, 2022 at 07:56:39PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add null instance of PlatformInitLib. What is this library needed for? take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH V6 25/42] OvmfPkg: Update PlatformInitLib to process Tdx hoblist

2022-02-22 Thread Gerd Hoffmann
On Sat, Feb 19, 2022 at 07:56:38PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > When host VMM create the Td guest, the system memory informations are > stored in TdHob, which is a memory region described in Tdx metadata. > The system memory region in TdHob sh

Re: [edk2-devel] [PATCH V6 24/42] OvmfPkg/PlatformPei: Update platform functions with PlatformInitLib

2022-02-22 Thread Gerd Hoffmann
> OvmfPkg/PlatformPei/Platform.c | 391 +++-- .. and again. please quash with patch #23 (also #21 + #22). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86855): https://edk2.groups.io/g/de

Re: [edk2-devel] [PATCH V6 20/42] OvmfPkg/PlatformPei: Update hob functions PlatformInitLib

2022-02-22 Thread Gerd Hoffmann
> OvmfPkg/PlatformPei/MemDetect.c | 20 +++ > OvmfPkg/PlatformPei/Platform.c | 101 > OvmfPkg/PlatformPei/Platform.h | 31 -- Same here, this patch should be squashed with #19 so git can detect the code motion and maintain history. take care, Ger

Re: [edk2-devel] [PATCH V6 18/42] OvmfPkg/PlatformPei: Update Cmos functions with PlatformInitLib

2022-02-22 Thread Gerd Hoffmann
Hi, > OvmfPkg/PlatformPei/Cmos.c | 55 - > OvmfPkg/PlatformPei/Cmos.h | 48 - That kills the git history. Better have adding the cmos function to PlatformInitLib and removing them from PlatformPei in the same patch, git will

Re: 回复: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: reserve snp pages

2022-02-22 Thread Gerd Hoffmann
On Mon, Feb 21, 2022 at 09:07:17AM -0600, Brijesh Singh wrote: > Hi Liming, > > The said PCD is applicable for the SNP. SNP is supported on x86 64-bit only, > and most of the development is focused around Qemu/OVMF. In other words, the > Bhyve, Xen, and CloudHV do not support the SNP yet. We can r

[edk2-devel] [PATCH] UefiPayloadPkg: Use Boot Splash

2022-02-22 Thread Sean Rhodes
Build with BootLogo using default image by default. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Sean Rhodes --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 3 +++ .../Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + UefiPayloa

Re: [edk2-devel] MdeModulePkg fails to build with latest clang 14

2022-02-22 Thread Ross Burton
On Tue, 22 Feb 2022 at 01:55, gaoliming wrote: > Do you use which tool chain? CLANG38 or CLANGPDB? I think the solution > should disable this warning in tool chain configuration. We use CLANG38. Cheers, Ross -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this grou