On February 22, 2022 9:01 PM, Gerd Hoffmann wrote: > > OvmfPkg/PlatformPei/Cmos.c | 55 ----------------------------- > > OvmfPkg/PlatformPei/Cmos.h | 48 ------------------------- > > That kills the git history. Better have adding the cmos function to > PlatformInitLib and removing them from PlatformPei in the same patch, git > will detect that you are effectively moving code then. > > Ideally we'd have a one patch doing the buildsystem changes (add empty > PlatformInitLib and add the lib to .inf and .dsc files), and one patch moving > the cmos code over. But given that the cmos code is rather small I'm also > fine with a single patch doing both (i.e. squash this patch with #17). > Thanks for reminder. It will be squashed in the next version.
Thanks Min -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86867): https://edk2.groups.io/g/devel/message/86867 Mute This Topic: https://groups.io/mt/89252045/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-