Re: [edk2-devel] [PATCH v4 1/4] IntelSiliconPkg/VTd: Fix typos

Reviewed-by: Jenny Huang -Original Message- From: Sheng, W Sent: Tuesday, December 21, 2021 9:20 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Huang, Jenny ; Kowalewski, Robert Subject: [PATCH v4 1/4] IntelSiliconPkg/VTd: Fix typos It is DRHD(DMA Remapping Hardwar

回复: [edk2-devel] [PATCH] MdeModulePkg/Variable: Make only EFI_VARIABLE_NON_VOLATILE invalid

Create https://github.com/tianocore/edk2/pull/2418 to merge it. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2022年1月12日 9:07 > 收件人: devel@edk2.groups.io; sunny.w...@arm.com > 抄送: 'Heinrich Schuchardt' ; 'G Edhaya > Chandran' ; 'Samer El-Haj-Mahmoud' > > 主题: 回复

回复: [edk2-devel] 回复: [Wiki V2] Wiki: Add optional steps for developer to run CI test before sending

Push it at 7a96af0c093c90bb265243f99b6f07e9b8256451 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2022年1月17日 18:29 > 收件人: 'Zhiguang Liu' ; devel@edk2.groups.io > 主题: [edk2-devel] 回复: [Wiki V2] Wiki: Add optional steps for developer to > run CI test before sending

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, January 18, 2022 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angel

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 01/18/2022 #cal-reminder

Hi, all Few issues are reported this week. Let’s cancel the meeting. 3808 EDK2 Test unassig...@tianocore.org UNCO CI: Uncrustify test should display what changes were made 16

Re: [edk2-devel] [Patch V2] UefiPayloadPkg: Change the user interface name of the Uiapp

Reviewed-by: Ray Ni -Original Message- From: Dong, Guo Sent: Tuesday, January 18, 2022 2:05 AM To: Xie, Yuanhao ; devel@edk2.groups.io Cc: Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: RE: [Patch V2] UefiPayloadPkg: Change the user interface name of the Uiapp Reviewed-by: Guo Dong

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 01/18/2022 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from SD card through UEFI payload

Please refer to the inline comments below: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Aiman > Rosli > Sent: Monday, January 17, 2022 8:56 PM > To: devel@edk2.groups.io > Cc: Rosli, Muhammad Aiman > Subject: [edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from

Re: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add Support for authenticated variable

Hi Liming, Pls see my comments below. 1. PcdNvStoreDefaultValueBuffer type is DynamicEx. Its PcdGetPtr is same to PcdGetExPtr. This change is not required. [Lin] It'll get alignment with PEI phase reference If using PcdGetExPtr version. Edk2/MdeModulePkg/Universal/PCD/Pei/Pcd.c#166 DataB

Re: [edk2-devel] [PATCH 01/11] UefiPayloadPkg: Remove All UGA Support

Reviewed-by: Guo Dong -Original Message- From: Jiang, Guomin Sent: Thursday, January 13, 2022 5:51 PM To: devel@edk2.groups.io Cc: GuoMinJ ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH 01/11] UefiPayloadPkg: Remove All UGA Support From: GuoMinJ REF: https//

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default.

Reviewed-by: Guo Dong -Original Message- From: Liu, Zhiguang Sent: Thursday, January 13, 2022 11:15 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [PATCH] UefiPayloadPkg: Not use BaseCpuTimerLib by default. For recent X86 CPU, 0x15 CPUID in

Re: [edk2-devel] [Patch V2] UefiPayloadPkg: Change the user interface name of the Uiapp

Reviewed-by: Guo Dong -Original Message- From: Xie, Yuanhao Sent: Monday, January 17, 2022 1:24 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [Patch V2] UefiPayloadPkg: Change the user interface name of the Uiapp Chanage the name "Uiapp"

Re: [edk2-devel] [PATCH 1/1] BaseTools: Enable GNU make parallel jobs by default

Hello Ard, Leif, Abner, Daniel, I changed the GNU make flag to enable the "--jobs" option in GCC5 toolchain by default for all architectures. Please verify whether this change has impact to the ARM and RISCV GCC5 builds. Thanks! Thanks Steven Shi > -Original Message- > From: Shi, Steve

[edk2-devel] [PATCH 1/1] BaseTools: Enable GNU make parallel jobs by default

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3807 * Enable GNU make parallel jobs support(--jobs flag) by default in GCC5 and CLANGPDB toolchains. This gmake flag can save full features bios linux build time by +20%. * Explictly distinguish and define the MS nmake flag and GNU gmake fl

[edk2-devel] [PATCH 0/1] Enable GNU make parallel jobs by default for GCC5 and CLANGPDB ToolChains

The GNU make parallel jobs flgs (-j or --jobs) can significantly (~30%) improve the edk2 build time in Linux. This patch enable the GNU make parallel jobs by default. Below the OVMF test result on GCC5 and CLANGPDB toolchains: GCC5 build without patch: jshi19@ub2-uefi-b01:~/wksp_efi/edk2-2$ time

[edk2-devel] [PATCH v2] MdeModulePkg: Enabling OS boot from SD card through UEFI payload

This changes is by adding 50ms delay during voltage switching from 3.3V to 1.8V, plus adding a goto Voltage33Retry for 3.3V checking and retrying. Signed-off-by: Aiman Rosli --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(

Re: [edk2-devel] [PATCH v2 6/6] OvmfPkg/Microvm/pcie: add pcie support

Hello Gerd, On Mon, 17 Jan 2022 at 11:02, Gerd Hoffmann wrote: > > Link in pcie and host bridge bits. Enables support for PCIe in microvm > (qemu-system-x86_64 -M microvm,pcie=on). > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777 > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Micro

Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl submodule to v3.0

Hi, I've continued working on this over the last weeks. Time for a status update. All applies to the latest tree, sneak preview is here: https://github.com/kraxel/edk2/commits/openssl3 > Also, assuming you have done enough test, would you please provide: > 1) size difference, Includin

Re: [edk2-devel] [PATCH 1/8] CryptoPkg/CrtLibSupport: add fcntl.h

On Mon, Jan 17, 2022 at 11:52:27AM +0100, Gerd Hoffmann wrote: > Add fcntl.h header file. > Will be needed by openssl 3.0. > > Signed-off-by: Gerd Hoffmann > --- > CryptoPkg/Library/Include/fcntl.h | 9 + > 1 file changed, 9 insertions(+) > create mode 100644 CryptoPkg/Library/Include/f

回复: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add Support for authenticated variable

Long: I add my comments below. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Long1 Huang > 发送时间: 2022年1月11日 1:03 > 收件人: devel@edk2.groups.io > 抄送: Huang Long ; Liming Gao > ; Chen Lin Z ; Dandan Bi > > 主题: [edk2-devel] [PATCH] MdeModulePkg/HiiDatabaseDxe: Add Support for > authenticated var

[edk2-devel] [PATCH 6/8] CryptoPkg/CrtLibSupport: add off_t

Add typedef for off_t. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index aff9daaee809..fd8e8e1a

[edk2-devel] [PATCH 8/8] CryptoPkg/UnitTest: fix DH testcase

openssl 3.0 wants at least 512 bytes, otherwise it throws an error: error:0280007E:Diffie-Hellman routines::modulus too small Signed-off-by: Gerd Hoffmann --- CryptoPkg/Test/UnitTest/Library/BaseCryptLib/DhTests.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoP

[edk2-devel] [PATCH 7/8] CryptoPkg/CrtLibSupport: fix strcpy

strcpy() returns a pointer to the destination string, AsciiStrCpyS() does not. So a simple #define does not work. Create a inline function instead. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH 3/8] CryptoPkg/CrtLibSupport: add INT_MIN

Add #define for INT_MIN. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index 8907f1f13788..c1f4e0

[edk2-devel] [PATCH 4/8] CryptoPkg/CrtLibSupport: add UINT_MAX

Add define for UINT_MAX. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index c1f4e0187693..45db46

[edk2-devel] [PATCH 5/8] CryptoPkg/CrtLibSupport: add MODULESDIR

Add dummy MODULESDIR #define Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index 45db46cf8bee..af

[edk2-devel] [PATCH 2/8] CryptoPkg/CrtLibSupport: add strstr()

Add #define for strstr(). Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index d257dca8fa9b..8907f

[edk2-devel] [PATCH 0/8] CryptoPkg updates for openssl 3.0

First batch of patches which update CrtLibSupport so it has everything needed to build openssl3. Also a testcase update for openssl3. This does not update the openssl submodule, that'll happen in a followup patch series. Gerd Hoffmann (8): CryptoPkg/CrtLibSupport: add fcntl.h CryptoPkg/CrtLi

[edk2-devel] [PATCH 1/8] CryptoPkg/CrtLibSupport: add fcntl.h

Add fcntl.h header file. Will be needed by openssl 3.0. Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/Include/fcntl.h | 9 + 1 file changed, 9 insertions(+) create mode 100644 CryptoPkg/Library/Include/fcntl.h diff --git a/CryptoPkg/Library/Include/fcntl.h b/CryptoPkg/Library/Inc

[edk2-devel] 回复: [Wiki V2] Wiki: Add optional steps for developer to run CI test before sending

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Zhiguang Liu > 发送时间: 2022年1月17日 14:03 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao > 主题: [Wiki V2] Wiki: Add optional steps for developer to run CI test before > sending > > V2: Add the step to join in https://edk2.groups.io/g/devel and wait for

[edk2-devel] [PATCH v2 6/6] OvmfPkg/Microvm/pcie: add pcie support

Link in pcie and host bridge bits. Enables support for PCIe in microvm (qemu-system-x86_64 -M microvm,pcie=on). Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3777 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 40 +- OvmfPkg/Microvm/READM

[edk2-devel] [PATCH v2 2/6] FdtPciHostBridgeLib: io range is not mandatory

io range is not mandatory according to pcie spec, so allow host bridges without io address space. Signed-off-by: Gerd Hoffmann --- .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 45 ++- 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/OvmfPkg/Fdt/FdtPciHostBridgeL

[edk2-devel] [PATCH v2 4/6] OvmfPkg/Microvm/pcie: no vbeshim please

Those old windows versions which need the vbeshim hack will not run on microvm anyway. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/VbeShim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/OvmfPkg/QemuVideoDxe/VbeShim.c b/OvmfPkg/QemuVideoDxe/VbeShim.c index 8faa146b6cce..2a04821

[edk2-devel] [PATCH v2 5/6] OvmfPkg/Microvm/pcie: mPhysMemAddressWidth tweak

microvm places the 64bit mmio space at the end of the physical address space. So mPhysMemAddressWidth must be correct, otherwise the pci host bridge setup throws an error because it thinks the 64bit mmio window is not addressable. On microvm we can simply use standard cpuid to figure the address

[edk2-devel] [PATCH v2 3/6] OvmfPkg/PlatformPei: unfix PcdPciExpressBaseAddress

Will be set by FdtPciHostBridgeLib, so it can't be an fixed when we want use that library. Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/PlatformPei.inf | 2 +- OvmfPkg/PlatformPei/MemDetect.c | 4 ++-- OvmfPkg/PlatformPei/Platform.c | 4 ++-- 3 files changed, 5 insertions(+), 5

[edk2-devel] [PATCH v2 0/6] OvmfPkg/Microvm/pcie: add pcie support

Needs two little tweaks in PCI code because microvm supports mmio only. Other than that just wire up the existing code (the PCIe host adapter used by microvm is the same (virtual) hardware used by the arm/aarch64 virtual machines). v2: - rebase to latest master - pick up review tags Ref: https:

[edk2-devel] [PATCH v2 1/6] PciHostBridge: io range is not mandatory

io range is not mandatory according to pcie spec, so allow bridge configurations without io address space assigned. Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModule

[edk2-devel] [PATCH v2 4/5] OvmfPkg/QemuVideoDxe: factor out QemuVideoBochsAddMode

Add helper function to add a video mode to the list of modes. Move code. Minor debug logging tweaks, no other functional change. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/Initialize.c | 77 +++ 1 file changed, 47 insertions(+), 30 deletions(-) diff --git

[edk2-devel] [PATCH v2 3/5] OvmfPkg/QemuVideoDxe: drop QEMU_VIDEO_BOCHS_MODES->ColorDepth

All video modes in the list are 32-bit, so drop the useless ColorDepth field. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/Qemu.h | 1 - OvmfPkg/QemuVideoDxe/Initialize.c | 80 +++ 2 files changed, 39 insertions(+), 42 deletions(-) diff --git a/OvmfPk

[edk2-devel] [PATCH v2 5/5] OvmfPkg/QemuVideoDxe: parse edid blob, detect display resolution

Check whenever an EDID blob is present. In case it is get the display resolution from it. Unless PcdVideoResolutionSource indicates the display resolution has been set already update PcdVideoHorizontalResolution and PcdVideoVerticalResolution accordingly. Also add the resolution to the mode list.

[edk2-devel] [PATCH v2 2/5] OvmfPkg/QemuVideoDxe: simplify InitializeBochsGraphicsMode

struct QEMU_VIDEO_MODE_DATA has all the data needed to set the video mode, there is no need to take the extra indirection and use struct QEMU_VIDEO_BOCHS_MODES. Signed-off-by: Gerd Hoffmann --- OvmfPkg/QemuVideoDxe/Qemu.h | 3 +-- OvmfPkg/QemuVideoDxe/Driver.c | 14 +++--- Ovm

[edk2-devel] [PATCH v2 1/5] OvmfPkg: add PcdVideoResolutionSource

It's a UINT8 (enum) PCD telling where the PcdVideoHorizontalResolution and PcdVideoVerticalResolution values are coming from. It can be: 0 (unset aka default from dsc file), or 1 (from PlatformConfig), or 2 (set by Video Driver). It will be used by video drivers to avoid overriding PlatformCo

[edk2-devel] [PATCH v2 0/5] OvmfPkg/QemuVideoDxe: pick up display resolution settings from the host

See last patch in the series for details. v2: - rebase to latest master - more verbose commit message explaining the motivation for the new PCD (see patch #1). Gerd Hoffmann (5): OvmfPkg: add PcdVideoResolutionSource OvmfPkg/QemuVideoDxe: simplify InitializeBochsGraphicsMode OvmfPkg/Qe

[edk2-devel] [Patch V2] UefiPayloadPkg: Change the user interface name of the Uiapp

Chanage the name "Uiapp" to "Enter Setup". Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Yuanhao Xie --- UefiPayloadPkg/UefiPayloadPkg.fdf | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf b/UefiPayloadPkg/