[edk2-devel] [PATCH v5 3/3] MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem

2021-12-21 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776 Put off UFS HCS.DP (Device Attached) checking until UfsDeviceDetection() to fix timing problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++

[edk2-devel] [PATCH v5 2/3] MdeModulePkg: Refactoring UFS DME request and fix timing problem

2021-12-21 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775 Refactoring UFS DME request function and retry up to 5 times. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 299 +++- 1 file changed, 17

[edk2-devel] [PATCH v5 1/3] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem

2021-12-21 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714 Replace with UFS_UNIT_DESC to fix response timeout problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 23 +-- 1 file changed, 11 i

[edk2-devel] [PATCH v5 0/3] MdeModulePkg: Fix UfsBlockIoPei timing problem

2021-12-21 Thread VincentX Ke
Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke VincentX Ke (3): MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem MdeModulePkg: Refactoring UFS DME request and fix timing problem MdeModulePkg: Put off UFS HCS.DP checking to fix timing proble

Re: [edk2-devel] [PATCH V2] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP

2021-12-21 Thread Ni, Ray
Reviewed-by: Ray Ni From: Bassa, Damian Sent: Tuesday, September 21, 2021 12:21 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Wu, Hao A ; Kolakowski, Jacek Subject: [PATCH V2] MdeModulePkg/PciBusDxe: Enumerator to check for RCiEP before looking for RP Before trying to access parent root port to

[edk2-devel] [PATCH v4 4/4] IntelSiliconPkg/VTd: Only generate PEI DMA buffer once.

2021-12-21 Thread Sheng Wei
VTdInfoNotify may be called manay times, PEI DMA buffer should be generated only once. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3667 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../Feature/VTd/IntelVTdDmarPei/DmarTable.c

[edk2-devel] [PATCH v4 3/4] IntelSiliconPkg/VTd: Support VTd Abort DMA Mode

2021-12-21 Thread Sheng Wei
If VTd ECAP_REG.ADMS bit is set, abort DMA mode is supported. When VTd Abort DMA Mode is enabled, hardware will abort all DMA operations without the need to set up a root-table with each entry marked as not-present. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3766 Cc: Ray Ni Cc: Rangas

[edk2-devel] [PATCH v4 2/4] IntelSiliconPkg/VTd: Update VTd register structs

2021-12-21 Thread Sheng Wei
Update VTd register structs accroding to VTd spec ver 3.3 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3765 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../Feature/VTd/IntelVTdDmarPei/IntelVTdDmar.c | 3 +- .../Feature/VT

[edk2-devel] [PATCH v4 1/4] IntelSiliconPkg/VTd: Fix typos

2021-12-21 Thread Sheng Wei
It is DRHD(DMA Remapping Hardware Unit Definition). REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3622 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski Signed-off-by: Sheng Wei --- .../IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/DmarTable.c | 12 ++--

[edk2-devel] [PATCH v4 0/4] There are 4 patches for VTd drivers

2021-12-21 Thread Sheng Wei
[PATCH 1/4] IntelSiliconPkg/VTd: Fix typos [PATCH 2/4] IntelSiliconPkg/VTd: Update VTd register structs [PATCH 3/4] IntelSiliconPkg/VTd: Support VTd Abort DMA Mode [PATCH 4/4] IntelSiliconPkg/VTd: Only generate PEI DMA buffer once. Patch v2 update: Fix build error in [PATCH 2/4] and [PATCH 4/4] P

Re: [edk2-devel] [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.

2021-12-21 Thread Donald Kuo
Reviewed-by: Donald Kuo -Original Message- From: Kumar, Chandana C Sent: Wednesday, December 22, 2021 12:33 AM To: Lin, JackX ; devel@edk2.groups.io Cc: Chiu, Chasel ; Dong, Eric ; Yao, Jiewen ; Ni, Ray ; Chaganty, Rangasai V ; Kuo, Donald Subject: RE: [edk2-platforms: PATCH] System

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 12/21/2021 #cal-reminder

2021-12-21 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] Platform/Intel/Readme : Fix platform list

2021-12-21 Thread Oram, Isaac W
Pushed as eb2d49b5a7..d64b135db -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, December 15, 2021 4:40 PM To: devel@edk2.groups.io; Oram, Isaac W Cc: Chaganty, Rangasai V ; Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] Platform/Intel/Readme : Fi

[edk2-devel] [PATCH v5 4/4] Silicon/ARM/NeoverseN1Soc: Remove PciExpressLib use PciSegmentLib instead

2021-12-21 Thread Khasim Mohammed
The patch removes PciExpressLib implementation for N1Sdp as: a) The PciSegmentLib implementation for N1Sdp makes MmioRead() calls instead of PciRead() which makes the PciExpressLib redundant. b) Since N1Sdp requires multiple segments to be supported, PciExpressLib and PciLib cannot

[edk2-devel] [PATCH v5 3/4] Silicon/ARM/NeoverseN1Soc: Add CCIX root complex support

2021-12-21 Thread Khasim Mohammed
This patch enables CCIX root complex support by updating the root complex node info in PciHostBridge library. Signed-off-by: Khasim Syed Mohammed --- .../PciHostBridgeLib/PciHostBridgeLib.c | 71 +-- .../PciHostBridgeLib/PciHostBridgeLib.inf | 11 ++- 2 files changed, 7

[edk2-devel] [PATCH v5 2/4] Silicon/ARM/NeoverseN1Soc: Update PCDs to support multiple PCI root ports

2021-12-21 Thread Khasim Mohammed
PCD entries are updated to remove the hardcoded assignments and to add support for multiple PCI root ports. Signed-off-by: Khasim Syed Mohammed --- .../AslTables/SsdtPci.asl | 8 +-- .../AslTables/SsdtRemotePci.asl | 4 +- .../ConfigurationManager.c

[edk2-devel] [PATCH v5 1/4] Silicon/ARM/NeoverseN1Soc: Port PCI Segment Library

2021-12-21 Thread Khasim Mohammed
The BasePCISegment Library in MdePkg doesn't allow configuring multiple segments required for PCIe and CCIX root port enumeration. Therefore, a custom PCI Segment library is adapted from SynQuacerPciSegmentLib and ported for N1Sdp. In addition to this, the hardware has few other limitations which

[edk2-devel] [PATCH v5 0/4] Enable CCIX port as PCIe root host on N1SDP

2021-12-21 Thread Khasim Mohammed
The patch series removes PciExpressLib and enables CCIX port as PCIe root on N1SDP. V5: - Split the CCIX patch, separate PCD updates and CCIX root port enablement. - Use GET_SEG_ macro for segment detection and update logic accordingly. V4: - Remove PciExpressLib and use PciSegmentLib instead. Mo

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 12/21/2021 #cal-reminder

2021-12-21 Thread gaoliming
The following issues will be reviewed this week. 3755 EDK2 Code unassig...@tianocore.org UNCO Displaying SMBIOS Type38 fields in smbiosview command in formatted manner 19:54:55

[edk2-devel] [PATCH 1/1] OvmfPkg: Bhyve: Delete unused AcpiTables/Ssdt.asl file

2021-12-21 Thread Rebecca Cran
The Ssdt.asl file isn't used, so delete it. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 15 --- 1 file changed, 15 deletions(-) diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl deleted file mode 100644 index 175ab3b7e66d..00

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field

2021-12-21 Thread Rebecca Cran
On 12/21/21 09:31, Ard Biesheuvel wrote: On Tue, 21 Dec 2021 at 16:06, Rebecca Cran wrote: According to the ACPI Specification version 6.0 and newer, the SSDT Revision field should be 2. Fix AcpiTables/Ssdt.aml. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +- 1 fi

Re: [edk2-devel] [edk2-platforms: PATCH] System will occur a CPU exception error when sorting CPU APIC map, because of a pointer point to an wrong space.

2021-12-21 Thread Kumar, Chandana C
Reviewed-by: Chandana C Kumar > -Original Message- > From: Lin, JackX > Sent: Tuesday, December 21, 2021 12:18 PM > To: devel@edk2.groups.io > Cc: Lin, JackX ; Lin, JackX ; Chiu, > Chasel ; Dong, Eric ; Yao, Jiewen > ; Ni, Ray ; Chaganty, Rangasai V > ; Kuo, Donald ; Kumar, > Chandana C

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field

2021-12-21 Thread Ard Biesheuvel
On Tue, 21 Dec 2021 at 16:06, Rebecca Cran wrote: > > According to the ACPI Specification version 6.0 and newer, the SSDT > Revision field should be 2. Fix AcpiTables/Ssdt.aml. > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +- > 1 file changed, 1 insertion(+), 1 d

[edk2-devel] ShellPkg: acpiview errors on Processor Local APIC struct in MADT

2021-12-21 Thread Rebecca Cran
acpiview is generating errors for the MADT table when it contains a Processor Local APIC entry: ERROR: Unknown Interrupt Controller Structure, Type = 0, Length = 8 Looking at ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c:475 I see there's no case statement for EFI_A

[edk2-devel] [PATCH 1/1] OvmfPkg: Bhyve: Correct the SSDT Revision field

2021-12-21 Thread Rebecca Cran
According to the ACPI Specification version 6.0 and newer, the SSDT Revision field should be 2. Fix AcpiTables/Ssdt.aml. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiTables/Ssdt.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/AcpiTables/Ssdt.asl b/Ovmf

[edk2-devel] [PATCH edk2 v2 2/3] StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR

2021-12-21 Thread Ming Huang
DEBUG_ERROR should be used in error branch. Signed-off-by: Ming Huang --- StandaloneMmPkg/Drivers/StandaloneMmCpu/EventHandle.c | 6 +++--- StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/StandaloneM

[edk2-devel] [PATCH edk2 v2 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-21 Thread Ming Huang
There are two scene communicate with StandaloneMm(MM): 1 edk2 -> TF-A -> MM, communicate MM use non-secure buffer which specify by EFI_SECURE_PARTITION_BOOT_INFO.SpNsCommBufBase; 2 RAS scene: fiq -> TF-A -> MM, use secure buffer which specify by EFI_SECURE_PARTITION_BOOT_INFO.SpShareBufBase; F

[edk2-devel] [PATCH edk2 v2 1/3] StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field

2021-12-21 Thread Ming Huang
TF-A: TrustedFirmware-A SPM: Secure Partition Manager(MM) In TF-A, the name of this field is sp_shared_buf_size. This field is the size of range for transmit data from TF-A to standaloneMM when SPM enable. SpPcpuSharedBufSize is pass from TF-A while StandaloneMM initialize. So, SpPcpuSharedBufSiz

[edk2-devel] [PATCH edk2 v2 0/3] Fix several issues in StanaloneMmPkg

2021-12-21 Thread Ming Huang
Changes since v1: Modify CheckBufferAddr() function. Ming Huang (3): StandaloneMmPkg: Fix issue about SpPcpuSharedBufSize field StandaloneMmPkg: Replace DEBUG_INFO with DEBUG_ERROR StandaloneMmPkg: Fix check buffer address failed issue from TF-A .../Drivers/StandaloneMmCpu/EventHandle.c

Re: [edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-21 Thread Ming Huang
在 12/9/21 1:46 AM, Omkar Anand Kulkarni 写道: > Hi Ming, > > Thanks for this patch. This patch helps to resolve Standalone MM issue while > exercising RAS use case. > Few comments mentioned inline. > > - Omkar > > > On 10/15/21 2:39 PM, Ming Huang via groups.io wrote: >> There are two scene

Re: [edk2-devel] [PATCH 1/1] UsbBusDxe: fix NOOPT build error

2021-12-21 Thread Wu, Hao A
> -Original Message- > From: Gerd Hoffmann > Sent: Monday, December 20, 2021 10:33 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Philippe Mathieu-Daudé > ; Wang, Jian J ; Pawel > Polawski ; Ni, Ray ; Gao, Liming > ; Gerd Hoffmann > Subject: [PATCH 1/1] UsbBusDxe: fix NOOPT build error