Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-22 Thread Marvin Häuser
23.11.2021 00:17:30 Michael Brown : > On 22/11/2021 16:42, Michael D Kinney wrote: >> You are also modifying the DebugLib in the paths where ASSERT() macros >> are disabled.  When they are disabled, we want all code/data associated >> with ASSERT() to be removed by the optimizing compiler/linker

[edk2-devel] [Patch 0/3] .pytool/Plugin/EccCheck: Remove git reset and optimize

2021-11-22 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 * Use temp directory for all operations to prevent any changed to git state. * Remove git reset operation that could corrupt staged and local changes. * Improve performance by removing redundant directory scans * Improve performance and

[edk2-devel] [Patch 3/3] .pytool/Plugin/EccCheck: Add performance optimizations

2021-11-22 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 Improve the performance of EccCheck by using a temp file instead of stdout to capture the results of the git diff commands. If a large patch set is passed into EccCheck, using stdout could be slow and also added the large diff content to the

[edk2-devel] [Patch 2/3] .pytool/Plugin/EccCheck: Remove temp directory on exception

2021-11-22 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 Add try/except to RunBuildPlugin() to remove temporary directory if a KeyboardInterrupt exception or an unexpected exception is detected. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Cc: Michael Kubacki Signed-off-by: Michael D Kinn

[edk2-devel] [Patch 1/3] .pytool/Plugin/EccCheck: Remove RevertCode()

2021-11-22 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2986 The RevertCode() method uses git reset which can remove local changes. Instead of modifying the local files, a copy of the package passed into the EccCheck tool is copied to a temp directory in Build/ecctemp. This same temp directory is als

回复: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

2021-11-22 Thread gaoliming
Pedro: I submit BZ https://bugzilla.tianocore.org/show_bug.cgi?id=3745 to request Ext2/Ext3 file system. Thanks Liming 发件人: devel@edk2.groups.io 代表 Pedro Falcato 发送时间: 2021年11月19日 11:10 收件人: edk2-devel-groups-io ; Liming Gao 主题: Re: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add unini

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/16/2021 #cal-reminder

2021-11-22 Thread gaoliming
The following issues will be discussed in this week meeting. 3745 EDK2 Pla Ext4Pkg pedro.falc...@gmail.com UNCO Support Ext2/Ext3 File System Thu 22:17 gaolim...@byosoft.com.cn

Re: [edk2-devel] Bug report: serial timeout gets overwritten shortly after setting it

2021-11-22 Thread Michael D Kinney
Hi Nicholas, How did you open the Serial I/O Protocol? If you open BY_DRIVER or EXCLUSIVE, then it should disconnect the Terminal driver from the Serial I/O Protocol and allow you to change the timeout and keep that timeout setting. For your UEFI application test case, the open mode of EXCLUSIVE

[edk2-devel] Bug report: serial timeout gets overwritten shortly after setting it

2021-11-22 Thread nicholasbishop
Hi, I have a bug to report with the serial I/O protocol. Using the SetAttributes function to change the timeout initially works, but after a short amount of time the timeout gets reset to 173 microseconds. I believe this is likely due to the implementation of the simple text input protocol, whi

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/23/2021 #cal-reminder

2021-11-22 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles

Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-22 Thread Michael Brown
On 22/11/2021 16:42, Michael D Kinney wrote: You are also modifying the DebugLib in the paths where ASSERT() macros are disabled. When they are disabled, we want all code/data associated with ASSERT() to be removed by the optimizing compiler/linker. The source code change appears to force a ref

Re: [edk2-devel] [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2021-11-22 Thread Sami Mujawar
Hi Abdul, Thank you for this patch series. This series looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/11/2021 10:21 AM, Abdul Lateef Attar wrote: Hi Sami, Zhichao, Addressed all review comments. Created two different patches, one for bitfield parser and another

Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-22 Thread Michael D Kinney
Hi Mikhail, Are you able to provide a few examples of dead code this change uncovers? If there is additional issues then wouldn't applying this patch break all the open source package builds that contain these issues? Does this patch series pass EDK II CI? Wouldn't it also make sense to remove

Re: [edk2-devel] CdePkgBlog 2021-11-14

2021-11-22 Thread Maciej Rabeda
Hi Kilian, From my point of view, the main problem with adoption of CdePkg to EDK2 is that it relies on Torito C library. 1. Torito C library License (https://github.com/KilianKegel/toro-C-Library/blob/master/LICENSE.md) only allows for creating UEFI Shell applications. * What about

Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved

2021-11-22 Thread Yao, Jiewen
Acked-by: Jiewen Yao > -Original Message- > From: Brijesh Singh > Sent: Monday, November 22, 2021 11:43 PM > To: Dov Murik ; devel@edk2.groups.io > Cc: brijesh.si...@amd.com; Ard Biesheuvel ; > Justen, Jordan L ; Gerd Hoffmann > ; Erdem Aktas ; James > Bottomley ; Yao, Jiewen ; Xu, > Min

Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved

2021-11-22 Thread Brijesh Singh via groups.io
On 11/18/21 5:31 AM, Dov Murik wrote: Mark the SEV launch secret MEMFD area as reserved, which will allow the guest OS to use it during the lifetime of the OS, without creating copies of the sensitive content. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Brijesh Singh Cc: Er

Re: [edk2-devel] [edk2-platforms][PATCH 00/14] Revise U500 for the latest RISC-V packages.

2021-11-22 Thread Daniel Schaefer
Great! U500 confirmed working again and cleanup through generic code. Reviewed-by: Daniel Schaefer From: Chang, Abner (HPS SW/FW Technologist) Sent: Monday, November 15, 2021 10:56 To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Schaefer, D

[edk2-devel] [PATCH v3 2/2] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

2021-11-22 Thread Abdul Lateef Attar via groups.io
Adds PrintFormatter function to the FADT flags field. Prints indivisual flag name along with flag value. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 59 +++- 1 file

[edk2-devel] [PATCH v3 1/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2021-11-22 Thread Abdul Lateef Attar via groups.io
Adds ParseAcpiBitFields() which is based on ParseAcpi() and capable of parsing the bit fields. Supports parsing of UINT8, UINT16, UINT32 and UINT64 byte data. Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiPar

[edk2-devel] [PATCH v3 0/2] ShellPkg/AcpiView: Adds ACPI_PARSER bitfield parser

2021-11-22 Thread Abdul Lateef Attar via groups.io
Hi Sami, Zhichao, Addressed all review comments. Created two different patches, one for bitfield parser and another for FADT Flags parser. Thanks AbduL REF : https://github.com/abdattar/edk2/tree/FadtFlagsParser Cc: Ray Ni Cc: Zhichao Gao Cc: Sami Mujawar Signed-off-by: Abdul Lateef Attar