[edk2-devel] [PATCH V3 3/3] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 OvmfPkg.dec is removed from [Packages] because it doesn't depend on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg. Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Anthony Perard Cc: Julien Grall Cc: Eric Dong Cc: Ray Ni Signed-off-by: Min Xu

[edk2-devel] [PATCH V3 1/3] OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 XenTimerDxe is a local Apic timer driver and it has nothing to do with Xen. So rename it to LocalApicTimerDxe. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH V3 2/3] OvmfPkg: Switch timer in build time for OvmfPkg

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 Discussion in https://bugzilla.tianocore.org/show_bug.cgi?id=1496 shows that 8254TimerDxe was not written for OVMF. It was moved over from PcAtChipsetPkg to OvmfPkg in 2019. Probably because OVMF was the only user left. Most likely the reas

[edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 XenTimerDxe is a local Apic timer driver and it has nothing to do with Xen. So rename it to LocalApicTimerDxe. After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE. Otherwise 8254 timer is used. Since LocalApicTimerDxe d

Re: [edk2-devel] 回复: [PATCH v1 1/1] MdeModulePkg/XhciSched: Fix missing DEBUG arguments

2021-11-07 Thread Wu, Hao A
Pushed via: PR - https://github.com/tianocore/edk2/pull/2181 Commit - https://github.com/tianocore/edk2/commit/b5d4a35d90771ec86ce9cf28727f471ee589fb78 Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming > Sent: Thursday, November 4, 2021 2:00

回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

2021-11-07 Thread gaoliming
Xiaolu: Can you calculate the required memory, then allocate it instead of use hard code memory length? Thanks Liming > -邮件原件- > 发件人: Jiang, Xiaolu > 发送时间: 2021年11月8日 10:26 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: Feng, Bob C ; Chen, Christine > ; Fu, Siyuan > 主题: RE: [edk2-devel

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-11-07 Thread Yao, Jiewen
Ok, then we have to wait. Please aware that we are in the code freeze state. We may have to check in after WW50. I would prefer to submit small patch set if possible. It is easy to get it reviewed and merged. A large patch set is hard to review. Usually it takes longer time (not linear). Thank

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-11-07 Thread Brijesh Singh via groups.io
[AMD Official Use Only] Without UefiCpuPkg we will have a broken SNP support and I would prefer not to commit a broken SEV-SNP support. The UefiCpuPkg is required for the multiple CPU boot and based all the feedback we have added a new ConfidentialCompting PCD that is set and used for OVMF. Spl

Re: [edk2-devel] [PATCH 1/1] BaseTools: Fix StructurePcd offset error.

2021-11-07 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Wednesday, October 27, 2021 6:00 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao Subject: [edk2-devel] [PATCH 1/1] BaseTools: Fix StructurePcd offset error. Currently when parse V

Re: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

2021-11-07 Thread Bob Feng
Xiaolu, I think you could calculate the Str16 length based on the input argument Str. Thanks, Bob -Original Message- From: Jiang, Xiaolu Sent: Monday, November 8, 2021 10:26 AM To: gaoliming ; devel@edk2.groups.io Cc: Feng, Bob C ; Chen, Christine ; Fu, Siyuan Subject: RE: [edk2-deve

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-11-07 Thread Yao, Jiewen
I recommend you split the patch set to OvmfPkg update and UefiPkg update, unless there is strong reason that you have to mix them together. With that, I can merge the OvmfPkg at first and we can move forward there, while waiting UefiPkg review. If you agree, please rebase and resubmit. Thank y

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-11-07 Thread Brijesh Singh via groups.io
[AMD Official Use Only] Hi, I am not getting any response from the UefiCpuPkg maintainers, I am not sure if the Ray/Rahul are on vacation or need more information. Jiewen and Gerd, Any recommendations how we proceed further ? I can send the rebased version and we can go ahead and commit it.

回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Include: Smbios Specification 3.5.0 changes

2021-11-07 Thread gaoliming
Thanks for your update. Reviewed-by: Liming Gao Besides, I suggest you also update ShellPkg\Library\UefiShellDebug1CommandsLib\SmbiosView to support new added tables. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Abdul Lateef > Attar via groups.io > 发送时间: 2021年11月5日 20:25 > 收

Re: [edk2-devel] [PATCH] BaseTools: Add authenticated variable store support

2021-11-07 Thread Bob Feng
This patch looks good to me. Liming, do you have any comments? Reviewed-by: Bob Feng -Original Message- From: Chen, Lin Z Sent: Thursday, November 4, 2021 7:29 PM To: devel@edk2.groups.io Cc: Chen, Lin Z ; Feng, Bob C ; Liming Gao Subject: [PATCH] BaseTools: Add authenticated variab

回复: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

2021-11-07 Thread gaoliming
Xiaolu: Why choose 4096? Is it enough? Thanks Liming > -邮件原件- > 发件人: Xiaolu.Jiang > 发送时间: 2021年11月6日 11:51 > 收件人: devel@edk2.groups.io > 抄送: Xiaolu.Jiang ; Bob Feng > ; Liming Gao ; Yuwei > Chen > 主题: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for > support more PCD

[edk2-devel] 回复: [PATCH V5 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

2021-11-07 Thread gaoliming
Min: Thanks for your update. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Min Xu > 发送时间: 2021年11月7日 20:35 > 收件人: devel@edk2.groups.io > 抄送: Min Xu ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Jiewen Yao ; > Jian J Wang ; Ken Lu ; Sami > Mujawar ; Gerd Hoffmann > 主题: [

[edk2-devel] [PATCH V5 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpmMeasurementLib supports TPM based measurement in DXE phase. After CcMeasurementProtocol is introduced, CC based measurement needs to be supported in DxeTpmMeasurementLib as well. A platform should have only one RTS/RTR. Only one of (vi

[edk2-devel] [PATCH V5 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpm2MeasureBootLib supports TPM2 based measure boot. After CcMeasurementProtocol is introduced, CC based measure boot needs to be supported in DxeTpm2MeasureBootLib as well. There are 2 major changes in this commit. 1. A platform should

[edk2-devel] [PATCH V5 0/3] Introduce CcMeasurementProtocol into EDK2

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 If Confidential Computing (Cc) firmware supports measurement and an event is created, CC-Guest firmware is designed to report the event log with the same data structure in TCG-Platform-Firmware-Profile specification with EFI_TCG2_EVENT_LOG_FO

[edk2-devel] [PATCH V5 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

2021-11-07 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 CC guest is a Confidential Computing guest. If CC Guest firmware supports measurement and an event is created, CC Guest firmware is designed to report the event log with the same data structure in TCG-Platform-Firmware-Profile specification w